[Bug driver/30460] New: asm_debug is not initialized in gcc.c

[Bug driver/30460] New: asm_debug is not initialized in gcc.c

[rschiele at uni-mannheim dot de]

asm_debug is not initialized in gcc.c. This can lead to a sigsegv when using a
custom specs file that does not overwrite asm_debug but other predefined spec
values.

Example:

---
*invoke_as:
%{!S:-o %|.s |
 nesc-as %(asm_options) %m.s %A }

---


-- 
           Summary: asm_debug is not initialized in gcc.c
           Product: gcc
           Version: 4.3.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: driver
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: rschiele at uni-mannheim dot de
 GCC build triplet: *-*-*
  GCC host triplet: *-*-*
GCC target triplet: *-*-*


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30460

[Bug driver/30460] asm_debug is not initialized in gcc.c

[rschiele at uni-mannheim dot de]

------- Comment #1 from rschiele at uni-mannheim dot de  2007-01-14 01:56 -------
Created an attachment (id=12903)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=12903&action=view)
Fix for the problem.

BTW: This is also true for 4.2.x and 4.1.x. I have not looked into older
releases.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30460

[Bug driver/30460] asm_debug is not initialized in gcc.c

[pinskia at gcc dot gnu dot org]

------- Comment #2 from pinskia at gcc dot gnu dot org  2007-01-14 02:10 -------
actually asm_debug is initialized in init_spec, with the following comment:
  /* Initialize here, not in definition.  The IRIX 6 O32 cc sometimes chokes
     on ?: in file-scope variable initializations.  */
  asm_debug = ASM_DEBUG_SPEC;


Oh, init_spec is not called because you read in the spec so there is no need to
call the initializer:
  /* Read the specs file unless it is a default one.  */
  if (specs_file != 0 && strcmp (specs_file, "specs"))
    read_specs (specs_file, TRUE);
  else
    init_spec ();

so your patch is incorrect as it might cause a bootstrap failure (unless IRIX 6
support has been removed).


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |minor
           Keywords|patch                       |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30460

[Bug driver/30460] asm_debug is not initialized in gcc.c

[rschiele at gmail dot com]

------- Comment #3 from rschiele at gmail dot com  2007-01-14 02:21 -------
Andrew, it does not help to initialize in init_spec() because init_spec() is
only called when there is _no_ spec file found.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30460

[Bug driver/30460] [4.0/4.1/4.2/4.3 Regression] asm_debug is not initialized in gcc.c when using a specs file

[pinskia at gcc dot gnu dot org]

-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to fail|                            |3.3.3 3.4.0 4.0.0 4.1.0
                   |                            |4.2.0 4.0.4 4.1.2 4.1.1
                   |                            |4.1.0 4.0.3 4.0.2 4.0.1
      Known to work|                            |3.0.4
            Summary|asm_debug is not initialized|[4.0/4.1/4.2/4.3 Regression]
                   |in gcc.c                    |asm_debug is not initialized
                   |                            |in gcc.c when using a specs
                   |                            |file
   Target Milestone|---                         |4.0.4


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30460

[Bug driver/30460] [4.0/4.1/4.2/4.3 Regression] asm_debug is not initialized in gcc.c when using a specs file

[rschiele at gmail dot com]

------- Comment #4 from rschiele at gmail dot com  2007-01-14 03:12 -------
What about just calling init_spec() _allways_ _before_ reading the default
specs file instead of calling it only when there is no default specs file?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30460

[Bug driver/30460] [4.0/4.1/4.2/4.3 Regression] asm_debug is not initialized in gcc.c when using a "default" specs file

[pinskia at gcc dot gnu dot org]

------- Comment #5 from pinskia at gcc dot gnu dot org  2007-01-14 06:16 -------
In my mind this is a minor issue because the way you are using the specs file
is wrong, you are using the defaults spec file and not using the overriding
one.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2007-01-14 06:16:27
               date|                            |
            Summary|[4.0/4.1/4.2/4.3 Regression]|[4.0/4.1/4.2/4.3 Regression]
                   |asm_debug is not initialized|asm_debug is not initialized
                   |in gcc.c when using a specs |in gcc.c when using a
                   |file                        |"default" specs file


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30460

[Bug driver/30460] [4.0/4.1/4.2/4.3 Regression] asm_debug is not initialized in gcc.c when using a "default" specs file

[rschiele at gmail dot com]

------- Comment #6 from rschiele at gmail dot com  2007-01-14 08:03 -------
Agreed, but why shouldn't we change the special handling of the default specs
file as suggested in comment #4? I can't see why we should enforce people to
specify _full_ information in the default specs file if they only want to
change _one_ thing from the compiled-in values. Is there any reason?

As far as I can see my suggestion in comment #4 would solve this issue and make
usage of a default specs file more convenient.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30460

[Bug driver/30460] [4.0/4.1/4.2/4.3 Regression] asm_debug is not initialized in gcc.c when using a "default" specs file

[rschiele at gmail dot com]

------- Comment #7 from rschiele at gmail dot com  2007-01-14 13:52 -------
Created an attachment (id=12904)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=12904&action=view)
new version of the fix

This implements my new suggestion on how to fix this. Any comments?


-- 

rschiele at gmail dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #12903|0                           |1
        is obsolete|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30460

[Bug driver/30460] [4.0/4.1/4.2/4.3 Regression] asm_debug is not initialized in gcc.c when using a "default" specs file

[gdr at gcc dot gnu dot org]

------- Comment #8 from gdr at gcc dot gnu dot org  2007-02-03 21:24 -------
won't fix in GCC-4.0.x.  Adjusting milestone.


-- 

gdr at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.0.4                       |4.1.3


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30460

[Bug driver/30460] [4.0/4.1/4.2/4.3 Regression] asm_debug is not initialized in gcc.c when using a "default" specs file

[pinskia at gcc dot gnu dot org]

-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.1.3                       |4.1.2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30460

[Bug driver/30460] [4.0/4.1/4.2/4.3 Regression] asm_debug is not initialized in gcc.c when using a "default" specs file

[mmitchel at gcc dot gnu dot org]

-- 

mmitchel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30460

[Bug driver/30460] [4.0/4.1/4.2/4.3 Regression] asm_debug is not initialized in gcc.c when using a "default" specs file

[mmitchel at gcc dot gnu dot org]

-- 

mmitchel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.1.2                       |4.1.3


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30460

[Bug driver/30460] [4.0/4.1/4.2/4.3 Regression] asm_debug is not initialized in gcc.c when using a "default" specs file

[aldyh at gcc dot gnu dot org]

-- 

aldyh at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |aldyh at gcc dot gnu dot org
                   |dot org                     |
             Status|NEW                         |ASSIGNED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30460

[Bug driver/30460] [4.0/4.1/4.2/4.3 Regression] asm_debug is not initialized in gcc.c when using a "default" specs file

[jakub at gcc dot gnu dot org]

------- Comment #9 from jakub at gcc dot gnu dot org  2007-11-16 07:03 -------
Subject: Bug 30460

Author: jakub
Date: Fri Nov 16 07:02:49 2007
New Revision: 130219

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=130219
Log:
        PR driver/30460
        * gcc.c (init_spec): Don't initialize asm_debug here...
        (main): ... but here.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/gcc.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30460

[Bug driver/30460] [4.0/4.1/4.2 Regression] asm_debug is not initialized in gcc.c when using a "default" specs file

[jakub at gcc dot gnu dot org]

------- Comment #10 from jakub at gcc dot gnu dot org  2007-11-16 07:10 -------
Fixed on the trunk.


-- 

jakub at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[4.0/4.1/4.2/4.3 Regression]|[4.0/4.1/4.2 Regression]
                   |asm_debug is not initialized|asm_debug is not initialized
                   |in gcc.c when using a       |in gcc.c when using a
                   |"default" specs file        |"default" specs file


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30460

[Bug driver/30460] [4.2 Regression] asm_debug is not initialized in gcc.c when using a "default" specs file

[jsm28 at gcc dot gnu dot org]

------- Comment #11 from jsm28 at gcc dot gnu dot org  2008-07-04 21:48 -------
Closing 4.1 branch.


-- 

jsm28 at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[4.1/4.2 Regression]        |[4.2 Regression] asm_debug
                   |asm_debug is not initialized|is not initialized in gcc.c
                   |in gcc.c when using a       |when using a "default" specs
                   |"default" specs file        |file
   Target Milestone|4.1.3                       |4.2.5


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30460

[Bug driver/30460] [4.2 Regression] asm_debug is not initialized in gcc.c when using a "default" specs file

[jsm28 at gcc dot gnu dot org]

------- Comment #12 from jsm28 at gcc dot gnu dot org  2009-03-30 20:22 -------
Closing 4.2 branch, fixed in 4.3.


-- 

jsm28 at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
      Known to fail|3.3.3 3.4.0 4.0.0 4.1.0     |3.3.3 3.4.0 4.0.0 4.1.0
                   |4.2.0 4.0.4 4.1.2 4.1.1     |4.2.0 4.0.4 4.1.2 4.1.1
                   |4.1.0 4.0.4 4.0.3 4.0.2     |4.1.0 4.0.4 4.0.3 4.0.2
                   |4.0.1                       |4.0.1 4.2.5
      Known to work|3.0.4                       |3.0.4 4.3.0
         Resolution|                            |FIXED
   Target Milestone|4.2.5                       |4.3.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30460