[Bug fortran/30605] New: -Wno-tabs should be active for -std=f2003 and -pedantic

[Bug fortran/30605] New: -Wno-tabs should be active for -std=f2003 and -pedantic

[jb at gcc dot gnu dot org]

-Wno-tabs according to the manual currently is active for -pedantic, -std=f95,
and -Wall. It should be active for -std=f2003 as well. Finally, it's not
actually active for -pedantic. 

% cat xtabs.f90
        print *, "hi"
end

-std=f2003 and -pedantic don't work:

% gfortran -std=f2003 xtabs.f90
%

% gfortran -pedantic xtabs.f90
%

-std=f95 and -Wall do work:

% gfortran -std=f95 xtabs.f90
xtabs.f90:1.1:

 print *, "hi"
1
Warning: Nonconforming tab character at (1)

% gfortran -Wall xtabs.f90
xtabs.f90:1.1:

 print *, "hi"
1
Warning: Nonconforming tab character at (1)


-- 
           Summary: -Wno-tabs should be active for -std=f2003 and -pedantic
           Product: gcc
           Version: 4.3.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: jb at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30605

[Bug fortran/30605] -Wno-tabs should be active for -std=f2003 and -pedantic

[kargl at gcc dot gnu dot org]

------- Comment #1 from kargl at gcc dot gnu dot org  2007-01-27 00:01 -------
Created an attachment (id=12966)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=12966&action=view)
untested patch

Here's an untested patch.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30605

[Bug fortran/30605] -Wno-tabs should be active for -std=f2003 and -pedantic

[kargl at gcc dot gnu dot org]

------- Comment #2 from kargl at gcc dot gnu dot org  2007-01-27 00:02 -------
Confirmed.  I just attached an untested patch.


-- 

kargl at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2007-01-27 00:02:23
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30605

[Bug fortran/30605] -Wno-tabs should be active for -std=f2003 and -pedantic

[kargl at gcc dot gnu dot org]

------- Comment #3 from kargl at gcc dot gnu dot org  2007-01-27 00:45 -------
Testing the patch shows -pedantic has found some invalid code
in the testsuite.


-- 

kargl at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kargl at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30605

[Bug fortran/30605] -Wno-tabs should be active for -std=f2003 and -pedantic

[kargl at gcc dot gnu dot org]

-- 

kargl at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |kargl at gcc dot gnu dot org
                   |dot org                     |
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2007-01-27 00:02:23         |2007-01-27 18:01:16
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30605

[Bug fortran/30605] -Wno-tabs should be active for -std=f2003 and -pedantic

[jb at gcc dot gnu dot org]

------- Comment #4 from jb at gcc dot gnu dot org  2007-01-30 23:06 -------
As an aside, aren't -Wtabs and -Wno-tabs reversed? Now -Wno-tabs warns against
tabs, but shouldn't it be -Wtabs that warns against using them and -Wno-tabs
should turn the warning off? 


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30605

[Bug fortran/30605] -Wno-tabs should be active for -std=f2003 and -pedantic

[sgk at troutmask dot apl dot washington dot edu]

------- Comment #5 from sgk at troutmask dot apl dot washington dot edu  2007-01-30 23:09 -------
Subject: Re:  -Wno-tabs should be active for -std=f2003 and -pedantic

On Tue, Jan 30, 2007 at 11:06:24PM -0000, jb at gcc dot gnu dot org wrote:
> 
> ------- Comment #4 from jb at gcc dot gnu dot org  2007-01-30 23:06 -------
> As an aside, aren't -Wtabs and -Wno-tabs reversed? Now -Wno-tabs warns against
> tabs, but shouldn't it be -Wtabs that warns against using them and -Wno-tabs
> should turn the warning off? 
> 

Well, when I wrote the original patch I interpreted -Wno-tabs
as "No tabs allowed in source", and -Wtabs is its opposite.
We can change this if others want.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30605

[Bug fortran/30605] -Wno-tabs should be active for -std=f2003 and -pedantic

[jb at gcc dot gnu dot org]

------- Comment #6 from jb at gcc dot gnu dot org  2007-02-01 11:30 -------
Right, I guess that's an equally valid POV. Thus, I don't think it's worth the
trouble to reverse them and confuse our users.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30605

[Bug fortran/30605] [4.2 only] -Wno-tabs should be active for -std=f2003 and -pedantic

[kargl at gcc dot gnu dot org]

------- Comment #7 from kargl at gcc dot gnu dot org  2007-02-04 21:31 -------
Fixed on trunk.


-- 

kargl at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|-Wno-tabs should be active  |[4.2 only] -Wno-tabs should
                   |for -std=f2003 and -pedantic|be active for -std=f2003 and
                   |                            |-pedantic


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30605

[Bug fortran/30605] [4.2 only] -Wno-tabs should be active for -std=f2003 and -pedantic

[kargl at gcc dot gnu dot org]

------- Comment #8 from kargl at gcc dot gnu dot org  2007-02-06 00:28 -------
Subject: Bug 30605

Author: kargl
Date: Tue Feb  6 00:28:14 2007
New Revision: 121631

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=121631
Log:
2007-02-05  Steven G. Kargl <kargl@gcc.gnu.org>

        PR fortran/30605
        * fortran/invoke.texi: Update documentation.
        * fortran/options.c (gfc_post_options): Deal with tabs with -std=f2003
        and -pedantic.

2007-02-04  Steven G. Kargl <kargl@gcc.gnu.org>

        PR fortran/30605
        * gfortran.dg/spread_shape_1.f90: Remove tabs.
        * gfortran.dg/derived_init_2.f90: Ditto.
        * gfortran.dg/elemental_subroutine_3.f90: Ditto.
        * gfortran.dg/array_initializer_1.f90: Ditto.
        * gfortran.dg/do_2.f90: Ditto.
        * gfortran.dg/proc_assign_1.f90: Ditto.


Modified:
    branches/gcc-4_2-branch/gcc/fortran/ChangeLog
    branches/gcc-4_2-branch/gcc/fortran/options.c
    branches/gcc-4_2-branch/gcc/testsuite/ChangeLog
    branches/gcc-4_2-branch/gcc/testsuite/gfortran.dg/array_initializer_1.f90
    branches/gcc-4_2-branch/gcc/testsuite/gfortran.dg/derived_init_2.f90
    branches/gcc-4_2-branch/gcc/testsuite/gfortran.dg/do_2.f90
   
branches/gcc-4_2-branch/gcc/testsuite/gfortran.dg/elemental_subroutine_3.f90
    branches/gcc-4_2-branch/gcc/testsuite/gfortran.dg/proc_assign_1.f90
    branches/gcc-4_2-branch/gcc/testsuite/gfortran.dg/spread_shape_1.f90


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30605

[Bug fortran/30605] [4.2 only] -Wno-tabs should be active for -std=f2003 and -pedantic

[kargl at gcc dot gnu dot org]

------- Comment #9 from kargl at gcc dot gnu dot org  2007-02-06 00:31 -------
Fixed in trunk and 4.2.  Won't fix in 4.1 or earlier.


-- 

kargl at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30605