public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug inline-asm/27301]  New: ICE on convoluted inline asm with "m" (statement expression)
@ 2006-04-25  9:00 jakub at gcc dot gnu dot org
  2006-04-25 18:41 ` [Bug inline-asm/27301] [4.0/4.1/4.2 Regression] ICE on convoluted inline asm with "m" (statement expression and vla) pinskia at gcc dot gnu dot org
                   ` (13 more replies)
  0 siblings, 14 replies; 15+ messages in thread
From: jakub at gcc dot gnu dot org @ 2006-04-25  9:00 UTC (permalink / raw)
  To: gcc-bugs

inline void
foo (void *ptr, long n)
{
  __asm__ __volatile__ ("" : : "m" (__extension__
                                    ({ struct { char x[n]; } *p = ptr;
                                     *p; })));

}

void
bar (void)
{
  char buf[16];
  foo (buf, sizeof foo);
}

ICEs in tree_cst_low, apparently GCC attempts to create a VLA through non-VLA
mechanism (expand_one_stack_var).


-- 
           Summary: ICE on convoluted inline asm with "m" (statement
                    expression)
           Product: gcc
           Version: 4.1.1
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: inline-asm
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: jakub at gcc dot gnu dot org
GCC target triplet: i686-linux, x86_64-linux


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27301


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [Bug inline-asm/27301] [4.0/4.1/4.2 Regression] ICE on convoluted inline asm with "m" (statement expression and vla)
  2006-04-25  9:00 [Bug inline-asm/27301] New: ICE on convoluted inline asm with "m" (statement expression) jakub at gcc dot gnu dot org
@ 2006-04-25 18:41 ` pinskia at gcc dot gnu dot org
  2006-04-25 18:47 ` [Bug c/27301] " pinskia at gcc dot gnu dot org
                   ` (12 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2006-04-25 18:41 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #1 from pinskia at gcc dot gnu dot org  2006-04-25 18:41 -------
Confirmed, the ICE is at least a regression.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
      Known to fail|                            |4.1.0 4.0.0 4.2.0
   Last reconfirmed|0000-00-00 00:00:00         |2006-04-25 18:41:51
               date|                            |
            Summary|ICE on convoluted inline asm|[4.0/4.1/4.2 Regression] ICE
                   |with "m" (statement         |on convoluted inline asm
                   |expression and vla)         |with "m" (statement
                   |                            |expression and vla)
   Target Milestone|---                         |4.0.4


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27301


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [Bug c/27301] [4.0/4.1/4.2 Regression] ICE on convoluted inline asm with "m" (statement expression and vla)
  2006-04-25  9:00 [Bug inline-asm/27301] New: ICE on convoluted inline asm with "m" (statement expression) jakub at gcc dot gnu dot org
  2006-04-25 18:41 ` [Bug inline-asm/27301] [4.0/4.1/4.2 Regression] ICE on convoluted inline asm with "m" (statement expression and vla) pinskia at gcc dot gnu dot org
@ 2006-04-25 18:47 ` pinskia at gcc dot gnu dot org
  2006-04-30  6:11 ` pinskia at gcc dot gnu dot org
                   ` (11 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2006-04-25 18:47 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #2 from pinskia at gcc dot gnu dot org  2006-04-25 18:47 -------
Hmm, interesting, we have a TARGET_EXPR before gimplifying:
  __asm__ __volatile__(""::"m" TARGET_EXPR <D.1284, {
    typedef struct
    {
      char x[0:(unsigned int) ((int) SAVE_EXPR <n> - 1)];
    } struct struct
    {
      char x[0:(unsigned int) ((int) SAVE_EXPR <n> - 1)];
    };
    struct
    {
      char x[0:(unsigned int) ((int) SAVE_EXPR <n> - 1)];
    } * p = (struct
    {
      char x[0:(unsigned int) ((int) SAVE_EXPR <n> - 1)];
    } *) ptr;


Which might be the real issue.
The C++ front-end rejects this code as a VLA type is invalid even for GNU C++.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|inline-asm                  |c


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27301


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [Bug c/27301] [4.0/4.1/4.2 Regression] ICE on convoluted inline asm with "m" (statement expression and vla)
  2006-04-25  9:00 [Bug inline-asm/27301] New: ICE on convoluted inline asm with "m" (statement expression) jakub at gcc dot gnu dot org
  2006-04-25 18:41 ` [Bug inline-asm/27301] [4.0/4.1/4.2 Regression] ICE on convoluted inline asm with "m" (statement expression and vla) pinskia at gcc dot gnu dot org
  2006-04-25 18:47 ` [Bug c/27301] " pinskia at gcc dot gnu dot org
@ 2006-04-30  6:11 ` pinskia at gcc dot gnu dot org
  2006-05-06 11:00 ` enrico dot scholz at informatik dot tu-chemnitz dot de
                   ` (10 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2006-04-30  6:11 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #3 from pinskia at gcc dot gnu dot org  2006-04-30 06:11 -------
Note the correct version of the inline-asm as far as I can tell is:

  __asm__ __volatile__ ("" : : "m" (__extension__
                                    *({ struct { char x[n]; } *p = ptr;
                                     p; })));

Which solves the ICE.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27301


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [Bug c/27301] [4.0/4.1/4.2 Regression] ICE on convoluted inline asm with "m" (statement expression and vla)
  2006-04-25  9:00 [Bug inline-asm/27301] New: ICE on convoluted inline asm with "m" (statement expression) jakub at gcc dot gnu dot org
                   ` (2 preceding siblings ...)
  2006-04-30  6:11 ` pinskia at gcc dot gnu dot org
@ 2006-05-06 11:00 ` enrico dot scholz at informatik dot tu-chemnitz dot de
  2006-06-04 18:35 ` mmitchel at gcc dot gnu dot org
                   ` (9 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: enrico dot scholz at informatik dot tu-chemnitz dot de @ 2006-05-06 11:00 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #4 from enrico dot scholz at informatik dot tu-chemnitz dot de  2006-05-06 11:00 -------
fwiw (I reported the issue in the RH bugzilla, which was then forwarded by
Jakub):

I toke this syntax out of the gcc documentation: info gcc -> g Extended Asm

| As an example, if you access ten bytes of a string, you can use a memory
input 
| like:
| 
|      {"m"( ({ struct { char x[10]; } *p = (void *)ptr ; *p; }) )}.


-- 

enrico dot scholz at informatik dot tu-chemnitz dot de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |enrico dot scholz at
                   |                            |informatik dot tu-chemnitz
                   |                            |dot de


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27301


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [Bug c/27301] [4.0/4.1/4.2 Regression] ICE on convoluted inline asm with "m" (statement expression and vla)
  2006-04-25  9:00 [Bug inline-asm/27301] New: ICE on convoluted inline asm with "m" (statement expression) jakub at gcc dot gnu dot org
                   ` (3 preceding siblings ...)
  2006-05-06 11:00 ` enrico dot scholz at informatik dot tu-chemnitz dot de
@ 2006-06-04 18:35 ` mmitchel at gcc dot gnu dot org
  2006-08-27 21:32 ` pinskia at gcc dot gnu dot org
                   ` (8 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: mmitchel at gcc dot gnu dot org @ 2006-06-04 18:35 UTC (permalink / raw)
  To: gcc-bugs



-- 

mmitchel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27301


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [Bug c/27301] [4.0/4.1/4.2 Regression] ICE on convoluted inline asm with "m" (statement expression and vla)
  2006-04-25  9:00 [Bug inline-asm/27301] New: ICE on convoluted inline asm with "m" (statement expression) jakub at gcc dot gnu dot org
                   ` (4 preceding siblings ...)
  2006-06-04 18:35 ` mmitchel at gcc dot gnu dot org
@ 2006-08-27 21:32 ` pinskia at gcc dot gnu dot org
  2007-02-03 16:52 ` [Bug c/27301] [4.0/4.1/4.2/4.3 " gdr at gcc dot gnu dot org
                   ` (7 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2006-08-27 21:32 UTC (permalink / raw)
  To: gcc-bugs

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 762 bytes --]



------- Comment #5 from pinskia at gcc dot gnu dot org  2006-08-27 21:32 -------
On the mainline we get a different ICE now:
[pinskia@celery gcc]$ ~/gcc-local//bin/gcc t.c
t.c: In function ‘foo’:
t.c:4: internal compiler error: in force_constant_size, at gimplify.c:709
Please submit a full bug report,
with preprocessed source if appropriate.
See <URL:http://gcc.gnu.org/bugs.html> for instructions.

Which showed up with:
2006-06-23  Olivier Hainque  <hainque@adacore.com>


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 GCC target triplet|i686-linux, x86_64-linux    |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27301


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [Bug c/27301] [4.0/4.1/4.2/4.3 Regression] ICE on convoluted inline asm with "m" (statement expression and vla)
  2006-04-25  9:00 [Bug inline-asm/27301] New: ICE on convoluted inline asm with "m" (statement expression) jakub at gcc dot gnu dot org
                   ` (5 preceding siblings ...)
  2006-08-27 21:32 ` pinskia at gcc dot gnu dot org
@ 2007-02-03 16:52 ` gdr at gcc dot gnu dot org
  2007-02-03 20:29 ` pinskia at gcc dot gnu dot org
                   ` (6 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: gdr at gcc dot gnu dot org @ 2007-02-03 16:52 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #6 from gdr at gcc dot gnu dot org  2007-02-03 16:52 -------
won't fix in GCC-4.0.x.  Adjusting milestone.


-- 

gdr at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.0.4                       |4.1.3


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27301


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [Bug c/27301] [4.0/4.1/4.2/4.3 Regression] ICE on convoluted inline asm with "m" (statement expression and vla)
  2006-04-25  9:00 [Bug inline-asm/27301] New: ICE on convoluted inline asm with "m" (statement expression) jakub at gcc dot gnu dot org
                   ` (6 preceding siblings ...)
  2007-02-03 16:52 ` [Bug c/27301] [4.0/4.1/4.2/4.3 " gdr at gcc dot gnu dot org
@ 2007-02-03 20:29 ` pinskia at gcc dot gnu dot org
  2007-02-14  9:25 ` mmitchel at gcc dot gnu dot org
                   ` (5 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2007-02-03 20:29 UTC (permalink / raw)
  To: gcc-bugs



-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.1.3                       |4.1.2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27301


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [Bug c/27301] [4.0/4.1/4.2/4.3 Regression] ICE on convoluted inline asm with "m" (statement expression and vla)
  2006-04-25  9:00 [Bug inline-asm/27301] New: ICE on convoluted inline asm with "m" (statement expression) jakub at gcc dot gnu dot org
                   ` (7 preceding siblings ...)
  2007-02-03 20:29 ` pinskia at gcc dot gnu dot org
@ 2007-02-14  9:25 ` mmitchel at gcc dot gnu dot org
  2007-09-20 10:10 ` jakub at gcc dot gnu dot org
                   ` (4 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: mmitchel at gcc dot gnu dot org @ 2007-02-14  9:25 UTC (permalink / raw)
  To: gcc-bugs



-- 

mmitchel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.1.2                       |4.1.3


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27301


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [Bug c/27301] [4.0/4.1/4.2/4.3 Regression] ICE on convoluted inline asm with "m" (statement expression and vla)
  2006-04-25  9:00 [Bug inline-asm/27301] New: ICE on convoluted inline asm with "m" (statement expression) jakub at gcc dot gnu dot org
                   ` (8 preceding siblings ...)
  2007-02-14  9:25 ` mmitchel at gcc dot gnu dot org
@ 2007-09-20 10:10 ` jakub at gcc dot gnu dot org
  2007-09-20 21:20 ` jakub at gcc dot gnu dot org
                   ` (3 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: jakub at gcc dot gnu dot org @ 2007-09-20 10:10 UTC (permalink / raw)
  To: gcc-bugs



-- 

jakub at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |jakub at gcc dot gnu dot org
                   |dot org                     |
                URL|                            |http://gcc.gnu.org/ml/gcc-
                   |                            |patches/2007-
                   |                            |09/msg01593.html
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2007-08-06 14:40:25         |2007-09-20 10:10:11
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27301


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [Bug c/27301] [4.0/4.1/4.2/4.3 Regression] ICE on convoluted inline asm with "m" (statement expression and vla)
  2006-04-25  9:00 [Bug inline-asm/27301] New: ICE on convoluted inline asm with "m" (statement expression) jakub at gcc dot gnu dot org
                   ` (9 preceding siblings ...)
  2007-09-20 10:10 ` jakub at gcc dot gnu dot org
@ 2007-09-20 21:20 ` jakub at gcc dot gnu dot org
  2007-09-21  9:51 ` [Bug c/27301] [4.0/4.1/4.2 " jakub at gcc dot gnu dot org
                   ` (2 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: jakub at gcc dot gnu dot org @ 2007-09-20 21:20 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #7 from jakub at gcc dot gnu dot org  2007-09-20 21:19 -------
Subject: Bug 27301

Author: jakub
Date: Thu Sep 20 21:19:36 2007
New Revision: 128629

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=128629
Log:
        PR c/33238
        PR c/27301
        * gimplify.c (gimplify_vla_decl): New function.
        (gimplify_decl_expr): Move VLA decl handling to gimplify_vla_decl.
        Call it.
        (gimplify_target_expr): Handle variable length TARGET_EXPRs.

        * gcc.c-torture/execute/20070919-1.c: New test.
        * gcc.dg/pr33238.c: New test.
        * gcc.dg/pr27301.c: New test.

Added:
    trunk/gcc/testsuite/gcc.c-torture/execute/20070919-1.c
    trunk/gcc/testsuite/gcc.dg/pr27301.c
    trunk/gcc/testsuite/gcc.dg/pr33238.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/gimplify.c
    trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27301


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [Bug c/27301] [4.0/4.1/4.2 Regression] ICE on convoluted inline asm with "m" (statement expression and vla)
  2006-04-25  9:00 [Bug inline-asm/27301] New: ICE on convoluted inline asm with "m" (statement expression) jakub at gcc dot gnu dot org
                   ` (10 preceding siblings ...)
  2007-09-20 21:20 ` jakub at gcc dot gnu dot org
@ 2007-09-21  9:51 ` jakub at gcc dot gnu dot org
  2008-07-04 21:21 ` [Bug c/27301] [4.2 " jsm28 at gcc dot gnu dot org
  2009-03-30 15:52 ` jsm28 at gcc dot gnu dot org
  13 siblings, 0 replies; 15+ messages in thread
From: jakub at gcc dot gnu dot org @ 2007-09-21  9:51 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #8 from jakub at gcc dot gnu dot org  2007-09-21 09:50 -------
Fixed so far in 4.3.


-- 

jakub at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to work|                            |4.3.0
            Summary|[4.0/4.1/4.2/4.3 Regression]|[4.0/4.1/4.2 Regression] ICE
                   |ICE on convoluted inline asm|on convoluted inline asm
                   |with "m" (statement         |with "m" (statement
                   |expression and vla)         |expression and vla)


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27301


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [Bug c/27301] [4.2 Regression] ICE on convoluted inline asm with "m" (statement expression and vla)
  2006-04-25  9:00 [Bug inline-asm/27301] New: ICE on convoluted inline asm with "m" (statement expression) jakub at gcc dot gnu dot org
                   ` (11 preceding siblings ...)
  2007-09-21  9:51 ` [Bug c/27301] [4.0/4.1/4.2 " jakub at gcc dot gnu dot org
@ 2008-07-04 21:21 ` jsm28 at gcc dot gnu dot org
  2009-03-30 15:52 ` jsm28 at gcc dot gnu dot org
  13 siblings, 0 replies; 15+ messages in thread
From: jsm28 at gcc dot gnu dot org @ 2008-07-04 21:21 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #9 from jsm28 at gcc dot gnu dot org  2008-07-04 21:20 -------
Closing 4.1 branch.


-- 

jsm28 at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[4.1/4.2 Regression] ICE on |[4.2 Regression] ICE on
                   |convoluted inline asm with  |convoluted inline asm with
                   |"m" (statement expression   |"m" (statement expression
                   |and vla)                    |and vla)
   Target Milestone|4.1.3                       |4.2.5


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27301


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [Bug c/27301] [4.2 Regression] ICE on convoluted inline asm with "m" (statement expression and vla)
  2006-04-25  9:00 [Bug inline-asm/27301] New: ICE on convoluted inline asm with "m" (statement expression) jakub at gcc dot gnu dot org
                   ` (12 preceding siblings ...)
  2008-07-04 21:21 ` [Bug c/27301] [4.2 " jsm28 at gcc dot gnu dot org
@ 2009-03-30 15:52 ` jsm28 at gcc dot gnu dot org
  13 siblings, 0 replies; 15+ messages in thread
From: jsm28 at gcc dot gnu dot org @ 2009-03-30 15:52 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #10 from jsm28 at gcc dot gnu dot org  2009-03-30 15:52 -------
Closing 4.2 branch, fixed in 4.3.


-- 

jsm28 at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
      Known to fail|4.1.0 4.0.0 4.0.4 4.2.0     |4.1.0 4.0.0 4.0.4 4.2.0
                   |                            |4.2.5
         Resolution|                            |FIXED
   Target Milestone|4.2.5                       |4.3.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27301


^ permalink raw reply	[flat|nested] 15+ messages in thread

end of thread, other threads:[~2009-03-30 15:52 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-04-25  9:00 [Bug inline-asm/27301] New: ICE on convoluted inline asm with "m" (statement expression) jakub at gcc dot gnu dot org
2006-04-25 18:41 ` [Bug inline-asm/27301] [4.0/4.1/4.2 Regression] ICE on convoluted inline asm with "m" (statement expression and vla) pinskia at gcc dot gnu dot org
2006-04-25 18:47 ` [Bug c/27301] " pinskia at gcc dot gnu dot org
2006-04-30  6:11 ` pinskia at gcc dot gnu dot org
2006-05-06 11:00 ` enrico dot scholz at informatik dot tu-chemnitz dot de
2006-06-04 18:35 ` mmitchel at gcc dot gnu dot org
2006-08-27 21:32 ` pinskia at gcc dot gnu dot org
2007-02-03 16:52 ` [Bug c/27301] [4.0/4.1/4.2/4.3 " gdr at gcc dot gnu dot org
2007-02-03 20:29 ` pinskia at gcc dot gnu dot org
2007-02-14  9:25 ` mmitchel at gcc dot gnu dot org
2007-09-20 10:10 ` jakub at gcc dot gnu dot org
2007-09-20 21:20 ` jakub at gcc dot gnu dot org
2007-09-21  9:51 ` [Bug c/27301] [4.0/4.1/4.2 " jakub at gcc dot gnu dot org
2008-07-04 21:21 ` [Bug c/27301] [4.2 " jsm28 at gcc dot gnu dot org
2009-03-30 15:52 ` jsm28 at gcc dot gnu dot org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).