[Bug fortran/30554] New: ICE in mio_pointer_ref at module.c:1945

[Bug fortran/30554] New: ICE in mio_pointer_ref at module.c:1945

[burnus at gcc dot gnu dot org]

> gfortran -c test.f90
test.f90:8: internal compiler error: Segmentation fault

Backtrace:
0x000000000043c85e in mio_pointer_ref (gp=0x28) at module.c:1945
1945          p = get_pointer (*((char **) gp));

#1  0x000000000043ccb7 in mio_symbol_ref (symp=0x28) at module.c:2174
#2  0x000000000043cd39 in mio_symtree_ref (stp=0xe44260) at module.c:2200

Test case:
------------------------------------
MODULE ATOMS
INTEGER :: NFREE = 0
END MODULE ATOMS

MODULE CONSTRAINT
USE ATOMS, ONLY: NFREE
CONTAINS
   SUBROUTINE ENERGY_CONSTRAINT ( HESSIAN )
   REAL , DIMENSION(1:(3*NFREE*(3*NFREE+1))/2):: HESSIAN
   END SUBROUTINE ENERGY_CONSTRAINT
END MODULE CONSTRAINT

MODULE POTENTIAL_ENERGY
USE ATOMS
USE CONSTRAINT,         ONLY : ENERGY_CONSTRAINT
END MODULE POTENTIAL_ENERGY
------------------------------------


-- 
           Summary: ICE in mio_pointer_ref at module.c:1945
           Product: gcc
           Version: 4.3.0
            Status: UNCONFIRMED
          Keywords: ice-on-valid-code
          Severity: normal
          Priority: P3
         Component: fortran
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: burnus at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30554

[Bug fortran/30554] ICE in mio_pointer_ref at module.c:1945

[burnus at gcc dot gnu dot org]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 346 bytes --]



------- Comment #1 from burnus at gcc dot gnu dot org  2007-01-23 10:34 -------
Based on the bugreport by Ignacio Fernández Galván
http://gcc.gnu.org/ml/fortran/2007-01/msg00531.html

The test case has been extracted from the Dynamo package,
http://www.pdynamo.org/Installation.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30554

[Bug fortran/30554] ICE in mio_pointer_ref at module.c:1945

[fxcoudert at gcc dot gnu dot org]

-- 

fxcoudert at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2007-01-23 13:30:32
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30554

[Bug fortran/30554] ICE in mio_pointer_ref at module.c:1945

[burnus at gcc dot gnu dot org]

------- Comment #2 from burnus at gcc dot gnu dot org  2007-01-23 20:56 -------
Some more debug information:

The error occurs when the symbol "hessian" is written.
The error is gone if one removes the ": only ENERGY_CONSTRAINT" or the "use
atoms" from the POTENTIAL_ENERGY module (if you have {atom,constraint}.mod
files, the two use statements in POTENTIAL_ENERGY are enough to cause the ICE.)

Till write_symbol everything looks fine (and a printf(sym-name) prints
"hessian" before the ICE occurs.)

==1963== Invalid read of size 8
==1963==    at 0x43C85E: mio_pointer_ref (module.c:1945)
==1963==    by 0x43CCB6: mio_symbol_ref (module.c:2174)
==1963==    by 0x43CD38: mio_symtree_ref (module.c:2200)
==1963==    by 0x43D767: mio_expr (module.c:2699)
==1963==    by 0x43C5E1: mio_array_spec (module.c:1846)
==1963==    by 0x43DCC8: mio_symbol (module.c:2946)
==1963==    by 0x43EC5B: write_symbol (module.c:3640)
==1963==    by 0x43EE0E: write_symbol1 (module.c:3708)
==1963==    by 0x43EDC1: write_symbol1 (module.c:3701)
==1963==    by 0x43F149: write_module (module.c:3828)
==1963==    by 0x43F34D: gfc_dump_module (module.c:3891)
==1963==    by 0x446C2A: gfc_parse_file (parse.c:3239)
==1963==  Address 0x28 is not stack'd, malloc'd or (recently) free'd


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30554

[Bug fortran/30554] ICE in mio_pointer_ref at module.c:1945

[pault at gcc dot gnu dot org]

------- Comment #3 from pault at gcc dot gnu dot org  2007-01-28 08:03 -------
Tobias,

> The error occurs when the symbol "hessian" is written.
> The error is gone if one removes the ": only ENERGY_CONSTRAINT" or the "use
> atoms" from the POTENTIAL_ENERGY module (if you have {atom,constraint}.mod
> files, the two use statements in POTENTIAL_ENERGY are enough to cause the ICE.)

The segfault also goes if you interchange the order of the two USE statements.

Paul


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30554

[Bug fortran/30554] ICE in mio_pointer_ref at module.c:1945

[patchapp at dberlin dot org]

------- Comment #4 from patchapp at dberlin dot org  2007-01-28 12:30 -------
Subject: Bug number PR30554

A patch for this bug has been added to the patch tracker.
The mailing list url for the patch is
http://gcc.gnu.org/ml/gcc-patches/2007-01/msg02282.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30554

[Bug fortran/30554] ICE in mio_pointer_ref at module.c:1945

[pault at gcc dot gnu dot org]

------- Comment #5 from pault at gcc dot gnu dot org  2007-01-28 13:40 -------
It looks like it is mine.

Paul


-- 

pault at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |pault at gcc dot gnu dot org
                   |dot org                     |
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2007-01-23 13:30:32         |2007-01-28 13:40:34
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30554

[Bug fortran/30554] ICE in mio_pointer_ref at module.c:1945

[pault at gcc dot gnu dot org]

------- Comment #6 from pault at gcc dot gnu dot org  2007-01-29 10:28 -------
Subject: Bug 30554

Author: pault
Date: Mon Jan 29 10:27:50 2007
New Revision: 121281

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=121281
Log:
2007-01-29  Paul Thomas  <pault@gcc.gnu.org>

        PR fortran/30554
        * module.c (read_module): If a symbol is excluded by an ONLY
        clause, check to see if there is a symtree already loaded. If
        so, attach the symtree to the pointer_info.

2007-01-29  Paul Thomas  <pault@gcc.gnu.org>

        PR fortran/30554
        * gfortran.dg/used_dummy_types_6.f90: New test.

Added:
    trunk/gcc/testsuite/gfortran.dg/used_dummy_types_6.f90
Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/module.c
    trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30554

[Bug fortran/30554] [4.2 and 4.1 only] ICE in mio_pointer_ref at module.c:1945

[jellby at yahoo dot com]

------- Comment #7 from jellby at yahoo dot com  2007-02-02 09:26 -------
The patch seems to fix the problem with the test file. Unfortunately, the
original problem with the Dynamo package remains, I still get:

gfortran -c -I./modules -J./modules -O3 -o objects/energy.o ./source/energy.F90
./source/energy.F90:0: internal compiler error: Segmentation fault


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30554

[Bug fortran/30554] [4.2 and 4.1 only] ICE in mio_pointer_ref at module.c:1945

[burnus at gcc dot gnu dot org]

------- Comment #8 from burnus at gcc dot gnu dot org  2007-02-02 10:03 -------
> The patch seems to fix the problem with the test file. Unfortunately, the
> original problem with the Dynamo package remains:

Modified test case - added:
  PRIVATE
  PUBLIC :: ENergY_CONTRAINT

-------------------------
MODULE ATOMS
INTEGER :: NFREE = 0
END MODULE ATOMS

MODULE CONSTRAINT
USE ATOMS, ONLY: NFREE
PRIVATE
PUBLIC :: ENERGY_CONSTRAINT
CONTAINS
   SUBROUTINE ENERGY_CONSTRAINT ( HESSIAN )
   REAL , DIMENSION(1:(3*NFREE*(3*NFREE+1))/2):: HESSIAN
   END SUBROUTINE ENERGY_CONSTRAINT
END MODULE CONSTRAINT

MODULE POTENTIAL_ENERGY
USE ATOMS
USE CONSTRAINT,         ONLY : ENERGY_CONSTRAINT
END MODULE POTENTIAL_ENERGY
-------------------------

The backtrace looks rather similar:

Program received signal SIGSEGV, Segmentation fault.
mio_pointer_ref (gp=0x28) at fortran/module.c:1945
1945          p = get_pointer (*((char **) gp));
(gdb) bt
#0  mio_pointer_ref (gp=0x28) at fortran/module.c:1945
#1  0x000000000043b549 in mio_symbol_ref (symp=0x28) at /fortran/module.c:2174
#2  0x000000000043bfab in mio_expr (ep=0xe52fd8) at fortran/module.c:2699
#3  0x000000000043c080 in mio_expr (ep=0xe52f20) at fortran/module.c:2655
#4  0x000000000043c077 in mio_expr (ep=0xe52e70) at fortran/module.c:2654
#5  0x000000000043c102 in mio_expr (ep=0xe52dc0) at fortran/module.c:2635
#6  0x000000000043c077 in mio_expr (ep=0xe4dfd0) at fortran/module.c:2654
#7  0x000000000043c783 in mio_array_spec (asp=<value optimized out>) at
fortran/module.c:1846
#8  0x000000000043cdb3 in mio_symbol (sym=0xe50490) at fortran/module.c:2946
#9  0x000000000043d257 in write_symbol (n=38, sym=0xe50490) at
fortran/module.c:3647


In order to test the real program, use:
Dynamo molecular dynamics library (<http://www.pdynamo.org/Installation.html>)
In the Makefile:
  FC = gfortran
  FFLAGS  = -c -I$(MOD_DIR) -J$(MOD_DIR) -O3
  FFLAGS1 = -c -I$(MOD_DIR) -J$(MOD_DIR) -O1
Run:
DYNAMO_HOME=. make all


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30554

[Bug fortran/30554] [4.2 and 4.1 only] ICE in mio_pointer_ref at module.c:1945

[pault at gcc dot gnu dot org]

------- Comment #9 from pault at gcc dot gnu dot org  2007-02-03 07:26 -------
Aaahhh... that's disappointing.  I'm off on a trip agian next week and this
will be loaded up on the portable as the 5 here and 5 there task.

Paul

PS


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30554

[Bug fortran/30554] [4.2 and 4.1 only] ICE in mio_pointer_ref at module.c:1945

[pault at gcc dot gnu dot org]

------- Comment #10 from pault at gcc dot gnu dot org  2007-02-03 21:11 -------
This fixes the problem and regtests OK:

Index: gcc/fortran/module.c
===================================================================
*** gcc/fortran/module.c        (revision 121540)
--- gcc/fortran/module.c        (working copy)
*************** write_symtree (gfc_symtree *st)
*** 3757,3771 ****
    pointer_info *p;

    sym = st->n.sym;
!   if (!gfc_check_access (sym->attr.access, sym->ns->default_access)
!       || (sym->attr.flavor == FL_PROCEDURE && sym->attr.generic
!         && !sym->attr.subroutine && !sym->attr.function))
      return;

    if (check_unique_name (st->name))
      return;

    p = find_pointer (sym);
    if (p == NULL)
      gfc_internal_error ("write_symtree(): Symbol not written");

--- 3757,3776 ----
    pointer_info *p;

    sym = st->n.sym;
!   if (!sym->attr.use_assoc
!       && (!gfc_check_access (sym->attr.access, sym->ns->default_access)
!               || (sym->attr.flavor == FL_PROCEDURE && sym->attr.generic
!                     && !sym->attr.subroutine && !sym->attr.function)))
      return;

    if (check_unique_name (st->name))
      return;

    p = find_pointer (sym);
+ 
+   if (p == NULL && sym->attr.use_assoc)
+     return;
+ 
    if (p == NULL)
      gfc_internal_error ("write_symtree(): Symbol not written");


I need to examine the part of the standard that deals with PRIVATE and PUBLIC
in modules to see if this really is right.

Watch this space.

Paul


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30554

[Bug fortran/30554] [4.2 and 4.1 only] ICE in mio_pointer_ref at module.c:1945

[pault at gcc dot gnu dot org]

------- Comment #11 from pault at gcc dot gnu dot org  2007-02-04 12:05 -------
PS
> 
> I need to examine the part of the standard that deals with PRIVATE and PUBLIC
> in modules to see if this really is right.
> 
I should have said, even if it is not correct, this clearly is touching the
right place and must be nearly OK.

Paul


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30554

[Bug fortran/30554] [4.2 and 4.1 only] ICE in mio_pointer_ref at module.c:1945

[patchapp at dberlin dot org]

------- Comment #12 from patchapp at dberlin dot org  2007-02-09 12:20 -------
Subject: Bug number PR30554

A patch for this bug has been added to the patch tracker.
The mailing list url for the patch is
http://gcc.gnu.org/ml/gcc-patches/2007-02/msg00807.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30554

[Bug fortran/30554] [4.2 and 4.1 only] ICE in mio_pointer_ref at module.c:1945

[pault at gcc dot gnu dot org]

------- Comment #13 from pault at gcc dot gnu dot org  2007-02-11 20:59 -------
Subject: Bug 30554

Author: pault
Date: Sun Feb 11 20:58:48 2007
New Revision: 121824

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=121824
Log:
2007-02-11  Paul Thomas  <pault@gcc.gnu.org>

        PR fortran/30554
        * module.c (find_symtree_for_symbol): New function to return
        a symtree that is not a "unique symtree" given a symbol.
        (read_module): Do not automatically set pointer_info to
        referenced because this inhibits the generation of a unique
        symtree.  Recycle the existing symtree if possible by calling
        find_symtree_for_symbol.

        PR fortran/30319
        * decl.c (add_init_expr_to_sym): Make new charlen for an array
        constructor initializer.

2007-02-11  Paul Thomas  <pault@gcc.gnu.org>

        PR fortran/30554
        * gfortran.dg/used_dummy_types_6.f90: Add the "privatized"
        versions of the modules.

        PR fortran/30617
        * gfortran.dg/intrinsic_actual_2.f90: Make this legal fortran
        by getting rid of recursive I/O and providing functions with
        results.

        PR fortran/30319
        * gfortran.dg/char_array_constructor_2.f90

Added:
    trunk/gcc/testsuite/gfortran.dg/char_array_constructor_2.f90
Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/decl.c
    trunk/gcc/fortran/module.c
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/gfortran.dg/intrinsic_actual_2.f90
    trunk/gcc/testsuite/gfortran.dg/used_dummy_types_6.f90


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30554

[Bug fortran/30554] [4.2 and 4.1 only] ICE in mio_pointer_ref at module.c:1945

[pault at gcc dot gnu dot org]

------- Comment #14 from pault at gcc dot gnu dot org  2007-02-12 23:40 -------
Subject: Bug 30554

Author: pault
Date: Mon Feb 12 23:39:51 2007
New Revision: 121865

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=121865
Log:
2007-02-13  Paul Thomas  <pault@gcc.gnu.org>

        PR fortran/30554
        * module.c (read_module): Set pointer_info to referenced if the
        symbol has no namespace.

2007-02-12  Paul Thomas  <pault@gcc.gnu.org>

        PR fortran/30554
        * gfortran.dg/used_dummy_types_7.f90: New test.

Added:
    trunk/gcc/testsuite/gfortran.dg/used_dummy_types_7.f90
Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/module.c
    trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30554

[Bug fortran/30554] [4.2 and 4.1 only] ICE in mio_pointer_ref at module.c:1945

[pault at gcc dot gnu dot org]

------- Comment #15 from pault at gcc dot gnu dot org  2007-02-17 17:17 -------
Subject: Bug 30554

Author: pault
Date: Sat Feb 17 17:16:56 2007
New Revision: 122074

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=122074
Log:
2007-02-17  Paul Thomas  <pault@gcc.gnu.org>

        PR fortran/30554
        * module.c (find_symtree_for_symbol): New function to return
        a symtree that is not a "unique symtree" given a symbol.
        (read_module): Do not automatically set pointer_info to
        referenced, if the symbol has a namespace, because this
        inhibits the generation of a unique symtree.  Recycle the
        symtree if possible by calling find_symtree_for_symbol. If a
        symbol is excluded by an ONLY clause, check to see if there is
        a symtree already loaded. If so, attach the symtree to the
        pointer_info.

        PR fortran/30319
        * decl.c (add_init_expr_to_sym): Make new charlen for an array
        constructor initializer.

2007-02-17  Paul Thomas  <pault@gcc.gnu.org>

        PR fortran/30554
        * gfortran.dg/used_dummy_types_6.f90: New test.
        * gfortran.dg/used_dummy_types_7.f90: New test..

        PR fortran/30617
        * gfortran.dg/intrinsic_actual_2.f90: Make this legal fortran
        by getting rid of recursive I/O and providing functions with
        results.

        PR fortran/30319
        * gfortran.dg/char_array_constructor_2.f90



Added:
   
branches/gcc-4_2-branch/gcc/testsuite/gfortran.dg/char_array_constructor_2.f90
    branches/gcc-4_2-branch/gcc/testsuite/gfortran.dg/used_dummy_types_6.f90
    branches/gcc-4_2-branch/gcc/testsuite/gfortran.dg/used_dummy_types_7.f90
Modified:
    branches/gcc-4_2-branch/gcc/fortran/ChangeLog
    branches/gcc-4_2-branch/gcc/fortran/decl.c
    branches/gcc-4_2-branch/gcc/fortran/module.c
    branches/gcc-4_2-branch/gcc/testsuite/ChangeLog
    branches/gcc-4_2-branch/gcc/testsuite/gfortran.dg/intrinsic_actual_2.f90


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30554

[Bug fortran/30554] [4.1 only] ICE in mio_pointer_ref at module.c:1945

[pault at gcc dot gnu dot org]

------- Comment #16 from pault at gcc dot gnu dot org  2007-02-17 17:18 -------
Fixed on trunk and 4.2

Paul


-- 

pault at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
            Summary|[4.2 and 4.1 only] ICE in   |[4.1 only] ICE in
                   |mio_pointer_ref at          |mio_pointer_ref at
                   |module.c:1945               |module.c:1945


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30554