public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug fortran/30882] New: incorrect error message for valid code
@ 2007-02-20 7:54 jv244 at cam dot ac dot uk
2007-02-20 14:04 ` [Bug fortran/30882] size with initialization expression value for dim= is rejected burnus at gcc dot gnu dot org
` (5 more replies)
0 siblings, 6 replies; 7+ messages in thread
From: jv244 at cam dot ac dot uk @ 2007-02-20 7:54 UTC (permalink / raw)
To: gcc-bugs
With recent trunk, gfortran incorrectly generates an error for the following
standard code:
SUBROUTINE S1(a)
INTEGER :: a(*)
IF(SIZE(a(1:10),1).NE.10) CALL ABORT()
END SUBROUTINE S1
INTEGER :: a(10)
CALL S1(a)
END
--
Summary: incorrect error message for valid code
Product: gcc
Version: 4.3.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: fortran
AssignedTo: unassigned at gcc dot gnu dot org
ReportedBy: jv244 at cam dot ac dot uk
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30882
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug fortran/30882] size with initialization expression value for dim= is rejected
2007-02-20 7:54 [Bug fortran/30882] New: incorrect error message for valid code jv244 at cam dot ac dot uk
@ 2007-02-20 14:04 ` burnus at gcc dot gnu dot org
2007-02-22 9:30 ` pault at gcc dot gnu dot org
` (4 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: burnus at gcc dot gnu dot org @ 2007-02-20 14:04 UTC (permalink / raw)
To: gcc-bugs
------- Comment #1 from burnus at gcc dot gnu dot org 2007-02-20 14:04 -------
IF(SIZE(a(1:10),1).NE.10) CALL ABORT()
1
Error: 'dim' argument of 'size' intrinsic at (1) is not a valid dimension index
Compiles just fine with ifort, nagf95 and g95.
--
burnus at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
Ever Confirmed|0 |1
Keywords| |rejects-valid
Last reconfirmed|0000-00-00 00:00:00 |2007-02-20 14:04:36
date| |
Summary|incorrect error message for |size with initialization
|valid code |expression value for dim= is
| |rejected
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30882
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug fortran/30882] size with initialization expression value for dim= is rejected
2007-02-20 7:54 [Bug fortran/30882] New: incorrect error message for valid code jv244 at cam dot ac dot uk
2007-02-20 14:04 ` [Bug fortran/30882] size with initialization expression value for dim= is rejected burnus at gcc dot gnu dot org
@ 2007-02-22 9:30 ` pault at gcc dot gnu dot org
2007-03-03 3:01 ` patchapp at dberlin dot org
` (3 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: pault at gcc dot gnu dot org @ 2007-02-22 9:30 UTC (permalink / raw)
To: gcc-bugs
------- Comment #2 from pault at gcc dot gnu dot org 2007-02-22 09:30 -------
(In reply to comment #1)
This fixes it:
Index: gcc/fortran/check.c
===================================================================
*** gcc/fortran/check.c (revision 122101)
--- gcc/fortran/check.c (working copy)
*************** dim_rank_check (gfc_expr *dim, gfc_expr
*** 337,343 ****
ar = gfc_find_array_ref (array);
rank = array->rank;
! if (ar->as->type == AS_ASSUMED_SIZE && !allow_assumed)
rank--;
if (mpz_cmp_ui (dim->value.integer, 1) < 0
--- 337,346 ----
ar = gfc_find_array_ref (array);
rank = array->rank;
! if (ar->as->type == AS_ASSUMED_SIZE
! && !allow_assumed
! && ar->type != AR_ELEMENT
! && ar->type != AR_SECTION)
rank--;
if (mpz_cmp_ui (dim->value.integer, 1) < 0
As with other recent PRs, I cannot do anything with it for a bit - feel free to
see it to completion.
Paul
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30882
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug fortran/30882] size with initialization expression value for dim= is rejected
2007-02-20 7:54 [Bug fortran/30882] New: incorrect error message for valid code jv244 at cam dot ac dot uk
2007-02-20 14:04 ` [Bug fortran/30882] size with initialization expression value for dim= is rejected burnus at gcc dot gnu dot org
2007-02-22 9:30 ` pault at gcc dot gnu dot org
@ 2007-03-03 3:01 ` patchapp at dberlin dot org
2007-03-03 10:43 ` burnus at gcc dot gnu dot org
` (2 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: patchapp at dberlin dot org @ 2007-03-03 3:01 UTC (permalink / raw)
To: gcc-bugs
------- Comment #3 from patchapp at dberlin dot org 2007-03-03 03:01 -------
Subject: Bug number PR30882
A patch for this bug has been added to the patch tracker.
The mailing list url for the patch is
http://gcc.gnu.org/ml/gcc-patches/2007-03/msg00111.html
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30882
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug fortran/30882] size with initialization expression value for dim= is rejected
2007-02-20 7:54 [Bug fortran/30882] New: incorrect error message for valid code jv244 at cam dot ac dot uk
` (2 preceding siblings ...)
2007-03-03 3:01 ` patchapp at dberlin dot org
@ 2007-03-03 10:43 ` burnus at gcc dot gnu dot org
2007-03-03 13:31 ` [Bug fortran/30882] [4.1 and 4.2 only] " burnus at gcc dot gnu dot org
2007-03-27 9:01 ` pault at gcc dot gnu dot org
5 siblings, 0 replies; 7+ messages in thread
From: burnus at gcc dot gnu dot org @ 2007-03-03 10:43 UTC (permalink / raw)
To: gcc-bugs
------- Comment #4 from burnus at gcc dot gnu dot org 2007-03-03 10:43 -------
Subject: Bug 30882
Author: burnus
Date: Sat Mar 3 10:43:25 2007
New Revision: 122503
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=122503
Log:
2007-03-03 Paul Thomas <pault@gcc.gnu.org>
PR fortran/30882
* check.c (dim_rank_check): The shape of subsections of
assumed-size arrays is known.
2007-03-03 Paul Thomas <pault@gcc.gnu.org>
PR fortran/30882
* gfortran.dg/size_dim.f90: New test.
-- Diese und die folgenden Zeilen werden ignoriert --
M gcc/testsuite/ChangeLog
A gcc/testsuite/gfortran.dg/size_dim.f90
M gcc/fortran/ChangeLog
M gcc/fortran/check.c
Added:
trunk/gcc/testsuite/gfortran.dg/size_dim.f90
Modified:
trunk/gcc/fortran/ChangeLog
trunk/gcc/fortran/check.c
trunk/gcc/testsuite/ChangeLog
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30882
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug fortran/30882] [4.1 and 4.2 only] size with initialization expression value for dim= is rejected
2007-02-20 7:54 [Bug fortran/30882] New: incorrect error message for valid code jv244 at cam dot ac dot uk
` (3 preceding siblings ...)
2007-03-03 10:43 ` burnus at gcc dot gnu dot org
@ 2007-03-03 13:31 ` burnus at gcc dot gnu dot org
2007-03-27 9:01 ` pault at gcc dot gnu dot org
5 siblings, 0 replies; 7+ messages in thread
From: burnus at gcc dot gnu dot org @ 2007-03-03 13:31 UTC (permalink / raw)
To: gcc-bugs
--
burnus at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|unassigned at gcc dot gnu |burnus at gcc dot gnu dot
|dot org |org
Status|NEW |ASSIGNED
Last reconfirmed|2007-02-20 14:04:36 |2007-03-03 13:30:59
date| |
Summary|size with initialization |[4.1 and 4.2 only] size with
|expression value for dim= is|initialization expression
|rejected |value for dim= is rejected
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30882
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug fortran/30882] [4.1 and 4.2 only] size with initialization expression value for dim= is rejected
2007-02-20 7:54 [Bug fortran/30882] New: incorrect error message for valid code jv244 at cam dot ac dot uk
` (4 preceding siblings ...)
2007-03-03 13:31 ` [Bug fortran/30882] [4.1 and 4.2 only] " burnus at gcc dot gnu dot org
@ 2007-03-27 9:01 ` pault at gcc dot gnu dot org
5 siblings, 0 replies; 7+ messages in thread
From: pault at gcc dot gnu dot org @ 2007-03-27 9:01 UTC (permalink / raw)
To: gcc-bugs
------- Comment #5 from pault at gcc dot gnu dot org 2007-03-27 10:01 -------
This is not a regression wrt 4.1 so closing.
Paul
--
pault at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30882
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2007-03-27 9:01 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-02-20 7:54 [Bug fortran/30882] New: incorrect error message for valid code jv244 at cam dot ac dot uk
2007-02-20 14:04 ` [Bug fortran/30882] size with initialization expression value for dim= is rejected burnus at gcc dot gnu dot org
2007-02-22 9:30 ` pault at gcc dot gnu dot org
2007-03-03 3:01 ` patchapp at dberlin dot org
2007-03-03 10:43 ` burnus at gcc dot gnu dot org
2007-03-03 13:31 ` [Bug fortran/30882] [4.1 and 4.2 only] " burnus at gcc dot gnu dot org
2007-03-27 9:01 ` pault at gcc dot gnu dot org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).