[Bug c++/29475] [4.0/4.1/4.2 Regression] incomplete template diagnostics.

[Bug c++/29475] [4.0/4.1/4.2 Regression] incomplete template diagnostics.

[pinskia at gcc dot gnu dot org]

------- Comment #1 from pinskia at gcc dot gnu dot org  2006-10-15 14:52 -------
Confirmed, a regression from 3.3.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2006-10-15 14:52:00
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29475

[Bug c++/29475] [4.0/4.1/4.2 Regression] incomplete template diagnostics.

[mmitchel at gcc dot gnu dot org]

-- 

mmitchel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29475

[Bug c++/29475] [4.0/4.1/4.2/4.3 Regression] incomplete template diagnostics.

[patchapp at dberlin dot org]

------- Comment #2 from patchapp at dberlin dot org  2006-11-05 20:40 -------
Subject: Bug number PR c++/29475

A patch for this bug has been added to the patch tracker.
The mailing list url for the patch is
http://gcc.gnu.org/ml/gcc-patches/2006-11/msg00266.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29475

[Bug c++/29475] [4.0/4.1/4.2/4.3 Regression] incomplete template diagnostics.

[mmitchel at gcc dot gnu dot org]

------- Comment #3 from mmitchel at gcc dot gnu dot org  2006-11-20 21:16 -------
Subject: Bug 29475

Author: mmitchel
Date: Mon Nov 20 21:15:44 2006
New Revision: 119027

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=119027
Log:
        PR c++/29475
        * cp-tree.h (enforce_access, perform_or_defer_access_check): Added an
        extra argument that represents the declaration to use to print
        potential error messages.
        * init.c (build_offset_ref): Adjusted the call to
        perform_or_defer_access_check.
        * class.c (alter_access, resolve_address_of_overloaded_function):
        Likewise.
        * decl.c (make_typename_type, make_unbound_class_template): Likewise. 
        * search.c (lookup_member): Likewise.
        * friend.c (add_friend): Likewise.
        * parser.c (cp_parser_template_id,
        cp_parser_pre_parsed_nested_name_specifier): Likewise.
        * semantics.c (finish_non_static_data_member,
        check_accessibility_of_qualified_id, finish_id_expression): Likewise.
        (pop_to_parent_deferring_access_checks, perform_access_checks,
        perform_or_defer_access_check): Adjusted the call to enforce_access.
        * call.c (enforce_access): Use the new extra argument to build the
        error message.
        (build_op_delete_call): Adjusted the call to
        perform_or_defer_access_check.
        (build_over_call): Likewise.

        PR c++/29475
        * g++.dg/template/access19.C: New test.
        * g++.old-deja/g++.other/access11.C: Adjusted the line where the
        error is reported.

Added:
    trunk/gcc/testsuite/g++.dg/template/access19.C   (with props)
Modified:
    trunk/gcc/cp/ChangeLog
    trunk/gcc/cp/call.c
    trunk/gcc/cp/class.c
    trunk/gcc/cp/cp-tree.h
    trunk/gcc/cp/decl.c
    trunk/gcc/cp/friend.c
    trunk/gcc/cp/init.c
    trunk/gcc/cp/parser.c
    trunk/gcc/cp/search.c
    trunk/gcc/cp/semantics.c
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/g++.old-deja/g++.other/access11.C

Propchange: trunk/gcc/testsuite/g++.dg/template/access19.C
            ('svn:executable' added)


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29475

[Bug c++/29475] [4.0/4.1/4.2/4.3 Regression] incomplete template diagnostics.

[simartin at users dot sourceforge dot net]

------- Comment #4 from simartin at users dot sourceforge dot net  2006-11-20 22:56 -------
The previous commit fixes the test case given in the description. However,
there still exist cases where such an "incomplete" diagnostic can be given; I'm
working on a patch that will fix this bug completely...


-- 

simartin at users dot sourceforge dot net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |simartin at users dot
                   |                            |sourceforge dot net


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29475

[Bug c++/29475] [4.0/4.1/4.2/4.3 Regression] incomplete template diagnostics.

[simartin at gcc dot gnu dot org]

------- Comment #5 from simartin at gcc dot gnu dot org  2006-12-16 08:51 -------
Subject: Bug 29475

Author: simartin
Date: Sat Dec 16 08:51:42 2006
New Revision: 119961

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=119961
Log:
2006-12-16  Simon Martin  <simartin@users.sourceforge.net>

        PR c++/29475
        * cp-tree.h (struct deferred_access_check): New structure to represent
a
        deferred access check. It replaces the previous representation as a
tree.
        (get_deferred_access_checks): Return a vector of struct
        deferred_access_check instead of a tree list.
        (perform_access_checks): Take a vector of struct deferred_access_check
        instead of a tree list.
        * semantics.c (struct deferred_access): Store the deferred access
checks
        as a vector of struct deferred_access_check instead of a tree list.
        (push_deferring_access_checks): Handle the change in struct
        deferred_access.
        (get_deferred_access_checks): Likewise.
        (pop_to_parent_deferring_access_checks): Likewise.
        (perform_or_defer_access_check): Likewise.
        (perform_access_checks): Take a vector of struct deferred_access_check
        instead of a tree list.
        * parser.c (struct tree_check): New structure to store various data
        associated with a CPP_NESTED_NAME_SPECIFIER or CPP_TEMPLATE_ID token.
        (struct cp_token): Changed the value field to be a union with a pointer
to
        a struct tree_check for CPP_NESTED_NAME_SPECIFIER or CPP_TEMPLATE_ID
        tokens and a tree field for all other tokens.
        (eof_token): Adjusted due to the change in struct cp_token.
        (cp_lexer_get_preprocessor_token): Likewise.
        (cp_lexer_purge_token): Likewise.
        (cp_lexer_purge_tokens_after): Likewise.
        (cp_lexer_print_token): Likewise.
        (cp_parser_error): Likewise.
        (cp_parser_identifier): Likewise.
        (cp_parser_string_literal): Likewise.
        (cp_parser_primary_expression): Likewise.
        (cp_parser_unqualified_id): Likewise.
        (cp_parser_parenthesized_expression_list): Likewise.
        (cp_parser_storage_class_specifier_opt): Likewise.
        (cp_parser_function_specifier_opt): Likewise.
        (cp_parser_type_specifier): Likewise.
        (cp_parser_simple_type_specifier): Likewise.
        (cp_parser_initializer_list): Likewise.
        (cp_parser_member_specification_opt): Likewise.
        (cp_parser_attribute_list): Likewise.
        (cp_parser_objc_expression): Likewise.
        (cp_parser_objc_protocol_qualifiers): Likewise.
        (cp_parser_objc_selector): Likewise.
        (cp_parser_objc_declaration): Likewise.
        (cp_parser_objc_statement): Likewise.
        (cp_parser_omp_clause_name): Likewise.
        (cp_parser_omp_clause_default): Likewise.
        (cp_parser_omp_clause_schedule): Likewise.
        (cp_parser_omp_parallel): Likewise.
        (cp_parser_initial_pragma): Likewise.
        (pragma_lex): Likewise.
        (cp_parser_pre_parsed_nested_name_specifier): Likewise.
        (cp_parser_nested_name_specifier_opt): Likewise.
        Use cp_token::u::tree_check_value to save the token's value, the
        associated deferred checks and its qualifying scope.
        (cp_parser_template_id): Likewise.
        (cp_parser_template_declaration_after_export): Adjusted the call to
        get_deferred_access_checks.
        (cp_parser_init_declarator): Take the access checks as a vector of
struct
        deferred_access_check instead of a tree list.
        (cp_parser_single_declaration): Likewise.
        (cp_parser_perform_template_parameter_access_checks): Likewise.
        (cp_parser_simple_declaration): Adjusted the call to
        cp_parser_init_declarator.
        (cp_parser_explicit_specialization): Adjusted the call to
        cp_parser_single_declaration.

Modified:
    trunk/gcc/cp/ChangeLog
    trunk/gcc/cp/cp-tree.h
    trunk/gcc/cp/parser.c
    trunk/gcc/cp/semantics.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29475

[Bug c++/29475] [4.0/4.1/4.2 Regression] incomplete template diagnostics.

[gdr at gcc dot gnu dot org]

------- Comment #6 from gdr at gcc dot gnu dot org  2007-02-03 20:40 -------
won't fix in GCC-4.0.x.  Adjusting milestone.


-- 

gdr at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.0.4                       |4.1.3


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29475

[Bug c++/29475] [4.0/4.1/4.2 Regression] incomplete template diagnostics.

[pinskia at gcc dot gnu dot org]

-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.1.3                       |4.1.2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29475

[Bug c++/29475] [4.0/4.1/4.2 Regression] incomplete template diagnostics.

[pluto at agmk dot net]

------- Comment #7 from pluto at agmk dot net  2007-02-14 08:18 -------
what about backport for 4.1/4.2 ?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29475

[Bug c++/29475] [4.0/4.1/4.2 Regression] incomplete template diagnostics.

[mmitchel at gcc dot gnu dot org]

-- 

mmitchel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.1.2                       |4.1.3


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29475

[Bug c++/29475] [4.0/4.1/4.2 Regression] incomplete template diagnostics.

[simartin at gcc dot gnu dot org]

------- Comment #8 from simartin at gcc dot gnu dot org  2007-02-22 19:58 -------
Subject: Bug 29475

Author: simartin
Date: Thu Feb 22 19:57:55 2007
New Revision: 122236

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=122236
Log:
2007-02-22  Simon Martin  <simartin@users.sourceforge.net>

        PR c++/29475
        * cp-tree.h (struct deferred_access_check): New structure to represent
a
        deferred access check. It replaces the previous representation as a
tree.
        (get_deferred_access_checks): Return a vector of struct
        deferred_access_check instead of a tree list.
        (perform_access_checks): Take a vector of struct deferred_access_check
        instead of a tree list.
        (enforce_access, perform_or_defer_access_check): Added an
        extra argument that represents the declaration to use to print
        potential error messages.
        * semantics.c (struct deferred_access): Store the deferred access
checks
        as a vector of struct deferred_access_check instead of a tree list.
        (push_deferring_access_checks): Handle the change in struct
        deferred_access.
        (get_deferred_access_checks): Likewise.
        (pop_to_parent_deferring_access_checks): Likewise.
        (perform_or_defer_access_check): Likewise.
        (perform_access_checks): Take a vector of struct deferred_access_check
        instead of a tree list.
        (finish_non_static_data_member, check_accessibility_of_qualified_id,
        finish_id_expression): Adjusted the call to
perform_or_defer_access_check.
        (pop_to_parent_deferring_access_checks, perform_access_checks,
        perform_or_defer_access_check): Adjusted the call to enforce_access.
        * parser.c (struct tree_check): New structure to store various data
        associated with a CPP_NESTED_NAME_SPECIFIER or CPP_TEMPLATE_ID token.
        (struct cp_token): Changed the value field to be a union with a pointer
to
        a struct tree_check for CPP_NESTED_NAME_SPECIFIER or CPP_TEMPLATE_ID
        tokens and a tree field for all other tokens.
        (eof_token): Adjusted due to the change in struct cp_token.
        (cp_lexer_get_preprocessor_token): Likewise.
        (cp_lexer_purge_token): Likewise.
        (cp_lexer_purge_tokens_after): Likewise.
        (cp_lexer_print_token): Likewise.
        (cp_parser_error): Likewise.
        (cp_parser_identifier): Likewise.
        (cp_parser_string_literal): Likewise.
        (cp_parser_primary_expression): Likewise.
        (cp_parser_unqualified_id): Likewise.
        (cp_parser_parenthesized_expression_list): Likewise.
        (cp_parser_storage_class_specifier_opt): Likewise.
        (cp_parser_function_specifier_opt): Likewise.
        (cp_parser_type_specifier): Likewise.
        (cp_parser_simple_type_specifier): Likewise.
        (cp_parser_initializer_list): Likewise.
        (cp_parser_member_specification_opt): Likewise.
        (cp_parser_attribute_list): Likewise.
        (cp_parser_objc_expression): Likewise.
        (cp_parser_objc_protocol_qualifiers): Likewise.
        (cp_parser_objc_selector): Likewise.
        (cp_parser_objc_declaration): Likewise.
        (cp_parser_objc_statement): Likewise.
        (cp_parser_omp_clause_name): Likewise.
        (cp_parser_omp_clause_default): Likewise.
        (cp_parser_omp_clause_schedule): Likewise.
        (cp_parser_omp_parallel): Likewise.
        (cp_parser_initial_pragma): Likewise.
        (pragma_lex): Likewise.
        (cp_parser_pre_parsed_nested_name_specifier): Likewise.
        (cp_parser_nested_name_specifier_opt): Likewise.
        Use cp_token::u::tree_check_value to save the token's value, the
        associated deferred checks and its qualifying scope.
        (cp_parser_template_id): Likewise.
        (cp_parser_template_declaration_after_export): Adjusted the call to
        get_deferred_access_checks.
        (cp_parser_init_declarator): Take the access checks as a vector of
struct
        deferred_access_check instead of a tree list.
        (cp_parser_single_declaration): Likewise.
        (cp_parser_perform_template_parameter_access_checks): Likewise.
        (cp_parser_simple_declaration): Adjusted the call to
        cp_parser_init_declarator.
        (cp_parser_explicit_specialization): Adjusted the call to
        cp_parser_single_declaration.
        (cp_parser_template_id, cp_parser_pre_parsed_nested_name_specifier):
        Adjusted the call to perform_or_defer_access_check.
        * init.c (build_offset_ref): Adjusted the call to
        perform_or_defer_access_check.
        * class.c (alter_access, resolve_address_of_overloaded_function):
        Likewise.
        * decl.c (make_typename_type, make_unbound_class_template): Likewise.
        * search.c (lookup_member): Likewise.
        * friend.c (add_friend): Likewise.
        * call.c (enforce_access): Use the new extra argument to build the
        error message.
        (build_op_delete_call): Adjusted the call to
        perform_or_defer_access_check.
        (build_over_call): Likewise.

Added:
    branches/gcc-4_2-branch/gcc/testsuite/g++.dg/template/access19.C
Modified:
    branches/gcc-4_2-branch/gcc/cp/ChangeLog
    branches/gcc-4_2-branch/gcc/cp/call.c
    branches/gcc-4_2-branch/gcc/cp/class.c
    branches/gcc-4_2-branch/gcc/cp/cp-tree.h
    branches/gcc-4_2-branch/gcc/cp/decl.c
    branches/gcc-4_2-branch/gcc/cp/friend.c
    branches/gcc-4_2-branch/gcc/cp/init.c
    branches/gcc-4_2-branch/gcc/cp/parser.c
    branches/gcc-4_2-branch/gcc/cp/search.c
    branches/gcc-4_2-branch/gcc/cp/semantics.c
    branches/gcc-4_2-branch/gcc/testsuite/ChangeLog
    branches/gcc-4_2-branch/gcc/testsuite/g++.old-deja/g++.other/access11.C


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29475

[Bug c++/29475] [4.0/4.1 Regression] incomplete template diagnostics.

[simartin at gcc dot gnu dot org]

------- Comment #9 from simartin at gcc dot gnu dot org  2007-02-22 20:09 -------
Fixed on 4.2 as well.

I will not apply it on 4.1 as requested by Mark here:
http://gcc.gnu.org/ml/gcc-patches/2007-02/msg01781.html


-- 

simartin at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[4.0/4.1/4.2 Regression]    |[4.0/4.1 Regression]
                   |incomplete  template        |incomplete  template
                   |diagnostics.                |diagnostics.


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29475

[Bug c++/29475] [4.0/4.1 Regression] incomplete template diagnostics.

[pluto at agmk dot net]

------- Comment #10 from pluto at agmk dot net  2007-02-22 20:23 -------
fixed for >= 4.2
wontfix for < 4.2 ( too big impact for mature branches ).


-- 

pluto at agmk dot net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29475