public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "ubizjak at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/30778] [4.3 Regression] invalid code generation for memset() with -mtune=k8
Date: Sat, 24 Feb 2007 08:53:00 -0000	[thread overview]
Message-ID: <20070224085341.30852.qmail@sourceware.org> (raw)
In-Reply-To: <bug-30778-7958@http.gcc.gnu.org/bugzilla/>



------- Comment #2 from ubizjak at gmail dot com  2007-02-24 08:53 -------
The problem here is in ix86_expand_set_or_movmem_via_loop().

In mtune=k8 case, we choose unrolled_loop as the algorithm, where main loop is
expanded as

      expand_set_or_movmem_via_loop (dst, NULL, destreg, NULL, promoted_val,
                                     count_exp, Pmode, 4, expected_size);

However, the value of "expected_size" equals 31 in the above testcase! This is
smaller that the smallest chunk size (SIZEOF (Pmode) * 4), requested by caller. 

For some reason, expand_set_or_movmem_via_loop() doesn't detect this anomaly
and generates loop for requested chunk size.

The fix is obvious and straightforward. Bail out of
expand_set_or_movmem_via_loop() early if expected_size < piece_size.

I'll fix this in the evening (CET) if Jan won't beat me to it ;)


, where some kind of guard is missing before entering "Main loop" section.


-- 

ubizjak at gmail dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ubizjak at gmail dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30778


  parent reply	other threads:[~2007-02-24  8:53 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-12 19:03 [Bug middle-end/30778] New: " belyshev at depni dot sinp dot msu dot ru
2007-02-12 19:22 ` [Bug target/30778] " pinskia at gcc dot gnu dot org
2007-02-13  9:44 ` rguenth at gcc dot gnu dot org
2007-02-16  2:01 ` pinskia at gcc dot gnu dot org
2007-02-24  8:53 ` ubizjak at gmail dot com [this message]
2007-02-24 10:59 ` ubizjak at gmail dot com
2007-02-24 22:55 ` ubizjak at gmail dot com
2007-02-24 23:09 ` hubicka at gcc dot gnu dot org
2007-02-24 23:24 ` ubizjak at gmail dot com
2007-02-24 23:47 ` hubicka at gcc dot gnu dot org
2007-02-25  7:54 ` ubizjak at gmail dot com
2007-02-25 17:37 ` hubicka at gcc dot gnu dot org
2007-02-26  7:04 ` ubizjak at gmail dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070224085341.30852.qmail@sourceware.org \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).