[Bug fortran/30871] New: incorrect error message for valid code

[Bug fortran/30871] New: incorrect error message for valid code

[jv244 at cam dot ac dot uk]

With recent trunk, gfortran incorrectly generates an error for the following
standard code:
TYPE data
 CHARACTER(LEN=3) :: A
END TYPE
TYPE(data), DIMENSION(10), TARGET :: Z
CHARACTER(LEN=1), DIMENSION(:), POINTER :: ptr
Z(:)%A="123"
ptr=>Z(:)%A(2:2)
write(6,*) ptr
END


-- 
           Summary: incorrect error message for valid code
           Product: gcc
           Version: 4.3.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: jv244 at cam dot ac dot uk


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30871

[Bug fortran/30871] Pointer to substring rejected with "Different character lengths in pointer assignment"

[burnus at gcc dot gnu dot org]

------- Comment #1 from burnus at gcc dot gnu dot org  2007-02-20 16:53 -------
Error: Different character lengths in pointer assignment at (1)

Compiles with g95, ifort and nagf95.


-- 

burnus at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rejects-valid
            Summary|incorrect error message for |Pointer to substring
                   |valid code                  |rejected with "Different
                   |                            |character lengths in pointer
                   |                            |assignment"


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30871

[Bug fortran/30871] Pointer to substring rejected with "Different character lengths in pointer assignment"

[fxcoudert at gcc dot gnu dot org]

-- 

fxcoudert at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2007-03-03 10:46:40
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30871

[Bug fortran/30871] Pointer to substring rejected with "Different character lengths in pointer assignment"

[tobi at gcc dot gnu dot org]

-- 

tobi at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |tobi at gcc dot gnu dot org
                   |dot org                     |
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2007-03-03 10:46:40         |2007-04-10 15:14:17
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30871

[Bug fortran/30871] Pointer to substring rejected with "Different character lengths in pointer assignment"

[tobi at gcc dot gnu dot org]

------- Comment #2 from tobi at gcc dot gnu dot org  2007-04-12 18:17 -------
This is not fixed with the patch for PR31266.  The remaining issue looks
closely related to not using byte-sized strides in array descriptors.


-- 

tobi at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tobi at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30871

[Bug fortran/30871] Pointer to substring rejected with "Different character lengths in pointer assignment"

[tobi at gcc dot gnu dot org]

-- 

tobi at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|tobi at gcc dot gnu dot org |unassigned at gcc dot gnu
                   |                            |dot org
             Status|ASSIGNED                    |NEW


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30871

[Bug fortran/30871] Pointer to substring rejected with "Different character lengths in pointer assignment"

[jv244 at cam dot ac dot uk]

------- Comment #3 from jv244 at cam dot ac dot uk  2007-07-03 18:23 -------
this has become an ICE in the meanwhile
test.f90:6: internal compiler error: in gfc_conv_expr_descriptor, at
fortran/trans-array.c:4492


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30871

[Bug fortran/30871] Pointer to substring rejected with "Different character lengths in pointer assignment"

[pault at gcc dot gnu dot org]

-- 

pault at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |pault at gcc dot gnu dot org
                   |dot org                     |
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2007-04-10 15:14:17         |2007-09-03 11:48:57
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30871

[Bug fortran/30871] Pointer to substring rejected with "Different character lengths in pointer assignment"

[pault at gcc dot gnu dot org]

------- Comment #4 from pault at gcc dot gnu dot org  2007-09-16 09:18 -------
Subject: Bug 30871

Author: pault
Date: Sun Sep 16 09:17:49 2007
New Revision: 128523

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=128523
Log:
2007-09-16  Paul Thomas  <pault@gcc.gnu.org>

        PR fortran/29396
        PR fortran/29606
        PR fortran/30625
        PR fortran/30871
        * trans.h : Add extra argument to gfc_build_array_ref. Rename
        gfc_conv_aliased_arg to gfc_conv_subref_array_arg.  Move
        prototype of is_aliased_array to gfortran.h and rename it
        gfc_is_subref_array.  Add field span to lang_decl, add a new
        decl lang specific flag accessed by GFC_DECL_SUBREF_ARRAY_P
        and a new type flag GFC_DECL_SUBREF_ARRAY_P.
        * trans.c (gfc_build_array_ref): Add the new argument, decl.
        If this is a subreference array pointer, use the lang_decl
        field 'span' to calculate the offset in bytes and use pointer
        arithmetic to address the element.
        * trans-array.c (gfc_conv_scalarized_array_ref,
        gfc_conv_array_ref): Add the backend declaration as the third
        field, if it is likely to be a subreference array pointer.
        (gfc_conv_descriptor_dimension, gfc_trans_array_ctor_element,
        gfc_trans_array_constructor_element, structure_alloc_comps,
        gfc_conv_array_index_offset): For all other references to
        gfc_build_array_ref, set the third argument to NULL.
        (gfc_get_dataptr_offset): New function.
        (gfc_conv_expr_descriptor): If the rhs of a pointer assignment
        is a subreference array, then calculate the offset to the
        subreference of the first element and set the descriptor data
        pointer to this, using gfc_get_dataptr_offset.
        trans-expr.c (gfc_get_expr_charlen): Use the expression for the
        character length for a character subreference.
        (gfc_conv_substring, gfc_conv_subref_array_arg): Add NULL for
        third argument in call to gfc_build_array_ref.
        (gfc_conv_aliased_arg): Rename to gfc_conv_subref_array_arg.
        (is_aliased_array): Remove.
        (gfc_conv_function_call): Change reference to is_aliased_array
        to gfc_is_subref_array and reference to gfc_conv_aliased_arg to
        gfc_conv_subref_array_arg.
        (gfc_trans_pointer_assignment): Add the array element length to
        the lang_decl 'span' field.
        * gfortran.h : Add subref_array_pointer to symbol_attribute and
        add the prototype for gfc_is_subref_array.
        * trans-stmt.c : Add NULL for third argument in all references
        to gfc_build_array_ref.
        * expr.c (gfc_is_subref_array): Renamed is_aliased_array.
        If this is a subreference array pointer, return true.
        (gfc_check_pointer_assign): If the rhs is a subreference array,
        set the lhs subreference_array_pointer attribute.
        * trans-decl.c (gfc_get_symbol_decl): Allocate the lang_decl
        field if the symbol is a subreference array pointer and set an
        initial value of zero for the 'span' field.
        * trans-io.c (set_internal_unit): Refer to is_subref_array and
        gfc_conv_subref_array_arg.
        (nml_get_addr_expr): Add NULL third argument to
        gfc_build_array_ref. 
        (gfc_trans_transfer): Use the scalarizer for a subreference
        array.

2007-09-16  Paul Thomas  <pault@gcc.gnu.org>

        PR fortran/29396
        PR fortran/29606
        PR fortran/30625
        PR fortran/30871
        * gfortran.dg/subref_array_pointer_1.f90: New test.
        * gfortran.dg/subref_array_pointer_2.f90: New test.


Added:
    trunk/gcc/testsuite/gfortran.dg/subref_array_pointer_1.f90
    trunk/gcc/testsuite/gfortran.dg/subref_array_pointer_2.f90
Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/expr.c
    trunk/gcc/fortran/gfortran.h
    trunk/gcc/fortran/trans-array.c
    trunk/gcc/fortran/trans-decl.c
    trunk/gcc/fortran/trans-expr.c
    trunk/gcc/fortran/trans-io.c
    trunk/gcc/fortran/trans-stmt.c
    trunk/gcc/fortran/trans.c
    trunk/gcc/fortran/trans.h
    trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30871

[Bug fortran/30871] Pointer to substring rejected with "Different character lengths in pointer assignment"

[pault at gcc dot gnu dot org]

------- Comment #5 from pault at gcc dot gnu dot org  2007-09-16 09:39 -------
Fixed on trunk

Paul


-- 

pault at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30871