public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug libfortran/30005]  New: Open errors (not/already exists etc.): show also the file name
@ 2006-11-28  8:46 burnus at gcc dot gnu dot org
  2006-12-03 20:16 ` [Bug libfortran/30005] " jvdelisle at gcc dot gnu dot org
                   ` (6 more replies)
  0 siblings, 7 replies; 8+ messages in thread
From: burnus at gcc dot gnu dot org @ 2006-11-28  8:46 UTC (permalink / raw)
  To: gcc-bugs

Example 1:
  open(77,file="not-existing.dat",status="old")
gfortran:
  At line 1 of file aaaa.f90
  Fortran runtime error: No such file or directory
ifort:
  forrtl: severe (29): file not found, unit 77, file /dev/shm/not-existing.dat
Expected: Add (similar to ifort) also the file name (and maybe the unit
number?) to the error message.

This should also be the case if no "file=" has been given, e.g.
  open(77,status="old")
ifort: file not found, unit 77, file /dev/shm/fort.77

Reasoning:
a) It is easier to see directly the needed file name than finding it in the
source code
b) The user might not have access to the source code


Example 2:
  open(77,file="already-existing.dat",status="new")
gfortran:
  At line 1 of file aaaa.f90
  Fortran runtime error: File exists
ifort:
  cannot overwrite existing file, unit 77, file /dev/shm/already-existing.dat
Expected: Add (similar to ifort) also the file name (and maybe the unit
number?) to the error message.


-- 
           Summary: Open errors (not/already exists etc.): show also the
                    file name
           Product: gcc
           Version: 4.3.0
            Status: UNCONFIRMED
          Keywords: diagnostic
          Severity: enhancement
          Priority: P3
         Component: libfortran
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: burnus at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30005


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug libfortran/30005] Open errors (not/already exists etc.): show also the file name
  2006-11-28  8:46 [Bug libfortran/30005] New: Open errors (not/already exists etc.): show also the file name burnus at gcc dot gnu dot org
@ 2006-12-03 20:16 ` jvdelisle at gcc dot gnu dot org
  2006-12-03 22:45 ` jvdelisle at gcc dot gnu dot org
                   ` (5 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: jvdelisle at gcc dot gnu dot org @ 2006-12-03 20:16 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #1 from jvdelisle at gcc dot gnu dot org  2006-12-03 20:16 -------
I have a patch for this testing.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30005


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug libfortran/30005] Open errors (not/already exists etc.): show also the file name
  2006-11-28  8:46 [Bug libfortran/30005] New: Open errors (not/already exists etc.): show also the file name burnus at gcc dot gnu dot org
  2006-12-03 20:16 ` [Bug libfortran/30005] " jvdelisle at gcc dot gnu dot org
@ 2006-12-03 22:45 ` jvdelisle at gcc dot gnu dot org
  2006-12-04  5:20 ` patchapp at dberlin dot org
                   ` (4 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: jvdelisle at gcc dot gnu dot org @ 2006-12-03 22:45 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #2 from jvdelisle at gcc dot gnu dot org  2006-12-03 22:45 -------
Created an attachment (id=12736)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=12736&action=view)
Preliminary patch

This patch adds a few checks for types of errors on opening a file to give a
more use friendly message.  I will probably put together a helper function in
error.c to do this in the final patch.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30005


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug libfortran/30005] Open errors (not/already exists etc.): show also the file name
  2006-11-28  8:46 [Bug libfortran/30005] New: Open errors (not/already exists etc.): show also the file name burnus at gcc dot gnu dot org
  2006-12-03 20:16 ` [Bug libfortran/30005] " jvdelisle at gcc dot gnu dot org
  2006-12-03 22:45 ` jvdelisle at gcc dot gnu dot org
@ 2006-12-04  5:20 ` patchapp at dberlin dot org
  2006-12-05  0:51 ` jvdelisle at gcc dot gnu dot org
                   ` (3 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: patchapp at dberlin dot org @ 2006-12-04  5:20 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #3 from patchapp at dberlin dot org  2006-12-04 05:20 -------
Subject: Bug number PR30005

A patch for this bug has been added to the patch tracker.
The mailing list url for the patch is
http://gcc.gnu.org/ml/gcc-patches/2006-12/msg00181.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30005


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug libfortran/30005] Open errors (not/already exists etc.): show also the file name
  2006-11-28  8:46 [Bug libfortran/30005] New: Open errors (not/already exists etc.): show also the file name burnus at gcc dot gnu dot org
                   ` (2 preceding siblings ...)
  2006-12-04  5:20 ` patchapp at dberlin dot org
@ 2006-12-05  0:51 ` jvdelisle at gcc dot gnu dot org
  2006-12-05 20:40 ` burnus at gcc dot gnu dot org
                   ` (2 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: jvdelisle at gcc dot gnu dot org @ 2006-12-05  0:51 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #4 from jvdelisle at gcc dot gnu dot org  2006-12-05 00:51 -------
Subject: Bug 30005

Author: jvdelisle
Date: Tue Dec  5 00:51:26 2006
New Revision: 119530

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=119530
Log:
2006-12-04  Jerry DeLisle  <jvdelisle@gcc.gnu.org>

        PR libfortran/30005
        * io/open.c: Add errno.h include.
        (new_unit): Add new error messages with file name for file open.

Modified:
    trunk/libgfortran/ChangeLog
    trunk/libgfortran/io/open.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30005


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug libfortran/30005] Open errors (not/already exists etc.): show also the file name
  2006-11-28  8:46 [Bug libfortran/30005] New: Open errors (not/already exists etc.): show also the file name burnus at gcc dot gnu dot org
                   ` (3 preceding siblings ...)
  2006-12-05  0:51 ` jvdelisle at gcc dot gnu dot org
@ 2006-12-05 20:40 ` burnus at gcc dot gnu dot org
  2006-12-16  5:27 ` jvdelisle at gcc dot gnu dot org
  2007-03-07 14:24 ` tkoenig at gcc dot gnu dot org
  6 siblings, 0 replies; 8+ messages in thread
From: burnus at gcc dot gnu dot org @ 2006-12-05 20:40 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #5 from burnus at gcc dot gnu dot org  2006-12-05 20:40 -------
Mark as fixed. As enhancement it does not need to go into 4.2/4.1.


-- 

burnus at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30005


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug libfortran/30005] Open errors (not/already exists etc.): show also the file name
  2006-11-28  8:46 [Bug libfortran/30005] New: Open errors (not/already exists etc.): show also the file name burnus at gcc dot gnu dot org
                   ` (4 preceding siblings ...)
  2006-12-05 20:40 ` burnus at gcc dot gnu dot org
@ 2006-12-16  5:27 ` jvdelisle at gcc dot gnu dot org
  2007-03-07 14:24 ` tkoenig at gcc dot gnu dot org
  6 siblings, 0 replies; 8+ messages in thread
From: jvdelisle at gcc dot gnu dot org @ 2006-12-16  5:27 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #6 from jvdelisle at gcc dot gnu dot org  2006-12-16 05:27 -------
Subject: Bug 30005

Author: jvdelisle
Date: Sat Dec 16 05:27:31 2006
New Revision: 119960

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=119960
Log:
2006-12-15  Jerry DeLisle  <jvdelisle@gcc.gnu.org>

        PR libfortran/30005
        * gfortran.dg/open_errors.f90: New test.

Added:
    trunk/gcc/testsuite/gfortran.dg/open_errors.f90
Modified:
    trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30005


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug libfortran/30005] Open errors (not/already exists etc.): show also the file name
  2006-11-28  8:46 [Bug libfortran/30005] New: Open errors (not/already exists etc.): show also the file name burnus at gcc dot gnu dot org
                   ` (5 preceding siblings ...)
  2006-12-16  5:27 ` jvdelisle at gcc dot gnu dot org
@ 2007-03-07 14:24 ` tkoenig at gcc dot gnu dot org
  6 siblings, 0 replies; 8+ messages in thread
From: tkoenig at gcc dot gnu dot org @ 2007-03-07 14:24 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #7 from tkoenig at gcc dot gnu dot org  2007-03-07 14:24 -------
*** Bug 31053 has been marked as a duplicate of this bug. ***


-- 

tkoenig at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |vivekrao4 at yahoo dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30005


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2007-03-07 14:24 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-11-28  8:46 [Bug libfortran/30005] New: Open errors (not/already exists etc.): show also the file name burnus at gcc dot gnu dot org
2006-12-03 20:16 ` [Bug libfortran/30005] " jvdelisle at gcc dot gnu dot org
2006-12-03 22:45 ` jvdelisle at gcc dot gnu dot org
2006-12-04  5:20 ` patchapp at dberlin dot org
2006-12-05  0:51 ` jvdelisle at gcc dot gnu dot org
2006-12-05 20:40 ` burnus at gcc dot gnu dot org
2006-12-16  5:27 ` jvdelisle at gcc dot gnu dot org
2007-03-07 14:24 ` tkoenig at gcc dot gnu dot org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).