[Bug libfortran/31099] New: Runtime error on legal code using RECL

[Bug libfortran/31099] New: Runtime error on legal code using RECL

[fxcoudert at gcc dot gnu dot org]

$ cat a.f90 
 PROGRAM TEST
   INTEGER :: A
   OPEN(10, FORM="UNFORMATTED", RECL=1024)
   A = -1
   WRITE(10) A
 END PROGRAM TEST

$ gfortran a.f90 && ./a.out            
At line 5 of file a.f90
Fortran runtime error: I/O past end of record on unformatted file
$ pgf90 a.f90 && ./a.out && xxd fort.10  
0000000: 0400 0000 ffff ffff 0400 0000            ............
$ sunf90 a.f90 && ./a.out && xxd fort.10
0000000: 0400 0000 ffff ffff 0400 0000            ............
$ ifort a.f90 && ./a.out && xxd fort.10 
0000000: 0400 0000 ffff ffff 0400 0000            ............


-- 
           Summary: Runtime error on legal code using RECL
           Product: gcc
           Version: 4.3.0
            Status: UNCONFIRMED
          Keywords: wrong-code
          Severity: normal
          Priority: P3
         Component: libfortran
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: fxcoudert at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31099

[Bug libfortran/31099] [4.3/4.2 regression] Runtime error on legal code using RECL

[fxcoudert at gcc dot gnu dot org]

------- Comment #1 from fxcoudert at gcc dot gnu dot org  2007-03-09 10:06 -------
This one hurts. Nevertheless, it's probably too late for 4.2.0...


-- 

fxcoudert at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jerrydy at sbcglobal dot net
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
      Known to fail|                            |4.2.0 4.3.0
      Known to work|                            |4.1.2
   Last reconfirmed|0000-00-00 00:00:00         |2007-03-09 10:06:17
               date|                            |
            Summary|Runtime error on legal code |[4.3/4.2 regression] Runtime
                   |using RECL                  |error on legal code using
                   |                            |RECL
   Target Milestone|---                         |4.2.1


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31099

[Bug libfortran/31099] [4.3/4.2 regression] Runtime error on legal code using RECL

[burnus at gcc dot gnu dot org]

------- Comment #2 from burnus at gcc dot gnu dot org  2007-03-09 12:29 -------
The error setting happens in io/transfer.c's write_buf:
--------------------
  /* Unformatted sequential.  */
  have_written = 0;
  if (dtp->u.p.current_unit->flags.has_recl
      && (gfc_offset) nbytes > dtp->u.p.current_unit->bytes_left)
    {
      printf("write_buf: has_recl=%d, nbytes=%ld, bytes_left=%ld\n",
dtp->u.p.current_unit->flags.has_recl, nbytes,
dtp->u.p.current_unit->bytes_left);
      nbytes = dtp->u.p.current_unit->bytes_left;
      short_record = 1;
    }
  else
    short_record = 0;
--------------------
My added printf shows:

write_buf: has_recl=1, nbytes=4, bytes_left=0

The check was added in Thomas' record length patch PR 29568.
http://gcc.gnu.org/viewcvs/trunk/libgfortran/io/transfer.c?r1=119087&r2=119412&diff_format=h


-- 

burnus at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |burnus at gcc dot gnu dot
                   |                            |org, tkoenig at gcc dot gnu
                   |                            |dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31099

[Bug libfortran/31099] [4.3/4.2 regression] Runtime error on legal code using RECL

[burnus at gcc dot gnu dot org]

------- Comment #3 from burnus at gcc dot gnu dot org  2007-03-09 12:55 -------
I was checking where bytes_left is set:

open.c:  u->bytes_left = 0;
This is the default setting in new_unit (/* Open an unused unit.  */)

It is also set to 0 in file_pos.c (two places).

In list_read.c's next_char it is set to current_unit->recl;

And in transfer.c:
- read_block
- write_block (but only if stdout/stderr or default reclen, otherwise a
ERROR_EOR error is generated, but this is not the error of this PR.)
- us_read
- us_write: This one is also not called for this PR
- next_record_w: Not for unformatted

The problem seems to be that bytes_left == 0 from the initial setting in
new_unit as no data has been written. And as 4bytes have to be written, nbytes
= 4 > bytes_left.

Note: The same problem occurs if one tries to read from a file which has been
written by gfortran-4.1. In this case the error condition is in:

transfer.c's read_block_direct:

  if (dtp->u.p.current_unit->flags.has_recl)
    {
      to_read_record =
        *nbytes > (size_t) dtp->u.p.current_unit->bytes_left ?
        *nbytes : (size_t) dtp->u.p.current_unit->bytes_left;
      short_record = 1;
    }
  else
    {
      to_read_record = *nbytes;
      short_record = 0;
    }

This check has been introduced by the same patch.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31099

[Bug libfortran/31099] [4.3/4.2 regression] Runtime error on legal code using RECL

[jvdelisle at gcc dot gnu dot org]

------- Comment #4 from jvdelisle at gcc dot gnu dot org  2007-03-09 18:02 -------
I believe I have a fix.  I am testing now.  We were not initializing a few
things when we have a record length given.

Index: io/open.c
===================================================================
--- io/open.c   (revision 122529)
+++ io/open.c   (working copy)
@@ -437,6 +437,8 @@ new_unit (st_parameter_open *opp, gfc_un
     {
       u->flags.has_recl = 1;
       u->recl = opp->recl_in;
+      u->recl_subrecord = u->recl;
+      u->bytes_left = u->recl;
     }
   else
     {


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31099

[Bug libfortran/31099] [4.3/4.2 regression] Runtime error on legal code using RECL

[Thomas dot Koenig at online dot de]

------- Comment #5 from Thomas dot Koenig at online dot de  2007-03-09 20:13 -------
Subject: Re:  [4.3/4.2 regression] Runtime error on legal code using RECL

> I believe I have a fix.  I am testing now.  We were not initializing a few
> things when we have a record length given.
> 
> Index: io/open.c
> ===================================================================
> --- io/open.c   (revision 122529)
> +++ io/open.c   (working copy)
> @@ -437,6 +437,8 @@ new_unit (st_parameter_open *opp, gfc_un
>      {
>        u->flags.has_recl = 1;
>        u->recl = opp->recl_in;
> +      u->recl_subrecord = u->recl;
> +      u->bytes_left = u->recl;
>      }
>    else
>      {

This looks good.

Thanks, Jerry, for picking up on this so fast.

I had been sort of wondering wether I had introduced any regressions
with my subrecord patch.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31099

[Bug libfortran/31099] [4.3/4.2 regression] Runtime error on legal code using RECL

[patchapp at dberlin dot org]

------- Comment #6 from patchapp at dberlin dot org  2007-03-09 21:30 -------
Subject: Bug number PR31099

A patch for this bug has been added to the patch tracker.
The mailing list url for the patch is
http://gcc.gnu.org/ml/gcc-patches/2007-03/msg00576.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31099

[Bug libfortran/31099] [4.3/4.2 regression] Runtime error on legal code using RECL

[jvdelisle at gcc dot gnu dot org]

------- Comment #7 from jvdelisle at gcc dot gnu dot org  2007-03-09 21:51 -------
Subject: Bug 31099

Author: jvdelisle
Date: Fri Mar  9 21:51:39 2007
New Revision: 122763

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=122763
Log:
2007-03-09  Jerry DeLisle  <jvdelisle@gcc.gnu.org>

        PR libgfortran/31099
        * io/open.c (new_unit): Initialize bytes_left and recl_subrecord.
        * io/transfer.c (next_record_w): Set bytes left to record length for
        sequential unformatted I/O.
        (next_record_r): Ditto.
        (read_block_direct): Fix test for exceeding bytes_left.

Modified:
    trunk/libgfortran/ChangeLog
    trunk/libgfortran/io/open.c
    trunk/libgfortran/io/transfer.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31099

[Bug libfortran/31099] [4.3/4.2 regression] Runtime error on legal code using RECL

[jvdelisle at gcc dot gnu dot org]

------- Comment #8 from jvdelisle at gcc dot gnu dot org  2007-03-09 23:55 -------
Subject: Bug 31099

Author: jvdelisle
Date: Fri Mar  9 23:55:17 2007
New Revision: 122773

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=122773
Log:
2007-03-09  Jerry DeLisle  <jvdelisle@gcc.gnu.org>

        PR libgfortran/31099
        * io/open.c (new_unit): Initialize bytes_left and recl_subrecord.
        * io/transfer.c (next_record_w): Set bytes left to record length for
        sequential unformatted I/O.
        (next_record_r): Ditto.
        (read_block_direct): Fix test for exceeding bytes_left.

Modified:
    branches/gcc-4_2-branch/libgfortran/ChangeLog
    branches/gcc-4_2-branch/libgfortran/io/open.c
    branches/gcc-4_2-branch/libgfortran/io/transfer.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31099

[Bug libfortran/31099] [4.3/4.2 regression] Runtime error on legal code using RECL

[jvdelisle at gcc dot gnu dot org]

------- Comment #9 from jvdelisle at gcc dot gnu dot org  2007-03-10 00:00 -------
Subject: Bug 31099

Author: jvdelisle
Date: Sat Mar 10 00:00:21 2007
New Revision: 122775

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=122775
Log:
2007-03-09  Jerry DeLisle  <jvdelisle@gcc.gnu.org>

        PR libgfortran/31099
        * gfortran.dg/unformatted_recl.f90: New test.

Added:
    branches/gcc-4_2-branch/gcc/testsuite/gfortran.dg/unformatted_recl_1.f90
Modified:
    branches/gcc-4_2-branch/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31099

[Bug libfortran/31099] [4.3/4.2 regression] Runtime error on legal code using RECL

[jvdelisle at gcc dot gnu dot org]

------- Comment #10 from jvdelisle at gcc dot gnu dot org  2007-03-10 00:03 -------
Subject: Bug 31099

Author: jvdelisle
Date: Sat Mar 10 00:03:19 2007
New Revision: 122776

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=122776
Log:
2007-03-09  Jerry DeLisle  <jvdelisle@gcc.gnu.org>

        PR libgfortran/31099
        * gfortran.dg/unformatted_recl.f90: New test.

Added:
    trunk/gcc/testsuite/gfortran.dg/unformatted_recl_1.f90
Modified:
    trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31099

[Bug libfortran/31099] [4.3/4.2 regression] Runtime error on legal code using RECL

[jvdelisle at gcc dot gnu dot org]

------- Comment #11 from jvdelisle at gcc dot gnu dot org  2007-03-10 00:05 -------
Fixed on 4.2 and 4.3


-- 

jvdelisle at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31099

[Bug libfortran/31099] [4.3/4.2 regression] Runtime error on legal code using RECL

[jellby at yahoo dot com]

------- Comment #12 from jellby at yahoo dot com  2007-03-14 09:04 -------
I get the same error if I rewind the file (or is it illegal?):

PROGRAM TEST
   INTEGER :: A
   OPEN(10, FORM="UNFORMATTED", RECL=1024)
   A = -1
   WRITE(10) A
   REWIND(10)
   WRITE(10) A
END PROGRAM TEST


-- 

jellby at yahoo dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jellby at yahoo dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31099

[Bug libfortran/31099] [4.3/4.2 regression] Runtime error on legal code using RECL

[jvdelisle at gcc dot gnu dot org]

------- Comment #13 from jvdelisle at gcc dot gnu dot org  2007-03-16 00:04 -------
Reopening - missed part of this.  Patch submitted for approval


-- 

jvdelisle at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31099

[Bug libfortran/31099] [4.3/4.2 regression] Runtime error on legal code using RECL

[jvdelisle at gcc dot gnu dot org]

------- Comment #14 from jvdelisle at gcc dot gnu dot org  2007-03-16 00:41 -------
Subject: Bug 31099

Author: jvdelisle
Date: Fri Mar 16 00:41:36 2007
New Revision: 122970

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=122970
Log:
2007-03-15  Jerry DeLisle  <jvdelisle@gcc.gnu.org>

        PR libgfortran/31099
        * io/file_pos.c (st_rewind): Don't set bytes_left to zero.

Modified:
    trunk/libgfortran/ChangeLog
    trunk/libgfortran/io/file_pos.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31099

[Bug libfortran/31099] [4.3/4.2 regression] Runtime error on legal code using RECL

[jvdelisle at gcc dot gnu dot org]

------- Comment #15 from jvdelisle at gcc dot gnu dot org  2007-03-16 01:11 -------
Subject: Bug 31099

Author: jvdelisle
Date: Fri Mar 16 01:11:01 2007
New Revision: 122973

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=122973
Log:
2007-03-15  Jerry DeLisle  <jvdelisle@gcc.gnu.org>

        PR libgfortran/31099
        * io/file_pos.c (st_rewind): Don't set bytes_left to zero.

Modified:
    branches/gcc-4_2-branch/libgfortran/ChangeLog
    branches/gcc-4_2-branch/libgfortran/io/file_pos.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31099

[Bug libfortran/31099] [4.3/4.2 regression] Runtime error on legal code using RECL

[jvdelisle at gcc dot gnu dot org]

------- Comment #16 from jvdelisle at gcc dot gnu dot org  2007-03-16 01:54 -------
Subject: Bug 31099

Author: jvdelisle
Date: Fri Mar 16 01:54:25 2007
New Revision: 122974

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=122974
Log:
2007-03-15  Jerry DeLisle  <jvdelisle@gcc.gnu.org>

        PR libgfortran/31099
        * gfortran.dg/unformatted_recl.f90: Update test.

Modified:
    branches/gcc-4_2-branch/gcc/testsuite/ChangeLog
    branches/gcc-4_2-branch/gcc/testsuite/gfortran.dg/unformatted_recl_1.f90


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31099

[Bug libfortran/31099] [4.3/4.2 regression] Runtime error on legal code using RECL

[jvdelisle at gcc dot gnu dot org]

------- Comment #17 from jvdelisle at gcc dot gnu dot org  2007-03-16 01:57 -------
Subject: Bug 31099

Author: jvdelisle
Date: Fri Mar 16 01:57:16 2007
New Revision: 122975

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=122975
Log:
2007-03-15  Jerry DeLisle  <jvdelisle@gcc.gnu.org>

        PR libgfortran/31099
        * gfortran.dg/unformatted_recl.f90: Update test.

Modified:
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/gfortran.dg/unformatted_recl_1.f90


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31099

[Bug libfortran/31099] [4.3/4.2 regression] Runtime error on legal code using RECL

[burnus at gcc dot gnu dot org]

------- Comment #18 from burnus at gcc dot gnu dot org  2007-04-02 22:49 -------
Is this PR fixed or not? Looking at the initial and the additional example, it
seems to be fixed both in 4.2 and in 4.3. Can this PR be closed?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31099

[Bug libfortran/31099] [4.3/4.2 regression] Runtime error on legal code using RECL

[jvdelisle at gcc dot gnu dot org]

------- Comment #19 from jvdelisle at gcc dot gnu dot org  2007-04-03 01:04 -------
Yes, this is fixed, closing.


-- 

jvdelisle at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31099

[Bug libfortran/31099] [4.3/4.2 regression] Runtime error on legal code using RECL

[tkoenig at gcc dot gnu dot org]

------- Comment #20 from tkoenig at gcc dot gnu dot org  2007-04-25 22:39 -------
*** Bug 31706 has been marked as a duplicate of this bug. ***


-- 

tkoenig at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gcc-bugs at wbfb dot de


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31099