[Bug middle-end/22156] [4.0/4.1 Regression] bit-field copying regressed

[Bug middle-end/22156] [4.0/4.1 Regression] bit-field copying regressed

[pinskia at gcc dot gnu dot org]

-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |minor
   Last reconfirmed|2005-06-23 19:49:18         |2005-10-13 21:06:28
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22156

[Bug middle-end/22156] [4.0/4.1 Regression] bit-field copying regressed

[pinskia at gcc dot gnu dot org]

------- Comment #7 from pinskia at gcc dot gnu dot org  2005-10-27 20:31 -------
Nothing can happen until 4.2.0 for this issue really as we need a real copy
prop for structs.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.0.3                       |4.2.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22156

[Bug middle-end/22156] [4.0/4.1 Regression] bit-field copying regressed

[pinskia at gcc dot gnu dot org]

-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P2                          |P5
   Target Milestone|4.2.0                       |4.1.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22156

[Bug middle-end/22156] [4.0/4.1/4.2 Regression] bit-field copying regressed

[steven at gcc dot gnu dot org]

------- Comment #8 from steven at gcc dot gnu dot org  2006-02-05 21:21 -------
This bug ought to have a much higher priority than P5 IMHO.


-- 

steven at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mark at codesourcery dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22156

[Bug middle-end/22156] [4.0/4.1/4.2 Regression] bit-field copying regressed

[mmitchel at gcc dot gnu dot org]

------- Comment #9 from mmitchel at gcc dot gnu dot org  2006-02-07 09:26 -------
Steven, if we increased the priority of the bug, what solution would you
envision?  This is not in any way meant to be a rhetorical or sarcastic
question.  My reading of the audit trail is that this bug is essentially a
feature request for a new optimization; given that, I don't think we can make
it release-critical.  Am I misunderstanding?

Thanks,

-- Mark


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22156

[Bug middle-end/22156] [4.0/4.1/4.2 Regression] bit-field copying regressed

[mmitchel at gcc dot gnu dot org]

-- 

mmitchel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.1.0                       |4.1.1


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22156

[Bug middle-end/22156] [4.0/4.1/4.2 Regression] bit-field copying regressed

[mmitchel at gcc dot gnu dot org]

------- Comment #10 from mmitchel at gcc dot gnu dot org  2006-05-25 02:36 -------
Will not be fixed in 4.1.1; adjust target milestone to 4.1.2.


-- 

mmitchel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.1.1                       |4.1.2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22156

[Bug middle-end/22156] [4.0/4.1/4.2/4.3 Regression] bit-field copying regressed

[mmitchel at gcc dot gnu dot org]

-- 

mmitchel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.1.2                       |4.1.3


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22156

[Bug middle-end/22156] [4.0/4.1/4.2/4.3 Regression] bit-field copying regressed

[aoliva at gcc dot gnu dot org]

-- 

aoliva at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |aoliva at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2007-01-15 20:06:24         |2007-03-20 04:42:47
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22156

[Bug middle-end/22156] [4.0/4.1/4.2/4.3 Regression] bit-field copying regressed

[patchapp at dberlin dot org]

------- Comment #11 from patchapp at dberlin dot org  2007-03-26 04:40 -------
Subject: Bug number PR 22156

A patch for this bug has been added to the patch tracker.
The mailing list url for the patch is
http://gcc.gnu.org/ml/gcc-patches/2007-03/msg01625.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22156

[Bug middle-end/22156] [4.0/4.1/4.2/4.3 Regression] bit-field copying regressed

[aoliva at gcc dot gnu dot org]

------- Comment #12 from aoliva at gcc dot gnu dot org  2007-04-05 19:50 -------
Subject: Bug 22156

Author: aoliva
Date: Thu Apr  5 19:50:34 2007
New Revision: 123524

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=123524
Log:
PR middle-end/22156
* tree-sra.c (struct sra_elt): Add in_bitfld_block.  Remove
all_no_warning.
(struct sra_walk_fns): Remove use_all parameter from use.
(sra_hash_tree): Handle BIT_FIELD_REFs.
(sra_elt_hash): Don't hash bitfld blocks.
(sra_elt_eq): Skip them in parent compares as well.  Handle
BIT_FIELD_REFs.
(sra_walk_expr): Don't maintain or pass down use_all_p.
(scan_use): Remove use_all parameter.
(scalarize_use): Likewise.  Re-expand assignment to
BIT_FIELD_REF of gimple_reg.  De-scalarize before input or
output, and re-scalarize after output.  Don't mark anything
for no warning.
(scalarize_ldst): Adjust.
(scalarize_walk_gimple_modify_statement): Likewise.
(build_element_name_1): Handle BIT_FIELD_REFs.
(instantiate_element): Don't warn for any element whose parent
is used as a whole.
(instantiate_missing_elements_1): Return the sra_elt.
(canon_type_for_field): New.
(try_instantiate_multiple_fields): New.
(instantiate_missing_elemnts): Use them.
(mark_no_warning): Removed.
(generate_one_element_ref): Handle BIT_FIELD_REFs.
(REPLDUP, sra_build_elt_assignment): New.
(generate_copy_inout): Use them.
(generate_element_copy): Likewise.  Handle bitfld differences.
(generate_element_zero): Don't recurse for blocks.  Use
sra_build_elt_assignment.
(generate_one_element_int): Take elt instead of var.  Use
sra_build_elt_assignment.
(generate_element_init_1): Adjust.
(scalarize_use, scalarize_copy): Use REPLDUP.
(scalarize_ldst): Move assert before dereference.
(dump_sra_elt_name): Handle BIT_FIELD_REFs.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/tree-sra.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22156

[Bug middle-end/22156] [4.0/4.1/4.2 Regression] bit-field copying regressed

[aoliva at gcc dot gnu dot org]

------- Comment #13 from aoliva at gcc dot gnu dot org  2007-04-05 23:06 -------
Fixed in trunk for 4.3, not sure about backporting...


-- 

aoliva at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[4.0/4.1/4.2/4.3 Regression]|[4.0/4.1/4.2 Regression]
                   |bit-field copying regressed |bit-field copying regressed


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22156

[Bug middle-end/22156] [4.0/4.1/4.2 Regression] bit-field copying regressed

[aoliva at gcc dot gnu dot org]

------- Comment #14 from aoliva at gcc dot gnu dot org  2007-04-30 18:41 -------
Subject: Bug 22156

Author: aoliva
Date: Mon Apr 30 18:41:11 2007
New Revision: 124302

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=124302
Log:
PR middle-end/22156
Temporarily revert:
2007-04-06  Andreas Tobler  <a.tobler@schweiz.org>
2007-04-05  Alexandre Oliva  <aoliva@redhat.com>
* tree-sra.c (try_instantiate_multiple_fields): Needlessly
initialize align to silence bogus warning.
2007-04-05  Alexandre Oliva  <aoliva@redhat.com>
* tree-sra.c (struct sra_elt): Add in_bitfld_block.  Remove
all_no_warning.
(struct sra_walk_fns): Remove use_all parameter from use.
(sra_hash_tree): Handle BIT_FIELD_REFs.
(sra_elt_hash): Don't hash bitfld blocks.
(sra_elt_eq): Skip them in parent compares as well.  Handle
BIT_FIELD_REFs.
(sra_walk_expr): Don't maintain or pass down use_all_p.
(scan_use): Remove use_all parameter.
(scalarize_use): Likewise.  Re-expand assignment to
BIT_FIELD_REF of gimple_reg.  De-scalarize before input or
output, and re-scalarize after output.  Don't mark anything
for no warning.
(scalarize_ldst): Adjust.
(scalarize_walk_gimple_modify_statement): Likewise.
(build_element_name_1): Handle BIT_FIELD_REFs.
(instantiate_element): Don't warn for any element whose parent
is used as a whole.
(instantiate_missing_elements_1): Return the sra_elt.
(canon_type_for_field): New.
(try_instantiate_multiple_fields): New.
(instantiate_missing_elemnts): Use them.
(mark_no_warning): Removed.
(generate_one_element_ref): Handle BIT_FIELD_REFs.
(REPLDUP, sra_build_elt_assignment): New.
(generate_copy_inout): Use them.
(generate_element_copy): Likewise.  Handle bitfld differences.
(generate_element_zero): Don't recurse for blocks.  Use
sra_build_elt_assignment.
(generate_one_element_int): Take elt instead of var.  Use
sra_build_elt_assignment.
(generate_element_init_1): Adjust.
(scalarize_use, scalarize_copy): Use REPLDUP.
(scalarize_ldst): Move assert before dereference.
(dump_sra_elt_name): Handle BIT_FIELD_REFs.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/tree-sra.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22156

[Bug middle-end/22156] [4.0/4.1/4.2/4.3 Regression] bit-field copying regressed

[pinskia at gcc dot gnu dot org]

------- Comment #15 from pinskia at gcc dot gnu dot org  2007-07-09 09:15 -------
Here is a new testcase which shows the problem on the trunk on powerpc-darwin:
struct s
{
  int i1:1;
  int i2:1;
};
void f(struct s *x, struct s *y) { *x = *y; }


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22156

[Bug middle-end/22156] [4.0/4.1/4.2/4.3 Regression] bit-field copying regressed

[aoliva at gcc dot gnu dot org]

------- Comment #16 from aoliva at gcc dot gnu dot org  2007-10-01 16:36 -------
Subject: Bug 22156

Author: aoliva
Date: Mon Oct  1 16:35:55 2007
New Revision: 128908

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=128908
Log:
PR middle-end/22156
* tree-sra.c (struct sra_elt): Add in_bitfld_block.
(sra_hash_tree): Handle BIT_FIELD_REFs.
(sra_elt_hash): Don't hash bitfld blocks.
(sra_elt_eq): Skip them in parent compares as well.  Handle
BIT_FIELD_REFs.
(build_element_name_1): Handle BIT_FIELD_REFs.
(instantiate_element): Propagate nowarn from parents.  Create
BIT_FIELD_REF for variables that are widened by scalarization.
Gimple-zero-initialize all bit-field variables that are not
part of parameters that are going to be scalarized on entry.
(instantiate_missing_elements_1): Return the sra_elt.
(canon_type_for_field): New.
(try_instantiate_multiple_fields): New.  Infer widest possible
access mode from decl or member type, but clip it at word
size, and only widen it if a field crosses an alignment
boundary.
(instantiate_missing_elements): Use them.
(generate_one_element_ref): Handle BIT_FIELD_REFs.
(scalar_bitfield_p): New.
(sra_build_assignment): Optimize assignments from scalarizable
BIT_FIELD_REFs.  Use BITS_BIG_ENDIAN to determine shift
counts.
(REPLDUP): New.
(sra_build_bf_assignment): New.  Optimize assignments to
scalarizable BIT_FIELD_REFs.
(sra_build_elt_assignment): New.  Optimize BIT_FIELD_REF
assignments to full variables.
(generate_copy_inout): Use the new macros and functions.
(generate_element_copy): Likewise.  Handle bitfld differences.
(generate_element_zero): Don't recurse for blocks.  Use
sra_build_elt_assignment.
(generate_one_element_init): Take elt instead of var.  Use
sra_build_elt_assignment.
(generate_element_init_1): Adjust.
(bitfield_overlap_info): New struct.
(bitfield_overlaps_p): New.
(sra_explode_bitfield_assignment): New.  Adjust widened
variables to account for endianness.
(sra_sync_for_bitfield_assignment): New.
(scalarize_use): Re-expand assignment to/from scalarized
BIT_FIELD_REFs.  Explode or sync needed members for
BIT_FIELD_REFs accesses or assignments.  Use REPLDUP.
(scalarize_copy): Use REPLDUP.
(scalarize_ldst): Move assert before dereference.  Adjust EH
handling.
(dump_sra_elt_name): Handle BIT_FIELD_REFs.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/tree-sra.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22156

[Bug middle-end/22156] [4.0/4.1/4.2/4.3 Regression] bit-field copying regressed

[aoliva at gcc dot gnu dot org]

------- Comment #17 from aoliva at gcc dot gnu dot org  2007-10-01 16:46 -------
Patch checked in.


-- 

aoliva at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22156

[Bug middle-end/22156] [4.0/4.1/4.2/4.3 Regression] bit-field copying regressed

[aoliva at gcc dot gnu dot org]

------- Comment #18 from aoliva at gcc dot gnu dot org  2007-10-09 04:41 -------
Subject: Bug 22156

Author: aoliva
Date: Tue Oct  9 04:41:39 2007
New Revision: 129149

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=129149
Log:
Add missing hunk in r129143 check in.  Add references to PR 22156.

Modified:
    trunk/gcc/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22156

[Bug middle-end/22156] [4.0/4.1/4.2/4.3 Regression] bit-field copying regressed

[aoliva at gcc dot gnu dot org]

------- Comment #19 from aoliva at gcc dot gnu dot org  2007-10-09 04:45 -------
Subject: Bug 22156

Author: aoliva
Date: Tue Oct  9 04:45:22 2007
New Revision: 129150

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=129150
Log:
PR middle-end/22156
* tree-sra.c (instantiate_element): Use BYTES_BIG_ENDIAN for
bit-field layout.
(sra_build_assignment): Likewise.  Set up mask depending on
precision, not type.
(sra_build_bf_assignment): Use BYTES_BIG_ENDIAN.  Don't overflow
computing bit masks.
(sra_build_elt_assignment): Don't view-convert from signed to
unsigned.
(sra_explode_bitfield_assignment): Use bit-field type if
possible.  Use BYTES_BIG_ENDIAN.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/tree-sra.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22156

[Bug middle-end/22156] [4.0/4.1/4.2/4.3 Regression] bit-field copying regressed

[aoliva at gcc dot gnu dot org]

------- Comment #20 from aoliva at gcc dot gnu dot org  2007-10-09 04:55 -------
Subject: Bug 22156

Author: aoliva
Date: Tue Oct  9 04:55:17 2007
New Revision: 129152

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=129152
Log:
PR tree-optimization/33655
PR middle-end/22156
* tree-sra.c (bitfield_overlaps_p): When fld->element is INTEGER_CST,
convert it to bitsizetype before size_binop call.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/tree-sra.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22156

[Bug middle-end/22156] [4.0/4.1/4.2/4.3 Regression] bit-field copying regressed

[pinskia at gcc dot gnu dot org]

-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.1.3                       |4.3.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22156