[Bug c++/25874] New: [gomp branch] ICE in calc_dfs_tree()

[Bug c++/25874] New: [gomp branch] ICE in calc_dfs_tree()

[martin at mpa-garching dot mpg dot de]

Current g++ from the gomp branch ICEs on the attached test case, but only
when -O and -fopenmp is specified:

~/data/planck/LevelS>g++ -v -O -fopenmp -c bug.ii
Using built-in specs.
Target: i686-pc-linux-gnu
Configured with: /scratch/gompcc/configure --quiet --prefix=/scratch/ugccgomp
--enable-languages=c++,fortran --with-gmp=/usr/local/appl/gmp-4.1.4
--enable-checking=release
Thread model: posix
gcc version 4.2.0-gomp-20050608-branch 20060119 (experimental) (merged
20060119)

/scratch/ugccgomp/libexec/gcc/i686-pc-linux-gnu/4.2.0-gomp-20050608-branch/cc1plus
-fpreprocessed bug.ii -quiet -dumpbase bug.ii -mtune=generic -auxbase bug -O
-version -fopenmp -o /tmp/ccpzsCty.s
GNU C++ version 4.2.0-gomp-20050608-branch 20060119 (experimental) (merged
20060119) (i686-pc-linux-gnu)
        compiled by GNU C version 4.2.0-gomp-20050608-branch 20060119
(experimental) (merged 20060119).
GGC heuristics: --param ggc-min-expand=100 --param ggc-min-heapsize=131072
Compiler executable checksum: e3aef40c574c8b69824cf08633defc10
Healpix_cxx/alm_powspec_tools.cc: In function 'void rotate_alm(Alm<xcomplex<T>
>&, double, double, double) [with T = double]':
Healpix_cxx/alm_powspec_tools.cc:396: internal compiler error: in
calc_dfs_tree, at dominance.c:373
Please submit a full bug report,
with preprocessed source if appropriate.
See <URL:http://gcc.gnu.org/bugs.html> for instructions.

This problem did not exist a few days ago.
Sorry for the long test case; I hope I can reduce it over the weekend.


-- 
           Summary: [gomp branch]  ICE in calc_dfs_tree()
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: martin at mpa-garching dot mpg dot de
 GCC build triplet: i686-pc-linux-gnu
  GCC host triplet: i686-pc-linux-gnu
GCC target triplet: i686-pc-linux-gnu


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25874

[Bug c++/25874] [gomp branch] ICE in calc_dfs_tree()

[martin at mpa-garching dot mpg dot de]

------- Comment #1 from martin at mpa-garching dot mpg dot de  2006-01-20 14:41 -------
Created an attachment (id=10685)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=10685&action=view)
test case to reproduce the bug


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25874

[Bug c++/25874] [gomp branch] ICE in calc_dfs_tree()

[martin at mpa-garching dot mpg dot de]

------- Comment #2 from martin at mpa-garching dot mpg dot de  2006-01-20 19:17 -------
Reduced testcase:

int foo();

struct wigner_d
  {
  void recurse () {
    int dd;
    for (int j=0; j<=1; ++j) {
#pragma omp parallel
      dd=5;
      }
    }
  };

template<typename T> void rotate_alm(T arg)
  {
  wigner_d rec;
  rec.recurse();
#pragma omp parallel
    foo();
  }

template void rotate_alm(float arg);
template void rotate_alm(double arg);


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25874

[Bug c++/25874] [gomp branch] ICE in calc_dfs_tree()

[dnovillo at gcc dot gnu dot org]

------- Comment #3 from dnovillo at gcc dot gnu dot org  2006-01-27 14:26 -------

Mine.


-- 

dnovillo at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |dnovillo at gcc dot gnu dot
                   |dot org                     |org
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2006-01-27 14:26:53
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25874

[Bug c++/25874] [gomp branch] ICE in calc_dfs_tree()

[reichelt at gcc dot gnu dot org]

------- Comment #4 from reichelt at gcc dot gnu dot org  2006-01-27 15:45 -------
Even shorter C-testcase (compile with -fopenmp -O):

================================
void foo();

inline void bar()
{
  int i;
  for ( i=0; i<1; ++i )
#pragma omp parallel
    foo();
}

void baz()
{
#pragma omp parallel
  bar();
}
================================


-- 

reichelt at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |reichelt at gcc dot gnu dot
                   |                            |org
           Keywords|                            |monitored


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25874

[Bug c++/25874] [gomp branch] ICE in calc_dfs_tree()

[dnovillo at gcc dot gnu dot org]

------- Comment #5 from dnovillo at gcc dot gnu dot org  2006-01-30 02:37 -------
Subject: Bug 25874

Author: dnovillo
Date: Mon Jan 30 02:37:09 2006
New Revision: 110392

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=110392
Log:

        PR 25874
        * omp-low.c (execute_expand_omp): Move CFG cleanup code ...
        (expand_omp): ... here.
        (expand_omp_parallel): Only remove barriers for combined
        parallel+workshare constructs.

testsuite/

        * g++.dg/gomp/pr25874.C: New test.
        * gcc.dg/gomp/pr25874.c: New test.


Added:
    branches/gomp-20050608-branch/gcc/testsuite/g++.dg/gomp/pr25874.C
    branches/gomp-20050608-branch/gcc/testsuite/gcc.dg/gomp/pr25874.c
Modified:
    branches/gomp-20050608-branch/gcc/ChangeLog.gomp
    branches/gomp-20050608-branch/gcc/omp-low.c
    branches/gomp-20050608-branch/gcc/testsuite/ChangeLog.gomp


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25874

[Bug c++/25874] [gomp branch] ICE in calc_dfs_tree()

[dnovillo at gcc dot gnu dot org]

------- Comment #6 from dnovillo at gcc dot gnu dot org  2006-01-30 03:09 -------

Fixed.  http://gcc.gnu.org/ml/gcc-patches/2006-01/msg02090.html.


-- 

dnovillo at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25874

[Bug c++/25874] [gomp branch] ICE in calc_dfs_tree()

[dnovillo at gcc dot gnu dot org]

------- Comment #7 from dnovillo at gcc dot gnu dot org  2006-01-30 03:11 -------
Subject: Bug 25874

Author: dnovillo
Date: Mon Jan 30 03:11:29 2006
New Revision: 110393

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=110393
Log:

        PR 25874
        * omp-low.c (execute_expand_omp): Move CFG cleanup code ...
        (expand_omp): ... here.
        (expand_omp_parallel): Only remove barriers for combined
        parallel+workshare constructs.


        * gcc.dg/gomp/pr25874.c: New test.


Added:
    trunk/gcc/testsuite/gcc.dg/gomp/pr25874.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/omp-low.c
    trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25874

[Bug c++/25874] [gomp] ICE in calc_dfs_tree()

[reichelt at gcc dot gnu dot org]

------- Comment #8 from reichelt at gcc dot gnu dot org  2006-04-17 12:09 -------
The ICE reappeared.
Probably with Jakub's fix for PR26823.

Btw, the testcase in the testsuite didn't trigger, it
probably lacks the line
/* { dg-options "-O" } */
This should be fixed once this bug gets fixed again.


-- 

reichelt at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu dot org
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |
            Summary|[gomp branch]  ICE in       |[gomp]  ICE in
                   |calc_dfs_tree()             |calc_dfs_tree()


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25874

[Bug c++/25874] [gomp] ICE in calc_dfs_tree()

[jakub at gcc dot gnu dot org]

-- 

jakub at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|dnovillo at gcc dot gnu dot |jakub at gcc dot gnu dot org
                   |org                         |
             Status|REOPENED                    |ASSIGNED
   Last reconfirmed|2006-01-27 14:26:53         |2006-04-19 09:59:31
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25874

[Bug c++/25874] [gomp] ICE in calc_dfs_tree()

[reichelt at gcc dot gnu dot org]

------- Comment #9 from reichelt at gcc dot gnu dot org  2006-05-22 09:28 -------
RTH, you wrote in http://gcc.gnu.org/ml/gcc-patches/2006-04/msg00972.html :
> On Tue, Apr 18, 2006 at 08:24:34AM -0400, Jakub Jelinek wrote:
> >       * omp-low.c (expand_omp_parallel): If child_cfun->cfg, free dominators,
> >       post dominators and cleanup cfg before returning.
> 
> I had moved the cleanup_tree_cfg out to the top-level because
> the cleanup invalidated basic blocks in the omp_region tree.
> Perhaps that's fixed by your sched_kind fix.  If so, we should
> simpy revert my previous fix, likely.
> 
> I guess I'll look into this after pre-processing my post-vacation
> mailbox.

Is there any progress on this PR?


-- 

reichelt at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rth at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25874

[Bug c++/25874] [gomp] ICE in calc_dfs_tree()

[reichelt at gcc dot gnu dot org]

------- Comment #10 from reichelt at gcc dot gnu dot org  2007-02-01 20:33 -------
The bug disappeared on mainline, but is still present on the 4.2 branch.

Is there any chance that this gets fixed before the 4.2.0 release?
It's really a problem that hurts OpenMP for C++.


-- 

reichelt at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to fail|                            |4.2.0
      Known to work|                            |4.3.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25874

[Bug c++/25874] [gomp] ICE in calc_dfs_tree()

[jakub at gcc dot gnu dot org]

------- Comment #11 from jakub at gcc dot gnu dot org  2007-03-21 16:16 -------
Richard, in http://gcc.gnu.org/ml/gcc-patches/2006-04/msg00972.html
you said you'll look into it.  The above mentioned patch (updated so that
it applies) is what I'm using in Fedora Core and RHEL gccs for almost a year
now.
Could you please look at this and either approve the updated version of that
patch (can repost), or come up with something else?

Thanks.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25874

[Bug c++/25874] [gomp] ICE in calc_dfs_tree()

[jakub at gcc dot gnu dot org]

------- Comment #12 from jakub at gcc dot gnu dot org  2007-04-14 18:43 -------
Subject: Bug 25874

Author: jakub
Date: Sat Apr 14 18:43:13 2007
New Revision: 123818

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=123818
Log:
        PR c++/25874
        * omp-low.c (expand_omp_parallel): If child_cfun->cfg, free dominators,
        post dominators and cleanup cfg before returning.

        * gcc.dg/gomp/pr25874.c: Add dg-options.
        * g++.dg/gomp/pr25874.C: Add dg-options.

Modified:
    branches/gcc-4_2-branch/gcc/ChangeLog
    branches/gcc-4_2-branch/gcc/omp-low.c
    branches/gcc-4_2-branch/gcc/testsuite/ChangeLog
    branches/gcc-4_2-branch/gcc/testsuite/g++.dg/gomp/pr25874.C
    branches/gcc-4_2-branch/gcc/testsuite/gcc.dg/gomp/pr25874.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25874

[Bug c++/25874] [gomp] ICE in calc_dfs_tree()

[jakub at gcc dot gnu dot org]

------- Comment #13 from jakub at gcc dot gnu dot org  2007-04-14 19:52 -------
Subject: Bug 25874

Author: jakub
Date: Sat Apr 14 19:52:45 2007
New Revision: 123822

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=123822
Log:
        PR c++/25874
        * omp-low.c (expand_omp_parallel): If child_cfun->cfg, free dominators,
        post dominators and cleanup cfg before returning.

        * gcc.dg/gomp/pr25874.c: Add dg-options.
        * g++.dg/gomp/pr25874.C: Add dg-options.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/omp-low.c
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/g++.dg/gomp/pr25874.C
    trunk/gcc/testsuite/gcc.dg/gomp/pr25874.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25874

[Bug c++/25874] [gomp] ICE in calc_dfs_tree()

[jakub at gcc dot gnu dot org]

------- Comment #14 from jakub at gcc dot gnu dot org  2007-04-14 20:44 -------
Fixed in SVN.


-- 

jakub at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25874

[Bug c++/25874] [gomp] ICE in calc_dfs_tree()

[reichelt at gcc dot gnu dot org]

-- 

reichelt at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.2.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25874