[Bug c++/31721] New: vector references turn into vector pointers

[Bug c++/31721] New: vector references turn into vector pointers

[pinskia at gcc dot gnu dot org]

Testcase:
#define vector __attribute__((__vector_size__(16) ))
vector int b;
vector int &a = b;

-------------------- cut --------------
This should be accepted as a is a reference to a vector int and we are
assigning it a b.


-- 
           Summary: vector references turn into vector pointers
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Keywords: rejects-valid
          Severity: normal
          Priority: P3
         Component: c++
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: pinskia at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31721

[Bug c++/31721] vector references turn into vector pointers

[pinskia at gcc dot gnu dot org]

------- Comment #1 from pinskia at gcc dot gnu dot org  2007-04-27 01:11 -------
*** Bug 14217 has been marked as a duplicate of this bug. ***


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tjw at omnigroup dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31721

[Bug c++/31721] vector references turn into vector pointers

[pinskia at gcc dot gnu dot org]

------- Comment #2 from pinskia at gcc dot gnu dot org  2007-04-27 01:12 -------
Confirmed via the duplicated bug.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2007-04-27 01:12:11
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31721

[Bug c++/31721] vector references turn into vector pointers

[pinskia at gcc dot gnu dot org]

------- Comment #3 from pinskia at gcc dot gnu dot org  2007-04-27 01:55 -------
The problem is obvious.
reconstruct_complex_type looks at POINTER_TYPE_P but it does not check which
case (pointer or reference) it should be building and just calls
build_pointer_type always which is wrong.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |pinskia at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31721

[Bug c++/31721] vector references turn into vector pointers

[pinskia at gcc dot gnu dot org]

------- Comment #4 from pinskia at gcc dot gnu dot org  2007-04-27 02:11 -------
This has been broken since the patch went in to support vector_size, see:
http://gcc.gnu.org/ml/gcc-patches/2001-12/msg00778.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31721

[Bug c++/31721] vector references turn into vector pointers

[pinskia at gcc dot gnu dot org]

------- Comment #5 from pinskia at gcc dot gnu dot org  2007-04-27 02:46 -------
In fact we should be using more than just build_reference_type, we should be
using build_reference_type_for_mode.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31721

[Bug c++/31721] vector references turn into vector pointers

[pinskia at gcc dot gnu dot org]

------- Comment #6 from pinskia at gcc dot gnu dot org  2007-04-29 07:44 -------
Sorry Timothy, if this bug took too long to fix, it seems like many people were
not using the vector extension with C++ that much so nobody actually looked
into it until now.  I only looked into it because I found the real cause and
somebody here (at Sony) reported the bug to me.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |http://gcc.gnu.org/ml/gcc-
                   |                            |patches/2007-
                   |                            |04/msg01970.html
           Keywords|                            |patch


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31721

[Bug c++/31721] vector references turn into vector pointers

[pinskia at gcc dot gnu dot org]

------- Comment #7 from pinskia at gcc dot gnu dot org  2007-04-30 18:01 -------
Subject: Bug 31721

Author: pinskia
Date: Mon Apr 30 18:01:18 2007
New Revision: 124300

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=124300
Log:
2007-04-30  Andrew Pinski  <andrew_pinski@playstation.sony.com>

        PR C++/31721
        * tree.c (reconstruct_complex_type): Reconstruct a reference
        correctly.
        Also use the same mode for the pointer as the old pointer type.
2007-04-30  Andrew pinski  <andrew_pinski@playstation.sony.com>

        PR C++/31721
        * g++.dg/ext/vector7.C: New testcase.


Added:
    trunk/gcc/testsuite/g++.dg/ext/vector7.C
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/tree.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31721

[Bug c++/31721] vector references turn into vector pointers

[pinskia at gcc dot gnu dot org]

------- Comment #8 from pinskia at gcc dot gnu dot org  2007-04-30 18:02 -------
Fixed.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.3.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31721