[Bug fortran/31781] New: fortran regressions on trunk if you --disable-checking

[Bug fortran/31781] New: fortran regressions on trunk if you --disable-checking

[zadeck at naturalbridge dot com]

if you --disable-checking when you build, you get additional fortran
regressions.  This is true on the current trunk and has most likely been true
for at least two weeks.  

FAIL: gfortran.dg/repeat_2.f90  -O0  execution test
FAIL: gfortran.dg/repeat_2.f90  -O1  execution test
FAIL: gfortran.dg/repeat_2.f90  -O2  execution test
FAIL: gfortran.dg/repeat_2.f90  -O3 -fomit-frame-pointer  execution test
FAIL: gfortran.dg/repeat_2.f90  -O3 -fomit-frame-pointer -funroll-loops 
execution test
FAIL: gfortran.dg/repeat_2.f90  -O3 -fomit-frame-pointer -funroll-all-loops
-finline-functions  execution test
FAIL: gfortran.dg/repeat_2.f90  -O3 -g  execution test
FAIL: gfortran.dg/repeat_2.f90  -Os  execution test


-- 
           Summary: fortran regressions on trunk if you --disable-checking
           Product: gcc
           Version: 4.3.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: zadeck at naturalbridge dot com
 GCC build triplet:  x86_64-unknown-linux-gnu
  GCC host triplet:  x86_64-unknown-linux-gnu
GCC target triplet:  x86_64-unknown-linux-gnu


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31781

[Bug fortran/31781] fortran regressions on trunk if you --disable-checking

[pinskia at gcc dot gnu dot org]

------- Comment #1 from pinskia at gcc dot gnu dot org  2007-05-02 03:34 -------
Most likely someone has a gcc_assert which has side effects.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  GCC build triplet| x86_64-unknown-linux-gnu   |x86_64-unknown-linux-gnu
   GCC host triplet| x86_64-unknown-linux-gnu   |x86_64-unknown-linux-gnu
 GCC target triplet| x86_64-unknown-linux-gnu   |x86_64-unknown-linux-gnu


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31781

[Bug fortran/31781] fortran regressions on trunk if you --disable-checking

[dfranke at gcc dot gnu dot org]

------- Comment #2 from dfranke at gcc dot gnu dot org  2007-05-03 22:46 -------
Confirmed.

Testcase:
$> cat repeat.f90
  character(len=1), parameter :: s1 = "a"
  print *, "aa: ", repeat(s1, 2)
  end

$> gfortran-svn -g -Wall -fdump-tree-original repeat.f90
$> cat repeat.f90.003t.original
MAIN__ ()
{
  _gfortran_set_std (68, 127, 0, 0, 0);
  {
    struct __st_parameter_dt dt_parm.0;

    dt_parm.0.common.filename = "repeat.f90";
    dt_parm.0.common.line = 3;
    dt_parm.0.common.unit = 6;
    dt_parm.0.common.flags = 128;
    _gfortran_st_write (&dt_parm.0);
    _gfortran_transfer_character (&dt_parm.0, "aa: ", 4);
    _gfortran_transfer_character (&dt_parm.0, "", 0);
    _gfortran_st_write_done (&dt_parm.0);
  }

If the PARAMETER statement of S1 is removed, REPEAT works as expected. 

Adding FX to CC as he worked on this a while ago.


-- 

dfranke at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dfranke at gcc dot gnu dot
                   |                            |org, fxcoudert at gcc dot
                   |                            |gnu dot org
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
  GCC build triplet|x86_64-unknown-linux-gnu    |
   GCC host triplet|x86_64-unknown-linux-gnu    |
 GCC target triplet|x86_64-unknown-linux-gnu    |
      Known to fail|                            |4.3.0
   Last reconfirmed|0000-00-00 00:00:00         |2007-05-03 22:46:39
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31781

[Bug fortran/31781] fortran regressions on trunk if you --disable-checking

[dfranke at gcc dot gnu dot org]

------- Comment #3 from dfranke at gcc dot gnu dot org  2007-05-03 22:57 -------
With "--enable-checking", the same dump as shown in comment #3 looks like:

$> cat repeat.f90.003t.original
MAIN__ ()
{
  _gfortran_set_std (68, 127, 0, 0, 0);
  {
    struct __st_parameter_dt dt_parm.0;

    dt_parm.0.common.filename = "repeat.f90";
    dt_parm.0.common.line = 3;
    dt_parm.0.common.unit = 6;
    dt_parm.0.common.flags = 128;
    _gfortran_st_write (&dt_parm.0);
    _gfortran_transfer_character (&dt_parm.0, "aa: ", 4);
    _gfortran_transfer_character (&dt_parm.0, "aa", 2);      # <-------
    _gfortran_st_write_done (&dt_parm.0);
  }


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31781

[Bug fortran/31781] fortran regressions on trunk if you --disable-checking

[fxcoudert at gcc dot gnu dot org]

------- Comment #4 from fxcoudert at gcc dot gnu dot org  2007-05-03 23:11 -------
Stupid mistake, trivial patch:

Index: simplify.c
===================================================================
--- simplify.c  (revision 124285)
+++ simplify.c  (working copy)
@@ -2919,7 +2919,10 @@ gfc_simplify_repeat (gfc_expr *e, gfc_ex
     return NULL;

   if (mpz_sgn (e->ts.cl->length->value.integer) != 0)
-    gcc_assert (gfc_extract_int (n, &ncop) == NULL);
+    {
+      const char *res = gfc_extract_int (n, &ncop);
+      gcc_assert (res == NULL);
+    }
   else
     ncop = 0;


Many thanks to Kenneth for reporting the bug, to Daniel for reducing it and
posting tree dumps, and to Andrew for pointing the likely cause of the bug!


-- 

fxcoudert at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |fxcoudert at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED
           Keywords|                            |patch, wrong-code
      Known to work|                            |4.1.2 4.2.0
   Last reconfirmed|2007-05-03 22:46:39         |2007-05-03 23:11:53
               date|                            |
   Target Milestone|---                         |4.3.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31781

[Bug fortran/31781] fortran regressions on trunk if you --disable-checking

[fxcoudert at gcc dot gnu dot org]

------- Comment #5 from fxcoudert at gcc dot gnu dot org  2007-05-04 10:26 -------
Subject: Bug 31781

Author: fxcoudert
Date: Fri May  4 09:26:41 2007
New Revision: 124412

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=124412
Log:
        PR fortran/31781
        * simplify.c (gfc_simplify_repeat): Don't put function call with
        side effect in a gcc_assert().

Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/simplify.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31781

[Bug fortran/31781] fortran regressions on trunk if you --disable-checking

[fxcoudert at gcc dot gnu dot org]

------- Comment #6 from fxcoudert at gcc dot gnu dot org  2007-05-04 10:29 -------
Fixed.


-- 

fxcoudert at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31781