public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug fortran/20896] ambiguous interface not detected
       [not found] <bug-20896-6642@http.gcc.gnu.org/bugzilla/>
@ 2006-12-26 14:38 ` patchapp at dberlin dot org
  2006-12-27 13:47 ` pault at gcc dot gnu dot org
                   ` (12 subsequent siblings)
  13 siblings, 0 replies; 14+ messages in thread
From: patchapp at dberlin dot org @ 2006-12-26 14:38 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #1 from patchapp at dberlin dot org  2006-12-26 14:38 -------
Subject: Bug number PR20896

A patch for this bug has been added to the patch tracker.
The mailing list url for the patch is
http://gcc.gnu.org/ml/gcc-patches/2006-12/msg01686.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20896


^ permalink raw reply	[flat|nested] 14+ messages in thread
* [Bug fortran/20896] ambiguous interface not detected
       [not found] <bug-20896-6642@http.gcc.gnu.org/bugzilla/>
  2006-12-26 14:38 ` [Bug fortran/20896] ambiguous interface not detected patchapp at dberlin dot org
@ 2006-12-27 13:47 ` pault at gcc dot gnu dot org
  2006-12-27 16:38 ` [Bug fortran/20896] [4.2 and 4.1 only] " pault at gcc dot gnu dot org
                   ` (11 subsequent siblings)
  13 siblings, 0 replies; 14+ messages in thread
From: pault at gcc dot gnu dot org @ 2006-12-27 13:47 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #2 from pault at gcc dot gnu dot org  2006-12-27 13:46 -------
Subject: Bug 20896

Author: pault
Date: Wed Dec 27 13:46:47 2006
New Revision: 120218

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=120218
Log:
2006-12-27  Paul Thomas  <pault@gcc.gnu.org>

        PR fortran/20896
        * interface.c (check_sym_interfaces): Try to resolve interface
        reference as a global symbol, if it is not a nodule procedure.
        (compare_actual_formal): Remove call to gfc_find_symbol; if
        the expression is already a variable it is locally declared
        and this has precedence.
        gfortran.h : Add prototype for resolve_global_procedure.
        resolve.c (resolve_global_procedure): Remove static attribute
        from function declaration.
        (resolve_fl_procedure): Remove symtree declaration and the
        redundant check for an ambiguous procedure.

        PR fortran/25135
        * module.c (load_generic_interfaces): If the symbol is present
        and is not generic it is ambiguous.

2006-12-27  Paul Thomas  <pault@gcc.gnu.org>

        PR fortran/20896
        * gfortran.dg/interface_10.f90: New test.
        * gfortran.dg/dummy_procedure_1.f90: Add error for call s1(z),
        since z is already, locally a variable.

        PR fortran/25135
        * gfortran.dg/generic_11.f90: New test.
        * gfortran.dg/interface_7.f90: Remove name clash between module
        name and procedure 'x' referenced in the interface.

Added:
    trunk/gcc/testsuite/gfortran.dg/generic_11.f90
    trunk/gcc/testsuite/gfortran.dg/interface_10.f90
Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/gfortran.h
    trunk/gcc/fortran/interface.c
    trunk/gcc/fortran/module.c
    trunk/gcc/fortran/resolve.c
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/gfortran.dg/dummy_procedure_1.f90
    trunk/gcc/testsuite/gfortran.dg/interface_7.f90


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20896


^ permalink raw reply	[flat|nested] 14+ messages in thread
* [Bug fortran/20896] [4.2 and 4.1 only] ambiguous interface not detected
       [not found] <bug-20896-6642@http.gcc.gnu.org/bugzilla/>
  2006-12-26 14:38 ` [Bug fortran/20896] ambiguous interface not detected patchapp at dberlin dot org
  2006-12-27 13:47 ` pault at gcc dot gnu dot org
@ 2006-12-27 16:38 ` pault at gcc dot gnu dot org
  2007-01-02 14:23 ` pault at gcc dot gnu dot org
                   ` (10 subsequent siblings)
  13 siblings, 0 replies; 14+ messages in thread
From: pault at gcc dot gnu dot org @ 2006-12-27 16:38 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #3 from pault at gcc dot gnu dot org  2006-12-27 16:38 -------
I suppose that I had better accept it...

Paul


-- 

pault at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |pault at gcc dot gnu dot org
                   |dot org                     |
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2005-12-31 19:56:44         |2006-12-27 16:38:11
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20896


^ permalink raw reply	[flat|nested] 14+ messages in thread
* [Bug fortran/20896] [4.2 and 4.1 only] ambiguous interface not detected
       [not found] <bug-20896-6642@http.gcc.gnu.org/bugzilla/>
                   ` (2 preceding siblings ...)
  2006-12-27 16:38 ` [Bug fortran/20896] [4.2 and 4.1 only] " pault at gcc dot gnu dot org
@ 2007-01-02 14:23 ` pault at gcc dot gnu dot org
  2007-01-03 18:05 ` patchapp at dberlin dot org
                   ` (9 subsequent siblings)
  13 siblings, 0 replies; 14+ messages in thread
From: pault at gcc dot gnu dot org @ 2007-01-02 14:23 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #4 from pault at gcc dot gnu dot org  2007-01-02 14:23 -------
Subject: Bug 20896

Author: pault
Date: Tue Jan  2 14:23:36 2007
New Revision: 120342

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=120342
Log:
2007-01-02  Paul Thomas  <pault@gcc.gnu.org>

        PR fortran/20896
        * interface.c (check_sym_interfaces): Remove call to
        resolve_global_procedure.
        gfortran.h : Remove prototype for resolve_global_procedure.
        resolve.c (resolve_global_procedure): Add static attribute
        to function declaration.

2007-01-02  Paul Thomas  <pault@gcc.gnu.org>

        PR fortran/20896
        * gfortran.dg/interface_10.f90: Remove.


Removed:
    trunk/gcc/testsuite/gfortran.dg/interface_10.f90
Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/gfortran.h
    trunk/gcc/fortran/interface.c
    trunk/gcc/fortran/resolve.c
    trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20896


^ permalink raw reply	[flat|nested] 14+ messages in thread
* [Bug fortran/20896] [4.2 and 4.1 only] ambiguous interface not detected
       [not found] <bug-20896-6642@http.gcc.gnu.org/bugzilla/>
                   ` (3 preceding siblings ...)
  2007-01-02 14:23 ` pault at gcc dot gnu dot org
@ 2007-01-03 18:05 ` patchapp at dberlin dot org
  2007-01-21 20:41 ` jvdelisle at gcc dot gnu dot org
                   ` (8 subsequent siblings)
  13 siblings, 0 replies; 14+ messages in thread
From: patchapp at dberlin dot org @ 2007-01-03 18:05 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #5 from patchapp at dberlin dot org  2007-01-03 18:05 -------
Subject: Bug number PR20896

A patch for this bug has been added to the patch tracker.
The mailing list url for the patch is
http://gcc.gnu.org/ml/gcc-patches/2007-01/msg00145.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20896


^ permalink raw reply	[flat|nested] 14+ messages in thread
* [Bug fortran/20896] [4.2 and 4.1 only] ambiguous interface not detected
       [not found] <bug-20896-6642@http.gcc.gnu.org/bugzilla/>
                   ` (4 preceding siblings ...)
  2007-01-03 18:05 ` patchapp at dberlin dot org
@ 2007-01-21 20:41 ` jvdelisle at gcc dot gnu dot org
  2007-01-31  9:55 ` burnus at gcc dot gnu dot org
                   ` (7 subsequent siblings)
  13 siblings, 0 replies; 14+ messages in thread
From: jvdelisle at gcc dot gnu dot org @ 2007-01-21 20:41 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #6 from jvdelisle at gcc dot gnu dot org  2007-01-21 20:41 -------
What is the status on this now?  After reviewing the standard I think I am in
agreement with what this patch does.  The standard is not exactly straight
forward  interpret.

Do we have consensus yet on this?  If so, I will commit for Paul.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20896


^ permalink raw reply	[flat|nested] 14+ messages in thread
* [Bug fortran/20896] [4.2 and 4.1 only] ambiguous interface not detected
       [not found] <bug-20896-6642@http.gcc.gnu.org/bugzilla/>
                   ` (5 preceding siblings ...)
  2007-01-21 20:41 ` jvdelisle at gcc dot gnu dot org
@ 2007-01-31  9:55 ` burnus at gcc dot gnu dot org
  2007-05-10 22:21 ` fxcoudert at gcc dot gnu dot org
                   ` (6 subsequent siblings)
  13 siblings, 0 replies; 14+ messages in thread
From: burnus at gcc dot gnu dot org @ 2007-01-31  9:55 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #7 from burnus at gcc dot gnu dot org  2007-01-31 09:55 -------
> > http://gcc.gnu.org/ml/gcc-patches/2007-01/msg00145.html
> Do we have consensus yet on this?
> The standard is not exactly straight forward interpret.

I'm not 100% sure. The standard is indeed not very clear about it.
My feeling is that the standard forbids some of the things on the basis that
the compiler is not required to check those, but I should study the patch and
the standard again.

With the patch the following is not ambiguous:

+     SUBROUTINE s2(p2)
+       interface
+         function p2 ()
+           real p2
+         end
+       end interface
+     END
+     SUBROUTINE s1(p1)
+       external p1
+     END

This is based on the following: the first one is a function (well, that's
obvious) and the second one is a subroutine. But is this indeed clear?
Without IMPLICIT NONE the second could be equally well a real function, or do I
miss something subtle?


-- 

burnus at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |burnus at net-b dot de


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20896


^ permalink raw reply	[flat|nested] 14+ messages in thread
* [Bug fortran/20896] [4.2 and 4.1 only] ambiguous interface not detected
       [not found] <bug-20896-6642@http.gcc.gnu.org/bugzilla/>
                   ` (6 preceding siblings ...)
  2007-01-31  9:55 ` burnus at gcc dot gnu dot org
@ 2007-05-10 22:21 ` fxcoudert at gcc dot gnu dot org
  2007-08-16 11:50 ` fxcoudert at gcc dot gnu dot org
                   ` (5 subsequent siblings)
  13 siblings, 0 replies; 14+ messages in thread
From: fxcoudert at gcc dot gnu dot org @ 2007-05-10 22:21 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #8 from fxcoudert at gcc dot gnu dot org  2007-05-10 23:20 -------
Paul, what is the status on this one?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20896


^ permalink raw reply	[flat|nested] 14+ messages in thread
* [Bug fortran/20896] [4.2 and 4.1 only] ambiguous interface not detected
       [not found] <bug-20896-6642@http.gcc.gnu.org/bugzilla/>
                   ` (7 preceding siblings ...)
  2007-05-10 22:21 ` fxcoudert at gcc dot gnu dot org
@ 2007-08-16 11:50 ` fxcoudert at gcc dot gnu dot org
  2007-08-20  3:48 ` pault at gcc dot gnu dot org
                   ` (4 subsequent siblings)
  13 siblings, 0 replies; 14+ messages in thread
From: fxcoudert at gcc dot gnu dot org @ 2007-08-16 11:50 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #9 from fxcoudert at gcc dot gnu dot org  2007-08-16 11:50 -------
(In reply to comment #8)
> Paul, what is the status on this one?

ping?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20896


^ permalink raw reply	[flat|nested] 14+ messages in thread
* [Bug fortran/20896] [4.2 and 4.1 only] ambiguous interface not detected
       [not found] <bug-20896-6642@http.gcc.gnu.org/bugzilla/>
                   ` (8 preceding siblings ...)
  2007-08-16 11:50 ` fxcoudert at gcc dot gnu dot org
@ 2007-08-20  3:48 ` pault at gcc dot gnu dot org
  2007-12-14 12:26 ` burnus at gcc dot gnu dot org
                   ` (3 subsequent siblings)
  13 siblings, 0 replies; 14+ messages in thread
From: pault at gcc dot gnu dot org @ 2007-08-20  3:48 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #10 from pault at gcc dot gnu dot org  2007-08-20 03:48 -------
(In reply to comment #9)
> (In reply to comment #8)
> > Paul, what is the status on this one?
> 
> ping?
> 
Go back to the thread on it.  I did not seem able to satisfy the reviewer as to
my interpretation of the standard; since I could not see any other, I let it
drop. I'll unassign myself.

Paul


-- 

pault at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|pault at gcc dot gnu dot org|unassigned at gcc dot gnu
                   |                            |dot org
             Status|ASSIGNED                    |NEW


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20896


^ permalink raw reply	[flat|nested] 14+ messages in thread
* [Bug fortran/20896] [4.2 and 4.1 only] ambiguous interface not detected
       [not found] <bug-20896-6642@http.gcc.gnu.org/bugzilla/>
                   ` (9 preceding siblings ...)
  2007-08-20  3:48 ` pault at gcc dot gnu dot org
@ 2007-12-14 12:26 ` burnus at gcc dot gnu dot org
  2007-12-17 18:05 ` [Bug fortran/20896] " dfranke at gcc dot gnu dot org
                   ` (2 subsequent siblings)
  13 siblings, 0 replies; 14+ messages in thread
From: burnus at gcc dot gnu dot org @ 2007-12-14 12:26 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #11 from burnus at gcc dot gnu dot org  2007-12-14 12:26 -------
I think this effectively a duplicate of PR 34004.

The example of comment 0 is invalid (the specific functions have arguments
which are not distinguishable per the Fortran standard, see PR 34004). That can
distinguish them in practice does not count.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20896


^ permalink raw reply	[flat|nested] 14+ messages in thread
* [Bug fortran/20896] ambiguous interface not detected
       [not found] <bug-20896-6642@http.gcc.gnu.org/bugzilla/>
                   ` (10 preceding siblings ...)
  2007-12-14 12:26 ` burnus at gcc dot gnu dot org
@ 2007-12-17 18:05 ` dfranke at gcc dot gnu dot org
  2009-04-14 14:50 ` dfranke at gcc dot gnu dot org
  2009-04-14 15:05 ` dfranke at gcc dot gnu dot org
  13 siblings, 0 replies; 14+ messages in thread
From: dfranke at gcc dot gnu dot org @ 2007-12-17 18:05 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #12 from dfranke at gcc dot gnu dot org  2007-12-17 18:05 -------
Changing the summary as it wrongly indicated that this is only an issue with
4.1 and 4.2.


-- 

dfranke at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dfranke at gcc dot gnu dot
                   |                            |org
            Summary|[4.2 and 4.1 only] ambiguous|ambiguous interface not
                   |interface not detected      |detected


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20896


^ permalink raw reply	[flat|nested] 14+ messages in thread
* [Bug fortran/20896] ambiguous interface not detected
       [not found] <bug-20896-6642@http.gcc.gnu.org/bugzilla/>
                   ` (11 preceding siblings ...)
  2007-12-17 18:05 ` [Bug fortran/20896] " dfranke at gcc dot gnu dot org
@ 2009-04-14 14:50 ` dfranke at gcc dot gnu dot org
  2009-04-14 15:05 ` dfranke at gcc dot gnu dot org
  13 siblings, 0 replies; 14+ messages in thread
From: dfranke at gcc dot gnu dot org @ 2009-04-14 14:50 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #13 from dfranke at gcc dot gnu dot org  2009-04-14 14:49 -------
Closing as WONTFIX.
See http://gcc.gnu.org/ml/fortran/2009-04/msg00149.html for discussion.


-- 

dfranke at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |WONTFIX


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20896


^ permalink raw reply	[flat|nested] 14+ messages in thread
* [Bug fortran/20896] ambiguous interface not detected
       [not found] <bug-20896-6642@http.gcc.gnu.org/bugzilla/>
                   ` (12 preceding siblings ...)
  2009-04-14 14:50 ` dfranke at gcc dot gnu dot org
@ 2009-04-14 15:05 ` dfranke at gcc dot gnu dot org
  13 siblings, 0 replies; 14+ messages in thread
From: dfranke at gcc dot gnu dot org @ 2009-04-14 15:05 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #14 from dfranke at gcc dot gnu dot org  2009-04-14 15:04 -------
Reopen, closed wrong PR :(


-- 

dfranke at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|WONTFIX                     |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20896


^ permalink raw reply	[flat|nested] 14+ messages in thread
end of thread, other threads:[~2009-04-14 15:05 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <bug-20896-6642@http.gcc.gnu.org/bugzilla/>
2006-12-26 14:38 ` [Bug fortran/20896] ambiguous interface not detected patchapp at dberlin dot org
2006-12-27 13:47 ` pault at gcc dot gnu dot org
2006-12-27 16:38 ` [Bug fortran/20896] [4.2 and 4.1 only] " pault at gcc dot gnu dot org
2007-01-02 14:23 ` pault at gcc dot gnu dot org
2007-01-03 18:05 ` patchapp at dberlin dot org
2007-01-21 20:41 ` jvdelisle at gcc dot gnu dot org
2007-01-31  9:55 ` burnus at gcc dot gnu dot org
2007-05-10 22:21 ` fxcoudert at gcc dot gnu dot org
2007-08-16 11:50 ` fxcoudert at gcc dot gnu dot org
2007-08-20  3:48 ` pault at gcc dot gnu dot org
2007-12-14 12:26 ` burnus at gcc dot gnu dot org
2007-12-17 18:05 ` [Bug fortran/20896] " dfranke at gcc dot gnu dot org
2009-04-14 14:50 ` dfranke at gcc dot gnu dot org
2009-04-14 15:05 ` dfranke at gcc dot gnu dot org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).