public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "janis at gcc dot gnu dot org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug testsuite/25352] xfail within dg-do command has no effect
Date: Thu, 10 May 2007 23:51:00 -0000	[thread overview]
Message-ID: <20070510235116.2253.qmail@sourceware.org> (raw)
In-Reply-To: <bug-25352-578@http.gcc.gnu.org/bugzilla/>



------- Comment #8 from janis at gcc dot gnu dot org  2007-05-11 00:51 -------
I had forgotten all about this.  Today I checked to see how older versions of
DejaGnu and GCC tests handled xfail for dg-do keywords other than "run".  I
only went back as far as GCC 3.0.4 and DejaGnu 1.4, but they also ignored xfail
in dg-do for preprocess/compile/assemble/link.

There are currently 27 tests that use this construct: three in libstdc++-v3 and
24 in gcc.

My recommendations are to document, in the description of test directives in
the GCC Internals manual, that xfail for dg-do is only honored for dg-do run
and ignored for other keywords, recommending the use of dg-xfail-if instead;
and to remove the xfail section from the 27 tests that use it when it's
ignored.

I'll do these if it sounds reasonable.  I don't think this is worth working
around in the GCC testsuite support or fixing in DejaGnu.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25352


  parent reply	other threads:[~2007-05-10 23:51 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-11 15:01 [Bug testsuite/25352] New: " ghazi at gcc dot gnu dot org
2005-12-11 15:14 ` [Bug testsuite/25352] " ghazi at gcc dot gnu dot org
2005-12-12 17:57 ` janis at gcc dot gnu dot org
2005-12-12 22:14 ` janis at gcc dot gnu dot org
2005-12-13 19:08 ` janis at gcc dot gnu dot org
2005-12-14 18:17 ` janis at gcc dot gnu dot org
2005-12-14 18:36 ` ghazi at gcc dot gnu dot org
2007-05-10 16:44 ` ghazi at gcc dot gnu dot org
2007-05-10 23:51 ` janis at gcc dot gnu dot org [this message]
2007-05-15 16:47 ` ghazi at gcc dot gnu dot org
2007-11-01 16:23 ` janis at gcc dot gnu dot org
2008-05-13 22:20 ` janis at gcc dot gnu dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070510235116.2253.qmail@sourceware.org \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).