public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "pcarlini at suse dot de" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug libstdc++/31836] [4.3 Regression] FAIL: 27_io/basic_istream/extractors_arithmetic/char/12.cc execution test Date: Mon, 14 May 2007 15:54:00 -0000 [thread overview] Message-ID: <20070514155409.20058.qmail@sourceware.org> (raw) In-Reply-To: <bug-31836-276@http.gcc.gnu.org/bugzilla/> ------- Comment #33 from pcarlini at suse dot de 2007-05-14 16:54 ------- (In reply to comment #32) > /* Define to 1 if you have the `finitef' function. */ > /* #undef _GLIBCXX_HAVE_FINITEF */ > /* Define to 1 if you have the `_finitef' function. */ > /* #undef _GLIBCXX_HAVE__FINITEF */ > /* Define to 1 if you have the `finite' function. */ > /* #undef _GLIBCXX_HAVE_FINITE */ > /* Define to 1 if you have the `_finite' function. */ > /* #undef _GLIBCXX_HAVE__FINITE */ > /* Define to 1 if you have the `isinf' function. */ > /* #undef _GLIBCXX_HAVE_ISINF */ > /* Define to 1 if you have the `_isinf' function. */ > /* #undef _GLIBCXX_HAVE__ISINF */ Ok, all undefined, it's possible. > Thus, the test that should be performed in > _ZSt14__convert_to_vIfEvPKcRT_RSt12_Ios_IostateRKPi should be: > > if (fabs(__d) > numeric_limits<float>::max()) > errno = ERANGE; Only *if* _GLIBCXX_HAVE_STRTOF is not defined, however. > Disassembly of that method shows that the test has been > optimized away. > This is not actually surprising, because _GLIBCXX_HAVE_STRTOF > has been set, and hence strtof has been used, and > __d remained uninitalized. Ok, therefore _GLIBCXX_HAVE_STRTOF is set and no further test is needed before the final one. In this case __d isn't optimized out, simply the pre-processor selects: float __f = strtof(__s, &__sanity); instead of double __d = strtod(__s, &__sanity); float __f = static_cast<float>(__d); Now, the strange thing is that, before these two last patches (in 4_2-branch in other terms), errno doesn't turn out to be == ERANGE for your target: strtof should have set it... -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31836
next prev parent reply other threads:[~2007-05-14 15:54 UTC|newest] Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top 2007-05-05 1:42 [Bug libstdc++/31836] New: " danglin at gcc dot gnu dot org 2007-05-05 20:11 ` [Bug libstdc++/31836] [4.3 Regression] " pcarlini at suse dot de 2007-05-05 20:12 ` pcarlini at suse dot de 2007-05-05 20:38 ` pcarlini at suse dot de 2007-05-05 21:57 ` pcarlini at suse dot de 2007-05-05 22:03 ` dave at hiauly1 dot hia dot nrc dot ca 2007-05-06 3:01 ` dave at hiauly1 dot hia dot nrc dot ca 2007-05-06 3:02 ` dave at hiauly1 dot hia dot nrc dot ca 2007-05-06 9:16 ` pcarlini at suse dot de 2007-05-06 9:16 ` pcarlini at suse dot de 2007-05-06 9:30 ` pcarlini at suse dot de 2007-05-06 11:51 ` paolo at gcc dot gnu dot org 2007-05-06 11:56 ` pcarlini at suse dot de 2007-05-06 21:35 ` dave at hiauly1 dot hia dot nrc dot ca 2007-05-06 22:08 ` dave at hiauly1 dot hia dot nrc dot ca 2007-05-06 22:59 ` pcarlini at suse dot de 2007-05-06 23:52 ` dave at hiauly1 dot hia dot nrc dot ca 2007-05-07 0:02 ` pcarlini at suse dot de 2007-05-11 16:36 ` amylaar at gcc dot gnu dot org 2007-05-11 17:29 ` pcarlini at suse dot de 2007-05-11 17:32 ` dave at hiauly1 dot hia dot nrc dot ca 2007-05-11 18:02 ` pcarlini at suse dot de 2007-05-11 18:04 ` pcarlini at suse dot de 2007-05-11 18:17 ` pcarlini at suse dot de 2007-05-11 22:38 ` dave at hiauly1 dot hia dot nrc dot ca 2007-05-12 0:22 ` dave at hiauly1 dot hia dot nrc dot ca 2007-05-12 0:51 ` pcarlini at suse dot de 2007-05-12 1:01 ` pcarlini at suse dot de 2007-05-12 1:23 ` dave at hiauly1 dot hia dot nrc dot ca 2007-05-12 1:37 ` dave at hiauly1 dot hia dot nrc dot ca 2007-05-12 18:17 ` pcarlini at suse dot de 2007-05-12 18:54 ` dave at hiauly1 dot hia dot nrc dot ca 2007-05-12 19:26 ` pcarlini at suse dot de 2007-05-14 15:40 ` amylaar at spamcop dot net 2007-05-14 15:54 ` pcarlini at suse dot de [this message] 2007-05-14 18:25 ` amylaar at spamcop dot net 2007-06-30 9:12 ` pinskia at gcc dot gnu dot org 2007-07-25 15:33 ` danglin at gcc dot gnu dot org 2007-07-25 15:36 ` danglin at gcc dot gnu dot org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20070514155409.20058.qmail@sourceware.org \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).