From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugs-return-218388-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 28037 invoked by alias); 17 May 2007 00:49:35 -0000
Received: (qmail 27982 invoked by uid 48); 17 May 2007 00:49:21 -0000
Date: Thu, 17 May 2007 00:49:00 -0000
Message-ID: <20070517004921.27981.qmail@sourceware.org>
X-Bugzilla-Reason: CC
References: <bug-31964-12424@http.gcc.gnu.org/bugzilla/>
Subject: [Bug fortran/31964] ishftc fails with certain thrid argument
In-Reply-To: <bug-31964-12424@http.gcc.gnu.org/bugzilla/>
Reply-To: gcc-bugzilla@gcc.gnu.org
To: gcc-bugs@gcc.gnu.org
From: "jvdelisle at gcc dot gnu dot org" <gcc-bugzilla@gcc.gnu.org>
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
X-SW-Source: 2007-05/txt/msg01253.txt.bz2



------- Comment #3 from jvdelisle at gcc dot gnu dot org  2007-05-17 01:49 -------
I think we have an off by one when setting mask.  I want to do some testing and
double check on all this.  Here is a patch:

Index: ishftc.c
===================================================================
*** ishftc.c    (revision 124756)
--- ishftc.c    (working copy)
*************** ishftc4 (GFC_INTEGER_4 i, GFC_INTEGER_4 
*** 45,51 ****
    if (shift == 0 || shift == size)
      return i;

!   mask = (~(GFC_INTEGER_4)0) << size;
    bits = i & ~mask;
    return (i & mask) | (bits >> (size - shift)) | ((i << shift) & ~mask);
  }
--- 45,51 ----
    if (shift == 0 || shift == size)
      return i;

!   mask = (~(GFC_INTEGER_4)0) << (size - 1);
    bits = i & ~mask;
    return (i & mask) | (bits >> (size - shift)) | ((i << shift) & ~mask);
  }
*************** ishftc8 (GFC_INTEGER_8 i, GFC_INTEGER_4 
*** 65,71 ****
    if (shift == 0 || shift == size)
      return i;

!   mask = (~(GFC_INTEGER_8)0) << size;
    bits = i & ~mask;
    return (i & mask) | (bits >> (size - shift)) | ((i << shift) & ~mask);
  }
--- 65,71 ----
    if (shift == 0 || shift == size)
      return i;

!   mask = (~(GFC_INTEGER_8)0) << (size - 1);
    bits = i & ~mask;
    return (i & mask) | (bits >> (size - shift)) | ((i << shift) & ~mask);
  }
*************** ishftc16 (GFC_INTEGER_16 i, GFC_INTEGER_
*** 86,92 ****
    if (shift == 0 || shift == size)
      return i;

!   mask = (~(GFC_INTEGER_16)0) << size;
    bits = i & ~mask;
    return (i & mask) | (bits >> (size - shift)) | ((i << shift) & ~mask);
  }
--- 86,92 ----
    if (shift == 0 || shift == size)
      return i;

!   mask = (~(GFC_INTEGER_16)0) << (size - 1);
    bits = i & ~mask;
    return (i & mask) | (bits >> (size - shift)) | ((i << shift) & ~mask);
  }


-- 

jvdelisle at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |jvdelisle at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2007-05-17 01:30:46         |2007-05-17 01:49:20
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31964