[Bug target/10768] ICEs on compilation of ada support library for avr

[Bug target/10768] ICEs on compilation of ada support library for avr

[pinskia at gcc dot gnu dot org]

------- Comment #13 from pinskia at gcc dot gnu dot org  2006-04-26 20:40 -------
*** Bug 26849 has been marked as a duplicate of this bug. ***


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10768

[Bug target/10768] ICEs on compilation of ada support library for avr

[pinskia at gcc dot gnu dot org]

------- Comment #14 from pinskia at gcc dot gnu dot org  2006-04-26 20:42 -------
(In reply to comment #12)
>  It deserves a separate entry in bugzilla.
> I propose to close this entry here.


I did the opposite and closed the other as a dup, since the orginal testcase
still fails with ICEs.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10768

[Bug target/10768] ICEs on compilation of ada support library for avr

[eweddington at cso dot atmel dot com]

------- Comment #15 from eweddington at cso dot atmel dot com  2007-04-11 04:20 -------
Bernd, Rolf,

Can you verify if this bug still exists? If so, I have in my notes that this
patch will fix this bug:
<http://svn.sourceforge.net/viewvc/avr-ada/trunk/patches/gcc-4.1-integer-bug-workaround.patch?view=log>

If so, can you attach the patch to this bug report?

Thanks


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10768

[Bug target/10768] ICEs on compilation of ada support library for avr

[rolf dot ebert dot gcc at gmx dot de]

------- Comment #16 from rolf dot ebert dot gcc at gmx dot de  2007-04-30 09:57 -------
(In reply to comment #15)
> Can you verify if this bug still exists? 

Yes, the problem is still present in 4.2

Bernd Trog developed a workaround available at
http://svn.sourceforge.net/viewvc/avr-ada/trunk/patches/gcc-4.1-integer-bug-workaround.patch?view=log
(sorry, I cannot attach it due to an internal error of bugzilla)

Also see the related discussion that started here
http://gcc.gnu.org/ml/gcc/2006-04/msg00512.html 

PR 30501 is a duplicate of this bug report and could be closed.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10768

[Bug target/10768] ICEs on compilation of ada support library for avr

[charlet at gcc dot gnu dot org]

------- Comment #17 from charlet at gcc dot gnu dot org  2007-04-30 09:59 -------
*** Bug 30501 has been marked as a duplicate of this bug. ***


-- 

charlet at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |linux at schildmann dot info


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10768

[Bug target/10768] ICEs on compilation of ada support library for avr

[rolf dot ebert dot gcc at gmx dot de]

------- Comment #18 from rolf dot ebert dot gcc at gmx dot de  2007-05-21 20:35 -------
Created an attachment (id=13597)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=13597&action=view)
Bernd's patch that fixes the problem

Bernd's patch as mentioned in comment #16


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10768

[Bug target/10768] ICEs on compilation of ada support library for avr

[charlet at gcc dot gnu dot org]

------- Comment #19 from charlet at gcc dot gnu dot org  2007-05-22 09:51 -------
Just to clarify: the patch posted is only a workaround/kludge, not a
real fix.

Arno


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10768

[Bug target/10768] ICEs on compilation of ada support library for avr

[eweddington at cso dot atmel dot com]

------- Comment #20 from eweddington at cso dot atmel dot com  2007-05-22 14:24 -------
Subject: RE:  ICEs on compilation of ada support library for
 avr



> -----Original Message-----
> From: charlet at gcc dot gnu dot org 
> [mailto:gcc-bugzilla@gcc.gnu.org] 
> Sent: Tuesday, May 22, 2007 2:51 AM
> To: eweddington@cso.atmel.com
> Subject: [Bug target/10768] ICEs on compilation of ada 
> support library for avr
> 
> 
> 
> ------- Comment #19 from charlet at gcc dot gnu dot org  
> 2007-05-22 09:51 -------
> Just to clarify: the patch posted is only a workaround/kludge, not a
> real fix.
> 
> Arno

Then what would be a real fix that could actually be approved and committed?

Eric Weddington


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10768

[Bug target/10768] ICEs on compilation of ada support library for avr

[charlet at adacore dot com]

------- Comment #21 from charlet at adacore dot com  2007-05-22 14:26 -------
Subject: Re:  ICEs on compilation of ada support library for avr

> Then what would be a real fix that could actually be approved and committed?

Fix support for long (or long long ?) in the avr back-end.

Arno


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10768

[Bug target/10768] ICEs on compilation of ada support library for avr

[linux at schildmann dot info]

------- Comment #22 from linux at schildmann dot info  2007-12-17 19:53 -------
Hello,

when compiling the package

   package Integer_Test is
      type Int_Type is new Integer;
   end Integer_Test;

the ICE occures when the GNAT node that represents
the lower bound of the integer type is converted
to the corresponding INTERGER_CST node.

In the above case comp_type (gcc/ada/cuintp.c:87)
represents a signed integer type with 16 bit precision
which is to small for the computations performed later:

The call to build_cst_from_int (Base = 32768) at
line gcc/ada/cuintp.c:110

   gnu_base = build_cst_from_int (comp_type, Base);

returns an INTEGER_CST with the value -32768 which
causes an overflow (and later the ICE) in the call to

   fold_build2 (MULT_EXPR, comp_type,
                        gnu_ret, gnu_base)

at line gcc/ada/cuintp.c:116.

See patch below.

Peter

-------------------------------------------

diff -Naur gcc-4.3-20071214.ORIG/gcc/ada/cuintp.c
gcc-4.3-20071214/gcc/ada/cuintp.c
--- gcc-4.3-20071214.ORIG/gcc/ada/cuintp.c      2007-09-03 12:06:52.000000000
+0200
+++ gcc-4.3-20071214/gcc/ada/cuintp.c   2007-12-15 19:33:37.000000000 +0100
@@ -104,8 +104,8 @@
         convert the final result back to the incoming type later on.  */

       if (TREE_CODE (comp_type) != REAL_TYPE
-         && TYPE_PRECISION (comp_type) < TYPE_PRECISION (integer_type_node))
-       comp_type = integer_type_node;
+         && TYPE_PRECISION (comp_type) < TYPE_PRECISION
(long_integer_type_node))
+       comp_type = long_integer_type_node;

       gnu_base = build_cst_from_int (comp_type, Base);


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10768

[Bug target/10768] ICEs on compilation of ada support library for avr

[charlet at gcc dot gnu dot org]

------- Comment #23 from charlet at gcc dot gnu dot org  2008-04-08 06:46 -------
Subject: Bug 10768

Author: charlet
Date: Tue Apr  8 06:46:04 2008
New Revision: 134013

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=134013
Log:
2008-04-08  Tristan Gingold  <gingold@adacore.com>

PR ada/10768

        * cuintp.c: Fix 16 bits issue for AVR.
        On AVR, integer is 16 bits, so it can't be used to do math with
        Base (=32768).
        So use long_integer instead.


Modified:
    trunk/gcc/ada/cuintp.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10768

[Bug target/10768] ICEs on compilation of ada support library for avr

[charlet at gcc dot gnu dot org]

------- Comment #24 from charlet at gcc dot gnu dot org  2008-04-08 07:25 -------
Fixed on mainline.


-- 

charlet at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.4.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10768

[Bug target/10768] ICEs on compilation of ada support library for avr

[berndtrog at yahoo dot com]

------- Additional Comments From berndtrog at yahoo dot com  2005-02-14 20:02 -------
>Bernd, does this still fail on the most recent HEAD?

Yes, it still fails:


+===========================GNAT BUG DETECTED==============================+
| 4.0.0 20050213 (experimental) (avr-unknown-none) GCC error:              |
| in gnat_to_gnu, at ada/trans.c:2536                                      |

compiling this:
--------- t.ads -------------
package T is
bug : Short_Integer;
end T;
--------- t.ads -------------

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10768

[Bug target/10768] ICEs on compilation of ada support library for avr

[ericw at evcohs dot com]

------- Additional Comments From ericw at evcohs dot com  2005-02-11 19:38 -------
Bernd, does this still fail on the most recent HEAD?

Eric

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10768

[Bug target/10768] ICEs on compilation of ada support library for avr

[berndtrog at yahoo dot com]

------- Additional Comments From berndtrog at yahoo dot com  2004-10-06 17:03 -------
Update:

gcc-head fails with
+===========================GNAT BUG DETECTED==============================+
| 4.0.0 20040917 (experimental) (avr-unknown-none) GCC error:              |
| in gnat_to_gnu, at ada/trans.c:2539                                      |
| No source file position information available                            |

compiling this:
--------- t.ads -------------
package T is
bug : Short_Integer;
end T;
--------- t.ads -------------

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10768

[Bug target/10768] ICEs on compilation of ada support library for avr

[berndtrog at yahoo dot com]

------- Additional Comments From berndtrog at yahoo dot com  2003-11-13 20:03 -------
>This is really specific to the avr port, so you would need to talk with the
>avr maintainer on these issues.
>Apparently basic things such as support for long is not properly
>supported by the avr back end, and this is turn causes bug box in gnat.

Denis,
would you please take a look in the avr back end?
Maybe its easy to support 'long' properly..

Thanks,
Bernd

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |denisc at overta dot ru


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10768

[Bug target/10768] ICEs on compilation of ada support library for avr

[pinskia at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10768


pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2003-10-28 15:34:57
               date|                            |

[Bug target/10768] ICEs on compilation of ada support library for avr

[charlet at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10768


charlet at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|ada                         |target
            Summary|ICEs on compilation of ada  |ICEs on compilation of ada
                   |support library             |support library for avr


------- Additional Comments From charlet at gcc dot gnu dot org  2003-10-22 09:08 -------
This is really specific to the avr port, so you would need to talk with the
avr maintainer on these issues.

Apparently basic things such as support for long is not properly
supported by the avr back end, and this is turn causes bug box in gnat.

Arno