[Bug c++/31743] [4.1/4.2/4.3 regression] ICE with invalid use of new

[Bug c++/31743] [4.1/4.2/4.3 regression] ICE with invalid use of new

[reichelt at gcc dot gnu dot org]

-- 

reichelt at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.1.3


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31743

[Bug c++/31743] New: [4.1/4.2/4.3 regression] ICE with invalid use of new

[reichelt at gcc dot gnu dot org]

The following invalid code snippet triggers an ICE since GCC 4.0.0:

===================
typedef int A[];
A* p = new A;
===================

bug.cc:2: internal compiler error: tree check: expected class 'type', have
'exceptional' (error_mark) in extract_muldiv_1, at fold-const.c:5661
Please submit a full bug report, [etc.]

With GCC 3.4.6 we got:
bug.cc:2: error: cannot convert `int*' to `int (*)[]' in initialization


-- 
           Summary: [4.1/4.2/4.3 regression] ICE with invalid use of new
           Product: gcc
           Version: 4.3.0
            Status: UNCONFIRMED
          Keywords: ice-on-invalid-code, monitored
          Severity: normal
          Priority: P3
         Component: c++
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: reichelt at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31743

[Bug c++/31743] [4.1/4.2/4.3 regression] ICE with invalid use of new

[mmitchel at gcc dot gnu dot org]

-- 

mmitchel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31743

[Bug c++/31743] [4.1/4.2/4.3 regression] ICE with invalid use of new

[brolley at redhat dot com]

------- Comment #1 from brolley at redhat dot com  2007-06-05 19:57 -------
Created an attachment (id=13659)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=13659&action=view)
Proposed patch


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31743

[Bug c++/31743] [4.1/4.2/4.3 regression] ICE with invalid use of new

[brolley at redhat dot com]

------- Comment #2 from brolley at redhat dot com  2007-06-05 20:09 -------
The macro invocation "TYPE_MODE (type)" causes the ICE when tree checking is
enabled because TREE_CODE_CLASS (type) is ERROR_MARK. Checking for this before
checking the tree and returning NULL_TREE allows the compiler to generate the
expected message.

Note that this bug exists in 4.2 and 4.3 but did not result in an ICE during my
initial testing because tree checking is disabled on those branches by default.


-- 

brolley at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |brolley at redhat dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31743

[Bug c++/31743] [4.1/4.2/4.3 regression] ICE with invalid use of new

[brolley at redhat dot com]

------- Comment #3 from brolley at redhat dot com  2007-06-05 20:11 -------
Typo (sorry!) ....

"4.2 and 4.3" above should be "4.1 and 4.2"


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31743

[Bug c++/31743] [4.1/4.2/4.3 regression] ICE with invalid use of new

[pinskia at gcc dot gnu dot org]

------- Comment #4 from pinskia at gcc dot gnu dot org  2007-06-05 20:39 -------
This patch is incorrect and just wrong, the C++ front-end should be catching
this before calling size_binop.  Also the code is invalid so we should have an
error.
This patch also allows us to get around the ICE (but still does not provide an
error):
Index: /home/apinski/src/gcc-fsf/pointerplusexpr/gcc/gcc/cp/tree.c
===================================================================
--- /home/apinski/src/gcc-fsf/pointerplusexpr/gcc/gcc/cp/tree.c (revision
125291)
+++ /home/apinski/src/gcc-fsf/pointerplusexpr/gcc/gcc/cp/tree.c (working copy)
@@ -1415,8 +1415,11 @@ cxx_print_statistics (void)
 tree
 array_type_nelts_top (tree type)
 {
+  tree tmp = array_type_nelts (type);
+  if (tmp == error_mark_node)
+    return error_mark_node;
   return fold_build2 (PLUS_EXPR, sizetype,
-                     array_type_nelts (type),
+                     tmp,
                      integer_one_node);
 }


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2007-06-05 20:39:08
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31743

[Bug c++/31743] [4.1/4.2/4.3 regression] ICE with invalid use of new

[brolley at redhat dot com]

------- Comment #5 from brolley at redhat dot com  2007-06-08 15:41 -------
OK, I've looked into this a bit more. For inspiration I looked into where the
error is generated when an incomplete struct is used instead of an unsized
array. I found it in:

cxx_incomplete_type_diagnostic called by
complete_type_or_else called by
build_new_1

I also discovered that this sequence of calls should have detected an unsized
array and generated the message we want. The reason it didn't is because this
knowledge is forgotten in cp_parser_new_type_id (in the case of "new A") or in
build_new_1 (in the case of "new (A)") when the top level array bound is
stripped off. This is done (in both cases) before complete_type_or_else is
called.

Now, the transformation in cp_parser_new_type_id is unnecessary since the same
transformation is done in build_new_1 and (as noted above) it is not performed
in the case of "new (A)". This gives us the opportunity to generate the error
in build_new_1 by calling complete_type_or_else before the transformation.

I'm attaching a patch which implements these two changes. The patch generates
the error "31743.C:2: error: invalid use of array with unspecified bounds"
which is analogous to the message generated when an incomplete struct is used. 

Andrew's patch is not necessary for the generation of the error, but it makes
sense to punt early in array_type_nelts_top when dealing with error_mark_node
regardless.

Tested against the trunk with no regressions in "make check-gcc".


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31743

[Bug c++/31743] [4.1/4.2/4.3 regression] ICE with invalid use of new

[brolley at redhat dot com]

------- Comment #6 from brolley at redhat dot com  2007-06-08 15:42 -------
Created an attachment (id=13667)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=13667&action=view)
New proposed patch


-- 

brolley at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #13659|0                           |1
        is obsolete|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31743

[Bug c++/31743] [4.1/4.2/4.3 regression] ICE with invalid use of new

[brolley at redhat dot com]

------- Comment #7 from brolley at redhat dot com  2007-06-08 15:46 -------
Small optimization. We need only call complete_type_or_else once we know it's
an array type.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31743

[Bug c++/31743] [4.1/4.2/4.3 regression] ICE with invalid use of new

[brolley at redhat dot com]

------- Comment #8 from brolley at redhat dot com  2007-06-08 15:47 -------
Created an attachment (id=13668)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=13668&action=view)
Improvement on previous patch


-- 

brolley at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #13667|0                           |1
        is obsolete|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31743

[Bug c++/31743] [4.1/4.2/4.3 regression] ICE with invalid use of new

[mmitchel at gcc dot gnu dot org]

------- Comment #9 from mmitchel at gcc dot gnu dot org  2007-07-04 00:21 -------
Subject: Bug 31743

Author: mmitchel
Date: Wed Jul  4 00:21:33 2007
New Revision: 126292

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=126292
Log:
        PR c++/31743
        * parser.c (cp_parser_new_type_id): Don't reduce a named array
        type to its base type and number of elements here.
        * init.c (build_new): Call complete_type_or_else to ensure that the
        type is complete and to issue a diagnostic if it is not.
        (build_new_1): Don't call complete_type_or_else here.

        PR c++/31743
        * g++.dg/init/new20.C: New test.

Added:
    trunk/gcc/testsuite/g++.dg/init/new20.C   (with props)
Modified:
    trunk/gcc/cp/ChangeLog
    trunk/gcc/cp/init.c
    trunk/gcc/cp/parser.c
    trunk/gcc/testsuite/ChangeLog

Propchange: trunk/gcc/testsuite/g++.dg/init/new20.C
            ('svn:executable' added)


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31743

[Bug c++/31743] [4.1/4.2/4.3 regression] ICE with invalid use of new

[reichelt at gcc dot gnu dot org]

------- Comment #10 from reichelt at gcc dot gnu dot org  2007-07-07 10:59 -------
Mark, is there any reason, you added the exectuable flag?
If not, would you mind removing it?

> Propchange: trunk/gcc/testsuite/g++.dg/init/new20.C
>            ('svn:executable' added)


-- 

reichelt at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mark at codesourcery dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31743

[Bug c++/31743] [4.1/4.2/4.3 regression] ICE with invalid use of new

[mark at codesourcery dot com]

------- Comment #11 from mark at codesourcery dot com  2007-07-07 19:18 -------
Subject: Re:  [4.1/4.2/4.3 regression] ICE with invalid use
 of new

reichelt at gcc dot gnu dot org wrote:
> ------- Comment #10 from reichelt at gcc dot gnu dot org  2007-07-07 10:59 -------
> Mark, is there any reason, you added the exectuable flag?
> If not, would you mind removing it?
> 
>> Propchange: trunk/gcc/testsuite/g++.dg/init/new20.C
>>            ('svn:executable' added)

I suspect that this is an accident of the file having been on a Cygwin
system at some point.  I've noticed that when I scp from a Cygwin
system, text files tend to get executable permissions.

If you will tell me how to remove the flag, I will take care of it.

Thanks,


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31743

[Bug c++/31743] [4.1/4.2/4.3 regression] ICE with invalid use of new

[reichelt at gcc dot gnu dot org]

------- Comment #12 from reichelt at gcc dot gnu dot org  2007-07-10 10:44 -------
> If you will tell me how to remove the flag, I will take care of it.

To clean the exectuable flag on "file" you can do
  svn propdel svn:executable  file
and then commit the change.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31743

[Bug c++/31743] [4.1/4.2 regression] ICE with invalid use of new

[mmitchel at gcc dot gnu dot org]

------- Comment #13 from mmitchel at gcc dot gnu dot org  2007-07-10 17:57 -------
OK, I've removed the executable property.


-- 

mmitchel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[4.1/4.2/4.3 regression] ICE|[4.1/4.2 regression] ICE
                   |with invalid use of new     |with invalid use of new


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31743

[Bug c++/31743] [4.2 regression] ICE with invalid use of new

[jsm28 at gcc dot gnu dot org]

------- Comment #14 from jsm28 at gcc dot gnu dot org  2008-07-04 22:01 -------
Closing 4.1 branch.


-- 

jsm28 at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[4.1/4.2 regression] ICE    |[4.2 regression] ICE with
                   |with invalid use of new     |invalid use of new
   Target Milestone|4.1.3                       |4.2.5


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31743

[Bug c++/31743] [4.2 regression] ICE with invalid use of new

[jsm28 at gcc dot gnu dot org]

------- Comment #15 from jsm28 at gcc dot gnu dot org  2009-03-30 21:44 -------
Closing 4.2 branch, fixed in 4.3.


-- 

jsm28 at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
      Known to fail|                            |4.2.5
      Known to work|                            |4.3.0
         Resolution|                            |FIXED
   Target Milestone|4.2.5                       |4.3.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31743