[Bug fortran/27698] New: subroutine _foo draws "unclassifiable statement" instead of a useful error.

[Bug fortran/27698] New: subroutine _foo draws "unclassifiable statement" instead of a useful error.

[toon at moene dot indiv dot nluug dot nl]

subroutine _foo
       end

draws the following error:

 In file bhatt.f:1

       subroutine _foo                                                  
      1
Error: Unclassifiable statement at (1)

whereas the compiler would be far more helpful pointing out that _foo is
against the Standard (Rule R304: A name should start with a letter).


-- 
           Summary: subroutine _foo draws "unclassifiable statement" instead
                    of a useful error.
           Product: gcc
           Version: 4.1.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: toon at moene dot indiv dot nluug dot nl


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27698

[Bug fortran/27698] subroutine _foo draws "unclassifiable statement" instead of a useful error.

[aldot at gcc dot gnu dot org]

------- Comment #1 from aldot at gcc dot gnu dot org  2006-05-21 11:50 -------
Created an attachment (id=11490)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=11490&action=view)
print error invalid form for SUBROUTINE at


Not tested.

2006-05-21  Bernhard Fischer  <aldot@gcc.gnu.org>

        PR fortran/27698
        *decl.c (gfc_match_subroutine): Emit error if the name of a subroutine
        is invalid.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27698

[Bug fortran/27698] subroutine _foo draws "unclassifiable statement" instead of a useful error.

[aldot at gcc dot gnu dot org]

-- 

aldot at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
           Keywords|                            |diagnostic
   Last reconfirmed|0000-00-00 00:00:00         |2006-05-21 11:53:24
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27698

[Bug fortran/27698] subroutine _foo draws "unclassifiable statement" instead of a useful error.

[kargl at gcc dot gnu dot org]

------- Comment #2 from kargl at gcc dot gnu dot org  2006-05-21 16:14 -------
Bernhard, 

Your patch only addresses one aspect of the problem.
Consider

function _foo
  entry _bar
end function


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27698

[Bug fortran/27698] subroutine _foo draws "unclassifiable statement" instead of a useful error.

[aldot at gcc dot gnu dot org]

------- Comment #3 from aldot at gcc dot gnu dot org  2006-07-05 17:19 -------
(In reply to comment #2)
> Bernhard, 
> 
> Your patch only addresses one aspect of the problem.
> Consider
> 
> function _foo
>   entry _bar
> end function
> 

Is it sufficient to print an error in gfc_match_name, or should the individual
callers be instrumented with separate messages (invalid form for
$everything_with_a_name at $there) ?


-- 

aldot at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kargl at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27698

[Bug fortran/27698] subroutine _foo draws "unclassifiable statement" instead of a useful error.

[sgk at troutmask dot apl dot washington dot edu]

------- Comment #4 from sgk at troutmask dot apl dot washington dot edu  2006-07-05 17:35 -------
Subject: Re:  subroutine _foo draws "unclassifiable statement" instead of a
useful error.

On Wed, Jul 05, 2006 at 05:19:44PM -0000, aldot at gcc dot gnu dot org wrote:
> 
> 
> ------- Comment #3 from aldot at gcc dot gnu dot org  2006-07-05 17:19 -------
> (In reply to comment #2)
> > Bernhard, 
> > 
> > Your patch only addresses one aspect of the problem.
> > Consider
> > 
> > function _foo
> >   entry _bar
> > end function
> > 
> 
> Is it sufficient to print an error in gfc_match_name, or should the individual
> callers be instrumented with separate messages (invalid form for
> $everything_with_a_name at $there) ?
> 

I think we can issue the error in gfc_match_name with some
generic message such as

gcc_error("Object at %L cannot have a leading underscore", locus);

I had forgotten about this PR.  Thanks for following up.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27698

[Bug fortran/27698] subroutine _foo draws "unclassifiable statement" instead of a useful error.

[patchapp at dberlin dot org]

------- Comment #5 from patchapp at dberlin dot org  2006-07-05 18:55 -------
Subject: Bug number PR fortran/27698

A patch for this bug has been added to the patch tracker.
The mailing list url for the patch is
http://gcc.gnu.org/ml/gcc-patches/2006-07/msg00159.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27698

[Bug fortran/27698] subroutine _foo draws "unclassifiable statement" instead of a useful error.

[aldot at gcc dot gnu dot org]

------- Comment #6 from aldot at gcc dot gnu dot org  2006-11-05 16:19 -------
Updating the testsuite to account for the new error message now.

Note that i think that we should take -fdollar-ok into account, i.e.:

if (!ISALPHA (c) && !(gfc_option.flag_dollar_ok && c == '$'))
  {
    bail;
  }

to allow for names (in the sense of 3.2.1) that begin with a dollar.

Such names are currently rejected (even if -fdollar-ok suggests that they
should be ok).


-- 

aldot at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aldot at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27698

[Bug fortran/27698] subroutine _foo draws "unclassifiable statement" instead of a useful error.

[sgk at troutmask dot apl dot washington dot edu]

------- Comment #7 from sgk at troutmask dot apl dot washington dot edu  2006-11-05 16:27 -------
Subject: Re:  subroutine _foo draws "unclassifiable statement" instead of a
useful error.

On Sun, Nov 05, 2006 at 04:19:08PM -0000, aldot at gcc dot gnu dot org wrote:
> 
> ------- Comment #6 from aldot at gcc dot gnu dot org  2006-11-05 16:19 -------
> Updating the testsuite to account for the new error message now.
> 
> Note that i think that we should take -fdollar-ok into account, i.e.:
> 
> if (!ISALPHA (c) && !(gfc_option.flag_dollar_ok && c == '$'))
>   {
>     bail;
>   }
> 
> to allow for names (in the sense of 3.2.1) that begin with a dollar.
> 
> Such names are currently rejected (even if -fdollar-ok suggests that they
> should be ok).
> 
> 

How does Intel's iand other commercial compilers handle
a leading dollar?  The standard is quite clear that the
first character in a name is an alphabetic character.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27698

[Bug fortran/27698] subroutine _foo draws "unclassifiable statement" instead of a useful error.

[aldot at gcc dot gnu dot org]

------- Comment #8 from aldot at gcc dot gnu dot org  2006-11-05 16:37 -------
> How does Intel's iand other commercial compilers handle
> a leading dollar?  The standard is quite clear that the
> first character in a name is an alphabetic character.
> 
ifort-9.1.xx accept it without any notice.
Why would a leading dollar be different to anywhere else in a name?

$ rm -f invalid.o ; cat invalid.f 
      subroutine $invalid_but_whatever
      end subroutine $invalid_but_whatever
      end
$ ifort -warn all -check all -o invalid.o -c invalid.f && nm invalid.o
         U for_set_reentrancy
         U __intel_new_proc_init
0000002a T $invalid_but_whatever_
00000000 r LITPACK_0.0.1
00000000 T MAIN__


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27698

[Bug fortran/27698] subroutine _foo draws "unclassifiable statement" instead of a useful error.

[sgk at troutmask dot apl dot washington dot edu]

------- Comment #9 from sgk at troutmask dot apl dot washington dot edu  2006-11-05 17:00 -------
Subject: Re:  subroutine _foo draws "unclassifiable statement" instead of a
useful error.

On Sun, Nov 05, 2006 at 04:37:42PM -0000, aldot at gcc dot gnu dot org wrote:
> 
> > How does Intel's iand other commercial compilers handle
> > a leading dollar?  The standard is quite clear that the
> > first character in a name is an alphabetic character.
> > 
> ifort-9.1.xx accept it without any notice.
> Why would a leading dollar be different to anywhere else in a name?
> 

IIRC, the use of $ is a Digital extension on VMS.  It's
been more than 15 years since I used VMS, but I vaguely
remmeber seeing Fortran with the $ only in the 2nd position.

But, if Intel (a Digital descented) accepts the leading
dollar sign, then your suggested modification is probably
correct.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27698

[Bug fortran/27698] subroutine _foo draws "unclassifiable statement" instead of a useful error.

[aldot at gcc dot gnu dot org]

------- Comment #10 from aldot at gcc dot gnu dot org  2006-11-05 17:16 -------
> IIRC, the use of $ is a Digital extension on VMS.  It's
> been more than 15 years since I used VMS, but I vaguely
> remmeber seeing Fortran with the $ only in the 2nd position.
> 
> But, if Intel (a Digital descented) accepts the leading
> dollar sign, then your suggested modification is probably
> correct.
> 

According to
http://publib.boulder.ibm.com/infocenter/lnxpcomp/v8v101/index.jsp?topic=/com.ibm.xlf101l.doc/xlfopg/extnames.htm
the XL fortran accepts
" 
Both the underscore (_) and the dollar sign ($) are valid characters anywhere
in names.
"
While we currently have -fdollar-ok to accept the (invalid !) use of '$' in a
name, we don't provide means to accept (invalid !) names with a leading
underscore. This would of course only serve compatibility to IBM's xlf and,
perhaps, other compilers.

Disallowing a dollar sign as the very first character in a name even if
-fdollar-ok was requested by the user seems to be a simple omission to me.

Whether we want to allow for such invalid code for compatibility is beyond my
judgement, though.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27698

[Bug fortran/27698] subroutine _foo draws "unclassifiable statement" instead of a useful error.

[aldot at gcc dot gnu dot org]

------- Comment #11 from aldot at gcc dot gnu dot org  2006-11-18 15:23 -------

> Disallowing a dollar sign as the very first character in a name even if
> -fdollar-ok was requested by the user seems to be a simple omission to me.
> 
> Whether we want to allow for such invalid code for compatibility is beyond my
> judgement, though.

One implication would concern implicit types, AFAICS.
gfc_namespace.default_type[GFC_LETTERS] is currently limiting implicit types to
a..z

Should -fdollar-ok be made to allow for a '$' even in the first position of a
name (including implicit types for types with a name starting with '$') or are
we better off to extend the documentation to explicitely note that '$' as the
_first_ char in a name is not supported in this extension?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27698

[Bug fortran/27698] subroutine _foo draws "unclassifiable statement" instead of a useful error.

[patchapp at dberlin dot org]

------- Comment #12 from patchapp at dberlin dot org  2007-01-03 16:50 -------
Subject: Bug number PR27698

A patch for this bug has been added to the patch tracker.
The mailing list url for the patch is
http://gcc.gnu.org/ml/gcc-patches/2007-01/msg00137.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27698

[Bug fortran/27698] subroutine _foo draws "unclassifiable statement" instead of a useful error.

[aldot at gcc dot gnu dot org]

------- Comment #13 from aldot at gcc dot gnu dot org  2007-01-07 16:23 -------
Subject: Bug 27698

Author: aldot
Date: Sun Jan  7 16:23:45 2007
New Revision: 120549

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=120549
Log:
fortran/ChangeLog

2007-01-03  Bernhard Fischer  <aldot@gcc.gnu.org>

        PR fortran/27698
        * match.c (gfc_match_name): Print diagnostics for invalid character
        in names.


testsuite/ChangeLog

2007-01-03  Bernhard Fischer  <aldot@gcc.gnu.org>

        PR fortran/27698
        * gfortran.dg/invalid_name.f90: New test.
        * gfortran.dg/do_iterator.f90: Adjust pattern for expected error.
        * gfortran.dg/gomp/pr29759.f90: Ditto.



Added:
    trunk/gcc/testsuite/gfortran.dg/invalid_name.f90
Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/match.c
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/gfortran.dg/do_iterator.f90
    trunk/gcc/testsuite/gfortran.dg/gomp/pr29759.f90


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27698

[Bug fortran/27698] subroutine _foo draws "unclassifiable statement" instead of a useful error.

[dfranke at gcc dot gnu dot org]

------- Comment #14 from dfranke at gcc dot gnu dot org  2007-05-21 20:24 -------
Can this be considered fixed?


-- 

dfranke at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dfranke at gcc dot gnu dot
                   |                            |org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27698

[Bug fortran/27698] subroutine _foo draws "unclassifiable statement" instead of a useful error.

[aldot at gcc dot gnu dot org]

------- Comment #15 from aldot at gcc dot gnu dot org  2007-05-22 18:10 -------
(In reply to comment #14)
> Can this be considered fixed?
> 
The initial issue is IMO fixed, the other questions raised in this PR are not
dealt with, AFAIK. See comments #8 to #10. Due to these, i did not close the
report yet, please do so if you think it's sufficiently fixed.

thanks,


-- 

aldot at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|2006-05-21 11:53:24         |2007-05-22 18:10:22
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27698

[Bug fortran/27698] subroutine _foo draws "unclassifiable statement" instead of a useful error.

[jvdelisle at gcc dot gnu dot org]

------- Comment #16 from jvdelisle at gcc dot gnu dot org  2007-06-10 03:07 -------
I think this is sufficiently fixed.  We do not need to support bad coding
practices (meaning not standard compliant 


-- 

jvdelisle at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27698