[Bug tree-optimization/14187] [tree-ssa] restricted pointers should not alias on the tree level

[Bug tree-optimization/14187] [tree-ssa] restricted pointers should not alias on the tree level

[dnovillo at gcc dot gnu dot org]

-- 

dnovillo at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dnovillo at gcc dot gnu dot
                   |                            |org
         AssignedTo|dnovillo at gcc dot gnu dot |unassigned at gcc dot gnu
                   |org                         |dot org
             Status|ASSIGNED                    |NEW


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14187

[Bug tree-optimization/14187] [tree-ssa] restricted pointers should not alias on the tree level

[pinskia at gcc dot gnu dot org]

------- Comment #5 from pinskia at gcc dot gnu dot org  2007-06-11 00:48 -------
(In reply to comment #3)
> Interestingly the following code is optimized:
That is because we create a new may_alias variable for malloc to point to so we
know that it cannot alias anything.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14187

[Bug tree-optimization/14187] [tree-ssa] restricted pointers should not alias on the tree level

[rguenth at gcc dot gnu dot org]

------- Comment #6 from rguenth at gcc dot gnu dot org  2008-10-01 14:28 -------
*** Bug 14192 has been marked as a duplicate of this bug. ***


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hoogerbrugge at hotmail dot
                   |                            |com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14187

[Bug tree-optimization/14187] [tree-ssa] restricted pointers should not alias on the tree level

[rguenth at gcc dot gnu dot org]

------- Comment #7 from rguenth at gcc dot gnu dot org  2008-10-01 14:30 -------
Note that C restrict semantics make it necessary to properly track what
pointer is based on what other pointer.  For this we miss both annotations
and a (simple) propagator that propagates this information, maybe as part
of PTA analysis.

Note that the current implementation has both missed-optimization and latent
wrong-code issues.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14187

[Bug tree-optimization/14187] [tree-ssa] restricted pointers should not alias on the tree level

[rguenth at gcc dot gnu dot org]

------- Comment #8 from rguenth at gcc dot gnu dot org  2008-10-01 14:32 -------
*** Bug 16306 has been marked as a duplicate of this bug. ***


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14187

[Bug tree-optimization/14187] [tree-ssa] restricted pointers should not alias on the tree level

[rguenth at gcc dot gnu dot org]

------- Comment #9 from rguenth at gcc dot gnu dot org  2008-10-01 14:33 -------
*** Bug 16913 has been marked as a duplicate of this bug. ***


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin at mpa-garching dot
                   |                            |mpg dot de


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14187

[Bug tree-optimization/14187] [tree-ssa] restricted pointers should not alias on the tree level

[rguenth at gcc dot gnu dot org]

------- Comment #10 from rguenth at gcc dot gnu dot org  2008-10-01 14:34 -------
*** Bug 28030 has been marked as a duplicate of this bug. ***


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gcc at pdoerfler dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14187

[Bug tree-optimization/14187] [tree-ssa] restricted pointers should not alias on the tree level

[rguenth at gcc dot gnu dot org]

------- Comment #11 from rguenth at gcc dot gnu dot org  2008-10-01 14:35 -------
*** Bug 29239 has been marked as a duplicate of this bug. ***


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |acahalan at gmail dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14187

[Bug tree-optimization/14187] [tree-ssa] restricted pointers should not alias on the tree level

[rguenth at gcc dot gnu dot org]

------- Comment #12 from rguenth at gcc dot gnu dot org  2008-10-01 14:35 -------
*** Bug 32273 has been marked as a duplicate of this bug. ***


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomash dot brechko at gmail
                   |                            |dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14187

[Bug tree-optimization/14187] [tree-ssa] restricted pointers should not alias on the tree level

[rguenth at gcc dot gnu dot org]

------- Comment #13 from rguenth at gcc dot gnu dot org  2008-10-01 14:38 -------
*** Bug 33272 has been marked as a duplicate of this bug. ***


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mmitchel at gcc dot gnu dot
                   |                            |org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14187

[Bug tree-optimization/14187] [tree-ssa] restricted pointers should not alias on the tree level

[rguenth at gcc dot gnu dot org]

------- Comment #14 from rguenth at gcc dot gnu dot org  2008-10-01 14:40 -------
*** Bug 33705 has been marked as a duplicate of this bug. ***


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |astrange at ithinksw dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14187

[Bug middle-end/14187] [tree-ssa] C restricted pointers are not properly implemented

[rguenth at gcc dot gnu dot org]

------- Comment #15 from rguenth at gcc dot gnu dot org  2008-10-01 15:01 -------
This is not solely a tree issue.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|tree-optimization           |middle-end
           Keywords|TREE                        |
            Summary|[tree-ssa] restricted       |[tree-ssa] C restricted
                   |pointers should not alias on|pointers are not properly
                   |the tree level              |implemented


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14187

[Bug middle-end/14187] [tree-ssa] C restricted pointers are not properly implemented

[rguenth at gcc dot gnu dot org]

------- Comment #17 from rguenth at gcc dot gnu dot org  2009-06-29 12:24 -------
Fixed.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.5.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14187

[Bug middle-end/14187] [tree-ssa] C restricted pointers are not properly implemented

[rguenth at gcc dot gnu dot org]

------- Comment #16 from rguenth at gcc dot gnu dot org  2009-06-29 12:23 -------
Subject: Bug 14187

Author: rguenth
Date: Mon Jun 29 12:23:21 2009
New Revision: 149048

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=149048
Log:
2009-06-29  Richard Guenther  <rguenther@suse.de>

        PR middle-end/14187
        * tree-ssa-alias.h (struct pt_solution): Add vars_contains_restrict
        flag.
        (pt_solutions_same_restrict_base): Declare.
        * tree-ssa-structalias.c (struct variable_info): Add is_restrict_var
        flag.
        (new_var_info): Initialize is_global_var properly for SSA_NAMEs.
        (make_constraint_from, make_copy_constraint): Move earlier.
        (make_constraint_from_heapvar): New function.
        (make_constraint_from_restrict): Likewise.
        (handle_lhs_call): Use it.
        (find_func_aliases): Use it to track conversions to restrict
        qualified pointers.
        (struct fieldoff): Add only_restrict_pointers flag.
        (push_fields_onto_fieldstack): Initialize it.
        (create_variable_info_for): Track global restrict qualified pointers.
        (intra_create_variable_infos): Use make_constraint_from_heapvar.
        Track restrict qualified pointer arguments.
        (set_uids_in_ptset): Use varinfo is_global_var flag.
        (find_what_var_points_to): Set the vars_contains_restrict flag.
        Always create the points-to solution for sets including restrict tags.
        (pt_solutions_same_restrict_base): New function.
        * tree-ssa-alias.c (ptr_derefs_may_alias_p): For two restrict
        qualified pointers use pt_solutions_same_restrict_base as
        additional source for disambiguation.

        * gcc.dg/tree-ssa/restrict-1.c: New testcase.
        * gcc.dg/tree-ssa/restrict-2.c: Likewise.
        * gcc.dg/tree-ssa/restrict-3.c: Likewise.
        * gcc.c-torture/execute/20090623-1.c: Likewise.
        * gcc.dg/tree-ssa/ldist-13.c: Likewise.
        * gcc.dg/tree-ssa/ldist-14.c: Likewise.

Added:
    trunk/gcc/testsuite/gcc.c-torture/execute/20090623-1.c
    trunk/gcc/testsuite/gcc.dg/tree-ssa/ldist-13.c
    trunk/gcc/testsuite/gcc.dg/tree-ssa/ldist-14.c
    trunk/gcc/testsuite/gcc.dg/tree-ssa/restrict-1.c
    trunk/gcc/testsuite/gcc.dg/tree-ssa/restrict-2.c
    trunk/gcc/testsuite/gcc.dg/tree-ssa/restrict-3.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/tree-ssa-alias.c
    trunk/gcc/tree-ssa-alias.h
    trunk/gcc/tree-ssa-structalias.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14187

[Bug middle-end/14187] [tree-ssa] C restricted pointers are not properly implemented

[manu at gcc dot gnu dot org]

------- Comment #18 from manu at gcc dot gnu dot org  2010-01-11 19:23 -------
(In reply to comment #17)
> Fixed.
> 

Richard, since this is a new feature of GCC 4.5, shouldn't we mention it in the
GCC 4.5 changes.html?

Even something short would be welcome by users, such as:

"Better optimizations when using the <a
href="http://gcc.gnu.org/onlinedocs/gcc/Restricted-Pointers.html">restrict
keyword</a>".


-- 

manu at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |manu at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14187

[Bug middle-end/14187] [tree-ssa] C restricted pointers are not properly implemented

[rguenther at suse dot de]

------- Comment #19 from rguenther at suse dot de  2010-01-12 09:54 -------
Subject: Re:  [tree-ssa] C restricted pointers are not
 properly implemented

On Mon, 11 Jan 2010, manu at gcc dot gnu dot org wrote:

> ------- Comment #18 from manu at gcc dot gnu dot org  2010-01-11 19:23 -------
> (In reply to comment #17)
> > Fixed.
> > 
> 
> Richard, since this is a new feature of GCC 4.5, shouldn't we mention it in the
> GCC 4.5 changes.html?
> 
> Even something short would be welcome by users, such as:
> 
> "Better optimizations when using the <a
> href="http://gcc.gnu.org/onlinedocs/gcc/Restricted-Pointers.html">restrict
> keyword</a>".

It's not universally better tho due to limitations on the RTL export
side.  I'll think of sth.

Richard.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14187

[Bug middle-end/14187] [tree-ssa] C restricted pointers are not properly implemented

[steven at gcc dot gnu dot org]

------- Comment #20 from steven at gcc dot gnu dot org  2010-01-30 22:29 -------
Richi, is restrict working now, even with -fno-strict aliasing?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14187

[Bug middle-end/14187] [tree-ssa] C restricted pointers are not properly implemented

[rguenth at gcc dot gnu dot org]

------- Comment #21 from rguenth at gcc dot gnu dot org  2010-01-30 22:46 -------
(In reply to comment #20)
> Richi, is restrict working now, even with -fno-strict aliasing?

Yes, it is.  See PR42617 for patches still required on the RTL side, it's
a bit late to apply them for 4.5 now.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14187

[Bug tree-optimization/14187] [tree-ssa] restricted pointers should not alias on the tree level

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-07-02 00:19 -------
Patch here: <http://gcc.gnu.org/ml/gcc-patches/2004-07/msg00116.html>.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14187

[Bug tree-optimization/14187] [tree-ssa] restricted pointers should not alias on the tree level

[pinskia at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|3.5.0                       |---


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14187