[Bug pch/30335] CreateFileMapping fails in Vista due to lack of admin privileges

[Bug pch/30335] CreateFileMapping fails in Vista due to lack of admin privileges

[Christoph_vW at reactos dot org]

------- Comment #1 from Christoph_vW at reactos dot org  2006-12-30 23:46 -------
Created an attachment (id=12848)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=12848&action=view)
patch


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30335

[Bug pch/30335] New: CreateFileMapping fails in Vista due to lack of admin privileges

[Christoph_vW at reactos dot org]

CreateFileMapping fails in Vista due to lack of admin privileges


-- 
           Summary: CreateFileMapping fails in Vista due to lack of admin
                    privileges
           Product: gcc
           Version: 4.1.2
            Status: UNCONFIRMED
          Severity: major
          Priority: P3
         Component: pch
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: Christoph_vW at reactos dot org
  GCC host triplet: Windows Vista
GCC target triplet: mingw i386


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30335

[Bug pch/30335] CreateFileMapping fails in Vista due to lack of admin privileges

[Christoph_vW at reactos dot org]

------- Comment #2 from Christoph_vW at reactos dot org  2006-12-30 23:49 -------
the #include <tchar.h> should be removed from the patch - it doesn't belong
there


-- 

Christoph_vW at reactos dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |Christoph_vW at reactos dot
                   |                            |org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30335

[Bug other/30335] CreateFileMapping fails in Vista due to lack of admin privileges

[pinskia at gcc dot gnu dot org]

-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|major                       |normal
          Component|pch                         |other
 GCC target triplet|mingw i386                  |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30335

[Bug other/30335] CreateFileMapping fails in Vista due to lack of admin privileges

[pinskia at gcc dot gnu dot org]

------- Comment #3 from pinskia at gcc dot gnu dot org  2006-12-31 12:08 -------
See badvista.fsf.org


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30335

[Bug other/30335] CreateFileMapping fails in Vista due to lack of admin privileges

[Christoph_vW at reactos dot org]

------- Comment #4 from Christoph_vW at reactos dot org  2006-12-31 13:48 -------
What do you want to tell me with this link? Without this patch I can not use
gcc on Vista - which means I can not use other free software either because I
am not able to compile it.

Should I set up a website like badgcc.windowsdevs.org now? Because noone cares
about windows developers here?

No Vista support, broken linking when using virtual stdcall, ...


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30335

[Bug other/30335] CreateFileMapping fails in Vista due to lack of admin privileges

[rguenth at gcc dot gnu dot org]

------- Comment #5 from rguenth at gcc dot gnu dot org  2006-12-31 14:16 -------
Just ignore comment #3 and post the patch to gcc-patches@gcc.gnu.org please,
indicating which target you configured for and how you tested this patch
(a bootstrap and regtest is required).


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 GCC target triplet|                            |mingw32-*-*


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30335

[Bug other/30335] CreateFileMapping fails in Vista due to lack of admin privileges

[pinskia at gcc dot gnu dot org]

------- Comment #6 from pinskia at gcc dot gnu dot org  2006-12-31 16:55 -------
This is a host issue only.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   GCC host triplet|Windows Vista               |mingw32-*-*
 GCC target triplet|mingw32-*-*                 |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30335

[Bug other/30335] CreateFileMapping fails in Vista due to lack of admin privileges

[dannysmith at users dot sourceforge dot net]

------- Comment #7 from dannysmith at users dot sourceforge dot net  2007-01-01 01:53 -------
I am not in position to test this on Vista until next week. Can you please
indicate how you tested.

Danny


-- 

dannysmith at users dot sourceforge dot net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |dannysmith at users dot
                   |dot org                     |sourceforge dot net
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2007-01-01 01:53:22
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30335

[Bug other/30335] CreateFileMapping fails in Vista due to lack of admin privileges

[dralnix at gmail dot com]

------- Comment #8 from dralnix at gmail dot com  2007-01-02 20:25 -------
This patch was tested by having various people on Vista (32/64) run a full
build of ReactOS as a limited user. (also tchar.h is needed for compilation
because of the _T macro)


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30335

[Bug other/30335] CreateFileMapping fails in Vista due to lack of admin privileges

[dannysmith at users dot sourceforge dot net]

------- Comment #9 from dannysmith at users dot sourceforge dot net  2007-02-02 19:31 -------
Created an attachment (id=12997)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=12997&action=view)
Patch for Vista/CreateFileMapping  


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30335

[Bug other/30335] CreateFileMapping fails in Vista due to lack of admin privileges

[dannysmith at users dot sourceforge dot net]

------- Comment #10 from dannysmith at users dot sourceforge dot net  2007-02-02 19:32 -------
It seems strange to me that CreateFileMapping puts _unnamed_ object into Global
namespace.  Can you point me to documentation for this feature?

If CreateFileMapping functionality has changed, maybe we should just avoid it
and use VirtualAlloc throughout.  Can you test attached patch with Reactos
build?

Danny


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30335

[Bug other/30335] CreateFileMapping fails in Vista due to lack of admin privileges

[magnus at greatlord dot com]

------- Comment #11 from magnus at greatlord dot com  2007-06-03 17:48 -------
Hi

I look at both patcher the frist one the
"GCC-v4.1-r120189-CreateFileMapping-Vista.patch" is most correct one in my
eyes. 

if you reading how CreateFileMapping works, at
http://msdn2.microsoft.com/en-us/library/aa366537.aspx

I interper it the text as u always need to use "local\\name" to support more
that one user. 

we need rember that apps can get admin right  in NT 2003 and down when they
runs so they where allown to use NULL in the last param and gain admins right
in vista this is not posible any longer, letting program getting admin right 
when user have limit right. so now all program need follow the api to proper

Now we looking at the second patch the host-mingw32.c.diff 
I have not tested it in vista or windows yet. But what I can see
it using vritualalloc that mean it alloc memory and getting allot slower
against
FileMapping we talking about allot extra comping time, and it is not a good
idea for big project like reactos, and another thing the swap file will incress
and windows does not always cleanup stuff in the swapfile until a reboot, that
is few big disages with host-mingw32.c.diff it exists allot other disgante over
it also.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30335

[Bug other/30335] CreateFileMapping fails in Vista due to lack of admin privileges

[dannysmith at users dot sourceforge dot net]

------- Comment #12 from dannysmith at users dot sourceforge dot net  2007-06-03 21:37 -------
(In reply to comment #11)
> Hi
> 
> 
> Now we looking at the second patch the host-mingw32.c.diff 
> I have not tested it in vista or windows yet. But what I can see
> it using vritualalloc that mean it alloc memory and getting allot slower
> against
> FileMapping we talking about allot extra comping time, and it is not a good
> idea for big project like reactos, and another thing the swap file will incress
> and windows does not always cleanup stuff in the swapfile until a reboot, that
> is few big disages with host-mingw32.c.diff it exists allot other disgante over

Huh?  This is called only once during compilation.  What evidence do you have
that CreateFileMapping is faster than VirtualAlloc here?

We are not sharing memory across processes so we don't really need to create a
named memory-mapped object. I would prefer to keep the memory object anonymous
rather than hardcoding a name that could be accessed by other processes.

Danny




-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30335

[Bug other/30335] CreateFileMapping fails in Vista due to lack of admin privileges

[reimer dot daniel at freenet dot de]

------- Comment #13 from reimer dot daniel at freenet dot de  2007-06-12 22:07 -------
I tried the second Patch from danny and got the same results when I tried to
build ReactOS in MultiCore, as with this one I used before.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30335

[Bug other/30335] CreateFileMapping fails in Vista due to lack of admin privileges

[reimer dot daniel at freenet dot de]

------- Comment #14 from reimer dot daniel at freenet dot de  2007-06-12 22:13 -------
http://www.reactos.org/paste/index.php/1aa48fc/


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30335

[Bug other/30335] CreateFileMapping fails in Vista due to lack of admin privileges

[dannysmith at users dot sourceforge dot net]

------- Comment #15 from dannysmith at users dot sourceforge dot net  2007-07-18 11:44 -------
Fixed.  I have modified Christoph's original patch to avoid problems on NT4
Danny


-- 

dannysmith at users dot sourceforge dot net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.3.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30335