[Bug rtl-optimization/32339] New: [4.3 Regression] ICE in insert_save, at caller-save.c:726

[Bug rtl-optimization/32339] New: [4.3 Regression] ICE in insert_save, at caller-save.c:726

[tbm at cyrius dot com]

I'm getting the following ICE with current gcc 4.3.  This worked with
20070604 and is probably due to the dataflow merge.  Note that PR31025
contains a similar ICE, but the description is quite different to what
I'm seeing.  Note that my testcase shows an ICE on ia64 but works on
x86_64.

tbm@coconut0:~$ /usr/lib/gcc-snapshot/bin/gcc -c -O2 freeciv-citydlg.c
freeciv-citydlg.c: In function 'change_callback':
freeciv-citydlg.c:15: internal compiler error: in insert_save, at
caller-save.c:726
Please submit a full bug report,

Testcase:


struct city_dialog
{
  struct city *pcity;
  char change_list_names[200][200];
  int change_list_ids[200];
};
change_callback (void)
{
  struct city_dialog *pdialog;
  int n;
  int i;
  get_city_dialog_production_full (pdialog->change_list_names[n],
    pdialog->pcity);
  pdialog->change_list_ids[n++] = i;
}


-- 
           Summary: [4.3 Regression] ICE in insert_save, at caller-
                    save.c:726
           Product: gcc
           Version: 4.3.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: rtl-optimization
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: tbm at cyrius dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32339

[Bug rtl-optimization/32339] [4.3 Regression] ICE in insert_save, at caller-save.c:726

[spark at gcc dot gnu dot org]

------- Comment #1 from spark at gcc dot gnu dot org  2007-06-14 14:10 -------
What's the target tripe ? I presume thi sis ia64-unknown-linux ?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32339

[Bug rtl-optimization/32339] [4.3 Regression] ICE in insert_save, at caller-save.c:726

[tbm at cyrius dot com]

------- Comment #2 from tbm at cyrius dot com  2007-06-14 14:16 -------
(In reply to comment #1)
> What's the target tripe ? I presume thi sis ia64-unknown-linux ?

Yes.


-- 

tbm at cyrius dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   GCC host triplet|zadeck@naturalbridge.com    |
 GCC target triplet|                            |ia64-linux-gnu


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32339

[Bug rtl-optimization/32339] [4.3 Regression] ICE in insert_save, at caller-save.c:726

[spark at gcc dot gnu dot org]

------- Comment #3 from spark at gcc dot gnu dot org  2007-06-14 17:52 -------
This is a bug in df-scan.c, marking regs unnecessarily as read-write,
which lead to unnecessarily stretched live ranges for regs involved in pre/post
modify insn. I'm working on it.


-- 

spark at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |spark at gcc dot gnu dot org
                   |dot org                     |
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2007-06-14 17:52:16
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32339

[Bug rtl-optimization/32339] [4.3 Regression] ICE in insert_save, at caller-save.c:726

[spark at gcc dot gnu dot org]

------- Comment #4 from spark at gcc dot gnu dot org  2007-06-14 18:31 -------
diff -r 8522653fd69d gcc/df-scan.c
--- a/gcc/df-scan.c     Thu Jun 14 00:17:05 2007 +0000
+++ b/gcc/df-scan.c     Thu Jun 14 11:29:46 2007 -0700
@@ -2982,9 +2982,9 @@ df_uses_record (struct df_collection_rec
     case PRE_MODIFY:
     case POST_MODIFY:
       /* Catch the def of the register being modified.  */
-      flags |= DF_REF_READ_WRITE | DF_REF_PRE_POST_MODIFY;
       df_ref_record (collection_rec, XEXP (x, 0), &XEXP (x, 0), bb, insn,
-                    DF_REF_REG_DEF, flags);
+                    DF_REF_REG_DEF,
+                     flags | DF_REF_READ_WRITE | DF_REF_PRE_POST_MODIFY);

       /* ... Fall through to handle uses ...  */

This patch fixes the problem.
I'm starting the testing.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32339

[Bug rtl-optimization/32339] [4.3 Regression] ICE in insert_save, at caller-save.c:726

[spark at gcc dot gnu dot org]

------- Comment #5 from spark at gcc dot gnu dot org  2007-06-15 06:33 -------
Subject: Bug 32339

Author: spark
Date: Fri Jun 15 06:33:24 2007
New Revision: 125736

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=125736
Log:
2007-06-14  Seongbae Park  <seongbae.park@gmail.com>

        PR rtl-optimization/32339
        * df-scan.c (df_uses_record): Don't modify flags but just add to it for
        df_ref_record.


Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/df-scan.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32339

[Bug rtl-optimization/32339] [4.3 Regression] ICE in insert_save, at caller-save.c:726

[pinskia at gcc dot gnu dot org]

------- Comment #6 from pinskia at gcc dot gnu dot org  2007-06-15 07:31 -------
The testcase should go into the torture testsuite.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pinskia at gcc dot gnu dot
                   |                            |org
   Target Milestone|---                         |4.3.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32339

[Bug rtl-optimization/32339] [4.3 Regression] ICE in insert_save, at caller-save.c:726

[spark at gcc dot gnu dot org]

------- Comment #7 from spark at gcc dot gnu dot org  2007-06-18 20:02 -------
Subject: Bug 32339

Author: spark
Date: Mon Jun 18 20:02:33 2007
New Revision: 125825

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=125825
Log:
gcc/ChangeLog:

2007-06-18  Seongbae Park  <seongbae.park@gmail.com>

        PR rtl-optimization/32339
        * df-scan.c (df_uses_record): Don't modify flags but just add to
        it for df_ref_record.

gcc/testsuite/ChangeLog:

2007-06-18  Martin Michlmayr <tbm@cyrius.com>

        PR rtl-optimization/32339
        * gcc.c-torture/compile/pr32339.c: New test.


Added:
    trunk/gcc/testsuite/gcc.c-torture/compile/pr32339.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/gcse.c
    trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32339

[Bug rtl-optimization/32339] [4.3 Regression] ICE in insert_save, at caller-save.c:726

[spark at gcc dot gnu dot org]

------- Comment #8 from spark at gcc dot gnu dot org  2007-06-19 04:30 -------
(In reply to comment #7)
> Subject: Bug 32339
> 
> Author: spark
> Date: Mon Jun 18 20:02:33 2007
> New Revision: 125825
> 
> URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=125825
> Log:
> gcc/ChangeLog:
> 
> 2007-06-18  Seongbae Park  <seongbae.park@gmail.com>
> 
>         PR rtl-optimization/32339
>         * df-scan.c (df_uses_record): Don't modify flags but just add to
>         it for df_ref_record.
> 
> gcc/testsuite/ChangeLog:
> 
> 2007-06-18  Martin Michlmayr <tbm@cyrius.com>
> 
>         PR rtl-optimization/32339
>         * gcc.c-torture/compile/pr32339.c: New test.
> 
> 
> Added:
>     trunk/gcc/testsuite/gcc.c-torture/compile/pr32339.c
> Modified:
>     trunk/gcc/ChangeLog
>     trunk/gcc/gcse.c
>     trunk/gcc/testsuite/ChangeLog

Please ignore this commit - this patch is for another bug fix,
although the testcase is the correct one.
I'll commit the testcase in a separate patch.
Sorry for the confusion.
Anyway, since this bug has been fixed by my earlier commit,
I'm marking it as fixed.


-- 

spark at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32339