public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "dnovillo at google dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/32327] [4.2 Regression] Incorrect stack sharing causing removal of live code
Date: Tue, 19 Jun 2007 17:40:00 -0000	[thread overview]
Message-ID: <20070619173956.18504.qmail@sourceware.org> (raw)
In-Reply-To: <bug-32327-91@http.gcc.gnu.org/bugzilla/>



------- Comment #27 from dnovillo at google dot com  2007-06-19 17:39 -------
Subject: Re:  [4.2 Regression] Incorrect stack sharing
 causing removal of live code

On 6/19/07 1:26 PM, rth at gcc dot gnu dot org wrote:
> ------- Comment #26 from rth at gcc dot gnu dot org  2007-06-19 17:26 -------
> (In reply to comment #10)
>> Talked to Dan Berlin and Diego Novillo here at Google. They told me
>> that all locals are promoted to function scope.
> 
> That *only* applies to register variables, not stack variables.

Yes, but our GIMPLE optimizers don't know that and we do not have a way
of enforcing that in GIMPLE.  There just are no scope boundaries in the
SSA web.  So, the end result is that in SSA we only have function scope.


> We very very much want to preserve scope of stack variables, because
> we very very much want to share stack space between stack variables
> of different scopes.  Failure to do so causes bad interactions with
> inlining, and causes stack space consumtion to grow to unacceptable
> levels.  I.e. you can't build kernels anymore.

Agreed.  We have to find a way of either tying the hands of code motion
transformations by making them use the SSA web *and* the TREE_BLOCKs, or
make stack slot sharing aware of live ranges.

Right now we have the unfortunate situation that an optimizer is making
a valid transformation which breaks the scope assumption that stack
sharing uses.

I am not sure if it would be practical to force code motion
optimizations to use anything other than the SSA web to do their
analysis.  Perhaps we could force scopes by building barriers on the SSA
web itself (say, by putting PHI nodes at scope boundaries, or something).

Alternatively, we could incorporate live-range analysis to stack slot
sharing.  That way, if code motion creates undue stack slot pressure, we
would merely emit suboptimal code, instead of wrong code.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32327


  parent reply	other threads:[~2007-06-19 17:40 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-13 19:57 [Bug c/32327] New: " dnovillo at gcc dot gnu dot org
2007-06-13 21:20 ` [Bug middle-end/32327] " pinskia at gcc dot gnu dot org
2007-06-13 21:25 ` dougkwan at google dot com
2007-06-13 21:32 ` pinskia at gcc dot gnu dot org
2007-06-13 21:37 ` pinskia at gcc dot gnu dot org
2007-06-13 21:42 ` [Bug middle-end/32327] [4.2 Regression] " pinskia at gcc dot gnu dot org
2007-06-13 21:50 ` dougkwan at google dot com
2007-06-13 21:53 ` pinskia at gcc dot gnu dot org
2007-06-14  0:14 ` dougkwan at google dot com
2007-06-14  0:28 ` pinskia at gcc dot gnu dot org
2007-06-14  0:35 ` dougkwan at google dot com
2007-06-14  0:42 ` pinskia at gcc dot gnu dot org
2007-06-14  0:42 ` pinskia at gcc dot gnu dot org
2007-06-14  0:46 ` dougkwan at google dot com
2007-06-14  0:52 ` pinskia at gmail dot com
2007-06-14  0:59 ` dougkwan at google dot com
2007-06-14  1:02 ` pinskia at gcc dot gnu dot org
2007-06-14  1:09 ` dougkwan at google dot com
2007-06-14  1:14 ` pinskia at gmail dot com
2007-06-14 17:58 ` ian at airs dot com
2007-06-14 18:05 ` dougkwan at google dot com
2007-06-14 18:13 ` rguenther at suse dot de
2007-06-15 13:15 ` mec at google dot com
2007-06-15 13:27 ` dnovillo at gcc dot gnu dot org
2007-06-15 22:10 ` dnovillo at gcc dot gnu dot org
2007-06-18 12:31 ` dnovillo at gcc dot gnu dot org
2007-06-19 17:26 ` rth at gcc dot gnu dot org
2007-06-19 17:40 ` dnovillo at google dot com [this message]
2007-06-19 18:58 ` amacleod at redhat dot com
2007-07-04  3:29 ` mmitchel at gcc dot gnu dot org
2007-07-04 11:23 ` dnovillo at google dot com
2007-07-20  3:46 ` mmitchel at gcc dot gnu dot org
2007-10-09 19:22 ` mmitchel at gcc dot gnu dot org
2008-02-01 16:58 ` jsm28 at gcc dot gnu dot org
2008-05-19 20:27 ` jsm28 at gcc dot gnu dot org
2009-03-30 22:06 ` jsm28 at gcc dot gnu dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070619173956.18504.qmail@sourceware.org \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).