[Bug libfortran/32456] New: IO error message should show Unit/Filename

[Bug libfortran/32456] New: IO error message should show Unit/Filename

[burnus at gcc dot gnu dot org]

! echo "z" > foo.dat
program test
  implicit none
  integer :: i
  open(99,file="foo.dat")
  read(99,*) i
  print *, i
end program

gfortran:
At line 5 of file x.f90
Fortran runtime error: Bad integer for item 1 in list input

Expected: gfortran prints out the filename and/or unit as other compilers do;
especially useful for users which don't have the source code.

g95:
At line 5 of file x.f90 (Unit 99 "foo.dat")
Fortran runtime error: Bad integer for item 1 in list input

NAG f95:
Invalid input for integer editing
Program terminated by I/O error on unit 99
(File="foo.dat",Formatted,Sequential)

ifort:
forrtl: severe (59): list-directed I/O syntax error, unit 99, file
/dev/shm/foo.dat

sunf95:
 Error 1083:  unexpected character in integer value
 Location:  the READ statement at line 5 of "x.f90"
 Unit:  99
 File:  foo.dat
 Input:  z

For stdin * they show (g95,NAG f95, ifort, sunf95):
At line 4 of file x.f90 (Unit 5)
Program terminated by I/O error on unit 5 (Input_Unit,Formatted,Sequential)
forrtl: severe (59): list-directed I/O syntax error, unit -4, file /dev/pts/0
 Unit:  *
 File:  standard input


-- 
           Summary: IO error message should show Unit/Filename
           Product: gcc
           Version: 4.3.0
            Status: UNCONFIRMED
          Keywords: diagnostic
          Severity: normal
          Priority: P3
         Component: libfortran
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: burnus at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32456

[Bug libfortran/32456] IO error message should show Unit/Filename

[jvdelisle at gcc dot gnu dot org]

------- Comment #1 from jvdelisle at gcc dot gnu dot org  2007-06-23 03:58 -------
Fairly straight forward I think.


-- 

jvdelisle at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |jvdelisle at gcc dot gnu dot
                   |dot org                     |org
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2007-06-23 03:58:52
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32456

[Bug libfortran/32456] IO error message should show Unit/Filename

[patchapp at dberlin dot org]

------- Comment #2 from patchapp at dberlin dot org  2007-06-24 20:35 -------
Subject: Bug number PR32456

A patch for this bug has been added to the patch tracker.
The mailing list url for the patch is
http://gcc.gnu.org/ml/gcc-patches/2007-06/msg01821.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32456

[Bug libfortran/32456] IO error message should show Unit/Filename

[jvdelisle at gcc dot gnu dot org]

------- Comment #3 from jvdelisle at gcc dot gnu dot org  2007-06-24 22:56 -------
Subject: Bug 32456

Author: jvdelisle
Date: Sun Jun 24 22:56:21 2007
New Revision: 125989

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=125989
Log:
2007-06-24  Jerry DeLisle  <jvdelisle@gcc.gnu.org>

        PR libgfortran/32456
        * runtime/error.c (show_locus): Update to emit the unit number
        and file name involved with the error.  Use new function
        filename_from_unit.
        * libgfortran.h (filename_from_unit): Declare new function.
        * io/unit.c (init_units): Set the unit file name for stdin, stdout,
        and stderr for use later in error reporting.
        (filename_from_unit): Add this new function.

Modified:
    trunk/libgfortran/ChangeLog
    trunk/libgfortran/io/unit.c
    trunk/libgfortran/libgfortran.h
    trunk/libgfortran/runtime/error.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32456

[Bug libfortran/32456] IO error message should show Unit/Filename

[jvdelisle at gcc dot gnu dot org]

------- Comment #4 from jvdelisle at gcc dot gnu dot org  2007-06-24 23:03 -------
Subject: Bug 32456

Author: jvdelisle
Date: Sun Jun 24 23:03:29 2007
New Revision: 125990

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=125990
Log:
2007-06-24  Jerry DeLisle  <jvdelisle@gcc.gnu.org>

        PR fortran/32456
        * gfortran.dg/error_format.f90: New test.

Added:
    trunk/gcc/testsuite/gfortran.dg/error_format.f90
Modified:
    trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32456

[Bug libfortran/32456] IO error message should show Unit/Filename

[jvdelisle at gcc dot gnu dot org]

------- Comment #5 from jvdelisle at gcc dot gnu dot org  2007-06-24 23:06 -------
Fixed on trunk.


-- 

jvdelisle at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.3.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32456

[Bug libfortran/32456] IO error message should show Unit/Filename

[jvdelisle at gcc dot gnu dot org]

------- Comment #6 from jvdelisle at gcc dot gnu dot org  2007-06-25 02:48 -------
Subject: Bug 32456

Author: jvdelisle
Date: Mon Jun 25 02:48:14 2007
New Revision: 125996

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=125996
Log:
2007-06-24  Jerry DeLisle  <jvdelisle@gcc.gnu.org>

        PR fortran/32456
        * gfortran.dg/secnds-1.f: Revise test to reduce random errors.

Modified:
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/gfortran.dg/secnds-1.f


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32456

[Bug libfortran/32456] IO error message should show Unit/Filename

[patchapp at dberlin dot org]

------- Comment #7 from patchapp at dberlin dot org  2007-06-29 06:15 -------
Subject: Bug number PR32456

A patch for this bug has been added to the patch tracker.
The mailing list url for the patch is
http://gcc.gnu.org/ml/gcc-patches/2007-06/msg02095.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32456

[Bug libfortran/32456] IO error message should show Unit/Filename

[andreast at gcc dot gnu dot org]

------- Comment #8 from andreast at gcc dot gnu dot org  2007-06-29 19:16 -------
With the patch referenced in #7 results on i686-darwin

                === gfortran Summary ===

# of expected passes            18372
# of unexpected failures        16
# of expected failures          8
# of unsupported tests          38


Thanks Jerry!


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32456

[Bug libfortran/32456] IO error message should show Unit/Filename

[jvdelisle at gcc dot gnu dot org]

------- Comment #9 from jvdelisle at gcc dot gnu dot org  2007-06-29 19:39 -------
Subject: Bug 32456

Author: jvdelisle
Date: Fri Jun 29 19:39:21 2007
New Revision: 126119

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=126119
Log:
2007-06-29  Jerry DeLisle  <jvdelisle@gcc.gnu.org>

        PR libgfortran/32456
        * io/unit.c (filename_from_unit): Don't use find_unit, instead search
        for unit directly.

Modified:
    trunk/libgfortran/ChangeLog
    trunk/libgfortran/io/unit.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32456

[Bug libfortran/32456] IO error message should show Unit/Filename

[kargl at gcc dot gnu dot org]

------- Comment #10 from kargl at gcc dot gnu dot org  2007-07-02 23:29 -------
Subject: Bug 32456

Author: kargl
Date: Mon Jul  2 23:29:27 2007
New Revision: 126238

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=126238
Log:
2007-07-02  Steven G. Kargl  <kargl@gcc.gnu.org>

        Restore collateral damage from ISO C Binding merge.

        2007-06-29  Jerry DeLisle  <jvdelisle@gcc.gnu.org>

        PR libgfortran/32456
        * io/unit.c (filename_from_unit): Don't use find_unit, instead search
        for unit directly.


Modified:
    trunk/libgfortran/ChangeLog
    trunk/libgfortran/io/unit.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32456