[Bug c++/32253] [4.3 regression] ICE with variadic templates and function pointers

[Bug c++/32253] [4.3 regression] ICE with variadic templates and function pointers

[reichelt at gcc dot gnu dot org]

-- 

reichelt at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.3.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32253

[Bug c++/32253] New: [4.3 regression] ICE with variadic templates and function pointers

[reichelt at gcc dot gnu dot org]

The following invalid code snippet triggers an ICE on mainline:

==================================================
template<void (*... fp)()> struct A
{
  A() { fp(); }
};

void foo();

A<foo> a;
==================================================

bug.cc: In constructor 'A<fp>::A()':
bug.cc:3: error: parameter packs not expanded with `...':
bug.cc:3: note:         'fp'
bug.cc: In constructor 'A<fp>::A() [with void (* fp)() = foo]':
bug.cc:8:   instantiated from here
bug.cc:3: internal compiler error: in gimplify_expr, at gimplify.c:5961
Please submit a full bug report, [etc.]


-- 
           Summary: [4.3 regression] ICE with variadic templates and
                    function pointers
           Product: gcc
           Version: 4.3.0
            Status: UNCONFIRMED
          Keywords: ice-on-invalid-code, error-recovery, monitored
          Severity: normal
          Priority: P3
         Component: c++
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: reichelt at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32253

[Bug c++/32253] [4.3 regression] ICE with variadic templates and function pointers

[mmitchel at gcc dot gnu dot org]

-- 

mmitchel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P4


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32253

[Bug c++/32253] [4.3 regression] ICE with variadic templates and function pointers

[dgregor at gcc dot gnu dot org]

------- Comment #1 from dgregor at gcc dot gnu dot org  2007-11-06 14:38 -------
Subject: Bug 32253

Author: dgregor
Date: Tue Nov  6 14:37:56 2007
New Revision: 129928

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=129928
Log:
2007-11-06  Douglas Gregor  <doug.gregor@gmail.com>

        PR c++/31439
        PR c++/32114
        PR c++/32115
        PR c++/32125
        PR c++/32126
        PR c++/32127
        PR c++/32128
        PR c++/32253
        PR c++/32566
        * typeck.c (check_return_expr): Pass address of retval to
        check_for_bare_parameter_packs.
        * class.c (build_base_field): Tolerate bases that have no layout
        due to errors.
        (end_of_base): Ditto.
        * tree.c (canonical_type_variant): Be careful with
        ERROR_MARK_NODE.
        * cp-tree.h (check_for_bare_parameter_packs): Now accepts a
        tree*.
        * pt.c (find_parameter_pack_data): Add set_packs_to_error field,
        which states whether parameter packs should be replaced with
        ERROR_MARK_NODE.
        (find_parameter_packs_r): Pass addresses to cp_walk_tree wherever
        possible. If set_packs_to_error is set true, replace the parameter
        pack with ERROR_MARK_NODE. Manage our own pointer sets.
        (uses_parameter_packs): Don't set parameter packs to
        ERROR_MARK_NODE.
        (check_for_bare_parameter_packs): Now takes a pointer to a tree,
        which may be modified (if it is a parameter pack). Instructs
        find_parameter_packs_r to replace parameter packs with
        ERROR_MARK_NODE (so that they won't cause errors later on).
        (process_template_parm): Pass pointer to
        check_for_bare_parameter_packs.
        (process_partial_specialization): Replace pack expansions before
        the end of the template argument list with ERROR_MARK_NODE.
        (push_template_decl_real): Pass pointer to
        check_for_bare_parameter_packs. Replace parameter packs not at the
        end of the template parameter list with ERROR_MARK_NODE.
        (convert_template_argument): Be more careful about using DECL_NAME
        on only declarations.
        (unify): Can't unify against ERROR_MARK_NODE.
        * semantics.c (finish_cond): Pass pointer to
        check_for_bare_parameter_packs.
        (finish_expr_stmt): Ditto.
        (finish_for_expr): Ditto.
        (finish_switch_cond): Pass pointer to
        check_for_bare_parameter_packs, and call it before we put the
        condition into the statement.
        (finish_mem_initializers): Pass pointer to
        check_for_bare_parameter_packs.
        (finish_member_declaration): Ditto.
        * parser.c (cp_parser_base_clause): Ditto.

2007-11-06  Douglas Gregor  <doug.gregor@gmail.com>

        * testsuite/g++.dg/parser/crash36.C: Tweak expected errors.
        * testsuite/g++.dg/cpp0x/pr31439.C: New.
        * testsuite/g++.dg/cpp0x/pr32114.C: New.
        * testsuite/g++.dg/cpp0x/pr32115.C: New.
        * testsuite/g++.dg/cpp0x/pr32125.C: New.
        * testsuite/g++.dg/cpp0x/pr32126.C: New.
        * testsuite/g++.dg/cpp0x/pr32127.C: New.
        * testsuite/g++.dg/cpp0x/pr32128.C: New.
        * testsuite/g++.dg/cpp0x/pr32253.C: New.
        * testsuite/g++.dg/cpp0x/pr32566.C: New.
        * testsuite/g++.dg/cpp0x/pr31445.C: Tweak expected errors.
        * testsuite/g++.dg/cpp0x/pr31438.C: Ditto.
        * testsuite/g++.dg/cpp0x/variadic81.C: Ditto.
        * testsuite/g++.dg/cpp0x/pr31432.C: Ditto.
        * testsuite/g++.dg/cpp0x/pr31442.C: Ditto.

Added:
    trunk/gcc/testsuite/g++.dg/cpp0x/pr31439.C
    trunk/gcc/testsuite/g++.dg/cpp0x/pr32114.C
    trunk/gcc/testsuite/g++.dg/cpp0x/pr32115.C
    trunk/gcc/testsuite/g++.dg/cpp0x/pr32125.C
    trunk/gcc/testsuite/g++.dg/cpp0x/pr32126.C
    trunk/gcc/testsuite/g++.dg/cpp0x/pr32127.C
    trunk/gcc/testsuite/g++.dg/cpp0x/pr32128.C
    trunk/gcc/testsuite/g++.dg/cpp0x/pr32253.C
    trunk/gcc/testsuite/g++.dg/cpp0x/pr32566.C
Modified:
    trunk/gcc/cp/ChangeLog
    trunk/gcc/cp/class.c
    trunk/gcc/cp/cp-tree.h
    trunk/gcc/cp/parser.c
    trunk/gcc/cp/pt.c
    trunk/gcc/cp/semantics.c
    trunk/gcc/cp/tree.c
    trunk/gcc/cp/typeck.c
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/g++.dg/cpp0x/pr31432.C
    trunk/gcc/testsuite/g++.dg/cpp0x/pr31438.C
    trunk/gcc/testsuite/g++.dg/cpp0x/pr31442.C
    trunk/gcc/testsuite/g++.dg/cpp0x/pr31445.C
    trunk/gcc/testsuite/g++.dg/cpp0x/variadic81.C
    trunk/gcc/testsuite/g++.dg/parse/crash36.C


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32253

[Bug c++/32253] [4.3 regression] ICE with variadic templates and function pointers

[dgregor at gcc dot gnu dot org]

------- Comment #2 from dgregor at gcc dot gnu dot org  2007-11-06 14:43 -------
Fixed


-- 

dgregor at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32253

[Bug c++/32253] [4.3 regression] ICE with variadic templates and function pointers

[fang at csl dot cornell dot edu]

------- Comment #3 from fang at csl dot cornell dot edu  2007-11-06 16:43 -------
"Sieben auf einen Streich!"  (9 really, but who's counting?)  :D


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32253