public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "dberlin at dberlin dot org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/32705] [4.3 regression] ICE in set_ssa_val_to, at tree-ssa-sccvn.c:1022
Date: Sat, 14 Jul 2007 02:05:00 -0000	[thread overview]
Message-ID: <20070714020456.27741.qmail@sourceware.org> (raw)
In-Reply-To: <bug-32705-10053@http.gcc.gnu.org/bugzilla/>



------- Comment #15 from dberlin at gcc dot gnu dot org  2007-07-14 02:04 -------
Subject: Re:  [4.3 regression] ICE in set_ssa_val_to, at tree-ssa-sccvn.c:1022

On 13 Jul 2007 20:43:37 -0000, ebotcazou at gcc dot gnu dot org
<gcc-bugzilla@gcc.gnu.org> wrote:
>
>
> ------- Comment #14 from ebotcazou at gcc dot gnu dot org  2007-07-13 20:43 -------
> > Instead, where we init everything to VN_TOP, init everything with
> > SSA_NAME_OCCURS_IN_ABNORMAL_PHI to itself instead of VN_TOP.
>
> @@ -1912,13 +1912,16 @@ init_scc_vn (void)
>    VN_TOP = create_tmp_var_raw (void_type_node, "vn_top");
>
>    /* Create the VN_INFO structures, and initialize value numbers to
> -     TOP.  */
> +     TOP, except for SSA names appearing in abnormal PHI nodes.  */
>    for (i = 0; i < num_ssa_names; i++)
>      {
>        tree name = ssa_name (i);
>        if (name)
>         {
> -         VN_INFO_GET (name)->valnum = VN_TOP;
> +         if (SSA_NAME_OCCURS_IN_ABNORMAL_PHI (name))
> +           VN_INFO_GET (name)->valnum = name;
> +         else
> +           VN_INFO_GET (name)->valnum = VN_TOP;
>           VN_INFO (name)->expr = name;
>         }
>      }
>
> is not sufficient to eliminate all the failures.  I get the same assertion
> failure for non-degenerate PHI nodes without SSA_NAME_OCCURS_IN_ABNORMAL_PHI
> anywhere, all operands having SSA_VAL set to VN_TOP.  Top-level function too.

Change the assert to allow to == VN_TOP.
It can happen when we have aliasing issues, and we believe some piece
of memory/a value to be truly undefined.
This is what is happening in your case, and since your case is legal,
we must allow it.
It's likely a bug in the rest of the compiler, however, since we
should almost *never* end up with bare NMT's like that.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32705


  parent reply	other threads:[~2007-07-14  2:05 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-09 16:51 [Bug tree-optimization/32705] New: [4.3 Regression] " rguenth at gcc dot gnu dot org
2007-07-09 17:36 ` [Bug tree-optimization/32705] " ebotcazou at gcc dot gnu dot org
2007-07-09 18:11 ` dberlin at dberlin dot org
2007-07-09 18:12 ` dberlin at dberlin dot org
2007-07-10  8:11 ` ebotcazou at gcc dot gnu dot org
2007-07-11 20:10 ` [Bug tree-optimization/32705] [4.3 regression] " ebotcazou at gcc dot gnu dot org
2007-07-11 22:20   ` Daniel Berlin
2007-07-11 22:21 ` dberlin at dberlin dot org
2007-07-13 14:37 ` ebotcazou at gcc dot gnu dot org
2007-07-13 15:12 ` ebotcazou at gcc dot gnu dot org
2007-07-13 15:49 ` ebotcazou at gcc dot gnu dot org
2007-07-13 16:47 ` dberlin at dberlin dot org
2007-07-13 17:16 ` ebotcazou at gcc dot gnu dot org
2007-07-13 17:19 ` dberlin at dberlin dot org
2007-07-13 19:09 ` ebotcazou at gcc dot gnu dot org
2007-07-13 20:43 ` ebotcazou at gcc dot gnu dot org
2007-07-14  2:05 ` dberlin at dberlin dot org [this message]
2007-07-14  6:12 ` ebotcazou at gcc dot gnu dot org
2007-07-14  8:44 ` ebotcazou at gcc dot gnu dot org
2007-07-14  8:46 ` ebotcazou at gcc dot gnu dot org
2007-07-21  8:37 ` pinskia at gcc dot gnu dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070714020456.27741.qmail@sourceware.org \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).