public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug fortran/31320] New: Illegal read with gfortran.dg/alloc_comp_assign_2.f90 and *_3.f90
@ 2007-03-22 23:17 burnus at gcc dot gnu dot org
2007-03-24 8:16 ` [Bug fortran/31320] " pault at gcc dot gnu dot org
` (9 more replies)
0 siblings, 10 replies; 11+ messages in thread
From: burnus at gcc dot gnu dot org @ 2007-03-22 23:17 UTC (permalink / raw)
To: gcc-bugs
gfortran -g gfortran.dg/alloc_comp_assign_2.f90
valgrind ./a.out
==30049== Invalid read of size 1
==30049== at 0x4C24854: memcpy (in
/usr/lib64/valgrind/amd64-linux/vgpreload_memcheck.so)
==30049== by 0x401682: MAIN__ (in
/projects/tob/gcc/gcc/testsuite/gfortran.dg/a.out)
==30049== by 0x405FAB: main (fmain.c:22)
==30049== Address 0x404D64B is 3 bytes after a block of size 16 alloc'd
==30049== at 0x4C22C56: malloc (in
/usr/lib64/valgrind/amd64-linux/vgpreload_memcheck.so)
==30049== by 0x4E3DD78: _gfortrani_get_mem (memory.c:53)
==30049== by 0x400A5C: MAIN__ (in
/projects/tob/gcc/gcc/testsuite/gfortran.dg/a.out)
==30049== by 0x405FAB: main (fmain.c:22)
I checked the example itself with g95 and NAG f95 and both fail at the second,
third and fourth "call abort()" whereas ifort has a segv.
Is this example (PR 20541) really valid?
A check with NAG f95, g95 and ifort with valgrind shows no problem for NAG f95,
and invalid reads for g95 and ifort.
For alloc_comp_assign_3.f90: Compiles with g95, ifort and NAG f95 and gives no
"call abort()", however, gfortran has:
==30454== Invalid read of size 1
==30454== at 0x4C24854: memcpy (in
/usr/lib64/valgrind/amd64-linux/vgpreload_memcheck.so)
==30454== by 0x401223: MAIN__ (alloc_comp_assign_3.f90:22)
==30454== by 0x40444B: main (fmain.c:22)
==30454== Address 0x404D64B is 3 bytes after a block of size 16 alloc'd
==30454== at 0x4C22C56: malloc (in
/usr/lib64/valgrind/amd64-linux/vgpreload_memcheck.so)
==30454== by 0x4E3DD78: _gfortrani_get_mem (memory.c:53)
==30454== by 0x400A5C: MAIN__ (alloc_comp_assign_3.f90:19)
==30454== by 0x40444B: main (fmain.c:22)
For alloc_comp_initializer_1.f90 the same.
--
Summary: Illegal read with gfortran.dg/alloc_comp_assign_2.f90
and *_3.f90
Product: gcc
Version: 4.3.0
Status: UNCONFIRMED
Keywords: wrong-code
Severity: normal
Priority: P3
Component: fortran
AssignedTo: unassigned at gcc dot gnu dot org
ReportedBy: burnus at gcc dot gnu dot org
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31320
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug fortran/31320] Illegal read with gfortran.dg/alloc_comp_assign_2.f90 and *_3.f90
2007-03-22 23:17 [Bug fortran/31320] New: Illegal read with gfortran.dg/alloc_comp_assign_2.f90 and *_3.f90 burnus at gcc dot gnu dot org
@ 2007-03-24 8:16 ` pault at gcc dot gnu dot org
2007-04-12 9:52 ` burnus at gcc dot gnu dot org
` (8 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: pault at gcc dot gnu dot org @ 2007-03-24 8:16 UTC (permalink / raw)
To: gcc-bugs
------- Comment #1 from pault at gcc dot gnu dot org 2007-03-24 08:16 -------
(In reply to comment #0)
> Is this example (PR 20541) really valid?
Lahey does not complain.
Paul
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31320
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug fortran/31320] Illegal read with gfortran.dg/alloc_comp_assign_2.f90 and *_3.f90
2007-03-22 23:17 [Bug fortran/31320] New: Illegal read with gfortran.dg/alloc_comp_assign_2.f90 and *_3.f90 burnus at gcc dot gnu dot org
2007-03-24 8:16 ` [Bug fortran/31320] " pault at gcc dot gnu dot org
@ 2007-04-12 9:52 ` burnus at gcc dot gnu dot org
2007-07-05 14:31 ` dfranke at gcc dot gnu dot org
` (7 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: burnus at gcc dot gnu dot org @ 2007-04-12 9:52 UTC (permalink / raw)
To: gcc-bugs
------- Comment #2 from burnus at gcc dot gnu dot org 2007-04-12 10:52 -------
> > Is this example (PR 20541) really valid?
> Lahey does not complain.
At compile time? Or at run time?
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31320
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug fortran/31320] Illegal read with gfortran.dg/alloc_comp_assign_2.f90 and *_3.f90
2007-03-22 23:17 [Bug fortran/31320] New: Illegal read with gfortran.dg/alloc_comp_assign_2.f90 and *_3.f90 burnus at gcc dot gnu dot org
2007-03-24 8:16 ` [Bug fortran/31320] " pault at gcc dot gnu dot org
2007-04-12 9:52 ` burnus at gcc dot gnu dot org
@ 2007-07-05 14:31 ` dfranke at gcc dot gnu dot org
2007-07-05 16:09 ` dfranke at gcc dot gnu dot org
` (6 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: dfranke at gcc dot gnu dot org @ 2007-07-05 14:31 UTC (permalink / raw)
To: gcc-bugs
------- Comment #3 from dfranke at gcc dot gnu dot org 2007-07-05 14:31 -------
Reduced testcase:
$> cat pr31320.f90
type :: a
integer, allocatable :: i(:)
end type a
type(a) :: x, y
x = a ((/1, 2, 3, 4/))
y = x
end
$> gfortran-svn -g -Wall pr31320.f90
$> valgrind --tool=memcheck --leak-check=full --show-reachable=yes a.out
[...]
==3173== Invalid read of size 1
==3173== at 0x4022CC1: memcpy (mc_replace_strmem.c:406)
==3173== by 0x80488AE: MAIN__ (alloc_comp_assign_2e.f90:8)
==3173== by 0x8048938: main (fmain.c:22)
==3173== Address 0x422C5C3 is 3 bytes after a block of size 16 alloc'd
==3173== at 0x40213D0: malloc (vg_replace_malloc.c:149)
==3173== by 0x8048710: MAIN__ (alloc_comp_assign_2e.f90:7)
==3173== by 0x8048938: main (fmain.c:22)
[...]
In addition, while reducing this, I saw different kinds of other errors, most
notably unnecessary free's and leaking memory.
--
dfranke at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dfranke at gcc dot gnu dot
| |org
Status|UNCONFIRMED |NEW
Ever Confirmed|0 |1
Last reconfirmed|0000-00-00 00:00:00 |2007-07-05 14:31:03
date| |
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31320
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug fortran/31320] Illegal read with gfortran.dg/alloc_comp_assign_2.f90 and *_3.f90
2007-03-22 23:17 [Bug fortran/31320] New: Illegal read with gfortran.dg/alloc_comp_assign_2.f90 and *_3.f90 burnus at gcc dot gnu dot org
` (2 preceding siblings ...)
2007-07-05 14:31 ` dfranke at gcc dot gnu dot org
@ 2007-07-05 16:09 ` dfranke at gcc dot gnu dot org
2007-07-05 16:33 ` dfranke at gcc dot gnu dot org
` (5 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: dfranke at gcc dot gnu dot org @ 2007-07-05 16:09 UTC (permalink / raw)
To: gcc-bugs
------- Comment #4 from dfranke at gcc dot gnu dot org 2007-07-05 16:09 -------
Some more examples. Uncomment either assignment to 'y' to have valgrind report
the errors indicated at the end of the line:
type :: a
integer, allocatable :: i(:)
end type a
type(a) :: x, y
x = a ((/ 1,2,3 /))
! y = a (x%i(1:3)) ! ok
! y = a (x%i(1:)) ! invalid read
! y = a (x%i(:3)) ! invalid read
! y = a (x%i(:)) ! invalid read, memory leak
! y = a (x%i) ! invalid read, memory leak
! y = x ! invalid read
end
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31320
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug fortran/31320] Illegal read with gfortran.dg/alloc_comp_assign_2.f90 and *_3.f90
2007-03-22 23:17 [Bug fortran/31320] New: Illegal read with gfortran.dg/alloc_comp_assign_2.f90 and *_3.f90 burnus at gcc dot gnu dot org
` (3 preceding siblings ...)
2007-07-05 16:09 ` dfranke at gcc dot gnu dot org
@ 2007-07-05 16:33 ` dfranke at gcc dot gnu dot org
2007-07-13 13:47 ` pault at gcc dot gnu dot org
` (4 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: dfranke at gcc dot gnu dot org @ 2007-07-05 16:33 UTC (permalink / raw)
To: gcc-bugs
------- Comment #5 from dfranke at gcc dot gnu dot org 2007-07-05 16:32 -------
Tobias, good catch :)
It seems to be another off-by-one issue. Comparing the tree dumps from
different assignments as shown in comment #4, one learns (copied only the
relevant lines, between any two adjacent lines any amount of other code was
removed):
struct a a.0;
struct array1_int4 parm.2;
parm.2.dim[0].ubound = 3;
a.0.i = (struct array1_int4) parm.2; /* ubound == 3 */
a.0.i.dim[0].ubound = a.0.i.dim[0].ubound + 1; /* ubound == 4 (!) */
x = a.0;
Adding
print *, ubound(x%i, 1), ubound(y%i, 1)
to the source gives 4/4 instead of 3/3 as one would expect from the initalizer.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31320
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug fortran/31320] Illegal read with gfortran.dg/alloc_comp_assign_2.f90 and *_3.f90
2007-03-22 23:17 [Bug fortran/31320] New: Illegal read with gfortran.dg/alloc_comp_assign_2.f90 and *_3.f90 burnus at gcc dot gnu dot org
` (4 preceding siblings ...)
2007-07-05 16:33 ` dfranke at gcc dot gnu dot org
@ 2007-07-13 13:47 ` pault at gcc dot gnu dot org
2007-07-16 12:57 ` burnus at gcc dot gnu dot org
` (3 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: pault at gcc dot gnu dot org @ 2007-07-13 13:47 UTC (permalink / raw)
To: gcc-bugs
------- Comment #6 from pault at gcc dot gnu dot org 2007-07-13 13:47 -------
(In reply to comment #5)
> struct a a.0;
> struct array1_int4 parm.2;
> parm.2.dim[0].ubound = 3;
> a.0.i = (struct array1_int4) parm.2; /* ubound == 3 */
> a.0.i.dim[0].ubound = a.0.i.dim[0].ubound + 1; /* ubound == 4 (!) */
> x = a.0;
> Adding
> print *, ubound(x%i, 1), ubound(y%i, 1)
> to the source gives 4/4 instead of 3/3 as one would expect from the initalizer.
This all happens in trans-expr.c(gfc_trans_subcomponent_assign):3007
The change for 0 to unity based indexing is done incorrectly - apparently, what
is assumed to be zero based comes through as something else... sometimes!
I think that the right thing to do here is to use the array_spec lower bound as
the base and to use the expression upper-lower as the range.
I'll see if I cannot post a fix in the next couple of days.
Paul
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31320
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug fortran/31320] Illegal read with gfortran.dg/alloc_comp_assign_2.f90 and *_3.f90
2007-03-22 23:17 [Bug fortran/31320] New: Illegal read with gfortran.dg/alloc_comp_assign_2.f90 and *_3.f90 burnus at gcc dot gnu dot org
` (5 preceding siblings ...)
2007-07-13 13:47 ` pault at gcc dot gnu dot org
@ 2007-07-16 12:57 ` burnus at gcc dot gnu dot org
2007-07-17 17:08 ` pault at gcc dot gnu dot org
` (2 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: burnus at gcc dot gnu dot org @ 2007-07-16 12:57 UTC (permalink / raw)
To: gcc-bugs
------- Comment #7 from burnus at gcc dot gnu dot org 2007-07-16 12:57 -------
For the fix for this PR and for PR32665, see:
A patch for this bug has been added to the patch tracker.
The mailing list url for the patch is
http://gcc.gnu.org/ml/gcc-patches/2007-07/msg01417.html
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31320
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug fortran/31320] Illegal read with gfortran.dg/alloc_comp_assign_2.f90 and *_3.f90
2007-03-22 23:17 [Bug fortran/31320] New: Illegal read with gfortran.dg/alloc_comp_assign_2.f90 and *_3.f90 burnus at gcc dot gnu dot org
` (6 preceding siblings ...)
2007-07-16 12:57 ` burnus at gcc dot gnu dot org
@ 2007-07-17 17:08 ` pault at gcc dot gnu dot org
2007-07-17 17:23 ` pault at gcc dot gnu dot org
2007-07-17 17:58 ` burnus at gcc dot gnu dot org
9 siblings, 0 replies; 11+ messages in thread
From: pault at gcc dot gnu dot org @ 2007-07-17 17:08 UTC (permalink / raw)
To: gcc-bugs
------- Comment #8 from pault at gcc dot gnu dot org 2007-07-17 17:07 -------
(In reply to comment #7)
Tobias,
Does the patch fix this, please? The testcase that you sent me breaks gfortran
in other places and probably should have a PR all of its very own. (try the
FORALL part separately).
Cheers
Paul
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31320
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug fortran/31320] Illegal read with gfortran.dg/alloc_comp_assign_2.f90 and *_3.f90
2007-03-22 23:17 [Bug fortran/31320] New: Illegal read with gfortran.dg/alloc_comp_assign_2.f90 and *_3.f90 burnus at gcc dot gnu dot org
` (7 preceding siblings ...)
2007-07-17 17:08 ` pault at gcc dot gnu dot org
@ 2007-07-17 17:23 ` pault at gcc dot gnu dot org
2007-07-17 17:58 ` burnus at gcc dot gnu dot org
9 siblings, 0 replies; 11+ messages in thread
From: pault at gcc dot gnu dot org @ 2007-07-17 17:23 UTC (permalink / raw)
To: gcc-bugs
------- Comment #9 from pault at gcc dot gnu dot org 2007-07-17 17:23 -------
Subject: Bug 31320
Author: pault
Date: Tue Jul 17 17:22:44 2007
New Revision: 126703
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=126703
Log:
2007-07-17 Paul Thomas <pault@gcc.gnu.org>
PR fortran/31320
PR fortran/32665
* trans-expr.c (gfc_trans_subcomponent_assign): Ensure that
renormalization unity base is done independently of existing
lbound value.
(gfc_trans_scalar_assign): If rhs is not a variable, put
lse->pre after rse->pre to ensure that de-allocation of lhs
occurs after evaluation of rhs.
2007-07-17 Paul Thomas <pault@gcc.gnu.org>
PR fortran/31320
PR fortran/32665
* gfortran.dg/alloc_comp_constructor_3.f90: New test.
Added:
trunk/gcc/testsuite/gfortran.dg/alloc_comp_constructor_3.f90
Modified:
trunk/gcc/fortran/ChangeLog
trunk/gcc/fortran/trans-expr.c
trunk/gcc/testsuite/ChangeLog
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31320
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug fortran/31320] Illegal read with gfortran.dg/alloc_comp_assign_2.f90 and *_3.f90
2007-03-22 23:17 [Bug fortran/31320] New: Illegal read with gfortran.dg/alloc_comp_assign_2.f90 and *_3.f90 burnus at gcc dot gnu dot org
` (8 preceding siblings ...)
2007-07-17 17:23 ` pault at gcc dot gnu dot org
@ 2007-07-17 17:58 ` burnus at gcc dot gnu dot org
9 siblings, 0 replies; 11+ messages in thread
From: burnus at gcc dot gnu dot org @ 2007-07-17 17:58 UTC (permalink / raw)
To: gcc-bugs
------- Comment #10 from burnus at gcc dot gnu dot org 2007-07-17 17:58 -------
> Does the patch fix this, please?
Yes, otherwise I would have blamed you in the patch review ;-)
> The testcase that you sent me breaks gfortran
> in other places and probably should have a PR all of its very own. (try the
> FORALL part separately).
I now filled PR 32795; I had hoped it would be something obvious, but it is
seemingly not.
Thanks for fixing this PR!
--
burnus at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31320
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2007-07-17 17:58 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-03-22 23:17 [Bug fortran/31320] New: Illegal read with gfortran.dg/alloc_comp_assign_2.f90 and *_3.f90 burnus at gcc dot gnu dot org
2007-03-24 8:16 ` [Bug fortran/31320] " pault at gcc dot gnu dot org
2007-04-12 9:52 ` burnus at gcc dot gnu dot org
2007-07-05 14:31 ` dfranke at gcc dot gnu dot org
2007-07-05 16:09 ` dfranke at gcc dot gnu dot org
2007-07-05 16:33 ` dfranke at gcc dot gnu dot org
2007-07-13 13:47 ` pault at gcc dot gnu dot org
2007-07-16 12:57 ` burnus at gcc dot gnu dot org
2007-07-17 17:08 ` pault at gcc dot gnu dot org
2007-07-17 17:23 ` pault at gcc dot gnu dot org
2007-07-17 17:58 ` burnus at gcc dot gnu dot org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).