[Bug c++/33462] New: [4.1/4.2/4.3 regression] Broken diagnostic: 'va_arg_expr' not supported by dump_expr

[Bug c++/33462] New: [4.1/4.2/4.3 regression] Broken diagnostic: 'va_arg_expr' not supported by dump_expr

[reichelt at gcc dot gnu dot org]

The following invalid testcase triggers a broken diagnostic since GCC 3.3.1:

===================================
struct A {};

void foo()
{
  ++__builtin_va_arg(0, A);
}
===================================

bug.cc:5: error: no match for 'operator++' in '++#'va_arg_expr' not supported
by dump_expr#<expression error>'


-- 
           Summary: [4.1/4.2/4.3 regression] Broken diagnostic:
                    'va_arg_expr' not supported by dump_expr
           Product: gcc
           Version: 4.3.0
            Status: UNCONFIRMED
          Keywords: diagnostic, monitored
          Severity: normal
          Priority: P3
         Component: c++
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: reichelt at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33462

[Bug c++/33462] [4.1/4.2/4.3 regression] Broken diagnostic: 'va_arg_expr' not supported by dump_expr

[reichelt at gcc dot gnu dot org]

-- 

reichelt at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.1.3


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33462

[Bug c++/33462] [4.1/4.2/4.3 regression] Broken diagnostic: 'va_arg_expr' not supported by dump_expr

[pcarlini at suse dot de]

-- 

pcarlini at suse dot de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |pcarlini at suse dot de
                   |dot org                     |
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2007-09-18 15:23:52
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33462

[Bug c++/33462] [4.1/4.2/4.3 regression] Broken diagnostic: 'va_arg_expr' not supported by dump_expr

[jakub at gcc dot gnu dot org]

------- Comment #1 from jakub at gcc dot gnu dot org  2007-09-18 15:34 -------
--- gcc/cp/error.c.jj   2007-09-11 12:43:28.000000000 +0200
+++ gcc/cp/error.c      2007-09-18 17:25:14.000000000 +0200
@@ -2054,6 +2054,15 @@ dump_expr (tree t, int flags)
       dump_type (t, flags);
       break;

+    case VA_ARG_EXPR:
+      pp_cxx_identifier (cxx_pp, "__builtin_va_arg");
+      pp_cxx_left_paren (cxx_pp);
+      dump_expr (TREE_OPERAND (t, 0), flags);
+      pp_separate_with_comma (cxx_pp);
+      dump_type (TREE_TYPE (t), flags);
+      pp_cxx_right_paren (cxx_pp);
+      break;
+
       /*  This list is incomplete, but should suffice for now.
          It is very important that `sorry' does not call
          `report_error_function'.  That could cause an infinite loop.  */


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33462

[Bug c++/33462] [4.1/4.2/4.3 regression] Broken diagnostic: 'va_arg_expr' not supported by dump_expr

[pcarlini at suse dot de]

------- Comment #2 from pcarlini at suse dot de  2007-09-18 15:39 -------
Thanks a lot Jakub, I'm going to do exactly that but as part of
cxx_pretty_print.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33462

[Bug c++/33462] [4.1/4.2/4.3 regression] Broken diagnostic: 'va_arg_expr' not supported by dump_expr

[pinskia at gcc dot gnu dot org]

------- Comment #3 from pinskia at gcc dot gnu dot org  2007-09-18 16:40 -------
Subject: Re:  [4.1/4.2/4.3 regression] Broken diagnostic: 'va_arg_expr' not
supported by dump_expr

On 18 Sep 2007 15:34:16 -0000, jakub at gcc dot gnu dot org
<gcc-bugzilla@gcc.gnu.org> wrote:
> +    case VA_ARG_EXPR:
> +      pp_cxx_identifier (cxx_pp, "__builtin_va_arg");


I would not use __builtin_va_arg here since this diagnostic, I would
just use va_arg.

Thanks,
Andrew Pinski


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33462

Re: [Bug c++/33462] [4.1/4.2/4.3 regression] Broken diagnostic: 'va_arg_expr' not supported by dump_expr

[Andrew Pinski]

On 18 Sep 2007 15:34:16 -0000, jakub at gcc dot gnu dot org
<gcc-bugzilla@gcc.gnu.org> wrote:
> +    case VA_ARG_EXPR:
> +      pp_cxx_identifier (cxx_pp, "__builtin_va_arg");


I would not use __builtin_va_arg here since this diagnostic, I would
just use va_arg.

Thanks,
Andrew Pinski

[Bug c++/33462] [4.1/4.2/4.3 regression] Broken diagnostic: 'va_arg_expr' not supported by dump_expr

[paolo at gcc dot gnu dot org]

------- Comment #4 from paolo at gcc dot gnu dot org  2007-09-18 18:05 -------
Subject: Bug 33462

Author: paolo
Date: Tue Sep 18 18:05:40 2007
New Revision: 128584

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=128584
Log:
/cp
2007-09-18  Paolo Carlini  <pcarlini@suse.de>

        PR c++/33462
        * cxx-pretty-print.c (pp_cxx_va_arg_expression): Add.
        (pp_cxx_primary_expression): Use it.
        * cxx-pretty-print.h (pp_cxx_va_arg_expression): Declare.
        * error.c (dump_expr): Use it.

/testsuite
2007-09-18  Paolo Carlini  <pcarlini@suse.de>

        PR c++/33462
        * g++.dg/ext/va-arg1.C: New.

Added:
    trunk/gcc/testsuite/g++.dg/ext/va-arg1.C
Modified:
    trunk/gcc/cp/ChangeLog
    trunk/gcc/cp/cxx-pretty-print.c
    trunk/gcc/cp/cxx-pretty-print.h
    trunk/gcc/cp/error.c
    trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33462

[Bug c++/33462] [4.1/4.2 regression] Broken diagnostic: 'va_arg_expr' not supported by dump_expr

[pcarlini at suse dot de]

------- Comment #5 from pcarlini at suse dot de  2007-09-18 18:06 -------
Fixed in mainline.


-- 

pcarlini at suse dot de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|pcarlini at suse dot de     |unassigned at gcc dot gnu
                   |                            |dot org
             Status|ASSIGNED                    |NEW
            Summary|[4.1/4.2/4.3 regression]    |[4.1/4.2 regression] Broken
                   |Broken diagnostic:          |diagnostic: 'va_arg_expr'
                   |'va_arg_expr' not supported |not supported by dump_expr
                   |by dump_expr                |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33462

[Bug c++/33462] [4.1/4.2 regression] Broken diagnostic: 'va_arg_expr' not supported by dump_expr

[pinskia at gcc dot gnu dot org]

------- Comment #6 from pinskia at gcc dot gnu dot org  2007-09-18 18:47 -------
No this is not fixed.  The error message is incorrect.  Most users will not use
__builtin_va_arg directly, they will be using va_arg.  So when they see
__builtin_va_arg, it will confuse them.  Can you please change it to be va_arg
instead of __builtin_va_arg.  


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33462

[Bug c++/33462] [4.1/4.2 regression] Broken diagnostic: 'va_arg_expr' not supported by dump_expr

[pcarlini at suse dot de]

------- Comment #7 from pcarlini at suse dot de  2007-09-18 19:06 -------
If Gaby agree with that change, I'm ok with it.


-- 

pcarlini at suse dot de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gdr at cs dot tamu dot edu


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33462

[Bug c++/33462] [4.1/4.2 regression] Broken diagnostic: 'va_arg_expr' not supported by dump_expr

[paolo at gcc dot gnu dot org]

------- Comment #8 from paolo at gcc dot gnu dot org  2007-09-18 19:42 -------
Subject: Bug 33462

Author: paolo
Date: Tue Sep 18 19:42:42 2007
New Revision: 128585

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=128585
Log:
cp/
2007-09-18  Paolo Carlini  <pcarlini@suse.de>

        PR c++/33462 (again)
        * cxx-pretty-print.c (pp_cxx_va_arg_expression): Print
        va_arg instead of __builtin_va_arg.

testsuite/
2007-09-18  Paolo Carlini  <pcarlini@suse.de>

        PR c++/33462 (again)
        * g++.dg/ext/va-arg1.C: Adjust.

Modified:
    trunk/gcc/cp/ChangeLog
    trunk/gcc/cp/cxx-pretty-print.c
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/g++.dg/ext/va-arg1.C


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33462

[Bug c++/33462] [4.1/4.2 regression] Broken diagnostic: 'va_arg_expr' not supported by dump_expr

[mmitchel at gcc dot gnu dot org]

-- 

mmitchel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P4


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33462

[Bug c++/33462] [4.1/4.2 regression] Broken diagnostic: 'va_arg_expr' not supported by dump_expr

[reichelt at gcc dot gnu dot org]

------- Comment #9 from reichelt at gcc dot gnu dot org  2008-01-02 23:45 -------
Subject: Bug 33462

Author: reichelt
Date: Wed Jan  2 23:44:10 2008
New Revision: 131266

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=131266
Log:
        Backport:
        2007-09-18  Paolo Carlini  <pcarlini@suse.de>

        PR c++/33462
        * cxx-pretty-print.c (pp_cxx_va_arg_expression): Add.
        (pp_cxx_primary_expression): Use it.
        * cxx-pretty-print.h (pp_cxx_va_arg_expression): Declare.
        * error.c (dump_expr): Use it.

        * g++.dg/ext/va-arg1.C: New.

Added:
    branches/gcc-4_2-branch/gcc/testsuite/g++.dg/ext/va-arg1.C
Modified:
    branches/gcc-4_2-branch/gcc/cp/ChangeLog
    branches/gcc-4_2-branch/gcc/cp/cxx-pretty-print.c
    branches/gcc-4_2-branch/gcc/cp/cxx-pretty-print.h
    branches/gcc-4_2-branch/gcc/cp/error.c
    branches/gcc-4_2-branch/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33462

[Bug c++/33462] [4.1 regression] Broken diagnostic: 'va_arg_expr' not supported by dump_expr

[reichelt at gcc dot gnu dot org]

------- Comment #10 from reichelt at gcc dot gnu dot org  2008-01-02 23:54 -------
Now also fixed in GCC 4.2.3.


-- 

reichelt at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[4.1/4.2 regression] Broken |[4.1 regression] Broken
                   |diagnostic: 'va_arg_expr'   |diagnostic: 'va_arg_expr'
                   |not supported by dump_expr  |not supported by dump_expr


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33462

[Bug c++/33462] [4.1 regression] Broken diagnostic: 'va_arg_expr' not supported by dump_expr

[jsm28 at gcc dot gnu dot org]

------- Comment #11 from jsm28 at gcc dot gnu dot org  2008-07-04 16:13 -------
Closing 4.1 branch.


-- 

jsm28 at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
      Known to fail|                            |4.1.3
      Known to work|                            |4.2.3
         Resolution|                            |FIXED
   Target Milestone|4.1.3                       |4.2.3


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33462