[Bug libfortran/33253] New: namelist: reading back a string with apostrophe

[Bug libfortran/33253] New: namelist: reading back a string with apostrophe

[tkoenig at gcc dot gnu dot org]

Reading back a namelist string which contains an
apostrophe doesn't work.

I am marking this as an enhancement because reading back
what we wrote with a namelist isn't guaranteed to work
(see note 10.37 in the working draft).  It does work with
ifort, for example.

$ cat namelist.f90 
program main
  implicit none
  character(len=3) :: a
  namelist /foo/ a
  open(10,status="scratch")
  a = "a'a"
  write(10,foo) 
  write (*,foo)
  rewind 10
  read (10,foo)
end program main
$ gfortran namelist.f90 
$ ./a.out
&FOO
 A=a'a,  /

At line 10 of file namelist.f90 (unit = 10, file = '/tmp/gfortrantmpy3HLPb')
Fortran runtime error: Cannot match namelist object name a'a,


-- 
           Summary: namelist: reading back a string with apostrophe
           Product: gcc
           Version: 4.3.0
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: P3
         Component: libfortran
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: tkoenig at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33253

[Bug libfortran/33253] namelist: reading back a string with apostrophe

[anlauf at gmx dot de]

------- Comment #1 from anlauf at gmx dot de  2007-08-31 08:20 -------
(In reply to comment #0)

> It does work with ifort, for example.

I works with g95, but fails with xlf, unless I add an
delim='apostrophe' to the open statement.

I the latter case gfortran still fails, so this might be
a bug.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33253

[Bug libfortran/33253] namelist: reading back a string with apostrophe

[anlauf at gmx dot de]

------- Comment #2 from anlauf at gmx dot de  2007-08-31 19:45 -------
(In reply to comment #1)

If I replace the open by:

  open(10,delim='apostrophe')

then the file fort.10 contains after the crash:

% cat fort.10 
&FOO
 A='a'a',  /


This looks like a quoting bug.

Jerry?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33253

[Bug libfortran/33253] namelist: reading back a string with apostrophe

[jvdelisle at gcc dot gnu dot org]

------- Comment #3 from jvdelisle at gcc dot gnu dot org  2007-08-31 20:17 -------
I want to study this a bit.  I think it is a bug.


-- 

jvdelisle at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |jvdelisle at gcc dot gnu dot
                   |dot org                     |org
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2007-08-31 20:17:04
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33253

[Bug libfortran/33253] namelist: reading back a string with apostrophe

[patchapp at dberlin dot org]

------- Comment #4 from patchapp at dberlin dot org  2007-09-03 19:05 -------
Subject: Bug number PR33253

A patch for this bug has been added to the patch tracker.
The mailing list url for the patch is
http://gcc.gnu.org/ml/gcc-patches/2007-09/msg00153.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33253

[Bug libfortran/33253] namelist: reading back a string with apostrophe

[jvdelisle at gcc dot gnu dot org]

------- Comment #5 from jvdelisle at gcc dot gnu dot org  2007-09-03 19:27 -------
Subject: Bug 33253

Author: jvdelisle
Date: Mon Sep  3 19:27:48 2007
New Revision: 128056

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=128056
Log:
2007-09-03  Jerry DeLisle  <jvdelisle@gcc.gnu.org>

        PR fortran/33253
        * gfortran.dg/namelist_15.f90: Update test.
        * gfortran.dg/namelist_24.f90: Update test.
        * gfortran.dg/namelist_38.f90: New test.

Added:
    trunk/gcc/testsuite/gfortran.dg/namelist_38.f90
Modified:
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/gfortran.dg/namelist_15.f90
    trunk/gcc/testsuite/gfortran.dg/namelist_24.f90


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33253

[Bug libfortran/33253] namelist: reading back a string with apostrophe

[jvdelisle at gcc dot gnu dot org]

------- Comment #6 from jvdelisle at gcc dot gnu dot org  2007-09-03 19:29 -------
Subject: Bug 33253

Author: jvdelisle
Date: Mon Sep  3 19:29:17 2007
New Revision: 128057

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=128057
Log:
2007-09-03  Jerry DeLisle  <jvdelisle@gcc.gnu.org>

        PR libfortran/33253
        * io/list_read.c (read_character): Use DELIM_APOSTROPHE and DELIM_QUOTE
        in check of first character in string.

Modified:
    trunk/libgfortran/ChangeLog
    trunk/libgfortran/io/list_read.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33253

[Bug libfortran/33253] namelist: reading back a string with apostrophe

[jvdelisle at gcc dot gnu dot org]

------- Comment #7 from jvdelisle at gcc dot gnu dot org  2007-09-03 19:32 -------
Fixed on trunk.


-- 

jvdelisle at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33253

[Bug libfortran/33253] namelist: reading back a string with apostrophe

[jvdelisle at gcc dot gnu dot org]

------- Comment #8 from jvdelisle at gcc dot gnu dot org  2007-09-06 01:20 -------
Subject: Bug 33253

Author: jvdelisle
Date: Thu Sep  6 01:20:02 2007
New Revision: 128170

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=128170
Log:
2007-09-05  Jerry DeLisle  <jvdelisle@gcc.gnu.org>

        PR libfortran/33253
        * io/write.c (nml_write_obj): Set the delimiter correctly before
calling
        write_character. (namelist_write): Clean up the code a little and add
        comments to clarify what its doing.

Modified:
    trunk/libgfortran/ChangeLog
    trunk/libgfortran/io/write.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33253

[Bug libfortran/33253] namelist: reading back a string with apostrophe

[jvdelisle at gcc dot gnu dot org]

------- Comment #9 from jvdelisle at gcc dot gnu dot org  2007-09-06 01:24 -------
Subject: Bug 33253

Author: jvdelisle
Date: Thu Sep  6 01:24:17 2007
New Revision: 128171

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=128171
Log:
2007-09-06  Jerry DeLisle  <jvdelisle@gcc.gnu.org>

        PR libfortran/33253
        * gfortran.dg/namelist_38.f90: Update test for DELIM= .

Modified:
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/gfortran.dg/namelist_38.f90


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33253

[Bug libfortran/33253] namelist: reading back a string with apostrophe

[jvdelisle at gcc dot gnu dot org]

------- Comment #10 from jvdelisle at gcc dot gnu dot org  2007-09-28 03:16 -------
Reverted the patch to close pr33421.  Reopening this to find the right
solution.


-- 

jvdelisle at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33253

[Bug libfortran/33253] namelist: reading back a string with apostrophe

[jvdelisle at gcc dot gnu dot org]

------- Comment #11 from jvdelisle at gcc dot gnu dot org  2007-09-30 01:58 -------
It turns out that the original patch for this bug is probably what we want. 
Unfortunately it uncovers a nasty latent bug where an extraneous namelist read
is attempted.  It only seems to occur with multiple levels of derived types. 
For example:

&MYNML
 x(2)%m(1)%ch(2) ='q', ,
&end

Will read correctly with the initial patch for the bug here if the extra comma
is placed at the end.  This is a bugger since it involves both recursive calls
and incrementing of loop specs all within a do - while loop.

Still working on it. :)


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33253

[Bug libfortran/33253] namelist: reading back a string with apostrophe

[jvdelisle at gcc dot gnu dot org]

------- Comment #12 from jvdelisle at gcc dot gnu dot org  2007-10-03 00:33 -------
Subject: Bug 33253

Author: jvdelisle
Date: Wed Oct  3 00:33:09 2007
New Revision: 128973

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=128973
Log:
2007-10-02  Jerry DeLisle  <jvdelisle@gcc.gnu.org>

        PR libfortran/33253
        * io/list_read.c (read_character): Use DELIM_APOSTROPHE and DELIM_QUOTE
        and quote value in check of first character in string.

Modified:
    trunk/libgfortran/ChangeLog
    trunk/libgfortran/io/list_read.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33253

[Bug libfortran/33253] namelist: reading back a string with apostrophe

[jvdelisle at gcc dot gnu dot org]

------- Comment #13 from jvdelisle at gcc dot gnu dot org  2007-10-03 00:40 -------
Subject: Bug 33253

Author: jvdelisle
Date: Wed Oct  3 00:39:58 2007
New Revision: 128975

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=128975
Log:
2007-10-03  Jerry DeLisle  <jvdelisle@gcc.gnu.org>

        PR libfortran/33253
        * gfortran.dg/namelist_38.f90: New test.
        * gfortran.dg/namelist_39.f90: New test.

Added:
    trunk/gcc/testsuite/gfortran.dg/namelist_38.f90
    trunk/gcc/testsuite/gfortran.dg/namelist_39.f90
Modified:
    trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33253

[Bug libfortran/33253] namelist: reading back a string with apostrophe

[jvdelisle at gcc dot gnu dot org]

------- Comment #14 from jvdelisle at gcc dot gnu dot org  2007-10-03 00:41 -------
Fixed on trunk.


-- 

jvdelisle at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33253

[Bug libfortran/33253] namelist: reading back a string with apostrophe

[jvdelisle at gcc dot gnu dot org]

------- Comment #15 from jvdelisle at gcc dot gnu dot org  2007-10-04 15:57 -------
Subject: Bug 33253

Author: jvdelisle
Date: Thu Oct  4 15:57:28 2007
New Revision: 129016

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=129016
Log:
2007-10-04  Jerry DeLisle  <jvdelisle@gcc.gnu.org>

        PR libfortran/33253
        * io/list_read.c (read_character): Use line_buffer to scan ahead for
        object name or string when no delimiter is found.

Modified:
    trunk/libgfortran/ChangeLog
    trunk/libgfortran/io/list_read.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33253

[Bug libfortran/33253] namelist: reading back a string with apostrophe

[jvdelisle at gcc dot gnu dot org]

------- Comment #16 from jvdelisle at gcc dot gnu dot org  2007-10-04 16:02 -------
Subject: Bug 33253

Author: jvdelisle
Date: Thu Oct  4 16:02:42 2007
New Revision: 129018

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=129018
Log:
2007-10-04  Jerry DeLisle  <jvdelisle@gcc.gnu.org>

        PR libfortran/33253
        * gfortran.dg/namelist_39.f90: Revise to use long names.

Modified:
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/gfortran.dg/namelist_39.f90


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33253

[Bug libfortran/33253] namelist: reading back a string with apostrophe

[patchapp at dberlin dot org]

------- Comment #17 from patchapp at dberlin dot org  2007-10-06 15:10 -------
Subject: Bug number PR33253

A patch for this bug has been added to the patch tracker.
The mailing list url for the patch is
http://gcc.gnu.org/ml/gcc-patches/2007-10/msg00011.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33253