[Bug libstdc++/32666] New: FAIL: abi_check

[Bug libstdc++/32666] New: FAIL: abi_check

[danglin at gcc dot gnu dot org]

abi_check is failing on hppa-unknown-linux-gnu with Debian lenny (libc6
2.5-9):

                === libstdc++-v3 check-abi Summary ===

# of added symbols:              74
# of missing symbols:            22
# of incompatible symbols:       23

using: baseline_symbols.txt
FAIL: abi_check

I've seen this with 4.2.1 and 4.3.0.


-- 
           Summary: FAIL: abi_check
           Product: gcc
           Version: 4.3.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libstdc++
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: danglin at gcc dot gnu dot org
 GCC build triplet: hppa-unknown-linux-gnu
  GCC host triplet: hppa-unknown-linux-gnu
GCC target triplet: hppa-unknown-linux-gnu


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32666

[Bug libstdc++/32666] FAIL: abi_check

[dave at hiauly1 dot hia dot nrc dot ca]

------- Comment #1 from dave at hiauly1 dot hia dot nrc dot ca  2007-07-07 15:55 -------
Subject: Re:   New: FAIL: abi_check

> I've seen this with 4.2.1 and 4.3.0.

Attached is the output log (probably somewhat out of order).

Dave


------- Comment #2 from dave at hiauly1 dot hia dot nrc dot ca  2007-07-07 15:55 -------
Created an attachment (id=13863)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=13863&action=view)


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32666

[Bug libstdc++/32666] FAIL: abi_check

[bkoz at gcc dot gnu dot org]

------- Comment #3 from bkoz at gcc dot gnu dot org  2007-09-18 21:54 -------
These all appear to be fails from missing C99 math functionality: tanl, etc.

So, maybe something with libmath config, config for C99 functions?

-benjamin


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32666

[Bug libstdc++/32666] FAIL: abi_check

[dave at hiauly1 dot hia dot nrc dot ca]

------- Comment #4 from dave at hiauly1 dot hia dot nrc dot ca  2007-09-18 22:24 -------
Subject: Re:  FAIL: abi_check

> So, maybe something with libmath config, config for C99 functions?

Think so,  I see asinf isn't found, yet it's there.  I'm going
to remove "-j 2" from my make script.  That should make it easier to see
what's happening.

Dave


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32666

[Bug libstdc++/32666] FAIL: abi_check

[dave at hiauly1 dot hia dot nrc dot ca]

------- Comment #5 from dave at hiauly1 dot hia dot nrc dot ca  2007-09-30 21:51 -------
Subject: Re:  FAIL: abi_check

> ------- Comment #3 from bkoz at gcc dot gnu dot org  2007-09-18 21:54 -------
> These all appear to be fails from missing C99 math functionality: tanl, etc.
> 
> So, maybe something with libmath config, config for C99 functions?

I think an update to the baseline symbols is needed.  We now have
libc 2.6.

Dave


------- Comment #6 from dave at hiauly1 dot hia dot nrc dot ca  2007-09-30 21:51 -------
Created an attachment (id=14274)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=14274&action=view)


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32666

[Bug libstdc++/32666] FAIL: abi_check

[bkoz at gcc dot gnu dot org]

------- Comment #7 from bkoz at gcc dot gnu dot org  2009-01-13 08:41 -------
From:
http://gcc.gnu.org/ml/gcc-patches/2008-03/msg00197.html

Looking at the __signbitl issue first. HPPA is the only platform that wants to
export this. Let's try to figure out why.

I see this in include/c_global/cmath

  template<typename _Tp>
    inline typename __gnu_cxx::__enable_if<__is_arithmetic<_Tp>::__value,
                                           int>::__type
    signbit(_Tp __f)
    {
      typedef typename __gnu_cxx::__promote<_Tp>::__type __type;
      return __builtin_signbit(__type(__f));
    }

This is from 

130443      paolo     signbit(_Tp __f)

or

Author: paolo
Date: Mon Nov 26 18:24:54 2007
New Revision: 130443

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=130443
Log:
2007-11-26  Paolo Carlini  <pcarlini@suse.de>

        PR libstdc++/25913
        * include/c_std/cmath (std::fpclassify, isfinite, isinf, isnan,
        isnormal, signbit, isgreater, isgreaterequal, isless, islessequal,
        islessgreater, isunordered): Guard with __enable_if and forward
        with __promote.
        * include/c_global/cmath: Likewise.
        * testsuite/26_numerics/headers/cmath/25913.cc: New.

        * include/c_std/cmath (__gnu_cxx::__capture_isfinite,
        __capture_isinf, __capture_isnan, __capture_isnormal,
        __capture_signbit, __capture_isgreater, __capture_isgreaterequal,
        __capture_isless, __capture_islessequal, __capture_islessgreater,
        __capture_isunordered): Remove.
        (std::isfinite, isinf, isnan, isnormal, signbit, isgreater,
        isgreaterequal, isless, islessequal, islessgreater, isunordered):
        Forward to the corresponding builtin.
        * include/c_global/cmath: Likewise.

        * include/c_global/cmath (std::atan2, pow): Guard with __enable_if.


OK. 

Well, that removed the last uses for libmath. (signbit, copysign. These were
once needed for the complex implementation but seem to not be necessary or use
builtins now, so can be removed.)

The following patch does so.

Dave, can you try it on hppa-linux? I've adjusted the baseline_symbols.txt file
such that it should pass now. If it does not, do 'make check-abi' and attach
the libstdc++.log file please. 

I'm not quite sure that the src/compatibility.cc bits are correct. They should
be correct for hppa, but I see that:

alpha-linux-gnu/baseline_symbols.txt:FUNC:atanl@@GLIBCXX_3.4.3
alpha-linux-gnu/baseline_symbols.txt:FUNC:tanl@@GLIBCXX_3.4
hppa-linux-gnu/baseline_symbols.txt:FUNC:atanl@@GLIBCXX_3.4.3
hppa-linux-gnu/baseline_symbols.txt:FUNC:tanl@@GLIBCXX_3.4
hppa-linux-gnu/baseline_symbols.txt.orig:FUNC:atanl@@GLIBCXX_3.4.3
hppa-linux-gnu/baseline_symbols.txt.orig:FUNC:tanl@@GLIBCXX_3.4
mips-linux-gnu/baseline_symbols.txt:FUNC:atanl@@GLIBCXX_3.4.3
mips-linux-gnu/baseline_symbols.txt:FUNC:tanl@@GLIBCXX_3.4
powerpc64-linux-gnu/baseline_symbols.txt:FUNC:atanl@GLIBCXX_3.4.3
powerpc64-linux-gnu/baseline_symbols.txt:FUNC:tanl@GLIBCXX_3.4
powerpc-linux-gnu/baseline_symbols.txt:FUNC:atanl@GLIBCXX_3.4.3
powerpc-linux-gnu/baseline_symbols.txt:FUNC:tanl@GLIBCXX_3.4
s390-linux-gnu/baseline_symbols.txt:FUNC:atanl@GLIBCXX_3.4.3
s390-linux-gnu/baseline_symbols.txt:FUNC:tanl@GLIBCXX_3.4
s390x-linux-gnu/baseline_symbols.txt:FUNC:atanl@@GLIBCXX_3.4.3
s390x-linux-gnu/baseline_symbols.txt:FUNC:tanl@@GLIBCXX_3.4
sparc-linux-gnu/baseline_symbols.txt:FUNC:atanl@GLIBCXX_3.4.3
sparc-linux-gnu/baseline_symbols.txt:FUNC:tanl@GLIBCXX_3.4

all these other ones need it too, and am not sure if the
_GLIBCXX_LONG_DOUBLE_COMPAT macro is true on these other platforms.


As an aside, I think that a lot of the GLIBCXX_CHECK_MATH finding of math
functions at configure time can be seriously reduced now that most of these are
builtins. This should be audited and fixed. We should not really have to define
most of these now.

-benjamin


-- 

bkoz at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |bkoz at gcc dot gnu dot org
                   |dot org                     |
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2009-01-13 08:41:37
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32666

[Bug libstdc++/32666] FAIL: abi_check

[bkoz at gcc dot gnu dot org]

------- Comment #8 from bkoz at gcc dot gnu dot org  2009-01-13 08:43 -------
Created an attachment (id=17083)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=17083&action=view)
check abi fails


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32666

[Bug libstdc++/32666] FAIL: abi_check

[bkoz at gcc dot gnu dot org]

------- Comment #9 from bkoz at gcc dot gnu dot org  2009-01-13 10:02 -------
Created an attachment (id=17084)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=17084&action=view)
shiny


-- 

bkoz at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #17083|0                           |1
        is obsolete|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32666

[Bug libstdc++/32666] FAIL: abi_check

[doko at ubuntu dot com]

------- Comment #10 from doko at ubuntu dot com  2009-01-15 18:38 -------
checked the patch with trunk 20090115:

                === libstdc++ tests ===


Running target unix
XPASS: 26_numerics/headers/cmath/c99_classification_macros_c.cc (test for
excess errors)

                === libstdc++ Summary ===

# of expected passes            5775
# of unexpected successes       1
# of expected failures          79
# of unsupported tests          331


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32666

[Bug libstdc++/32666] FAIL: abi_check

[bkoz at gcc dot gnu dot org]

------- Comment #11 from bkoz at gcc dot gnu dot org  2009-01-15 20:02 -------
Subject: Bug 32666

Author: bkoz
Date: Thu Jan 15 20:02:11 2009
New Revision: 143406

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=143406
Log:
2009-01-15  Benjamin Kosnik  <bkoz@redhat.com>

        PR libstdc++/32666
        * config/abi/post/hppa-linux-gnu/baseline_symbols.txt: Update.

2009-01-15  Benjamin Kosnik  <bkoz@redhat.com>

        PR libstdc++/32666
        * Makefile.am (hosted_source): Remove libmath directory.
        * Makefile.in: Regenerate.
        * linkage.m4 (GLIBCXX_CHECK_COMPLEX_MATH_SUPPORT): Remove.
        (AC_REPLACE_MATHFUNCS): Remove.
        (GLIBCXX_CHECK_MATH_SUPPORT): Remove copysign, copysignl checks as done
        in GLIBCXX_CHECK_C99_TR1.
        * acinclude.m4: Remove libmath, need_math.
        * crossconfig.m4: Remove use of HAVE_COPYSIGN, HAVE_COPYSIGNL,
        HAVE_COPYSIGNF, GLIBCXX_CHECK_COMPLEX_MATH_SUPPORT, need_libmath.
        * configure.ac: Same.
        * configure: Regenerate.
        * fragment.am: Fix comment.
        * config.h.in: Regenerate.
        * src/Makefile.in: Regenerate.
        * src/Makefile.am: Remove libmath references.
        * doc/Makefile.in: Regenerate.
        * po/Makefile.in: Regenerate.
        * include/Makefile.in: Regenerate.
        * libsupc++/Makefile.in: Regenerate.
        * testsuite/Makefile.in: Regenerate.

        * src/compatibility.cc: Also export long double versions of "C" math
        library if hppa-linux.
        * config/abi/pre/gnu.ver: Remove unused __signbit exports.
        * doc/xml/manual/appendix_contributing.xml: Remove libmath reference.

        * libmath: Remove.
        * libmath/signbit.c: Same.
        * libmath/stubs.c: Same.
        * libmath/Makefile.in: Same.
        * libmath/copysignf.c: Same.
        * libmath/mathconf.h: Same.
        * libmath/signbitf.c: Same.
        * libmath/Makefile.am: Same.
        * libmath/signbitl.c: Same.


Removed:
    trunk/libstdc++-v3/libmath/
Modified:
    trunk/libstdc++-v3/ChangeLog
    trunk/libstdc++-v3/Makefile.am
    trunk/libstdc++-v3/Makefile.in
    trunk/libstdc++-v3/acinclude.m4
    trunk/libstdc++-v3/config.h.in
    trunk/libstdc++-v3/config/abi/post/hppa-linux-gnu/baseline_symbols.txt
    trunk/libstdc++-v3/config/abi/pre/gnu.ver
    trunk/libstdc++-v3/configure
    trunk/libstdc++-v3/configure.ac
    trunk/libstdc++-v3/crossconfig.m4
    trunk/libstdc++-v3/doc/Makefile.in
    trunk/libstdc++-v3/doc/xml/manual/appendix_contributing.xml
    trunk/libstdc++-v3/fragment.am
    trunk/libstdc++-v3/include/Makefile.in
    trunk/libstdc++-v3/libsupc++/Makefile.in
    trunk/libstdc++-v3/linkage.m4
    trunk/libstdc++-v3/po/Makefile.in
    trunk/libstdc++-v3/src/Makefile.am
    trunk/libstdc++-v3/src/Makefile.in
    trunk/libstdc++-v3/src/compatibility.cc
    trunk/libstdc++-v3/testsuite/Makefile.in


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32666

[Bug libstdc++/32666] FAIL: abi_check

[dave at hiauly1 dot hia dot nrc dot ca]

------- Comment #12 from dave at hiauly1 dot hia dot nrc dot ca  2009-01-16 00:24 -------
Subject: Re:  FAIL: abi_check

> ------- Comment #9 from bkoz at gcc dot gnu dot org  2009-01-13 10:02 -------
> Created an attachment (id=17084)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=17084&action=view)
>  --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=17084&action=view)
> shiny

I applied to above on hppa2.0w-hp-hpux11.11.  With respect to the
previous build, there are a number of new fails:

Executing on host: /test/gnu/gcc/objdir/./gcc/g++ -shared-libgcc
-B/test/gnu/gcc
/objdir/./gcc -nostdinc++
-L/test/gnu/gcc/objdir/hppa2.0w-hp-hpux11.11/libstdc++
-v3/src -L/test/gnu/gcc/objdir/hppa2.0w-hp-hpux11.11/libstdc++-v3/src/.libs
-B/o
pt/gnu/gcc/gcc-4.4.0/hppa2.0w-hp-hpux11.11/bin/
-B/opt/gnu/gcc/gcc-4.4.0/hppa2.0
w-hp-hpux11.11/lib/ -isystem
/opt/gnu/gcc/gcc-4.4.0/hppa2.0w-hp-hpux11.11/includ
e -isystem /opt/gnu/gcc/gcc-4.4.0/hppa2.0w-hp-hpux11.11/sys-include -g -O2
-D_GL
IBCXX_ASSERT -fmessage-length=0 -g -O2 -g -O2   -DLOCALEDIR="." -nostdinc++
-I/t
est/gnu/gcc/objdir/hppa2.0w-hp-hpux11.11/libstdc++-v3/include/hppa2.0w-hp-hpux11
.11 -I/test/gnu/gcc/objdir/hppa2.0w-hp-hpux11.11/libstdc++-v3/include
-I/test/gn
u/gcc/gcc/libstdc++-v3/libsupc++
-I/test/gnu/gcc/gcc/libstdc++-v3/include/backwa
rd -I/test/gnu/gcc/gcc/libstdc++-v3/testsuite/util
/test/gnu/gcc/gcc/libstdc++-v
3/testsuite/26_numerics/complex/13450.cc    -include bits/stdc++.h
./libtestc++.
a  -lm   -o ./13450.exe    (timeout = 600)
/usr/ccs/bin/ld: Unsatisfied symbols:
   logl (first referenced in /var/tmp//ccQdgBMy.o) (code)
   sinl (first referenced in /var/tmp//ccQdgBMy.o) (code)
   expl (first referenced in /var/tmp//ccQdgBMy.o) (code)
   powl (first referenced in /var/tmp//ccQdgBMy.o) (code)
   atan2l (first referenced in /var/tmp//ccQdgBMy.o) (code)
   sqrtl (first referenced in /var/tmp//ccQdgBMy.o) (code)
   cosl (first referenced in /var/tmp//ccQdgBMy.o) (code)
   collect2: ld returned 1 exit status

Dave


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32666

[Bug libstdc++/32666] FAIL: abi_check hppa

[bkoz at gcc dot gnu dot org]

------- Comment #13 from bkoz at gcc dot gnu dot org  2009-01-16 02:26 -------

Ouch. I see this also on arm-elf crosses, whoops.

Here's a patch that I'm currently testing on cross. If it fixes it, then I'll
check it in and then please try on hpux.


-- 

bkoz at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|FAIL: abi_check             |FAIL: abi_check hppa


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32666

[Bug libstdc++/32666] FAIL: abi_check hppa

[bkoz at gcc dot gnu dot org]

------- Comment #14 from bkoz at gcc dot gnu dot org  2009-01-16 02:26 -------
Created an attachment (id=17112)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=17112&action=view)
add in stubs.c for long double only


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32666

[Bug libstdc++/32666] FAIL: abi_check hppa

[dave at hiauly1 dot hia dot nrc dot ca]

------- Comment #15 from dave at hiauly1 dot hia dot nrc dot ca  2009-01-16 20:51 -------
Subject: Re:  FAIL: abi_check hppa

> add in stubs.c for long double only

I think we also need float stubs.  I saw some problems with
floorf in the testsuite in my last build.

Dave


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32666

[Bug libstdc++/32666] FAIL: abi_check hppa

[dave at hiauly1 dot hia dot nrc dot ca]

------- Comment #16 from dave at hiauly1 dot hia dot nrc dot ca  2009-01-17 16:02 -------
Subject: Re:  FAIL: abi_check hppa

> I think we also need float stubs.  I saw some problems with
> floorf in the testsuite in my last build.

There are four testsuite fails due to floorf being missing.  Here's one:

Executing on host: /test/gnu/gcc/objdir/./gcc/g++ -shared-libgcc
-B/test/gnu/gcc
/objdir/./gcc -nostdinc++
-L/test/gnu/gcc/objdir/hppa2.0w-hp-hpux11.11/libstdc++
-v3/src -L/test/gnu/gcc/objdir/hppa2.0w-hp-hpux11.11/libstdc++-v3/src/.libs
-B/o
pt/gnu/gcc/gcc-4.4.0/hppa2.0w-hp-hpux11.11/bin/
-B/opt/gnu/gcc/gcc-4.4.0/hppa2.0
w-hp-hpux11.11/lib/ -isystem
/opt/gnu/gcc/gcc-4.4.0/hppa2.0w-hp-hpux11.11/includ
e -isystem /opt/gnu/gcc/gcc-4.4.0/hppa2.0w-hp-hpux11.11/sys-include -g -O2
-D_GL
IBCXX_ASSERT -fmessage-length=0 -g -O2 -g -O2   -DLOCALEDIR="." -nostdinc++
-I/t
est/gnu/gcc/objdir/hppa2.0w-hp-hpux11.11/libstdc++-v3/include/hppa2.0w-hp-hpux11
.11 -I/test/gnu/gcc/objdir/hppa2.0w-hp-hpux11.11/libstdc++-v3/include
-I/test/gn
u/gcc/gcc/libstdc++-v3/libsupc++
-I/test/gnu/gcc/gcc/libstdc++-v3/include/backwa
rd -I/test/gnu/gcc/gcc/libstdc++-v3/testsuite/util
/test/gnu/gcc/gcc/libstdc++-v
3/testsuite/tr1/5_numerical_facilities/special_functions/12_ellint_1/check_nan.c
c    -include bits/stdc++.h ./libtestc++.a  -lm   -o ./check_nan.exe   
(timeout
 = 600)
/usr/ccs/bin/ld: Unsatisfied symbols:
   floorf (first referenced in /var/tmp//ccLVzphs.o) (code)
collect2: ld returned 1 exit status
...
FAIL: tr1/5_numerical_facilities/special_functions/12_ellint_1/check_nan.cc
(tes
t for excess errors)

Other f functions that are checked for and missing on hppa2.0w-hp-hpux11.11
are, ceilf, finitef, frexpf, hypotf, isnanf, ldexpf, modff, sincosf, strtof.
HP-UX 10 is the same except for having finitef and isnanf.

Dave


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32666

[Bug libstdc++/32666] FAIL: abi_check hppa

[bkoz at redhat dot com]

------- Comment #17 from bkoz at redhat dot com  2009-01-20 05:51 -------

The float versions were added in r143457

http://gcc.gnu.org/ml/gcc-cvs/2009-01/msg00470.html

hpux 11 looks fine, but I don't see 10.x results.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32666

[Bug libstdc++/32666] FAIL: abi_check hppa

[dave at hiauly1 dot hia dot nrc dot ca]

------- Comment #18 from dave at hiauly1 dot hia dot nrc dot ca  2009-01-20 15:36 -------
Subject: Re:  FAIL: abi_check hppa

> The float versions were added in r143457

The abi check problem is fixed, and the hpux test results on
hppa2.0w-hp-hpux11.11 and hppa64-hp-hpux11.11 are again ok.

Dave


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32666

[Bug libstdc++/32666] FAIL: abi_check hppa

[bkoz at gcc dot gnu dot org]

------- Comment #19 from bkoz at gcc dot gnu dot org  2009-01-20 19:25 -------

Fixed for 4.4.0


-- 

bkoz at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.4.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32666