* [Bug fortran/33626] Parentheses get wrong kind during matching
2007-10-02 13:39 [Bug fortran/33626] New: Parentheses get wrong kind during matching fxcoudert at gcc dot gnu dot org
@ 2007-10-02 15:59 ` fxcoudert at gcc dot gnu dot org
2007-10-03 14:40 ` tobi at gcc dot gnu dot org
` (13 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: fxcoudert at gcc dot gnu dot org @ 2007-10-02 15:59 UTC (permalink / raw)
To: gcc-bugs
--
fxcoudert at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
Ever Confirmed|0 |1
Last reconfirmed|0000-00-00 00:00:00 |2007-10-02 15:59:33
date| |
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33626
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug fortran/33626] Parentheses get wrong kind during matching
2007-10-02 13:39 [Bug fortran/33626] New: Parentheses get wrong kind during matching fxcoudert at gcc dot gnu dot org
2007-10-02 15:59 ` [Bug fortran/33626] " fxcoudert at gcc dot gnu dot org
@ 2007-10-03 14:40 ` tobi at gcc dot gnu dot org
2007-10-03 16:12 ` tobi at gcc dot gnu dot org
` (12 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: tobi at gcc dot gnu dot org @ 2007-10-03 14:40 UTC (permalink / raw)
To: gcc-bugs
--
tobi at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|unassigned at gcc dot gnu |tobi at gcc dot gnu dot org
|dot org |
Status|NEW |ASSIGNED
Last reconfirmed|2007-10-02 15:59:33 |2007-10-03 14:40:17
date| |
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33626
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug fortran/33626] Parentheses get wrong kind during matching
2007-10-02 13:39 [Bug fortran/33626] New: Parentheses get wrong kind during matching fxcoudert at gcc dot gnu dot org
2007-10-02 15:59 ` [Bug fortran/33626] " fxcoudert at gcc dot gnu dot org
2007-10-03 14:40 ` tobi at gcc dot gnu dot org
@ 2007-10-03 16:12 ` tobi at gcc dot gnu dot org
2007-10-03 16:22 ` tobi at gcc dot gnu dot org
` (11 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: tobi at gcc dot gnu dot org @ 2007-10-03 16:12 UTC (permalink / raw)
To: gcc-bugs
------- Comment #1 from tobi at gcc dot gnu dot org 2007-10-03 16:12 -------
Created an attachment (id=14291)
--> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=14291&action=view)
Putative patch
This patch fixes the testcase.
FX, I take it that you have a ready-built compiler with type-checking enabled.
In that case I would ask you to try this patch. Otherwise I'll take care of
this myself.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33626
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug fortran/33626] Parentheses get wrong kind during matching
2007-10-02 13:39 [Bug fortran/33626] New: Parentheses get wrong kind during matching fxcoudert at gcc dot gnu dot org
` (2 preceding siblings ...)
2007-10-03 16:12 ` tobi at gcc dot gnu dot org
@ 2007-10-03 16:22 ` tobi at gcc dot gnu dot org
2007-10-03 16:26 ` fxcoudert at gcc dot gnu dot org
` (10 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: tobi at gcc dot gnu dot org @ 2007-10-03 16:22 UTC (permalink / raw)
To: gcc-bugs
------- Comment #2 from tobi at gcc dot gnu dot org 2007-10-03 16:22 -------
Created an attachment (id=14292)
--> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=14292&action=view)
Putative patch redux
Coming to think of it, the charlen thing can probably also be moved to the
first switch and done unconditionally. This hasn't yet gotten the testsuite
treatment from me, though.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33626
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug fortran/33626] Parentheses get wrong kind during matching
2007-10-02 13:39 [Bug fortran/33626] New: Parentheses get wrong kind during matching fxcoudert at gcc dot gnu dot org
` (3 preceding siblings ...)
2007-10-03 16:22 ` tobi at gcc dot gnu dot org
@ 2007-10-03 16:26 ` fxcoudert at gcc dot gnu dot org
2007-10-03 16:36 ` Tobias dot Schlueter at physik dot uni-muenchen dot de
` (9 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: fxcoudert at gcc dot gnu dot org @ 2007-10-03 16:26 UTC (permalink / raw)
To: gcc-bugs
------- Comment #3 from fxcoudert at gcc dot gnu dot org 2007-10-03 16:26 -------
(In reply to comment #1)
> Created an attachment (id=14291)
--> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=14291&action=view) [edit]
> Putative patch
I thought about that, because it seems right, but the the question is: what was
the intent of the original situation, which only copied typespec only for
unknown types?
> FX, I take it that you have a ready-built compiler with type-checking enabled.
> In that case I would ask you to try this patch. Otherwise I'll take care of
> this myself.
I'll test it.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33626
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug fortran/33626] Parentheses get wrong kind during matching
2007-10-02 13:39 [Bug fortran/33626] New: Parentheses get wrong kind during matching fxcoudert at gcc dot gnu dot org
` (4 preceding siblings ...)
2007-10-03 16:26 ` fxcoudert at gcc dot gnu dot org
@ 2007-10-03 16:36 ` Tobias dot Schlueter at physik dot uni-muenchen dot de
2007-10-03 16:40 ` fxcoudert at gcc dot gnu dot org
` (8 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: Tobias dot Schlueter at physik dot uni-muenchen dot de @ 2007-10-03 16:36 UTC (permalink / raw)
To: gcc-bugs
------- Comment #4 from Tobias dot Schlueter at physik dot uni-muenchen dot de 2007-10-03 16:36 -------
Subject: Re: Parentheses get wrong kind during matching
fxcoudert at gcc dot gnu dot org wrote:
> ------- Comment #3 from fxcoudert at gcc dot gnu dot org 2007-10-03 16:26 -------
> (In reply to comment #1)
>> Created an attachment (id=14291)
--> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=14291&action=view)
> --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=14291&action=view) [edit]
>> Putative patch
>
> I thought about that, because it seems right, but the the question is: what was
> the intent of the original situation, which only copied typespec only for
> unknown types?
I'm thinking that was a case of playing it overly safe as the comment
indicates.
OTOH I'm seeing a testsuite failure with derived_comp_array_ref_5.f90
for which I have no explanation at the moment, I'll have to doublecheck
if it disappears without my patch.
> I'll test it.
Thanks!
- Tobi
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33626
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug fortran/33626] Parentheses get wrong kind during matching
2007-10-02 13:39 [Bug fortran/33626] New: Parentheses get wrong kind during matching fxcoudert at gcc dot gnu dot org
` (5 preceding siblings ...)
2007-10-03 16:36 ` Tobias dot Schlueter at physik dot uni-muenchen dot de
@ 2007-10-03 16:40 ` fxcoudert at gcc dot gnu dot org
2007-10-03 16:46 ` Tobias dot Schlueter at physik dot uni-muenchen dot de
` (7 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: fxcoudert at gcc dot gnu dot org @ 2007-10-03 16:40 UTC (permalink / raw)
To: gcc-bugs
------- Comment #5 from fxcoudert at gcc dot gnu dot org 2007-10-03 16:40 -------
(In reply to comment #4)
> OTOH I'm seeing a testsuite failure with derived_comp_array_ref_5.f90
> for which I have no explanation at the moment, I'll have to doublecheck
> if it disappears without my patch.
Hum... Why do I keep sending regular regressions heads-up, can you remind me?
;-)
http://gcc.gnu.org/ml/fortran/2007-10/msg00040.html
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33626
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug fortran/33626] Parentheses get wrong kind during matching
2007-10-02 13:39 [Bug fortran/33626] New: Parentheses get wrong kind during matching fxcoudert at gcc dot gnu dot org
` (6 preceding siblings ...)
2007-10-03 16:40 ` fxcoudert at gcc dot gnu dot org
@ 2007-10-03 16:46 ` Tobias dot Schlueter at physik dot uni-muenchen dot de
2007-10-03 16:52 ` fxcoudert at gcc dot gnu dot org
` (6 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: Tobias dot Schlueter at physik dot uni-muenchen dot de @ 2007-10-03 16:46 UTC (permalink / raw)
To: gcc-bugs
------- Comment #6 from Tobias dot Schlueter at physik dot uni-muenchen dot de 2007-10-03 16:46 -------
Subject: Re: Parentheses get wrong kind during matching
fxcoudert at gcc dot gnu dot org wrote:
> ------- Comment #5 from fxcoudert at gcc dot gnu dot org 2007-10-03 16:40 -------
> (In reply to comment #4)
>> OTOH I'm seeing a testsuite failure with derived_comp_array_ref_5.f90
>> for which I have no explanation at the moment, I'll have to doublecheck
>> if it disappears without my patch.
>
> Hum... Why do I keep sending regular regressions heads-up, can you remind me?
> ;-)
Ouch, a warning regression seemd so unlikely to happen in the tree that
I thought it would be my fault, even though I very well remembered that
you had sent an e-mail pointing out failures of default_format_1.f90
(which I'm seeing as well).
Note to self: always memorize e-mail's from FX in their entirety :)
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33626
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug fortran/33626] Parentheses get wrong kind during matching
2007-10-02 13:39 [Bug fortran/33626] New: Parentheses get wrong kind during matching fxcoudert at gcc dot gnu dot org
` (7 preceding siblings ...)
2007-10-03 16:46 ` Tobias dot Schlueter at physik dot uni-muenchen dot de
@ 2007-10-03 16:52 ` fxcoudert at gcc dot gnu dot org
2007-10-03 17:06 ` Tobias dot Schlueter at physik dot uni-muenchen dot de
` (5 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: fxcoudert at gcc dot gnu dot org @ 2007-10-03 16:52 UTC (permalink / raw)
To: gcc-bugs
------- Comment #7 from fxcoudert at gcc dot gnu dot org 2007-10-03 16:52 -------
(In reply to comment #6)
> failures of default_format_1.f90 (which I'm seeing as well)
You're seeing failures of default_format_1.f90 on i686-darwin (IIRC, that's
what you've got these days)? That's not supposed to happen, I thought it'd be
only on powerpc-darwin (which I have xfail'ed)! Could you compile it and run it
under gdb, and see where it aborts? (I expect it to be the line about tiny, in
which case it'd be the same failure as powerpc.)
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33626
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug fortran/33626] Parentheses get wrong kind during matching
2007-10-02 13:39 [Bug fortran/33626] New: Parentheses get wrong kind during matching fxcoudert at gcc dot gnu dot org
` (8 preceding siblings ...)
2007-10-03 16:52 ` fxcoudert at gcc dot gnu dot org
@ 2007-10-03 17:06 ` Tobias dot Schlueter at physik dot uni-muenchen dot de
2007-10-03 17:09 ` fxcoudert at gcc dot gnu dot org
` (4 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: Tobias dot Schlueter at physik dot uni-muenchen dot de @ 2007-10-03 17:06 UTC (permalink / raw)
To: gcc-bugs
------- Comment #8 from Tobias dot Schlueter at physik dot uni-muenchen dot de 2007-10-03 17:06 -------
Subject: Re: Parentheses get wrong kind during matching
fxcoudert at gcc dot gnu dot org wrote:
> ------- Comment #7 from fxcoudert at gcc dot gnu dot org 2007-10-03 16:52 -------
> (In reply to comment #6)
>> failures of default_format_1.f90 (which I'm seeing as well)
>
> You're seeing failures of default_format_1.f90 on i686-darwin (IIRC, that's
> what you've got these days)? That's not supposed to happen, I thought it'd be
> only on powerpc-darwin (which I have xfail'ed)! Could you compile it and run it
> under gdb, and see where it aborts? (I expect it to be the line about tiny, in
> which case it'd be the same failure as powerpc.)
I checked all tests individually, and both the tests related to
tiny(0.0_8) fail.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33626
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug fortran/33626] Parentheses get wrong kind during matching
2007-10-02 13:39 [Bug fortran/33626] New: Parentheses get wrong kind during matching fxcoudert at gcc dot gnu dot org
` (9 preceding siblings ...)
2007-10-03 17:06 ` Tobias dot Schlueter at physik dot uni-muenchen dot de
@ 2007-10-03 17:09 ` fxcoudert at gcc dot gnu dot org
2007-10-03 22:06 ` fxcoudert at gcc dot gnu dot org
` (3 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: fxcoudert at gcc dot gnu dot org @ 2007-10-03 17:09 UTC (permalink / raw)
To: gcc-bugs
------- Comment #9 from fxcoudert at gcc dot gnu dot org 2007-10-03 17:09 -------
(In reply to comment #8)
> I checked all tests individually, and both the tests related to
> tiny(0.0_8) fail.
That means Apple's printf() failures to read and write denormals are not
powerpc-specific. I've xfail'ed the test on all *-apple-darwin*. Thanks for
testing!
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33626
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug fortran/33626] Parentheses get wrong kind during matching
2007-10-02 13:39 [Bug fortran/33626] New: Parentheses get wrong kind during matching fxcoudert at gcc dot gnu dot org
` (10 preceding siblings ...)
2007-10-03 17:09 ` fxcoudert at gcc dot gnu dot org
@ 2007-10-03 22:06 ` fxcoudert at gcc dot gnu dot org
2007-10-04 7:35 ` tobi at gcc dot gnu dot org
` (2 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: fxcoudert at gcc dot gnu dot org @ 2007-10-03 22:06 UTC (permalink / raw)
To: gcc-bugs
------- Comment #10 from fxcoudert at gcc dot gnu dot org 2007-10-03 22:05 -------
(In reply to comment #2)
> Created an attachment (id=14292)
--> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=14292&action=view) [edit]
> Putative patch redux
That patch regtests fines on x86_64-linux with type-checking enabled. It's OK
to commit.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33626
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug fortran/33626] Parentheses get wrong kind during matching
2007-10-02 13:39 [Bug fortran/33626] New: Parentheses get wrong kind during matching fxcoudert at gcc dot gnu dot org
` (11 preceding siblings ...)
2007-10-03 22:06 ` fxcoudert at gcc dot gnu dot org
@ 2007-10-04 7:35 ` tobi at gcc dot gnu dot org
2007-10-04 15:11 ` fxcoudert at gcc dot gnu dot org
2007-10-04 15:24 ` tobi at gcc dot gnu dot org
14 siblings, 0 replies; 16+ messages in thread
From: tobi at gcc dot gnu dot org @ 2007-10-04 7:35 UTC (permalink / raw)
To: gcc-bugs
------- Comment #11 from tobi at gcc dot gnu dot org 2007-10-04 07:34 -------
Subject: Bug 33626
Author: tobi
Date: Thu Oct 4 07:34:38 2007
New Revision: 129002
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=129002
Log:
PR fortran/33626
fortran/
* resolve.c (resolve_operator): Always copy the type for
expressions in parentheses.
testsuite/
* gfortran.dg/parens_6.f90: New.
Added:
trunk/gcc/testsuite/gfortran.dg/parens_6.f90
Modified:
trunk/gcc/fortran/ChangeLog
trunk/gcc/fortran/resolve.c
trunk/gcc/testsuite/ChangeLog
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33626
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug fortran/33626] Parentheses get wrong kind during matching
2007-10-02 13:39 [Bug fortran/33626] New: Parentheses get wrong kind during matching fxcoudert at gcc dot gnu dot org
` (12 preceding siblings ...)
2007-10-04 7:35 ` tobi at gcc dot gnu dot org
@ 2007-10-04 15:11 ` fxcoudert at gcc dot gnu dot org
2007-10-04 15:24 ` tobi at gcc dot gnu dot org
14 siblings, 0 replies; 16+ messages in thread
From: fxcoudert at gcc dot gnu dot org @ 2007-10-04 15:11 UTC (permalink / raw)
To: gcc-bugs
------- Comment #12 from fxcoudert at gcc dot gnu dot org 2007-10-04 15:10 -------
Fixed, isn't it?
--
fxcoudert at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
Target Milestone|--- |4.3.0
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33626
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug fortran/33626] Parentheses get wrong kind during matching
2007-10-02 13:39 [Bug fortran/33626] New: Parentheses get wrong kind during matching fxcoudert at gcc dot gnu dot org
` (13 preceding siblings ...)
2007-10-04 15:11 ` fxcoudert at gcc dot gnu dot org
@ 2007-10-04 15:24 ` tobi at gcc dot gnu dot org
14 siblings, 0 replies; 16+ messages in thread
From: tobi at gcc dot gnu dot org @ 2007-10-04 15:24 UTC (permalink / raw)
To: gcc-bugs
------- Comment #13 from tobi at gcc dot gnu dot org 2007-10-04 15:24 -------
Yes, I only happened to leave before the commit message arrived.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33626
^ permalink raw reply [flat|nested] 16+ messages in thread