[Bug target/33635] New: Bootstrap broken on mips-sgi-irix6.5

[Bug target/33635] New: Bootstrap broken on mips-sgi-irix6.5

[fxcoudert at gcc dot gnu dot org]

Mainline currently doesn't bootstrap on mips-sgi-irix6.5 due to an ICE while
compiling mips-sgi-irix6.5/64/libgcc/_powitf2.o at stage 1. This happens,
afaict, with any use of the TF mode with either -mabi=64 or -mabi=n32:

$ cat foo.i
void __powitf2 (float x __attribute__ ((mode (TF)))) {}
$ /usr/people/francois/devel/ibin/./gcc/cc1 -fpreprocessed foo.i -quiet
zsh: segmentation fault  /usr/people/francois/devel/ibin/./gcc/cc1
-fpreprocessed foo.i -quiet

The backtrace for the segfault is:

Program received signal SIGSEGV, Segmentation fault.
0x104d7d50 in reg_classes_intersect_p (c1=32, c2=MD0_REG)
    at ../../trunk/gcc/regclass.c:2481
2481    {
(gdb) where
#0  0x104d7d50 in reg_classes_intersect_p (c1=32, c2=MD0_REG)
    at ../../trunk/gcc/regclass.c:2481
#1  0x102323cc in mips_cannot_change_mode_class (from=TFmode, to=DImode,
    class=FP_REGS) at ../../trunk/gcc/config/mips/mips.c:9346
#2  0x10823a38 in simplify_subreg (outermode=DImode, op=0x40b4c80,
    innermode=TFmode, byte=0) at ../../trunk/gcc/simplify-rtx.c:5014
#3  0x10824968 in simplify_gen_subreg (outermode=DImode, op=0x40b4c80,
    innermode=TFmode, byte=0) at ../../trunk/gcc/simplify-rtx.c:5211
#4  0x1027a700 in operand_subword (op=0x40b4c80, offset=0,
    validate_address=1, mode=TFmode) at ../../trunk/gcc/emit-rtl.c:1425
#5  0x1027a76c in operand_subword_force (op=0x40b4c80, offset=0, mode=TFmode)
    at ../../trunk/gcc/emit-rtl.c:1438
#6  0x10337484 in emit_move_multi_word (mode=TFmode, x=0x4c84200, y=0x40b4c80)
    at ../../trunk/gcc/expr.c:3275
#7  0x10337980 in emit_move_insn_1 (x=0x4c84200, y=0x40b4c80)
    at ../../trunk/gcc/expr.c:3347
#8  0x10337dc0 in emit_move_insn (x=0x4c84200, y=0x40b4c80)
    at ../../trunk/gcc/expr.c:3407
#9  0x102b4894 in copy_to_reg (x=0x40b4c80) at ../../trunk/gcc/explow.c:617
#10 0x1027a7cc in operand_subword_force (op=0x40b4c80, offset=0, mode=TFmode)
    at ../../trunk/gcc/emit-rtl.c:1448


I'm keeping the build tree so that I can investigate more if needed, please
tell me what to do.


-- 
           Summary: Bootstrap broken on mips-sgi-irix6.5
           Product: gcc
           Version: 4.3.0
            Status: UNCONFIRMED
          Keywords: build
          Severity: normal
          Priority: P3
         Component: target
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: fxcoudert at gcc dot gnu dot org
 GCC build triplet: mips-sgi-irix6.5
  GCC host triplet: mips-sgi-irix6.5
GCC target triplet: mips-sgi-irix6.5


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33635

[Bug target/33635] Bootstrap broken on mips-sgi-irix6.5

[rsandifo at gcc dot gnu dot org]

------- Comment #1 from rsandifo at gcc dot gnu dot org  2007-10-03 18:39 -------
Sorry, this is my fault.


-- 

rsandifo at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |rsandifo at gcc dot gnu dot
                   |dot org                     |org
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2007-10-03 18:39:04
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33635

[Bug target/33635] Bootstrap broken on mips-sgi-irix6.5

[rsandifo at gcc dot gnu dot org]

------- Comment #2 from rsandifo at gcc dot gnu dot org  2007-10-03 18:39 -------
Subject: Bug 33635

Author: rsandifo
Date: Wed Oct  3 18:39:30 2007
New Revision: 128991

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=128991
Log:
gcc/
        PR target/33635
        * config/mips/mips-protos.h (mips_split_64bit_move): Rename to...
        (mips_split_doubleword_move): ...this.
        * config/mips/mips.c (mips_subword): Extend to handle 64-bit words;
        use natural endianness for multi-format FPR values.
        (mips_split_64bit_move): Rename to...
        (mips_split_doubleword_move): ...this and extend to 64-bit words.
        Use move_doubleword_fpr* patterns for moves involving FPRs.
        (mips_save_reg): Update the call to mips_split_64bit_move.
        (mips_secondary_reload_class): Return NO_REGS for any reload of a
        nonzero constant into an FPR if the constant can be forced to memory.
        * config/mips/mips.md: Update the splitter calls to
        mips_split_64bit_move.
        (UNSPEC_LOAD_DF_LOW): Rename to...
        (UNSPEC_LOAD_LOW): ...this.
        (UNSPEC_LOAD_DF_HIGH): Rename to...
        (UNSPEC_LOAD_HIGH): ...this.
        (UNSPEC_STORE_DF_HIGH): Rename to...
        (UNSPEC_STORE_WORD): ...this.
        (SPLITF): New mode iterator.
        (HALFMODE): New mode attribute.
        (movtf): New expander.
        (*movtf_internal): New define_insn_and_split.
        (move_doubleword_fpr<mode>): New expander.
        (load_df_low, load_df_high, store_df_high, mthc1, mfhc1): Replace
        with...
        (load_low<mode>, load_high<mode>, store_word<mode>, mthc1<mode>)
        (mfhc1<mode>): ...these more general patterns.

gcc/testsuite/
        PR target/33635
        * gcc.target/mips/mips.exp (setup_mips_tests): Set mips_isa_rev
        and mips_forced_be.
        (dg-mips-options): Handle -EL and -mel.  Make -mfp64 imply
        -mhard-float and a suitable ISA.  Improve handling of -mipsXrY
        options.
        * gcc.target/mips/fpr-moves-1.c: New test.
        * gcc.target/mips/fpr-moves-2.c: Likewise.
        * gcc.target/mips/fpr-moves-3.c: Likewise.
        * gcc.target/mips/fpr-moves-4.c: Likewise.
        * gcc.target/mips/fpr-moves-5.c: Likewise.
        * gcc.target/mips/fpr-moves-6.c: Likewise.
        * gcc.target/mips/mips32r2-mxhc1.c: Remove -march=mips32r2

Added:
    trunk/gcc/testsuite/gcc.target/mips/fpr-moves-1.c
    trunk/gcc/testsuite/gcc.target/mips/fpr-moves-2.c
    trunk/gcc/testsuite/gcc.target/mips/fpr-moves-3.c
    trunk/gcc/testsuite/gcc.target/mips/fpr-moves-4.c
    trunk/gcc/testsuite/gcc.target/mips/fpr-moves-5.c
    trunk/gcc/testsuite/gcc.target/mips/fpr-moves-6.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/mips/mips-protos.h
    trunk/gcc/config/mips/mips.c
    trunk/gcc/config/mips/mips.md
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/gcc.target/mips/mips.exp
    trunk/gcc/testsuite/gcc.target/mips/mips32r2-mxhc1.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33635

[Bug target/33635] Bootstrap broken on mips-sgi-irix6.5

[rsandifo at gcc dot gnu dot org]

------- Comment #3 from rsandifo at gcc dot gnu dot org  2007-10-03 18:42 -------
Thanks for the report.  As per my gcc-patches@ message,
I think the committed patch is at least a step on the
road to recovery.  Please let me know if it fixes things,
or if it still isn't enough.


-- 

rsandifo at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |WAITING


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33635

[Bug target/33635] Bootstrap broken on mips-sgi-irix6.5

[fxcoudert at gcc dot gnu dot org]

------- Comment #4 from fxcoudert at gcc dot gnu dot org  2007-10-04 13:25 -------
We still have an ICE on __powitf2, at -O2 (but not -O1):

$ cat foo.i
typedef float TFtype __attribute__ ((mode (TF)));
TFtype __powitf2 (TFtype x, int m)
{
  TFtype y = x;
  while (m >>= 1)
    {
      x = x * x;
      if (m % 2)
        y = y * x;
    }
  return y;
}
$ cc1 -fpreprocessed foo.i -quiet -mabi=n32 -O2
foo.i: In function '__powitf2':
foo.i:12:1: error: insn does not satisfy its constraints:
(insn 12 11 40 5 foo.i:7 (set (reg:TF 46 $f14 [ x ])
        (reg:TF 44 $f12 [ x ])) 242 {*movtf_internal} (nil))
foo.i:12:1: internal compiler error: in reload_cse_simplify_operands, at
postreload.c:395


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33635

[Bug target/33635] Bootstrap broken on mips-sgi-irix6.5

[rsandifo at gcc dot gnu dot org]

------- Comment #5 from rsandifo at gcc dot gnu dot org  2007-10-04 20:21 -------
Created an attachment (id=14297)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=14297&action=view)
patch for comment #4

Ah yes, this is the old "moves of cost 2 don't need reloads" thing.
Could you try the attached patch?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33635

[Bug target/33635] Bootstrap broken on mips-sgi-irix6.5

[fxcoudert at gcc dot gnu dot org]

------- Comment #6 from fxcoudert at gcc dot gnu dot org  2007-10-05 07:52 -------
(In reply to comment #5)
> Ah yes, this is the old "moves of cost 2 don't need reloads" thing.
> Could you try the attached patch?

Bootstrap completed (C + Fortran) with this patch applied. Thanks.


-- 

fxcoudert at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |NEW
   Last reconfirmed|2007-10-03 18:39:04         |2007-10-05 07:52:35
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33635

[Bug target/33635] Bootstrap broken on mips-sgi-irix6.5

[rsandifo at gcc dot gnu dot org]

------- Comment #7 from rsandifo at gcc dot gnu dot org  2007-10-05 08:34 -------
Subject: Bug 33635

Author: rsandifo
Date: Fri Oct  5 08:34:01 2007
New Revision: 129031

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=129031
Log:
gcc/
        PR target/33635
        * config/mips/mips.c (mips_register_move_cost): Rewrite to use
        subset checks.  Make the cost of FPR -> FPR moves depend on
        mips_mode_ok_for_mov_fmt_p.

gcc/testsuite/
        PR target/33635
        * gcc.target/mips/pr33635-1.c: New test.

Added:
    trunk/gcc/testsuite/gcc.target/mips/pr33635-1.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/mips/mips.c
    trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33635

[Bug target/33635] Bootstrap broken on mips-sgi-irix6.5

[rsandifo at gcc dot gnu dot org]

------- Comment #8 from rsandifo at gcc dot gnu dot org  2007-10-05 08:42 -------
Thanks for testing.  I included some more general cleanups in the
patch and committed to mainline.


-- 

rsandifo at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33635

[Bug target/33635] [4.3 Regression] Bootstrap broken on mips-sgi-irix6.5

[pinskia at gcc dot gnu dot org]

-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |ice-on-valid-code
            Summary|Bootstrap broken on mips-   |[4.3 Regression] Bootstrap
                   |sgi-irix6.5                 |broken on mips-sgi-irix6.5
   Target Milestone|---                         |4.3.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33635