[Bug fortran/33689] New: [Regression 4.3] Array with constant bound rejected as automatic array

[Bug fortran/33689] New: [Regression 4.3] Array with constant bound rejected as automatic array

[burnus at gcc dot gnu dot org]

The following program is valid and compiles with GCC 4.2.x. However, using
today's 4.3.0 it is rejected with the message:

    REAL, save :: c(0:(lmaxd+1)*(lmaxd+1))
                                         1
Error: automatic object 'c' at (1) cannot have the SAVE attribute

Obviously, 'C' is not an automatic object but has constant bounds and can thus
have the SAVE attribute.

  subroutine grylmr()
    integer, parameter :: lmaxd = 20
    REAL, save :: c(0:(lmaxd+1)*(lmaxd+1))
  end subroutine grylmr
end


-- 
           Summary: [Regression 4.3] Array with constant bound rejected as
                    automatic array
           Product: gcc
           Version: 4.3.0
            Status: UNCONFIRMED
          Keywords: rejects-valid
          Severity: normal
          Priority: P3
         Component: fortran
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: burnus at gcc dot gnu dot org
OtherBugsDependingO 32834
             nThis:


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33689

[Bug fortran/33689] [Regression 4.3] Array with constant bound rejected as automatic array

[burnus at gcc dot gnu dot org]

------- Comment #1 from burnus at gcc dot gnu dot org  2007-10-08 09:07 -------
Fails:
  2007-10-08-r129121
Works:
  2007-09-27-r128828


-- 

burnus at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to fail|                            |4.3.0
      Known to work|                            |4.2.1 4.1.3


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33689

[Bug fortran/33689] [Regression 4.3] Array with constant bound rejected as automatic array

[dominiq at lps dot ens dot fr]

------- Comment #2 from dominiq at lps dot ens dot fr  2007-10-08 10:11 -------
works with revision 129038 (20071005).


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33689

[Bug fortran/33689] [Regression 4.3] Array with constant bound rejected as automatic array

[burnus at gcc dot gnu dot org]

------- Comment #3 from burnus at gcc dot gnu dot org  2007-10-08 17:58 -------
Works: r129068; fails: r129069.

http://gcc.gnu.org/ml/gcc-cvs/2007-10/msg00174.html

r129069 | tobi | 2007-10-07 13:45:15 +0200 (So, 07 Okt 2007) | 14 lines

PR 20851
fortran/
* expr.c (check_inquiry): Typo fix in error message.
(check_init_expr): Same * 3.
(check_restricted): Verify that no dummy arguments appear in
restricted expressions in ELEMENTAL procedures.
* resolve.c (resolve_fl_variable): Exchange order of checks to
avoid side-effect.


-- 

burnus at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tobi at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33689

[Bug fortran/33689] [Regression 4.3] Array with constant bound rejected as automatic array

[Tobias dot Schlueter at physik dot uni-muenchen dot de]

------- Comment #4 from Tobias dot Schlueter at physik dot uni-muenchen dot de  2007-10-08 18:02 -------
Subject: Re:  [Regression 4.3] Array with constant bound
 rejected as automatic array

burnus at gcc dot gnu dot org wrote:
> ------- Comment #3 from burnus at gcc dot gnu dot org  2007-10-08 17:58 -------
> Works: r129068; fails: r129069.
> 
> http://gcc.gnu.org/ml/gcc-cvs/2007-10/msg00174.html
> 
> r129069 | tobi | 2007-10-07 13:45:15 +0200 (So, 07 Okt 2007) | 14 lines
> 
> PR 20851
> fortran/
> * expr.c (check_inquiry): Typo fix in error message.
> (check_init_expr): Same * 3.
> (check_restricted): Verify that no dummy arguments appear in
> restricted expressions in ELEMENTAL procedures.
> * resolve.c (resolve_fl_variable): Exchange order of checks to
> avoid side-effect.
> 
> 
Just great, looks like we were relying on a side-effect before.

I'll have a look.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33689

[Bug fortran/33689] [Regression 4.3] Array with constant bound rejected as automatic array

[tobi at gcc dot gnu dot org]

------- Comment #5 from tobi at gcc dot gnu dot org  2007-10-08 18:25 -------
I think I have a fix.  Needs some more testing, though.


-- 

tobi at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |tobi at gcc dot gnu dot org
                   |dot org                     |
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2007-10-08 18:25:27
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33689

[Bug fortran/33689] [Regression 4.3] Array with constant bound rejected as automatic array

[patchapp at dberlin dot org]

------- Comment #6 from patchapp at dberlin dot org  2007-10-08 20:26 -------
Subject: Bug number PR33689

A patch for this bug has been added to the patch tracker.
The mailing list url for the patch is
http://gcc.gnu.org/ml/gcc-patches/2007-10/msg00439.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33689

[Bug fortran/33689] [Regression 4.3] Array with constant bound rejected as automatic array

[tobi at gcc dot gnu dot org]

------- Comment #7 from tobi at gcc dot gnu dot org  2007-10-08 20:54 -------
Subject: Bug 33689

Author: tobi
Date: Mon Oct  8 20:54:47 2007
New Revision: 129139

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=129139
Log:
PR fortran/33689
fortran/
* resolve.c (gfc_resolve_expr): Fix indentation.
(resolve_fl_variable_derived): Rename argument.
(resolve_fl_variable): Fix case in message.  Clarify logic.
Correctly simplify array bounds.
testsuite/
* gfortran.dg/spec_expr_5.f90: New.

Added:
    trunk/gcc/testsuite/gfortran.dg/spec_expr_5.f90
Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/resolve.c
    trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33689

[Bug fortran/33689] [Regression 4.3] Array with constant bound rejected as automatic array

[tobi at gcc dot gnu dot org]

------- Comment #8 from tobi at gcc dot gnu dot org  2007-10-08 22:10 -------
Fixed.


-- 

tobi at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.3.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33689