[Bug ada/33722] New: putenv() is made posix-conformant on FreeBSD 7.x

[Bug ada/33722] New: putenv() is made posix-conformant on FreeBSD 7.x

[kostikbel at ukr dot net]

The putenv() in the FreeBSD 7.x is made posix-conforming, that means
that the function does not make the copy of the argument string for entering
it into the environment.

As consequence, gcc/ada/env.c, __gnat_setenv() function shall not call
free() on the malloc'ed string. Otherwise, memory of the environment
strings become corrupted. In particular, bootstrap cannot proceed because
gnat tools segfaults.


-- 
           Summary: putenv() is made posix-conformant on FreeBSD 7.x
           Product: gcc
           Version: 4.2.2
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: ada
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: kostikbel at ukr dot net
 GCC build triplet: i386-pc-freebsd7
  GCC host triplet: i386-pc-freebsd7
GCC target triplet: i386-pc-freebsd7


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33722

[Bug ada/33722] putenv() is made posix-conformant on FreeBSD 7.x

[kostikbel at ukr dot net]

------- Comment #1 from kostikbel at ukr dot net  2007-10-10 08:16 -------
Created an attachment (id=14335)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=14335&action=view)
Fix for free() after putenv() on FreeBSD 7.x

The patch allowed me to bootstrap gcc 4.2.2 on the FreeBSD 7.x with
gnat enabled.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33722

[Bug ada/33722] putenv() is made posix-conformant on FreeBSD 7.x

[charlet at adacore dot com]

------- Comment #2 from charlet at adacore dot com  2007-10-10 08:18 -------
Subject: Re:  putenv() is made posix-conformant on FreeBSD 7.x

> Created an attachment (id=14335)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=14335&action=view)
>  --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=14335&action=view)
> Fix for free() after putenv() on FreeBSD 7.x
> 
> The patch allowed me to bootstrap gcc 4.2.2 on the FreeBSD 7.x with
> gnat enabled.

Patch looks good to me. OK for 4.2 branch and trunk.

Arno


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33722

Re: [Bug ada/33722] putenv() is made posix-conformant on FreeBSD 7.x

[Arnaud Charlet]

> Created an attachment (id=14335)
>  --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=14335&action=view)
> Fix for free() after putenv() on FreeBSD 7.x
> 
> The patch allowed me to bootstrap gcc 4.2.2 on the FreeBSD 7.x with
> gnat enabled.

Patch looks good to me. OK for 4.2 branch and trunk.

Arno

[Bug ada/33722] putenv() is made posix-conformant on FreeBSD 7.x

[sam at gcc dot gnu dot org]

------- Comment #3 from sam at gcc dot gnu dot org  2007-12-01 11:52 -------
Subject: Bug 33722

Author: sam
Date: Sat Dec  1 11:52:42 2007
New Revision: 130555

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=130555
Log:
2007-12-01  Kostik Belousov  <kostikbel@ukr.net>

    gcc/ada/
        PR ada/33722
        * env.c (__gnat_setenv): FreeBSD 7 has a POSIX conformant putenv()
        and its argument must not be free()ed.


Modified:
    trunk/gcc/ada/ChangeLog
    trunk/gcc/ada/env.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33722

[Bug ada/33722] putenv() is made posix-conformant on FreeBSD 7.x

[sam at gcc dot gnu dot org]

------- Comment #4 from sam at gcc dot gnu dot org  2007-12-01 12:03 -------
Subject: Bug 33722

Author: sam
Date: Sat Dec  1 12:03:42 2007
New Revision: 130556

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=130556
Log:
2007-12-01  Kostik Belousov  <kostikbel@ukr.net>

    gcc/ada/
        PR ada/33722
        * env.c (__gnat_setenv): FreeBSD 7 has a POSIX conformant putenv()
        and its argument must not be free()ed.


Modified:
    branches/gcc-4_2-branch/gcc/ada/ChangeLog
    branches/gcc-4_2-branch/gcc/ada/env.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33722

[Bug ada/33722] putenv() is made posix-conformant on FreeBSD 7.x

[sam at gcc dot gnu dot org]

------- Comment #5 from sam at gcc dot gnu dot org  2007-12-01 12:04 -------
The patch has been committed in SVN trunk and in the 4.2 branch.


-- 

sam at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33722