[Bug tree-optimization/33812] New: Vectorizer testcases fail

[Bug tree-optimization/33812] New: Vectorizer testcases fail

[irar at il dot ibm dot com]

With current trunk (r129433) vectorizer testcases fail on powerpc64:

FAIL: gcc.dg/vect/vect-64.c (internal compiler error)
FAIL: gcc.dg/vect/vect-64.c (test for excess errors)
WARNING: gcc.dg/vect/vect-64.c compilation failed to produce executable
FAIL: gcc.dg/vect/vect-68.c (internal compiler error)
FAIL: gcc.dg/vect/vect-68.c (test for excess errors)
WARNING: gcc.dg/vect/vect-68.c compilation failed to produce executable
FAIL: gcc.dg/vect/vect-70.c (internal compiler error)
FAIL: gcc.dg/vect/vect-70.c (test for excess errors)
WARNING: gcc.dg/vect/vect-70.c compilation failed to produce executable
FAIL: gcc.dg/vect/no-scevccp-slp-31.c (internal compiler error)
FAIL: gcc.dg/vect/no-scevccp-slp-31.c (test for excess errors)
WARNING: gcc.dg/vect/no-scevccp-slp-31.c compilation failed to produce
executable

The tests ICE:
vect-64.c: In function גmain1ג:
vect-64.c:75: internal compiler error: in change_address_1, at emit-rtl.c:1888
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://gcc.gnu.org/bugs.html> for instructions.

#0  change_address_1 (memref=0xf7e44f40, mode=SImode, addr=0xf7e44f30,
validate=1) at ../../gcc/gcc/emit-rtl.c:1888
#1  0x10179fd4 in validize_mem (ref=0xf7e44f40) at ../../gcc/gcc/explow.c:546
#2  0x101a88e8 in emit_move_insn (x=0xf7e38e00, y=0xf7e44f40) at
../../gcc/gcc/expr.c:3403
#3  0x105543e4 in rs6000_emit_epilogue (sibcall=0) at
../../gcc/gcc/config/rs6000/rs6000.c:16095
#4  0x28000488 in ?? ()
#5  0x105ec5ec in gen_epilogue () at
../../gcc/gcc/config/rs6000/rs6000.md:14476
#6  0x102242b4 in rest_of_handle_thread_prologue_and_epilogue () at
../../gcc/gcc/function.c:5298
#7  0x102a7af4 in execute_one_pass (pass=0x108f6a78) at
../../gcc/gcc/passes.c:1117
#8  0x102a7d68 in execute_pass_list (pass=0x108f6a78) at
../../gcc/gcc/passes.c:1170
#9  0x102a7d80 in execute_pass_list (pass=0x108f6ee8) at
../../gcc/gcc/passes.c:1171
#10 0x102a7d80 in execute_pass_list (pass=0x108f6eb4) at
../../gcc/gcc/passes.c:1171
#11 0x103ae68c in tree_rest_of_compilation (fndecl=0xf7dbc100) at
../../gcc/gcc/tree-optimize.c:404
#12 0x105705fc in cgraph_expand_function (node=0xf7dbc300) at
../../gcc/gcc/cgraphunit.c:1060
#13 0x105728c4 in cgraph_optimize () at ../../gcc/gcc/cgraphunit.c:1123
#14 0x10017914 in c_write_global_declarations () at ../../gcc/gcc/c-decl.c:8077
#15 0x1033fff0 in toplev_main (argc=<value optimized out>, argv=<value
optimized out>) at ../../gcc/gcc/toplev.c:1055
#16 0x1009e370 in main (argc=0, argv=0x0) at ../../gcc/gcc/main.c:35

This doesn't happen with r129290.

Ira


-- 
           Summary: Vectorizer testcases fail
           Product: gcc
           Version: 4.3.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: tree-optimization
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: irar at il dot ibm dot com
 GCC build triplet: powerpc64-suse-linux
  GCC host triplet: powerpc64-suse-linux
GCC target triplet: powerpc64-suse-linux


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33812

[Bug tree-optimization/33812] Vectorizer testcases fail

[dominiq at lps dot ens dot fr]

------- Comment #1 from dominiq at lps dot ens dot fr  2007-10-18 13:40 -------
This seems to be a duplicate of PR33806, at least the ICE occurs at the same
point.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33812

[Bug tree-optimization/33812] Vectorizer testcases fail

[dominiq at lps dot ens dot fr]

------- Comment #2 from dominiq at lps dot ens dot fr  2007-10-18 14:32 -------
The same occurs in 32 bit mode, see for instance

http://gcc.gnu.org/ml/gcc-testresults/2007-10/msg00804.html

[karma] dominiq/Desktop% gfc -O2 -ftree-vectorize -maltivec
/opt/gcc/_gcc-clean/gcc/testsuite/gcc.dg/vect/costmodel/ppc/costmodel-vect-68d.c 

/opt/gcc/_gcc-clean/gcc/testsuite/gcc.dg/vect/costmodel/ppc/costmodel-vect-68d.c:
In function 'main1':
/opt/gcc/_gcc-clean/gcc/testsuite/gcc.dg/vect/costmodel/ppc/costmodel-vect-68d.c:39:
internal compiler error: in change_address_1, at emit-rtl.c:1888


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33812

[Bug tree-optimization/33812] Vectorizer testcases fail

[dominiq at lps dot ens dot fr]

------- Comment #3 from dominiq at lps dot ens dot fr  2007-10-18 14:37 -------
The PR started between revisions 129388 (works) and 129401 (does not).


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33812

[Bug tree-optimization/33812] Vectorizer testcases fail

[dominiq at lps dot ens dot fr]

------- Comment #4 from dominiq at lps dot ens dot fr  2007-10-18 16:40 -------
May I guess revision 129400?

--- trunk/gcc/ChangeLog 2007/10/17 00:46:27     129399
+++ trunk/gcc/ChangeLog 2007/10/17 01:05:50     129400
@@ -1,3 +1,10 @@
+2007-10-17  Alan Modra  <amodra@bigpond.net.au>
+
+       * config/rs6000/rs6000.c (rs6000_emit_epilogue): Correct
+       altivec sp_offset.  Rearrange sp_offset assignments to
+       correspond to stack adjustments.  Use frame_reg_rtx for
+       SPE register restores.  Correct SPE stack adjustment.
+
 2007-10-17  Manuel Lopez-Ibanez  <manu@gcc.gnu.org>
        * builtins.c (gimplify_va_arg_expr): Use inform for help message.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33812

[Bug target/33812] [4.3 Regression] Vectorizer testcases fail

[pinskia at gcc dot gnu dot org]

------- Comment #5 from pinskia at gcc dot gnu dot org  2007-10-18 16:56 -------
Looks like they also appear on ppc-darwin too:

http://gcc.gnu.org/ml/gcc-testresults/2007-10/msg00818.html


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pinskia at gcc dot gnu dot
                   |                            |org
           Severity|normal                      |critical
             Status|UNCONFIRMED                 |NEW
          Component|tree-optimization           |target
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2007-10-18 16:56:18
               date|                            |
            Summary|Vectorizer testcases fail   |[4.3 Regression] Vectorizer
                   |                            |testcases fail
   Target Milestone|---                         |4.3.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33812

[Bug target/33812] [4.3 Regression] Vectorizer testcases fail

[dominiq at lps dot ens dot fr]

------- Comment #6 from dominiq at lps dot ens dot fr  2007-10-19 16:39 -------
See comment#2 of PR33806. I did not tested the gcc side.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33812

[Bug target/33812] [4.3 Regression] Vectorizer testcases fail

[dominiq at lps dot ens dot fr]

------- Comment #7 from dominiq at lps dot ens dot fr  2007-10-19 21:21 -------
After reverting the changes made in revision 129400 (otherwise revision 129491
+ gfortran patches), the gcc testsuite gives:

Target: powerpc-apple-darwin8

        === gcc tests ===

Schedule of variations:
    unix

XPASS: gcc.dg/20020103-1.c scan-assembler-not LC[0-9]
FAIL: gcc.dg/initpri1.c execution test
FAIL: gcc.dg/memcpy-1.c scan-tree-dump-times nasty_local 0
FAIL: gcc.dg/ssp-2.c (test for excess errors)
FAIL: gcc.dg/tree-ssa/ssa-fre-4.c scan-tree-dump Replaced \(char\) .*with 
XPASS: gcc.dg/tree-ssa/update-threading.c scan-tree-dump-times Invalid sum 0
FAIL: gcc.dg/vect/costmodel/ppc/costmodel-vect-31d.c scan-tree-dump-times
vectorization not profitable 1
FAIL: gcc.dg/vect/costmodel/ppc/costmodel-vect-31d.c scan-tree-dump-times
vectorized 1 loops 0
FAIL: gcc.dg/vect/costmodel/ppc/costmodel-vect-68d.c scan-tree-dump-times
vectorization not profitable 1
FAIL: gcc.dg/vect/costmodel/ppc/costmodel-vect-68d.c scan-tree-dump-times
vectorized 1 loops 0
FAIL: gcc.dg/vect/section-anchors-pr27770.c (test for excess errors)
FAIL: gcc.dg/vect/section-anchors-vect-69.c (test for excess errors)
FAIL: gcc.dg/vect/section-anchors-vect-69.c scan-tree-dump-times Alignment of
access forced using peeling 4
FAIL: gcc.target/powerpc/parity-1.c scan-assembler popcntb
FAIL: gcc.target/powerpc/popcount-1.c scan-assembler popcntb

        === gcc Summary ===

# of expected passes            46942
# of unexpected failures        13
# of unexpected successes       2
# of expected failures          166
# of untested testcases         35
# of unsupported tests          419
/opt/gcc/darwin_buildw/gcc/xgcc  version 4.3.0 20071019 (experimental) (GCC) 

This can be compared to

http://gcc.gnu.org/ml/gcc-testresults/2007-10/msg00869.html


-- 

dominiq at lps dot ens dot fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |amodra at bigpond dot net
                   |                            |dot au


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33812

[Bug target/33812] [4.3 Regression] Vectorizer testcases fail

[amodra at bigpond dot net dot au]

------- Comment #8 from amodra at bigpond dot net dot au  2007-10-19 23:48 -------
I'm building a current powerpc64 compiler at the moment to verify, but I think
this is because rs6000_emit_epilogue is now generating mems with address
sp+offset where offset is too large.  Prior to my patch we restored altivec
regs and vrsave from the wrong address...

Fix is to move the block of code restoring vrsave to after we have restored the
old stack pointer.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33812

[Bug target/33812] [4.3 Regression] Vectorizer testcases fail

[amodra at bigpond dot net dot au]

-- 

amodra at bigpond dot net dot au changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |amodra at bigpond dot net
                   |dot org                     |dot au
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2007-10-18 16:56:18         |2007-10-19 23:50:43
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33812

[Bug target/33812] [4.3 Regression] Vectorizer testcases fail

[amodra at bigpond dot net dot au]

------- Comment #9 from amodra at bigpond dot net dot au  2007-10-19 23:51 -------
*** Bug 33806 has been marked as a duplicate of this bug. ***


-- 

amodra at bigpond dot net dot au changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dominiq at lps dot ens dot
                   |                            |fr


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33812

[Bug target/33812] [4.3 Regression] Vectorizer testcases fail

[amodra at bigpond dot net dot au]

------- Comment #10 from amodra at bigpond dot net dot au  2007-10-20 00:08 -------
Prior to my patch:

.L.main1:
        mflr 0
        mr 12,1
        std 0,16(1)
        lis 0,0xffff
        ori 0,0,4656
        stdux 1,1,0
        mfvrsave 0
        stw 0,-4(12)
so we store vrsave at frame_top-4
...
        lwz 12,-4(1)
        li 3,0
        mtvrsave 12
but here we restore from frame_top+0xfff...f4656-4
        ld 1,0(1)
because the frame isn't popped until here.
        ld 0,16(1)
        mtlr 0
        blr


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33812

[Bug target/33812] [4.3 Regression] Vectorizer testcases fail

[amodra at gcc dot gnu dot org]

------- Comment #11 from amodra at gcc dot gnu dot org  2007-10-20 13:11 -------
Subject: Bug 33812

Author: amodra
Date: Sat Oct 20 13:11:14 2007
New Revision: 129511

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=129511
Log:
        PR target/33812
        * config/rs6000/rs6000.c (rs6000_emit_epilogue): Revert 2007-05-16
        change for vrsave, ie restore after frame pop.


Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/rs6000/rs6000.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33812

[Bug target/33812] [4.3 Regression] ICE from epilogue vrsave code

[amodra at bigpond dot net dot au]

------- Comment #12 from amodra at bigpond dot net dot au  2007-10-20 13:12 -------
Patch applied


-- 

amodra at bigpond dot net dot au changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
            Summary|[4.3 Regression] Vectorizer |[4.3 Regression] ICE from
                   |testcases fail              |epilogue vrsave code


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33812