public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug fortran/33917] New: Rejects valid procedure declarations
@ 2007-10-26 21:55 fxcoudert at gcc dot gnu dot org
2007-10-26 22:00 ` [Bug fortran/33917] " burnus at gcc dot gnu dot org
` (10 more replies)
0 siblings, 11 replies; 12+ messages in thread
From: fxcoudert at gcc dot gnu dot org @ 2007-10-26 21:55 UTC (permalink / raw)
To: gcc-bugs
This one is a heisenbug, which showed up in the testsuite while testing a patch
but is also present on trunk:
$ cat proc_decl_2.f90
program s
implicit none
procedure() :: q2
procedure() :: q3
procedure() :: q5
procedure(sub) :: p4
procedure(p4) :: p6
contains
subroutine sub
end subroutine
end program s
$ gfortran proc_decl_2.f90
proc_decl_2.f90:7.21:
procedure(p4) :: p6
1
Error: Interface 'p4' of procedure 'p6' at (1) must be explicit
--
Summary: Rejects valid procedure declarations
Product: gcc
Version: 4.3.0
Status: UNCONFIRMED
Keywords: rejects-valid
Severity: normal
Priority: P3
Component: fortran
AssignedTo: unassigned at gcc dot gnu dot org
ReportedBy: fxcoudert at gcc dot gnu dot org
GCC build triplet: x86_64-unknown-linux-gnu
GCC host triplet: x86_64-unknown-linux-gnu
GCC target triplet: x86_64-unknown-linux-gnu
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33917
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug fortran/33917] Rejects valid procedure declarations
2007-10-26 21:55 [Bug fortran/33917] New: Rejects valid procedure declarations fxcoudert at gcc dot gnu dot org
@ 2007-10-26 22:00 ` burnus at gcc dot gnu dot org
2007-10-26 23:14 ` burnus at gcc dot gnu dot org
` (9 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: burnus at gcc dot gnu dot org @ 2007-10-26 22:00 UTC (permalink / raw)
To: gcc-bugs
------- Comment #1 from burnus at gcc dot gnu dot org 2007-10-26 21:59 -------
As depending which line is commented out or not, the bug disappears or appears,
my educated guess would be that one does not properly walk a tree and thus not
all leafs are found.
--
burnus at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |burnus at gcc dot gnu dot
| |org
Status|UNCONFIRMED |NEW
Ever Confirmed|0 |1
Last reconfirmed|0000-00-00 00:00:00 |2007-10-26 21:59:55
date| |
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33917
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug fortran/33917] Rejects valid procedure declarations
2007-10-26 21:55 [Bug fortran/33917] New: Rejects valid procedure declarations fxcoudert at gcc dot gnu dot org
2007-10-26 22:00 ` [Bug fortran/33917] " burnus at gcc dot gnu dot org
@ 2007-10-26 23:14 ` burnus at gcc dot gnu dot org
2007-10-27 15:30 ` burnus at gcc dot gnu dot org
` (8 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: burnus at gcc dot gnu dot org @ 2007-10-26 23:14 UTC (permalink / raw)
To: gcc-bugs
------- Comment #2 from burnus at gcc dot gnu dot org 2007-10-26 23:14 -------
procedure(sub) :: p4
procedure(p4) :: p6
The problem is that first sub needs to be resolved for p4 and then p4 before
p6.
The problem is that "procedure(p4) :: p6" is checked before "procedure(sub) ::
p4" and that thus for "p6" sym->interface->attr.if_source == IFSRC_UNKNOWN
instead of IFSRC_DECL.
This seems to be a tree-walking problem. The solution is to make sure the
interfaces are resolved first such that the following holds true:
/* Get the attributes from the interface (now resolved). */
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33917
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug fortran/33917] Rejects valid procedure declarations
2007-10-26 21:55 [Bug fortran/33917] New: Rejects valid procedure declarations fxcoudert at gcc dot gnu dot org
2007-10-26 22:00 ` [Bug fortran/33917] " burnus at gcc dot gnu dot org
2007-10-26 23:14 ` burnus at gcc dot gnu dot org
@ 2007-10-27 15:30 ` burnus at gcc dot gnu dot org
2007-10-28 19:57 ` burnus at gcc dot gnu dot org
` (7 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: burnus at gcc dot gnu dot org @ 2007-10-27 15:30 UTC (permalink / raw)
To: gcc-bugs
------- Comment #3 from burnus at gcc dot gnu dot org 2007-10-27 15:30 -------
Mine - I have patch.
--
burnus at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|unassigned at gcc dot gnu |burnus at gcc dot gnu dot
|dot org |org
Status|NEW |ASSIGNED
Last reconfirmed|2007-10-26 21:59:55 |2007-10-27 15:30:19
date| |
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33917
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug fortran/33917] Rejects valid procedure declarations
2007-10-26 21:55 [Bug fortran/33917] New: Rejects valid procedure declarations fxcoudert at gcc dot gnu dot org
` (2 preceding siblings ...)
2007-10-27 15:30 ` burnus at gcc dot gnu dot org
@ 2007-10-28 19:57 ` burnus at gcc dot gnu dot org
2007-10-29 20:04 ` [Bug fortran/33917] Rejects valid PROCEDURE declarations burnus at gcc dot gnu dot org
` (6 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: burnus at gcc dot gnu dot org @ 2007-10-28 19:57 UTC (permalink / raw)
To: gcc-bugs
------- Comment #4 from burnus at gcc dot gnu dot org 2007-10-28 19:57 -------
See also:
http://groups.google.com/group/comp.lang.fortran/browse_thread/thread/2eea7b997482aa5e/
The answers decides whether
http://gcc.gnu.org/ml/fortran/2007-10/msg00362.html
or
http://gcc.gnu.org/ml/fortran/2007-10/msg00371.html
is the correct approach.
Additionally, we probably need to fix gfortran for the second example.
(The third question there is related to PR 33162.)
--
burnus at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
GCC host triplet|x86_64-unknown-linux-gnu |
GCC target triplet|x86_64-unknown-linux-gnu |
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33917
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug fortran/33917] Rejects valid PROCEDURE declarations
2007-10-26 21:55 [Bug fortran/33917] New: Rejects valid procedure declarations fxcoudert at gcc dot gnu dot org
` (3 preceding siblings ...)
2007-10-28 19:57 ` burnus at gcc dot gnu dot org
@ 2007-10-29 20:04 ` burnus at gcc dot gnu dot org
2007-10-30 3:45 ` patchapp at dberlin dot org
` (5 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: burnus at gcc dot gnu dot org @ 2007-10-29 20:04 UTC (permalink / raw)
To: gcc-bugs
------- Comment #5 from burnus at gcc dot gnu dot org 2007-10-29 20:04 -------
This gets difficult.
Using
procedure(p4) :: p6
procedure(sub) :: p4
is invalid per
"C1212 (R1215) [...] If name is declared by a procedure-declaration-stmt it
shall be previously declared."
("name" = interface-name)
However, depending how the tree is parsed, it is rejected or not (rather
independent of my patch).
Using Janus' patch, it is always accepted.
--
burnus at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Rejects valid procedure |Rejects valid PROCEDURE
|declarations |declarations
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33917
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug fortran/33917] Rejects valid PROCEDURE declarations
2007-10-26 21:55 [Bug fortran/33917] New: Rejects valid procedure declarations fxcoudert at gcc dot gnu dot org
` (4 preceding siblings ...)
2007-10-29 20:04 ` [Bug fortran/33917] Rejects valid PROCEDURE declarations burnus at gcc dot gnu dot org
@ 2007-10-30 3:45 ` patchapp at dberlin dot org
2007-11-08 15:28 ` burnus at gcc dot gnu dot org
` (4 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: patchapp at dberlin dot org @ 2007-10-30 3:45 UTC (permalink / raw)
To: gcc-bugs
------- Comment #6 from patchapp at dberlin dot org 2007-10-30 03:45 -------
Subject: Bug number PR 33917
A patch for this bug has been added to the patch tracker.
The mailing list url for the patch is
http://gcc.gnu.org/ml/gcc-patches/2007-10/msg01622.html
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33917
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug fortran/33917] Rejects valid PROCEDURE declarations
2007-10-26 21:55 [Bug fortran/33917] New: Rejects valid procedure declarations fxcoudert at gcc dot gnu dot org
` (5 preceding siblings ...)
2007-10-30 3:45 ` patchapp at dberlin dot org
@ 2007-11-08 15:28 ` burnus at gcc dot gnu dot org
2007-11-08 15:36 ` burnus at gcc dot gnu dot org
` (3 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: burnus at gcc dot gnu dot org @ 2007-11-08 15:28 UTC (permalink / raw)
To: gcc-bugs
------- Comment #7 from burnus at gcc dot gnu dot org 2007-11-08 15:28 -------
Subject: Bug 33917
Author: burnus
Date: Thu Nov 8 15:28:30 2007
New Revision: 130002
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=130002
Log:
2007-11-08 Tobias Burnus <burnus@net-b.de>
PR fortran/33917
* interface.c (check_sym_interfaces): Disallow PROCEDURE-declared
procedures for MODULE PROCEDURE.
* decl.c (match_procedure_in_interface): Do not mark as procedure.
2007-11-08 Tobias Burnus <burnus@net-b.de>
PR fortran/33917
* gfortran.dg/proc_decl_5.f90: New.
* gfortran.dg/proc_decl_6.f90: New.
Added:
trunk/gcc/testsuite/gfortran.dg/proc_decl_5.f90
trunk/gcc/testsuite/gfortran.dg/proc_decl_6.f90
Modified:
trunk/gcc/fortran/ChangeLog
trunk/gcc/fortran/decl.c
trunk/gcc/fortran/interface.c
trunk/gcc/testsuite/ChangeLog
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33917
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug fortran/33917] Rejects valid PROCEDURE declarations
2007-10-26 21:55 [Bug fortran/33917] New: Rejects valid procedure declarations fxcoudert at gcc dot gnu dot org
` (6 preceding siblings ...)
2007-11-08 15:28 ` burnus at gcc dot gnu dot org
@ 2007-11-08 15:36 ` burnus at gcc dot gnu dot org
2007-11-15 12:36 ` patchapp at dberlin dot org
` (2 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: burnus at gcc dot gnu dot org @ 2007-11-08 15:36 UTC (permalink / raw)
To: gcc-bugs
------- Comment #8 from burnus at gcc dot gnu dot org 2007-11-08 15:36 -------
Sorry, the check in was for PR 33917.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33917
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug fortran/33917] Rejects valid PROCEDURE declarations
2007-10-26 21:55 [Bug fortran/33917] New: Rejects valid procedure declarations fxcoudert at gcc dot gnu dot org
` (7 preceding siblings ...)
2007-11-08 15:36 ` burnus at gcc dot gnu dot org
@ 2007-11-15 12:36 ` patchapp at dberlin dot org
2007-11-15 15:12 ` burnus at gcc dot gnu dot org
2007-11-15 15:18 ` burnus at gcc dot gnu dot org
10 siblings, 0 replies; 12+ messages in thread
From: patchapp at dberlin dot org @ 2007-11-15 12:36 UTC (permalink / raw)
To: gcc-bugs
------- Comment #9 from patchapp at dberlin dot org 2007-11-15 12:35 -------
Subject: Bug number PR33917
A patch for this bug has been added to the patch tracker.
The mailing list url for the patch is
http://gcc.gnu.org/ml/gcc-patches/2007-11/msg00842.html
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33917
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug fortran/33917] Rejects valid PROCEDURE declarations
2007-10-26 21:55 [Bug fortran/33917] New: Rejects valid procedure declarations fxcoudert at gcc dot gnu dot org
` (8 preceding siblings ...)
2007-11-15 12:36 ` patchapp at dberlin dot org
@ 2007-11-15 15:12 ` burnus at gcc dot gnu dot org
2007-11-15 15:18 ` burnus at gcc dot gnu dot org
10 siblings, 0 replies; 12+ messages in thread
From: burnus at gcc dot gnu dot org @ 2007-11-15 15:12 UTC (permalink / raw)
To: gcc-bugs
------- Comment #10 from burnus at gcc dot gnu dot org 2007-11-15 15:12 -------
Subject: Bug 33917
Author: burnus
Date: Thu Nov 15 15:12:03 2007
New Revision: 130202
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=130202
Log:
2007-11-15 Tobias Burnus <burnus@net-b.de>
PR fortran/33917
* decl.c (match_procedure_decl): Pre-resolve interface.
* resolve.c (resolve_symbol): Reject interfaces later
declared in procedure statements.
2007-11-15 Tobias Burnus <burnus@net-b.de>
PR fortran/33917
* gfortran.dg/proc_decl_11.f90: New.
Added:
trunk/gcc/testsuite/gfortran.dg/proc_decl_11.f90
Modified:
trunk/gcc/fortran/ChangeLog
trunk/gcc/fortran/decl.c
trunk/gcc/fortran/resolve.c
trunk/gcc/testsuite/ChangeLog
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33917
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug fortran/33917] Rejects valid PROCEDURE declarations
2007-10-26 21:55 [Bug fortran/33917] New: Rejects valid procedure declarations fxcoudert at gcc dot gnu dot org
` (9 preceding siblings ...)
2007-11-15 15:12 ` burnus at gcc dot gnu dot org
@ 2007-11-15 15:18 ` burnus at gcc dot gnu dot org
10 siblings, 0 replies; 12+ messages in thread
From: burnus at gcc dot gnu dot org @ 2007-11-15 15:18 UTC (permalink / raw)
To: gcc-bugs
------- Comment #11 from burnus at gcc dot gnu dot org 2007-11-15 15:18 -------
FIXED on the trunk (4.3.0) [is not part of any branch].
--
burnus at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
GCC build triplet|x86_64-unknown-linux-gnu |
Resolution| |FIXED
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33917
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2007-11-15 15:18 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-10-26 21:55 [Bug fortran/33917] New: Rejects valid procedure declarations fxcoudert at gcc dot gnu dot org
2007-10-26 22:00 ` [Bug fortran/33917] " burnus at gcc dot gnu dot org
2007-10-26 23:14 ` burnus at gcc dot gnu dot org
2007-10-27 15:30 ` burnus at gcc dot gnu dot org
2007-10-28 19:57 ` burnus at gcc dot gnu dot org
2007-10-29 20:04 ` [Bug fortran/33917] Rejects valid PROCEDURE declarations burnus at gcc dot gnu dot org
2007-10-30 3:45 ` patchapp at dberlin dot org
2007-11-08 15:28 ` burnus at gcc dot gnu dot org
2007-11-08 15:36 ` burnus at gcc dot gnu dot org
2007-11-15 12:36 ` patchapp at dberlin dot org
2007-11-15 15:12 ` burnus at gcc dot gnu dot org
2007-11-15 15:18 ` burnus at gcc dot gnu dot org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).