[Bug c++/34055] New: [4.3 regression] ICE with invalid specialization of variadic template

[Bug c++/34055] New: [4.3 regression] ICE with invalid specialization of variadic template

[reichelt at gcc dot gnu dot org]

The following invalid code snippet triggers an ICE on mainline:

=====================================================================
template<typename...> struct A;

template<typename...T> struct A<T*>
{
  void foo();
};

template<typename...T> void A<T*>::foo() {}
=====================================================================

bug.cc:3: error: parameter packs not expanded with `...':
bug.cc:3: note:         'T'
bug.cc:3: error: template parameters not used in partial specialization:
bug.cc:3: error:         'T'
bug.cc:8: internal compiler error: same canonical type node for different types
<typeprefixerror>* and T*
Please submit a full bug report, [etc.]


-- 
           Summary: [4.3 regression] ICE with invalid specialization of
                    variadic template
           Product: gcc
           Version: 4.3.0
            Status: UNCONFIRMED
          Keywords: ice-on-invalid-code, error-recovery, monitored
          Severity: normal
          Priority: P3
         Component: c++
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: reichelt at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34055

[Bug c++/34055] [4.3 regression] ICE with invalid specialization of variadic template

[reichelt at gcc dot gnu dot org]

-- 

reichelt at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.3.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34055

[Bug c++/34055] [4.3 regression] ICE with invalid specialization of variadic template

[reichelt at gcc dot gnu dot org]

------- Comment #1 from reichelt at gcc dot gnu dot org  2007-11-14 20:54 -------
Fixed by the patch for PR34058 et al.


-- 

reichelt at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34055

[Bug c++/34055] [4.3 regression] ICE with invalid specialization of variadic template

[reichelt at gcc dot gnu dot org]

------- Comment #2 from reichelt at gcc dot gnu dot org  2007-12-08 20:50 -------
Trivially modified versions of the testcase - using T& or T() instead of T* -
still fail:

================================================
template<typename...> struct A;

template<typename...T> struct A<T&>
{
  void foo();
};

template<typename...T> void A<T&>::foo() {}
================================================

bug.cc:3: error: parameter packs not expanded with `...':
bug.cc:3: note:         'T'
bug.cc:8: internal compiler error: same canonical type node for different types
<typeprefixerror>& and T&
Please submit a full bug report, [etc.]

================================================
template<typename...> struct A;

template<typename...T> struct A<T()>
{
  void foo();
};

template<typename...T> void A<T()>::foo() {}
================================================

bug.cc:3: error: parameter packs not expanded with `...':
bug.cc:3: note:         'T'
bug.cc:8: internal compiler error: same canonical type node for different types
<typeprefixerror>()() and T ()()
Please submit a full bug report, [etc.]


-- 

reichelt at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |UNCONFIRMED
         Resolution|FIXED                       |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34055

[Bug c++/34055] [4.3 regression] ICE with invalid specialization of variadic template

[dgregor at gcc dot gnu dot org]

-- 

dgregor at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |dgregor at gcc dot gnu dot
                   |dot org                     |org
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2007-12-20 21:02:29
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34055

[Bug c++/34055] [4.3 regression] ICE with invalid specialization of variadic template

[mmitchel at gcc dot gnu dot org]

-- 

mmitchel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34055

[Bug c++/34055] [4.3 regression] ICE with invalid specialization of variadic template

[mmitchel at gcc dot gnu dot org]

-- 

mmitchel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34055

[Bug c++/34055] [4.3 regression] ICE with invalid specialization of variadic template

[dgregor at gcc dot gnu dot org]

------- Comment #3 from dgregor at gcc dot gnu dot org  2008-01-15 16:59 -------
Patch here: http://gcc.gnu.org/ml/gcc-patches/2008-01/msg00650.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34055

[Bug c++/34055] [4.3 regression] ICE with invalid specialization of variadic template

[dgregor at gcc dot gnu dot org]

------- Comment #4 from dgregor at gcc dot gnu dot org  2008-01-15 18:08 -------
Subject: Bug 34055

Author: dgregor
Date: Tue Jan 15 18:08:00 2008
New Revision: 131547

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=131547
Log:
2008-01-15  Douglas Gregor  <doug.gregor@gmail.com>

        PR c++/34051
        PR c++/34055
        PR c++/34102
        PR c++/34103
        * typeck.c (check_return_expr): If there are bare parameter packs
        in the return value, set it to error_mark_node.
        * tree.c (cp_walk_subtrees): Walk USING_DECL nodes.
        * pt.c (find_parameter_packs_r): Look at the type of
        IDENTIFIER_NODEs (e.g., for user-defined conversions).
        (check_for_bare_parameter_packs): Flip the result: now returns
        TRUE when there were bare parameter packs, FALSE otherwise.
        (push_template_decl_real): Deal with flipped result of
        check_for_bare_parameter_packs.
        * semantics.c (finish_cond): If there are bare parameter packs in
        the conditional, set it to error_mark_node.
        (finish_expr_stmt): If there are bare parameter packs in the
        expression, set it to error_mark_node.
        (finish_for_expr): Ditto.
        (finish_switch_cond): If there are bare parameter packs in
        the conditional, set it to error_mark_node.
        (finish_mem_initializers): If there are bare parameter packs in
        the member initializer, set it to error_mark_node.
        (finish_member_declaration): Check the attributes of the
        declaration for bare parameter packs, and remove the attributes if
        any have bare parameter packs.
        * parser.c (cp_parser_using_declaration): Check the using
        declaration for bare parameter packs.
        (cp_parser_base_clause): If there are bare parameter packs in a
        base specifier, don't add it to the chain.

2008-01-15  Douglas Gregor  <doug.gregor@gmail.com>

        PR c++/34051
        PR c++/34055
        PR c++/34102
        PR c++/34103
        * g++.dg/cpp0x/vt-34051-2.C: New.
        * g++.dg/cpp0x/vt-34102.C: New.
        * g++.dg/cpp0x/vt-34051.C: New.
        * g++.dg/cpp0x/vt-34055.C: New.
        * g++.dg/cpp0x/vt-34103.C: New.


Added:
    trunk/gcc/testsuite/g++.dg/cpp0x/vt-34051-2.C
    trunk/gcc/testsuite/g++.dg/cpp0x/vt-34051.C
    trunk/gcc/testsuite/g++.dg/cpp0x/vt-34055.C
    trunk/gcc/testsuite/g++.dg/cpp0x/vt-34102.C
    trunk/gcc/testsuite/g++.dg/cpp0x/vt-34103.C
Modified:
    trunk/gcc/cp/ChangeLog
    trunk/gcc/cp/parser.c
    trunk/gcc/cp/pt.c
    trunk/gcc/cp/semantics.c
    trunk/gcc/cp/tree.c
    trunk/gcc/cp/typeck.c
    trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34055

[Bug c++/34055] [4.3 regression] ICE with invalid specialization of variadic template

[dgregor at gcc dot gnu dot org]

------- Comment #5 from dgregor at gcc dot gnu dot org  2008-01-15 18:09 -------
Fixed in mainline


-- 

dgregor at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34055

[Bug c++/34055] [4.3 regression] ICE with invalid specialization of variadic template

[reichelt at gcc dot gnu dot org]

------- Comment #6 from reichelt at gcc dot gnu dot org  2008-01-16 23:06 -------
This is still not fixed.

The testcase in the testsuite - trunk/gcc/testsuite/g++.dg/cpp0x/vt-34055.C -
is only covers the original testcase (which was fixed quite a while ago).
The other two testcases from comment #2 still fail.

Btw, as this is only error-recovery, the bug should probably be downgraded to
P4.


-- 

reichelt at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34055

[Bug c++/34055] [4.3 regression] ICE with invalid specialization of variadic template

[dgregor at gcc dot gnu dot org]

------- Comment #7 from dgregor at gcc dot gnu dot org  2008-01-28 22:05 -------
Darn! Mine again.


-- 

dgregor at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |ASSIGNED
   Last reconfirmed|2007-12-20 21:02:29         |2008-01-28 22:05:37
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34055

[Bug c++/34055] [4.3 regression] ICE with invalid specialization of variadic template

[dgregor at gcc dot gnu dot org]

------- Comment #8 from dgregor at gcc dot gnu dot org  2008-01-29 14:01 -------
Subject: Bug 34055

Author: dgregor
Date: Tue Jan 29 13:59:59 2008
New Revision: 131938

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=131938
Log:
2008-01-29  Douglas Gregor  <doug.gregor@gmail.com>

        PR c++/34055
        PR c++/34103
        PR c++/34219
        PR c++/34606
        PR c++/34753
        PR c++/34754
        PR c++/34755
        PR c++/34919
        PR c++/34961
        * c-pretty-print.c (pp_c_type_qualifier_list): Don't try to print
        qualifiers for an ERROR_MARK_NODE or a NULL_TREE.


2008-01-29  Douglas Gregor  <doug.gregor@gmail.com>

        PR c++/34055
        PR c++/34103
        PR c++/34219
        PR c++/34606
        PR c++/34753
        PR c++/34754
        PR c++/34755
        PR c++/34919
        PR c++/34961
        * typeck.c (check_return_expr): Tweak call to
        check_for_bare_parameter_packs.
        * class.c (add_method): Be careful with error_mark_nodes.
        * cp-tree.h (check_for_bare_parameter_packs): Remove "*" from
        signature.
        * pt.c (struct find_parameter_pack_data): Remove
        SET_PACKS_TO_ERROR.
        (find_parameter_packs_r): Don't use SET_PACKS_TO_ERROR.
        (uses_parameter_packs): Don't set SET_PACKS_TO_ERROR.
        (make_pack_expansion): Ditto.
        (check_for_bare_parameter_packs): Parameter is now a tree, not a
        tree*.
        (process_template_parm): Tweak call to
        check_for_bare_parameter_packs.  
        (push_template_decl_real): Tweak calls to
        check_for_bare_parameter_packs. If bare parameter packs are found
        in the list of exceptions, clear out that list after giving an
        error.
        * semantics.c (finish_cond): Tweak call to
        check_for_bare_parameter_packs.
        (finish_expr_stmt): Ditto.
        (finish_for_expr): Ditto.
        (finish_switch_cond): Ditto.
        (finish_mem_initializers): Ditto.
        (finish_member_declaration): Ditto.
        (finish_static_assert): Check for bare parameter packs in the
        condition.
        * decl2.c (cplus_decl_attributes): Check for bare parameter packs in
the
        attributes of a declaration.
        * parser.c (cp_parser_using_declaration): Tweak call to
        check_for_bare_parameter_packs.
        (cp_parser_base_clause): Ditto.


2008-01-29  Douglas Gregor  <doug.gregor@gmail.com>

        PR c++/34055
        PR c++/34103
        PR c++/34219
        PR c++/34606
        PR c++/34753
        PR c++/34754
        PR c++/34755
        PR c++/34919
        PR c++/34961
        * g++.dg/cpp0x/vt-34219-2.C: New.
        * g++.dg/cpp0x/pr32126.C: Tweak expected error messages.
        * g++.dg/cpp0x/vt-34961.C: New.
        * g++.dg/cpp0x/vt-34055.C: Tweak error messages; add new test
        cases from the re-opened PR.
        * g++.dg/cpp0x/vt-34753.C: New.
        * g++.dg/cpp0x/vt-34919.C: New.
        * g++.dg/cpp0x/vt-34754.C: New.
        * g++.dg/cpp0x/vt-34606.C: New.
        * g++.dg/cpp0x/vt-34219.C: New.
        * g++.dg/cpp0x/pr32125.C: Tweak expected error messages.
        * g++.dg/cpp0x/vt-34755.C: New.
        * g++.dg/cpp0x/pr31438.C: Ditto.
        * g++.dg/cpp0x/variadic81.C: Ditto.

Added:
    trunk/gcc/testsuite/g++.dg/cpp0x/vt-34219-2.C
    trunk/gcc/testsuite/g++.dg/cpp0x/vt-34219.C
    trunk/gcc/testsuite/g++.dg/cpp0x/vt-34606.C
    trunk/gcc/testsuite/g++.dg/cpp0x/vt-34753.C
    trunk/gcc/testsuite/g++.dg/cpp0x/vt-34754.C
    trunk/gcc/testsuite/g++.dg/cpp0x/vt-34755.C
    trunk/gcc/testsuite/g++.dg/cpp0x/vt-34919.C
    trunk/gcc/testsuite/g++.dg/cpp0x/vt-34961.C
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/c-pretty-print.c
    trunk/gcc/cp/ChangeLog
    trunk/gcc/cp/class.c
    trunk/gcc/cp/cp-tree.h
    trunk/gcc/cp/decl.c
    trunk/gcc/cp/decl2.c
    trunk/gcc/cp/parser.c
    trunk/gcc/cp/pt.c
    trunk/gcc/cp/semantics.c
    trunk/gcc/cp/typeck.c
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/g++.dg/cpp0x/pr31438.C
    trunk/gcc/testsuite/g++.dg/cpp0x/pr32125.C
    trunk/gcc/testsuite/g++.dg/cpp0x/pr32126.C
    trunk/gcc/testsuite/g++.dg/cpp0x/variadic81.C
    trunk/gcc/testsuite/g++.dg/cpp0x/vt-34055.C


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34055

[Bug c++/34055] [4.3 regression] ICE with invalid specialization of variadic template

[dgregor at gcc dot gnu dot org]

------- Comment #9 from dgregor at gcc dot gnu dot org  2008-01-29 14:24 -------
Fixed in mainline


-- 

dgregor at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34055