[Bug rtl-optimization/34249] New: [4.3 Regression] FAIL: gcc.dg/tree-prof/bb-reorg.c compilation, -fprofile-use -D_PROFILE_USE

[Bug rtl-optimization/34249] New: [4.3 Regression] FAIL: gcc.dg/tree-prof/bb-reorg.c compilation, -fprofile-use -D_PROFILE_USE

[hjl at lucon dot org]

I got

Executing on host: /export/build/gnu/gcc/build-x86_64-linux/gcc/xgcc
-B/export/build/gnu/gcc/build-x86_64-linux/gcc/
/net/gnu-13/export/gnu/src/gcc/gcc/gcc/testsuite/gcc.dg/tree-prof/bb-reorg.c  
-O2 -freorder-blocks-and-partition -fprofile-use -D_PROFILE_USE
-fno-show-column  -lm   -o
/export/build/gnu/gcc/build-x86_64-linux/gcc/testsuite/gcc/bb-reorg.x02   
(timeout = 300)
/tmp/ccNBvTsg.s: Assembler messages:
/tmp/ccNBvTsg.s:150: Error: can't resolve `.text.unlikely' {.text.unlikely
section} - `.LFB15' {.text section}
compiler exited with status 1


-- 
           Summary: [4.3 Regression] FAIL: gcc.dg/tree-prof/bb-reorg.c
                    compilation,  -fprofile-use -D_PROFILE_USE
           Product: gcc
           Version: 4.3.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: rtl-optimization
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: hjl at lucon dot org
GCC target triplet: x86_64-unknown-linux-gnu


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34249

[Bug rtl-optimization/34249] FAIL: gcc.dg/tree-prof/bb-reorg.c compilation, -fprofile-use -D_PROFILE_USE

[hjl at lucon dot org]

------- Comment #1 from hjl at lucon dot org  2007-11-27 12:49 -------
This testcase doesn't work on Linux/x86-64.


-- 

hjl at lucon dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |revitale at gcc dot gnu dot
                   |                            |org
            Summary|[4.3 Regression] FAIL:      |FAIL: gcc.dg/tree-prof/bb-
                   |gcc.dg/tree-prof/bb-reorg.c |reorg.c compilation,  -
                   |compilation,  -fprofile-use |fprofile-use -D_PROFILE_USE
                   |-D_PROFILE_USE              |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34249

[Bug rtl-optimization/34249] FAIL: gcc.dg/tree-prof/bb-reorg.c compilation, -fprofile-use -D_PROFILE_USE

[rguenth at gcc dot gnu dot org]

------- Comment #2 from rguenth at gcc dot gnu dot org  2007-11-27 14:06 -------
Confirmed.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2007-11-27 14:06:26
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34249

[Bug rtl-optimization/34249] FAIL: gcc.dg/tree-prof/bb-reorg.c compilation, -fprofile-use -D_PROFILE_USE

[pinskia at gcc dot gnu dot org]

------- Comment #3 from pinskia at gcc dot gnu dot org  2007-12-02 23:52 -------
This testcase never worked.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pinskia at gcc dot gnu dot
                   |                            |org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34249

[Bug rtl-optimization/34249] [4.3 Regression] FAIL: gcc.dg/tree-prof/bb-reorg.c compilation, -fprofile-use -D_PROFILE_USE

[ubizjak at gmail dot com]

------- Comment #4 from ubizjak at gmail dot com  2008-01-14 12:59 -------
(In reply to comment #3)
> This testcase never worked.

It works when -g is added to compile flags.

The problem is, that final pass calls dwarf2out_switch_text_section() for
NOTE_INSN_SWITCH_TEXT_SECTIONS only when debug hooks are actually initialized.
When "-g" is added, everything works as expected, since
dwarf2out_switch_text_section() is now active and we get:

.LSFDE2:
        .long   .LEFDE2-.LASFDE2
.LASFDE2:
        .long   .Lframe0
        .quad   .LFB15
        .quad   .LHOTB1
        .quad   .LHOTE1-.LHOTB1
        .quad   .LCOLDB1
        .quad   .LCOLDE1-.LCOLDB1
        .align 8
.LEFDE2:

instead of:

.LASFDE3:
        .long   .LASFDE3-.Lframe1
        .long   .LFB15
        .long   .LFE15-.LFB15
        .uleb128 0x0
        .align 8
.LEFDE3:

BTW: I also think that -freorder-blocks-and-partition should enable
flag_inhibit_size_directive, since .size is not correct with -fr-b-a-p.

I'm not an expert on this area, so perhaps original authors would like to fix
this issue?


-- 

ubizjak at gmail dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ctice at apple dot com
            Summary|FAIL: gcc.dg/tree-prof/bb-  |[4.3 Regression] FAIL:
                   |reorg.c compilation,  -     |gcc.dg/tree-prof/bb-reorg.c
                   |fprofile-use -D_PROFILE_USE |compilation,  -fprofile-use
                   |                            |-D_PROFILE_USE


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34249

[Bug debug/34249] [4.3 Regression] FAIL: gcc.dg/tree-prof/bb-reorg.c compilation, -fprofile-use -D_PROFILE_USE

[ubizjak at gmail dot com]

------- Comment #5 from ubizjak at gmail dot com  2008-01-14 14:21 -------
I'm testing following patch:

Index: final.c
===================================================================
--- final.c     (revision 131520)
+++ final.c     (working copy)
@@ -1777,7 +1777,13 @@ final_scan_insn (rtx insn, FILE *file, i

        case NOTE_INSN_SWITCH_TEXT_SECTIONS:
          in_cold_section_p = !in_cold_section_p;
-         (*debug_hooks->switch_text_section) ();
+#ifdef DWARF2_UNWIND_INFO
+         if (dwarf2out_do_frame ())
+           dwarf2out_switch_text_section ();
+         else
+#endif
+           (*debug_hooks->switch_text_section) ();
+
          switch_to_section (current_function_section ());
          break;

Index: debug.h
===================================================================
--- debug.h     (revision 131520)
+++ debug.h     (working copy)
@@ -160,6 +160,7 @@ extern void dwarf2out_frame_finish (void
 /* Decide whether we want to emit frame unwind information for the current
    translation unit.  */
 extern int dwarf2out_do_frame (void);
+extern void dwarf2out_switch_text_section(void);

 extern void debug_flush_symbol_queue (void);
 extern void debug_queue_symbol (tree);
Index: dwarf2out.c
===================================================================
--- dwarf2out.c (revision 131520)
+++ dwarf2out.c (working copy)
@@ -3659,7 +3659,6 @@ static void dwarf2out_imported_module_or
 static void dwarf2out_abstract_function (tree);
 static void dwarf2out_var_location (rtx);
 static void dwarf2out_begin_function (tree);
-static void dwarf2out_switch_text_section (void);

 /* The debug hooks structure.  */

@@ -7094,7 +7093,7 @@ dwarf2out_note_section_used (void)
     cold_text_section_used = true;
 }

-static void
+void
 dwarf2out_switch_text_section (void)
 {
   dw_fde_ref fde;


-- 

ubizjak at gmail dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ubizjak at gmail dot com
          Component|rtl-optimization            |debug


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34249

[Bug debug/34249] [4.3 Regression] FAIL: gcc.dg/tree-prof/bb-reorg.c compilation, -fprofile-use -D_PROFILE_USE

[ubizjak at gmail dot com]

-- 

ubizjak at gmail dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |ubizjak at gmail dot com
                   |dot org                     |
                URL|                            |http://gcc.gnu.org/ml/gcc-
                   |                            |patches/2008-
                   |                            |01/msg00612.html
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2007-11-27 14:06:26         |2008-01-14 17:16:25
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34249

[Bug debug/34249] [4.3 Regression] FAIL: gcc.dg/tree-prof/bb-reorg.c compilation, -fprofile-use -D_PROFILE_USE

[ubizjak at gmail dot com]

-- 

ubizjak at gmail dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.3.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34249

[Bug debug/34249] [4.3 Regression] FAIL: gcc.dg/tree-prof/bb-reorg.c compilation, -fprofile-use -D_PROFILE_USE

[uros at gcc dot gnu dot org]

------- Comment #6 from uros at gcc dot gnu dot org  2008-01-16 11:11 -------
Subject: Bug 34249

Author: uros
Date: Wed Jan 16 11:10:27 2008
New Revision: 131570

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=131570
Log:
        PR debug/34249
        * debug.h (dwarf2out_switch_text_section): Move declaration from ...
        * dwarf2out.c (dwarf2out_switch_text_section): ... here.  Make
        function global.
        * final.c (final_scan_insn) [NOTE_INSN_SWITCH_TEXT_SECTIONS]:
        Depending on dwarf2out_do_frame, call dwarf2out_switch_text_section
        for DWARF2_UNWIND_INFO targets.


Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/debug.h
    trunk/gcc/dwarf2out.c
    trunk/gcc/final.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34249

[Bug debug/34249] [4.3 Regression] FAIL: gcc.dg/tree-prof/bb-reorg.c compilation, -fprofile-use -D_PROFILE_USE

[ubizjak at gmail dot com]

------- Comment #7 from ubizjak at gmail dot com  2008-01-16 11:15 -------
Fixed for 4.3.0.


-- 

ubizjak at gmail dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34249

[Bug debug/34249] [4.3 Regression] FAIL: gcc.dg/tree-prof/bb-reorg.c compilation, -fprofile-use -D_PROFILE_USE

[hjl at lucon dot org]

------- Comment #8 from hjl at lucon dot org  2008-01-16 16:16 -------
It isn't fixed. The error went from as to ld:

/export/build/gnu/gcc/build-x86_64-linux/gcc/xgcc
-B/export/build/gnu/gcc/build-x86_64-linux/gcc/
/net/gnu-13/export/gnu/src/gcc/gcc/gcc/testsuite/gcc.dg/tree-prof/bb-reorg.c  
-O2 -freorder-blocks-and-partition -fprofile-use -D_PROFILE_USE
-fno-show-column  -lm   -o
/export/build/gnu/gcc/build-x86_64-linux/gcc/testsuite/gcc/bb-reorg.x02   
(timeout = 300)
/usr/local/bin/ld: error in /tmp/ccoylUaf.o(.eh_frame); no .eh_frame_hdr table
will be created.^M
output is:
/usr/local/bin/ld: error in /tmp/ccoylUaf.o(.eh_frame); no .eh_frame_hdr table
will be created.^M

FAIL: gcc.dg/tree-prof/bb-reorg.c compilation,  -fprofile-use -D_PROFILE_USE

I am using the Linux binutils 2.18.50.0.3.


-- 

hjl at lucon dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34249

[Bug debug/34249] [4.3 Regression] FAIL: gcc.dg/tree-prof/bb-reorg.c compilation, -fprofile-use -D_PROFILE_USE

[ubizjak at gmail dot com]

------- Comment #9 from ubizjak at gmail dot com  2008-01-16 17:25 -------
(In reply to comment #8)
> It isn't fixed. The error went from as to ld:

Here is my log:

Executing on host: /home/uros/gcc-build-all/gcc/xgcc
-B/home/uros/gcc-build-all/gcc/ /home/uros/gcc-svn/trunk/gcc/
testsuite/gcc.dg/tree-prof/bb-reorg.c   -O2 -freorder-blocks-and-partition
-fprofile-use -D_PROFILE_USE -fno-show-
column  -lm   -o /home/uros/gcc-build-all/gcc/testsuite/gcc/bb-reorg.x02   
(timeout = 300)
PASS: gcc.dg/tree-prof/bb-reorg.c compilation,  -fprofile-use -D_PROFILE_USE
Setting LD_LIBRARY_PATH to
:/home/uros/gcc-build-all/gcc:/home/uros/gcc-build-all/gcc/32::/home/uros/gcc-build-all
/gcc:/home/uros/gcc-build-all/gcc/32:/usr/local/lib64:/usr/lib/xorg:/usr/lib64/xorg
PASS: gcc.dg/tree-prof/bb-reorg.c execution,    -fprofile-use -D_PROFILE_USE
testcase /home/uros/gcc-svn/trunk/gcc/testsuite/gcc.dg/tree-prof/tree-prof.exp
completed in 2 seconds

GNU ld version 2.17.50.0.3-6 20060715

The difference between non-working (.s_) and working (.s) asm dump is:

--- bb-reorg.s_ 2008-01-16 18:22:01.000000000 +0100
+++ bb-reorg.s  2008-01-16 18:22:40.000000000 +0100
@@ -147,9 +147,12 @@
 .LASFDE3:
        .long   .LASFDE3-.Lframe1
        .long   .LFB15
-       .long   .LFE15-.LFB15
+       .long   .LHOTB1
+       .long   .LHOTE1-.LHOTB1
+       .long   .LCOLDB1
+       .long   .LCOLDE1-.LCOLDB1
        .uleb128 0x0
        .align 8
 .LEFDE3:
-       .ident  "GCC: (GNU) 4.3.0 20080107 (experimental) [trunk revision
131375]"
+       .ident  "GCC: (GNU) 4.3.0 20080114 (experimental) [trunk revision
131520]"
        .section        .note.GNU-stack,"",@progbits


Is the problem with binutils here?


-- 

ubizjak at gmail dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |WAITING


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34249

[Bug debug/34249] [4.3 Regression] FAIL: gcc.dg/tree-prof/bb-reorg.c compilation, -fprofile-use -D_PROFILE_USE

[ubizjak at gmail dot com]

------- Comment #10 from ubizjak at gmail dot com  2008-01-16 17:44 -------
(In reply to comment #9)

>  .LASFDE3:
>         .long   .LASFDE3-.Lframe1
>         .long   .LFB15
> -       .long   .LFE15-.LFB15
> +       .long   .LHOTB1
> +       .long   .LHOTE1-.LHOTB1
> +       .long   .LCOLDB1
> +       .long   .LCOLDE1-.LCOLDB1
>         .uleb128 0x0
>         .align 8

The fact that both dumps contain ".long   .LFB15" is a bit suspicious.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34249

[Bug debug/34249] [4.3 Regression] FAIL: gcc.dg/tree-prof/bb-reorg.c compilation, -fprofile-use -D_PROFILE_USE

[hjl at lucon dot org]

------- Comment #11 from hjl at lucon dot org  2008-01-16 18:23 -------
(In reply to comment #9)
> 
> GNU ld version 2.17.50.0.3-6 20060715
> 

Your linker doesn't issue the error since it is too old. See

http://sourceware.org/bugzilla/show_bug.cgi?id=4454


-- 

hjl at lucon dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|2008-01-14 17:16:25         |2008-01-16 18:23:05
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34249

[Bug debug/34249] [4.3 Regression] FAIL: gcc.dg/tree-prof/bb-reorg.c compilation, -fprofile-use -D_PROFILE_USE

[ubizjak at gmail dot com]

------- Comment #12 from ubizjak at gmail dot com  2008-01-16 18:25 -------
Created an attachment (id=14949)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=14949&action=view)
Patch to fix issue in Comment #8

H.J, could you test if attached patch fixes the problem from Comment #8?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34249

[Bug debug/34249] [4.3 Regression] FAIL: gcc.dg/tree-prof/bb-reorg.c compilation, -fprofile-use -D_PROFILE_USE

[hjl at lucon dot org]

------- Comment #13 from hjl at lucon dot org  2008-01-16 20:17 -------
(In reply to comment #12)
> Created an attachment (id=14949)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=14949&action=view) [edit]
> Patch to fix issue in Comment #8
> 
> H.J, could you test if attached patch fixes the problem from Comment #8?
> 

Yes, it works:

http://gcc.gnu.org/ml/gcc-testresults/2008-01/msg00695.html


-- 

hjl at lucon dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|2008-01-16 18:23:05         |2008-01-16 20:17:13
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34249

[Bug debug/34249] [4.3 Regression] FAIL: gcc.dg/tree-prof/bb-reorg.c compilation, -fprofile-use -D_PROFILE_USE

[uros at gcc dot gnu dot org]

------- Comment #14 from uros at gcc dot gnu dot org  2008-01-16 21:21 -------
Subject: Bug 34249

Author: uros
Date: Wed Jan 16 21:20:39 2008
New Revision: 131578

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=131578
Log:
        PR debug/34249
        * dwarf2out.c (output_call_frame_info): Move output of FDE initial
        location address to the correct place.  Update copyright year.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/dwarf2out.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34249

[Bug debug/34249] [4.3 Regression] FAIL: gcc.dg/tree-prof/bb-reorg.c compilation, -fprofile-use -D_PROFILE_USE

[ubizjak at gmail dot com]

------- Comment #15 from ubizjak at gmail dot com  2008-01-16 21:36 -------
Fixed again.


-- 

ubizjak at gmail dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34249