[Bug middle-end/34245] New: Missing __builtin_fpclassify

[Bug middle-end/34245] New: Missing __builtin_fpclassify

[pcarlini at suse dot de]

Builtins for all the other floating-point classification macros are already
implemented and it would be nice to complete the set with __builtin_fpclassify
(could be certainly exploited in libstdc++, also)


-- 
           Summary: Missing __builtin_fpclassify
           Product: gcc
           Version: 4.3.0
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: P3
         Component: middle-end
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: pcarlini at suse dot de


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34245

[Bug middle-end/34245] Missing __builtin_fpclassify

[rguenth at gcc dot gnu dot org]

------- Comment #1 from rguenth at gcc dot gnu dot org  2007-11-27 12:49 -------
Confirmed.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rguenth at gcc dot gnu dot
                   |                            |org
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2007-11-27 12:49:12
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34245

[Bug middle-end/34245] Missing __builtin_fpclassify

[joseph at codesourcery dot com]

------- Comment #2 from joseph at codesourcery dot com  2007-11-27 15:34 -------
Subject: Re:   New: Missing __builtin_fpclassify

As previously discussed, this builtin would either need to be used in the 
form

#define fpclassify(x) __builtin_fpclassify(FP_INFINITE, FP_NAN, FP_NORMAL,
FP_SUBNORMAL, FP_ZERO, (x))

or would need GCC to be configured with target-specific information about 
FP_*, since the values of the FP_* macros are not standardized.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34245

[Bug middle-end/34245] Missing __builtin_fpclassify

[pcarlini at suse dot de]

------- Comment #3 from pcarlini at suse dot de  2007-11-27 16:00 -------
(In reply to comment #2)
> As previously discussed,

Didn't know about that. If you have a pointer, I would like to read the thread.

                           this builtin would either need to be used in the 
> form
> 
> #define fpclassify(x) __builtin_fpclassify(FP_INFINITE, FP_NAN, FP_NORMAL,
> FP_SUBNORMAL, FP_ZERO, (x))

In my opinion, this would be already a nice improvement.

> or would need GCC to be configured with target-specific information about 
> FP_*, since the values of the FP_* macros are not standardized.

I see. At the moment, I'm not able to understand whether that is a major /
controversial change... I would appreciate some additional details, if
possible. Thanks.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34245

[Bug middle-end/34245] Missing __builtin_fpclassify

[joseph at codesourcery dot com]

------- Comment #4 from joseph at codesourcery dot com  2007-11-27 16:20 -------
Subject: Re:  Missing __builtin_fpclassify

On Tue, 27 Nov 2007, pcarlini at suse dot de wrote:

> > As previously discussed,
> 
> Didn't know about that. If you have a pointer, I would like to read the thread.

http://gcc.gnu.org/ml/gcc-patches/2007-01/msg02210.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34245

[Bug middle-end/34245] Missing __builtin_fpclassify

[paolo dot carlini at oracle dot com]

------- Comment #5 from paolo dot carlini at oracle dot com  2009-07-24 09:07 -------
Implemented here:

2008-05-23  Kaveh R. Ghazi  <ghazi@caip.rutgers.edu>

        * builtin-types.def (BT_FN_INT_INT_INT_INT_INT_INT_VAR): New.
        * builtins.c (fold_builtin_fpclassify): New.
        (fold_builtin_varargs): Handle BUILT_IN_FPCLASSIFY.
        * builtins.def (BUILT_IN_FPCLASSIFY): New.
        * c-common.c (handle_type_generic_attribute): Adjust to accept
        fixed arguments before an elipsis.
        (check_builtin_function_arguments): Handle BUILT_IN_FPCLASSIFY.
        * doc/extend.texi: Document __builtin_fpclassify.


-- 

paolo dot carlini at oracle dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.4.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34245