[Bug tree-optimization/33655] [4.3 Regression] ICE in bitfield_overlaps_p, at tree-sra.c:2901

[Bug tree-optimization/33655] [4.3 Regression] ICE in bitfield_overlaps_p, at tree-sra.c:2901

[rguenth at gcc dot gnu dot org]

------- Comment #1 from rguenth at gcc dot gnu dot org  2007-10-04 12:19 -------
Created an attachment (id=14295)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=14295&action=view)
testcase (unreduced)

Reducing.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33655

[Bug tree-optimization/33655] New: [4.3 Regression] ICE in bitfield_overlaps_p, at tree-sra.c:2901

[rguenth at gcc dot gnu dot org]

Building ncurses with trunk ICEs with:

/usr/bin/gcc -DHAVE_CONFIG_H -I../ncurses -I. -I. -I../include -D_GNU_SOURCE
-DNDEBUG -O2 -g -fmessage-length=0 -pipe -D_REENTRANT -fPIC -c
../ncurses/./base/lib_addch.c -o ../obj_s/lib_addch.o
gcc-trunk: warning: -pipe ignored because -save-temps specified
../ncurses/./base/lib_addch.c: In function 'render_char':
../ncurses/./base/lib_addch.c:541: internal compiler error: in
bitfield_overlaps_p, at tree-sra.c:2901
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://gcc.gnu.org/bugs.html> for instructions.

This was caused by

2007-10-01  Alexandre Oliva  <aoliva@redhat.com>

        PR middle-end/22156
        * tree-sra.c (struct sra_elt): Add in_bitfld_block.
        (sra_hash_tree): Handle BIT_FIELD_REFs.
        (sra_elt_hash): Don't hash bitfld blocks.
...


-- 
           Summary: [4.3 Regression] ICE in bitfield_overlaps_p, at tree-
                    sra.c:2901
           Product: gcc
           Version: 4.3.0
            Status: UNCONFIRMED
          Keywords: ice-on-valid-code
          Severity: normal
          Priority: P3
         Component: tree-optimization
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: rguenth at gcc dot gnu dot org
GCC target triplet: x86_64-*-*


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33655

[Bug tree-optimization/33655] [4.3 Regression] ICE in bitfield_overlaps_p, at tree-sra.c:2901

[rguenth at gcc dot gnu dot org]

------- Comment #2 from rguenth at gcc dot gnu dot org  2007-10-04 12:28 -------
Reduced testcase, fails with -O:

typedef struct {
    unsigned long attr;
    int chars[2];
} cchar_t;
typedef struct _win_st {
    cchar_t _bkgrnd;
} WINDOW;
void render_char(WINDOW *win, cchar_t ch)
{
    if ((ch).chars[0] == L' '
        && (ch).chars[1] == L'\0')
        ch = win->_bkgrnd;
}


#1  0x0000000000945da0 in bitfield_overlaps_p (blen=0x2b7db0ca8b70, 
    bpos=0x2b7db0cc43c0, fld=0x13f66d0, data=0x7ffff9e5cfc0)
    at /space/rguenther/src/svn/pointer_plus/gcc/tree-sra.c:2901
2901        gcc_unreachable ();
(gdb) call debug_tree (fld->element)
 <integer_cst 0x2b7db0ca8810 type <integer_type 0x2b7db0cb7000 long unsigned
int> constant invariant 1>


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33655

[Bug tree-optimization/33655] [4.3 Regression] ICE in bitfield_overlaps_p, at tree-sra.c:2901

[aoliva at gcc dot gnu dot org]

-- 

aoliva at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |aoliva at gcc dot gnu dot
                   |dot org                     |org
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2007-10-05 15:24:19
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33655

[Bug tree-optimization/33655] [4.3 Regression] ICE in bitfield_overlaps_p, at tree-sra.c:2901

[aoliva at gcc dot gnu dot org]

------- Comment #3 from aoliva at gcc dot gnu dot org  2007-10-05 17:45 -------
Testing patch at http://gcc.gnu.org/ml/gcc-patches/2007-10/msg00298.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33655

[Bug tree-optimization/33655] [4.3 Regression] ICE in bitfield_overlaps_p, at tree-sra.c:2901

[aoliva at gcc dot gnu dot org]

------- Comment #4 from aoliva at gcc dot gnu dot org  2007-10-06 11:48 -------
Subject: Bug 33655

Author: aoliva
Date: Sat Oct  6 11:47:51 2007
New Revision: 129052

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=129052
Log:
gcc/ChangeLog:
PR tree-optimization/33655
* tree-sra.c (bitfield_overlaps_p): Handle array and complex
elements.
gcc/testsuite/ChangeLog:
PR tree-optimization/33655
* gcc.dg/torture/pr33655.c: New.

Added:
    trunk/gcc/testsuite/gcc.dg/torture/pr33655.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/tree-sra.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33655

[Bug tree-optimization/33655] [4.3 Regression] ICE in bitfield_overlaps_p, at tree-sra.c:2901

[hjl at lucon dot org]

------- Comment #5 from hjl at lucon dot org  2007-10-07 14:33 -------
(In reply to comment #4)
> Subject: Bug 33655
> 
> Author: aoliva
> Date: Sat Oct  6 11:47:51 2007
> New Revision: 129052
> 
> URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=129052
> Log:
> gcc/ChangeLog:
> PR tree-optimization/33655
> * tree-sra.c (bitfield_overlaps_p): Handle array and complex
> elements.
> gcc/testsuite/ChangeLog:
> PR tree-optimization/33655
> * gcc.dg/torture/pr33655.c: New.
> 
> Added:
>     trunk/gcc/testsuite/gcc.dg/torture/pr33655.c
> Modified:
>     trunk/gcc/ChangeLog
>     trunk/gcc/testsuite/ChangeLog
>     trunk/gcc/tree-sra.c
> 

This patch doesn't work on Linux/ia64. I got

Executing on host: /export/build/gnu/gcc/build-ia64-linux/gcc/xgcc
-B/export/build/gnu/gcc/build-ia64-linux/gcc/
/net/gnu-13/export/gnu/src/gcc/gcc/gcc/testsuite/gcc.dg/torture/pr33655.c   -O1
  -fno-show-column -S  -o pr33655.s    (timeout = 300)
/net/gnu-13/export/gnu/src/gcc/gcc/gcc/testsuite/gcc.dg/torture/pr33655.c: In
function 'render_char':^M
/net/gnu-13/export/gnu/src/gcc/gcc/gcc/testsuite/gcc.dg/torture/pr33655.c:14:
internal compiler error: in size_binop, at fold-const.c:2036^M
Please submit a full bug report,^M
with preprocessed source if appropriate.^M
See <http://gcc.gnu.org/bugs.html> for instructions.^M


-- 

hjl at lucon dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hjl at lucon dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33655

[Bug tree-optimization/33655] [4.3 Regression] ICE in bitfield_overlaps_p, at tree-sra.c:2901

[wilson at specifix dot com]

------- Comment #6 from wilson at specifix dot com  2007-10-08 22:16 -------
Subject: Re:  [4.3 Regression] ICE in bitfield_overlaps_p,
 at tree-sra.c:2901

hjl at lucon dot org wrote:
> This patch doesn't work on Linux/ia64. I got

IA-64 is using a TImode bitsizetype because it defines 
MAX_FIXED_MODE_SIZE to enable TImode.  The x86_64 port does not, so it 
ends up with a DImode bitsizetype and hence does not have the same 
problem.  It looks like a few other 64-bit ports will fail the same way 
though, like powerpc64 and s390.

We can fix this with small patch to add another bitsizetype conversion 
call.  I'll attach a patch.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33655

[Bug tree-optimization/33655] [4.3 Regression] ICE in bitfield_overlaps_p, at tree-sra.c:2901

[wilson at gcc dot gnu dot org]

------- Comment #7 from wilson at gcc dot gnu dot org  2007-10-08 22:19 -------
Created an attachment (id=14324)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=14324&action=view)
add another conversion to bitsizetype

Here is an patch to fix the IA-64 failure for this testcase.  This makes the
testcase work (i.e. gcc doesn't ICE), but has not been otherwise tested as yet.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33655

[Bug tree-optimization/33655] [4.3 Regression] ICE in bitfield_overlaps_p, at tree-sra.c:2901

[aoliva at gcc dot gnu dot org]

------- Comment #8 from aoliva at gcc dot gnu dot org  2007-10-09 04:55 -------
Subject: Bug 33655

Author: aoliva
Date: Tue Oct  9 04:55:17 2007
New Revision: 129152

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=129152
Log:
PR tree-optimization/33655
PR middle-end/22156
* tree-sra.c (bitfield_overlaps_p): When fld->element is INTEGER_CST,
convert it to bitsizetype before size_binop call.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/tree-sra.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33655

[Bug tree-optimization/33655] [4.3 Regression] ICE in bitfield_overlaps_p, at tree-sra.c:2901

[aoliva at gcc dot gnu dot org]

------- Comment #9 from aoliva at gcc dot gnu dot org  2007-10-09 04:56 -------
Fixed


-- 

aoliva at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33655

[Bug tree-optimization/33655] [4.3 Regression] ICE in bitfield_overlaps_p, at tree-sra.c:2901

[pinskia at gcc dot gnu dot org]

-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.3.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33655