[Bug ada/33688] New: Ada package Gnat.Sockets missing constant for IP_PKTINFO (patch)

[Bug ada/33688] New: Ada package Gnat.Sockets missing constant for IP_PKTINFO (patch)

[kayhayen at gmx dot de]

We are using gcc and Gnat.Sockets and have the need to filter incoming packets
according to their origin (device, IP, port), in order to enable this we have
patched gcc to offer the constant IP_PKTINFO.

I am going to attach an archive with the patched files for gcc-snapshot. The
addition is quite straightforward and we would be happy if it could make it
into 4.3.0 or 4.3.1 mayhaps.


-- 
           Summary: Ada package Gnat.Sockets missing constant for IP_PKTINFO
                    (patch)
           Product: gcc
           Version: 4.3.0
            Status: UNCONFIRMED
          Severity: minor
          Priority: P3
         Component: ada
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: kayhayen at gmx dot de


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33688

[Bug ada/33688] Ada package Gnat.Sockets missing constant for IP_PKTINFO (patch)

[kayhayen at gmx dot de]

------- Comment #1 from kayhayen at gmx dot de  2007-10-08 09:03 -------
Created an attachment (id=14321)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=14321&action=view)
Patch adding IP_PKTINFO constand and implementation changes to Gnat.Sockets

I can also make it in a patch form, but I am unfamiliar with the preferred form
of using it.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33688

[Bug ada/33688] Ada package Gnat.Sockets missing constant for IP_PKTINFO (patch)

[sam at rfc1149 dot net]

------- Comment #2 from sam at rfc1149 dot net  2007-10-27 19:29 -------
Created an attachment (id=14415)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=14415&action=view)
Updated patch for the current enhancement report

I've produced a patch from the given sources, adapted to the current trunk.
Note that all platform-dependent version of g-soccon.ads must be rebuilt
(except for x86-linux).


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33688

[Bug ada/33688] Ada package Gnat.Sockets missing constant for IP_PKTINFO (patch)

[kayhayen at gmx dot de]

------- Comment #3 from kayhayen at gmx dot de  2007-12-09 08:28 -------
This is to confirm that the patch cleanly applied to a couple of snapshots
since, the last one I tested was "gcc-snapshot-20071202" as found in the Ubuntu
Hardy archives.

Would it be possible to apply it? And now that it has a patch, how do you
express that in this bug tracker. :-)

Yours,
Kay


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33688

[Bug ada/33688] Ada package Gnat.Sockets missing constant for IP_PKTINFO (patch)

[sam at gcc dot gnu dot org]

------- Comment #4 from sam at gcc dot gnu dot org  2007-12-09 11:42 -------
Building all the system dependent files corresponding to this patch requires
access to all supported targets to update the constant value and is extremely
time consuming. This is certainly not something I am willing or able to do
myself.

Your best hope is to wait until AdaCore update their own version of the files
when they need to, add this constant at the same time, and merge the results
into the FSF tree. In the meantime, I'm afraid you will have to live with your
own patched version.


-- 

sam at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|sam at rfc1149 dot net      |sam at gcc dot gnu dot org
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2007-12-09 11:42:04
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33688

[Bug ada/33688] Ada package Gnat.Sockets missing constant for IP_PKTINFO (patch)

[charlet at gcc dot gnu dot org]

------- Comment #5 from charlet at gcc dot gnu dot org  2007-12-19 16:26 -------
Subject: Bug 33688

Author: charlet
Date: Wed Dec 19 16:25:58 2007
New Revision: 131084

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=131084
Log:
2007-12-19  Thomas Quinot  <quinot@adacore.com>

        Part of PR ada/33688
        * gen-soccon.c: Add constant IP_PKTINFO to allow getting ancillary
        datagram info on Linux.


Modified:
    trunk/gcc/ada/gen-soccon.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33688

[Bug ada/33688] Ada package Gnat.Sockets missing constant for IP_PKTINFO (patch)

[charlet at gcc dot gnu dot org]

------- Comment #6 from charlet at gcc dot gnu dot org  2008-03-26 07:35 -------
Subject: Bug 33688

Author: charlet
Date: Wed Mar 26 07:34:57 2008
New Revision: 133545

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=133545
Log:
2008-03-26  Thomas Quinot  <quinot@adacore.com>

PR ada/33688

        * g-socket.ads, g-socket.adb (Options, Set_Socket_Option,
        Get_Socket_Option): Add support for Receive_Packet_Info.

        * g-soccon.ads, g-soccon-tru64.ads, g-soccon-aix.ads,
        g-soccon-irix.ads, g-soccon-hpux.ads, g-soccon-solaris.ads,
        g-soccon-vms.ads, g-soccon-mingw.ads, g-soccon-freebsd.ads,
        g-soccon-hpux-ia64.ads, g-soccon-solaris-64.ads, g-soccon-darwin.ads,
        g-soccon-lynxos.ads, g-soccon-linux-64.ads, g-soccon-linux-x86.ads: Add
        new constants SO_REUSEPORT and IP_PKTINFO


Modified:
    trunk/gcc/ada/g-soccon-aix.ads
    trunk/gcc/ada/g-soccon-darwin.ads
    trunk/gcc/ada/g-soccon-freebsd.ads
    trunk/gcc/ada/g-soccon-hpux-ia64.ads
    trunk/gcc/ada/g-soccon-hpux.ads
    trunk/gcc/ada/g-soccon-irix.ads
    trunk/gcc/ada/g-soccon-linux-64.ads
    trunk/gcc/ada/g-soccon-linux-x86.ads
    trunk/gcc/ada/g-soccon-lynxos.ads
    trunk/gcc/ada/g-soccon-mingw.ads
    trunk/gcc/ada/g-soccon-solaris-64.ads
    trunk/gcc/ada/g-soccon-solaris.ads
    trunk/gcc/ada/g-soccon-tru64.ads
    trunk/gcc/ada/g-soccon-vms.ads
    trunk/gcc/ada/g-soccon.ads
    trunk/gcc/ada/g-socket.adb
    trunk/gcc/ada/g-socket.ads


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33688

[Bug ada/33688] Ada package Gnat.Sockets missing constant for IP_PKTINFO (patch)

[charlet at gcc dot gnu dot org]

------- Comment #7 from charlet at gcc dot gnu dot org  2008-03-26 07:58 -------
This PR should now be addressed, please reopen if not, clarifying what's
missing.


-- 

charlet at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.4.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33688

[Bug ada/33688] Ada package Gnat.Sockets missing constant for IP_PKTINFO (patch)

[danglin at gcc dot gnu dot org]

------- Comment #8 from danglin at gcc dot gnu dot org  2008-04-02 00:32 -------
The change to g-soccon-darwin.ads didn't define IP_PKTINFO.

/Users/dave/gnu/gcc/objdir/./gcc/xgcc -B/Users/dave/gnu/gcc/objdir/./gcc/
-B/opt
/gnu/gcc/gcc-4.4.0/i686-apple-darwin9/bin/
-B/opt/gnu/gcc/gcc-4.4.0/i686-apple-d
arwin9/lib/ -isystem /opt/gnu/gcc/gcc-4.4.0/i686-apple-darwin9/include -isystem 
/opt/gnu/gcc/gcc-4.4.0/i686-apple-darwin9/sys-include -c -g -O2 -fPIC -pipe     
                -fno-common      -W -Wall -gnatpg  g-socket.adb -o g-socket.o
g-socket.adb:103:49: "IP_PKTINFO" not declared in "Constants"


-- 

danglin at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |danglin at gcc dot gnu dot
                   |                            |org
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33688

[Bug ada/33688] Ada package Gnat.Sockets missing constant for IP_PKTINFO (patch)

[danglin at gcc dot gnu dot org]

------- Comment #9 from danglin at gcc dot gnu dot org  2008-04-02 01:03 -------
Subject: Bug 33688

Author: danglin
Date: Wed Apr  2 01:02:58 2008
New Revision: 133814

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=133814
Log:
        PR ada/33688
        * g-soccon-darwin.ads: Define new constant IP_PKTINFO.


Modified:
    trunk/gcc/ada/ChangeLog
    trunk/gcc/ada/g-soccon-darwin.ads


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33688

[Bug ada/33688] Ada package Gnat.Sockets missing constant for IP_PKTINFO (patch)

[danglin at gcc dot gnu dot org]

------- Comment #10 from danglin at gcc dot gnu dot org  2008-04-02 01:03 -------
Fixed.


-- 

danglin at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33688