public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug libfortran/34540] New: cshift, eoshift, kind=1 and kind=2 arguments...
@ 2007-12-20 20:40 tkoenig at gcc dot gnu dot org
2007-12-20 21:16 ` [Bug libfortran/34540] " tkoenig at gcc dot gnu dot org
` (20 more replies)
0 siblings, 21 replies; 22+ messages in thread
From: tkoenig at gcc dot gnu dot org @ 2007-12-20 20:40 UTC (permalink / raw)
To: gcc-bugs
I really thought we had these figured out...
$ cat shift-variations.f90
program main
integer(kind=1) :: d1
integer(kind=2) :: d2
integer(kind=4) :: d4
integer(kind=8) :: d8
integer(kind=1), dimension(2) :: s1
integer(kind=2), dimension(2) :: s2
integer(kind=4), dimension(2) :: s4
integer(kind=8), dimension(2) :: s8
real, dimension(2,2) :: r
data r /1.0, 2.0, 3.0, 4.0/
s1 = (/1, 1/)
s2 = (/1, 1/)
s4 = (/1, 1/)
s8 = (/1, 1/)
d1 = 1
d2 = 1
d4 = 1
d8 = 1
print *,eoshift(r,shift=s1,dim=d1)
print *,eoshift(r,shift=s2,dim=d2)
print *,eoshift(r,shift=s4,dim=d4)
print *,eoshift(r,shift=s8,dim=d8)
print *,cshift(r,shift=s1,dim=d1)
print *,cshift(r,shift=s2,dim=d2)
print *,cshift(r,shift=s4,dim=d4)
print *,cshift(r,shift=s8,dim=d8)
end program main
$ gfortran shift-variations.f90
$ ./a.out
0.0000000 3.98764005E-34 1.26116862E-44 0.0000000
-2.73992191E-05 -2.85282731E-05 0.0000000 4.08616923E-38
2.0000000 0.0000000 4.0000000 0.0000000
2.0000000 0.0000000 4.0000000 0.0000000
Fortran runtime error: Argument 'DIM' is out of range in call to 'CSHIFT'
$ gfortran -v
Using built-in specs.
Target: i686-pc-linux-gnu
Configured with: ../../gcc/trunk/configure --prefix=/home/ig25
--enable-languages=c,fortran
Thread model: posix
gcc version 4.3.0 20071216 (experimental) (GCC)
--
Summary: cshift, eoshift, kind=1 and kind=2 arguments...
Product: gcc
Version: 4.3.0
Status: UNCONFIRMED
Keywords: wrong-code
Severity: normal
Priority: P3
Component: libfortran
AssignedTo: unassigned at gcc dot gnu dot org
ReportedBy: tkoenig at gcc dot gnu dot org
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34540
^ permalink raw reply [flat|nested] 22+ messages in thread
* [Bug libfortran/34540] cshift, eoshift, kind=1 and kind=2 arguments...
2007-12-20 20:40 [Bug libfortran/34540] New: cshift, eoshift, kind=1 and kind=2 arguments tkoenig at gcc dot gnu dot org
@ 2007-12-20 21:16 ` tkoenig at gcc dot gnu dot org
2007-12-21 3:13 ` [Bug libfortran/34540] [4.3 Regression] " jvdelisle at gcc dot gnu dot org
` (19 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: tkoenig at gcc dot gnu dot org @ 2007-12-20 21:16 UTC (permalink / raw)
To: gcc-bugs
--
tkoenig at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|unassigned at gcc dot gnu |tkoenig at gcc dot gnu dot
|dot org |org
Status|UNCONFIRMED |ASSIGNED
Ever Confirmed|0 |1
Last reconfirmed|0000-00-00 00:00:00 |2007-12-20 21:16:21
date| |
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34540
^ permalink raw reply [flat|nested] 22+ messages in thread
* [Bug libfortran/34540] [4.3 Regression] cshift, eoshift, kind=1 and kind=2 arguments...
2007-12-20 20:40 [Bug libfortran/34540] New: cshift, eoshift, kind=1 and kind=2 arguments tkoenig at gcc dot gnu dot org
2007-12-20 21:16 ` [Bug libfortran/34540] " tkoenig at gcc dot gnu dot org
@ 2007-12-21 3:13 ` jvdelisle at gcc dot gnu dot org
2007-12-21 19:49 ` tkoenig at gcc dot gnu dot org
` (18 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: jvdelisle at gcc dot gnu dot org @ 2007-12-21 3:13 UTC (permalink / raw)
To: gcc-bugs
------- Comment #1 from jvdelisle at gcc dot gnu dot org 2007-12-21 03:13 -------
This is a regression. The test case is OK with 4.2
--
jvdelisle at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|cshift, eoshift, kind=1 and |[4.3 Regression] cshift,
|kind=2 arguments... |eoshift, kind=1 and kind=2
| |arguments...
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34540
^ permalink raw reply [flat|nested] 22+ messages in thread
* [Bug libfortran/34540] [4.3 Regression] cshift, eoshift, kind=1 and kind=2 arguments...
2007-12-20 20:40 [Bug libfortran/34540] New: cshift, eoshift, kind=1 and kind=2 arguments tkoenig at gcc dot gnu dot org
2007-12-20 21:16 ` [Bug libfortran/34540] " tkoenig at gcc dot gnu dot org
2007-12-21 3:13 ` [Bug libfortran/34540] [4.3 Regression] " jvdelisle at gcc dot gnu dot org
@ 2007-12-21 19:49 ` tkoenig at gcc dot gnu dot org
2007-12-21 20:57 ` tkoenig at gcc dot gnu dot org
` (17 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: tkoenig at gcc dot gnu dot org @ 2007-12-21 19:49 UTC (permalink / raw)
To: gcc-bugs
------- Comment #2 from tkoenig at gcc dot gnu dot org 2007-12-21 19:49 -------
The problem is with dim.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34540
^ permalink raw reply [flat|nested] 22+ messages in thread
* [Bug libfortran/34540] [4.3 Regression] cshift, eoshift, kind=1 and kind=2 arguments...
2007-12-20 20:40 [Bug libfortran/34540] New: cshift, eoshift, kind=1 and kind=2 arguments tkoenig at gcc dot gnu dot org
` (2 preceding siblings ...)
2007-12-21 19:49 ` tkoenig at gcc dot gnu dot org
@ 2007-12-21 20:57 ` tkoenig at gcc dot gnu dot org
2007-12-21 21:07 ` jvdelisle at gcc dot gnu dot org
` (16 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: tkoenig at gcc dot gnu dot org @ 2007-12-21 20:57 UTC (permalink / raw)
To: gcc-bugs
------- Comment #3 from tkoenig at gcc dot gnu dot org 2007-12-21 20:56 -------
The problem is with the lines
if (dim->expr_type != EXPR_CONSTANT)
{
/* Mark this for later setting the type in gfc_conv_missing_dummy.
*/
dim->representation.length = shift->ts.kind;
}
else
{
gfc_resolve_dim_arg (dim);
/* Convert dim to shift's kind to reduce variations. */
if (dim->ts.kind != shift->ts.kind)
gfc_convert_type_warn (dim, &shift->ts, 2, 0);
}
For the test case, we take the first branch, which means we never
adjust dim's kind.
Jerry, you did some work in this area. I'mm CC: ing you on
this in case this rings a bell.
--
tkoenig at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jvdelisle at gcc dot gnu dot
| |org
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34540
^ permalink raw reply [flat|nested] 22+ messages in thread
* [Bug libfortran/34540] [4.3 Regression] cshift, eoshift, kind=1 and kind=2 arguments...
2007-12-20 20:40 [Bug libfortran/34540] New: cshift, eoshift, kind=1 and kind=2 arguments tkoenig at gcc dot gnu dot org
` (3 preceding siblings ...)
2007-12-21 20:57 ` tkoenig at gcc dot gnu dot org
@ 2007-12-21 21:07 ` jvdelisle at gcc dot gnu dot org
2007-12-21 22:18 ` jvdelisle at gcc dot gnu dot org
` (15 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: jvdelisle at gcc dot gnu dot org @ 2007-12-21 21:07 UTC (permalink / raw)
To: gcc-bugs
------- Comment #4 from jvdelisle at gcc dot gnu dot org 2007-12-21 21:07 -------
Yes, this is my doing in fixing PR33317. I will look at it tonight.
--
jvdelisle at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Last reconfirmed|2007-12-20 21:16:21 |2007-12-21 21:07:37
date| |
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34540
^ permalink raw reply [flat|nested] 22+ messages in thread
* [Bug libfortran/34540] [4.3 Regression] cshift, eoshift, kind=1 and kind=2 arguments...
2007-12-20 20:40 [Bug libfortran/34540] New: cshift, eoshift, kind=1 and kind=2 arguments tkoenig at gcc dot gnu dot org
` (4 preceding siblings ...)
2007-12-21 21:07 ` jvdelisle at gcc dot gnu dot org
@ 2007-12-21 22:18 ` jvdelisle at gcc dot gnu dot org
2007-12-22 1:57 ` jvdelisle at gcc dot gnu dot org
` (14 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: jvdelisle at gcc dot gnu dot org @ 2007-12-21 22:18 UTC (permalink / raw)
To: gcc-bugs
------- Comment #5 from jvdelisle at gcc dot gnu dot org 2007-12-21 22:18 -------
Patch is testing.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34540
^ permalink raw reply [flat|nested] 22+ messages in thread
* [Bug libfortran/34540] [4.3 Regression] cshift, eoshift, kind=1 and kind=2 arguments...
2007-12-20 20:40 [Bug libfortran/34540] New: cshift, eoshift, kind=1 and kind=2 arguments tkoenig at gcc dot gnu dot org
` (5 preceding siblings ...)
2007-12-21 22:18 ` jvdelisle at gcc dot gnu dot org
@ 2007-12-22 1:57 ` jvdelisle at gcc dot gnu dot org
2007-12-22 2:00 ` jvdelisle at gcc dot gnu dot org
` (13 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: jvdelisle at gcc dot gnu dot org @ 2007-12-22 1:57 UTC (permalink / raw)
To: gcc-bugs
------- Comment #6 from jvdelisle at gcc dot gnu dot org 2007-12-22 01:57 -------
Subject: Bug 34540
Author: jvdelisle
Date: Sat Dec 22 01:57:07 2007
New Revision: 131133
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=131133
Log:
2007-12-21 Jerry DeLisle <jvdelisle@gcc.gnu.org>
PR fortran/34540
* iresolve.c (gfc_resolve_cshift): Take optional dim path
only if the argument is an optional itself.
* iresolve.c (gfc_resolve_eoshift): Same.
Modified:
trunk/gcc/fortran/ChangeLog
trunk/gcc/fortran/iresolve.c
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34540
^ permalink raw reply [flat|nested] 22+ messages in thread
* [Bug libfortran/34540] [4.3 Regression] cshift, eoshift, kind=1 and kind=2 arguments...
2007-12-20 20:40 [Bug libfortran/34540] New: cshift, eoshift, kind=1 and kind=2 arguments tkoenig at gcc dot gnu dot org
` (6 preceding siblings ...)
2007-12-22 1:57 ` jvdelisle at gcc dot gnu dot org
@ 2007-12-22 2:00 ` jvdelisle at gcc dot gnu dot org
2007-12-22 2:01 ` jvdelisle at gcc dot gnu dot org
` (12 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: jvdelisle at gcc dot gnu dot org @ 2007-12-22 2:00 UTC (permalink / raw)
To: gcc-bugs
------- Comment #7 from jvdelisle at gcc dot gnu dot org 2007-12-22 02:00 -------
Subject: Bug 34540
Author: jvdelisle
Date: Sat Dec 22 01:59:56 2007
New Revision: 131134
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=131134
Log:
2007-12-21 Jerry DeLisle <jvdelisle@gcc.gnu.org>
PR fortran/34540
* gfortran.dg/shift-kind_2.f90: New test.
Added:
trunk/gcc/testsuite/gfortran.dg/shift-kind_2.f90
Modified:
trunk/gcc/testsuite/ChangeLog
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34540
^ permalink raw reply [flat|nested] 22+ messages in thread
* [Bug libfortran/34540] [4.3 Regression] cshift, eoshift, kind=1 and kind=2 arguments...
2007-12-20 20:40 [Bug libfortran/34540] New: cshift, eoshift, kind=1 and kind=2 arguments tkoenig at gcc dot gnu dot org
` (7 preceding siblings ...)
2007-12-22 2:00 ` jvdelisle at gcc dot gnu dot org
@ 2007-12-22 2:01 ` jvdelisle at gcc dot gnu dot org
2007-12-22 9:32 ` tkoenig at gcc dot gnu dot org
` (11 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: jvdelisle at gcc dot gnu dot org @ 2007-12-22 2:01 UTC (permalink / raw)
To: gcc-bugs
------- Comment #8 from jvdelisle at gcc dot gnu dot org 2007-12-22 02:00 -------
Fixed on trunk.
--
jvdelisle at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34540
^ permalink raw reply [flat|nested] 22+ messages in thread
* [Bug libfortran/34540] [4.3 Regression] cshift, eoshift, kind=1 and kind=2 arguments...
2007-12-20 20:40 [Bug libfortran/34540] New: cshift, eoshift, kind=1 and kind=2 arguments tkoenig at gcc dot gnu dot org
` (8 preceding siblings ...)
2007-12-22 2:01 ` jvdelisle at gcc dot gnu dot org
@ 2007-12-22 9:32 ` tkoenig at gcc dot gnu dot org
2007-12-22 10:57 ` dominiq at lps dot ens dot fr
` (10 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: tkoenig at gcc dot gnu dot org @ 2007-12-22 9:32 UTC (permalink / raw)
To: gcc-bugs
------- Comment #9 from tkoenig at gcc dot gnu dot org 2007-12-22 09:32 -------
Hi Jerry,
thanks for the quick fix.
I don't have time for testing right now, but maybe you
can also check that
module tst_foo
implicit none
contains
subroutine tst_optional(a,n1,n2)
real, dimension(:,:) :: a
integer(kind=1), intent(in), optional:: n1
integer(kind=2), intent(in), optional:: n2
integer(kind=1), dimension(2) :: s1
s1 = (/1, 1/)
print *,cshift(a,shift=s1,dim=n1)
print *,cshift(a,shift=s1,dim=n2)
print *,eoshift(a,shift=s1,dim=n1)
print *,eoshift(a,shift=s1,dim=n2)
end subroutine tst_optional
end module tst_foo
program main
use tst_foo
implicit none
real, dimension(2,2) :: r
integer(kind=1) :: d1
integer(kind=2) :: d2
data r /1.0, 2.0, 3.0, 4.0/
d1 = 1_1
d2 = 1_2
call tst_optional(r, d1,d2)
end program main
works?
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34540
^ permalink raw reply [flat|nested] 22+ messages in thread
* [Bug libfortran/34540] [4.3 Regression] cshift, eoshift, kind=1 and kind=2 arguments...
2007-12-20 20:40 [Bug libfortran/34540] New: cshift, eoshift, kind=1 and kind=2 arguments tkoenig at gcc dot gnu dot org
` (9 preceding siblings ...)
2007-12-22 9:32 ` tkoenig at gcc dot gnu dot org
@ 2007-12-22 10:57 ` dominiq at lps dot ens dot fr
2007-12-22 15:00 ` jvdelisle at gcc dot gnu dot org
` (9 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: dominiq at lps dot ens dot fr @ 2007-12-22 10:57 UTC (permalink / raw)
To: gcc-bugs
------- Comment #10 from dominiq at lps dot ens dot fr 2007-12-22 10:57 -------
The test case in comment #9 fails with:
Fortran runtime error: Argument 'DIM' is out of range in call to 'CSHIFT'
gfortran: gcc version 4.3.0 20071222, revision 131134 + patches for PR34421,
PR34514, PR34533, and PR34536 (they all did what they were supposed to do
without regression at revision 131125).
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34540
^ permalink raw reply [flat|nested] 22+ messages in thread
* [Bug libfortran/34540] [4.3 Regression] cshift, eoshift, kind=1 and kind=2 arguments...
2007-12-20 20:40 [Bug libfortran/34540] New: cshift, eoshift, kind=1 and kind=2 arguments tkoenig at gcc dot gnu dot org
` (10 preceding siblings ...)
2007-12-22 10:57 ` dominiq at lps dot ens dot fr
@ 2007-12-22 15:00 ` jvdelisle at gcc dot gnu dot org
2007-12-22 16:04 ` [Bug libfortran/34540] " jvdelisle at gcc dot gnu dot org
` (8 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: jvdelisle at gcc dot gnu dot org @ 2007-12-22 15:00 UTC (permalink / raw)
To: gcc-bugs
------- Comment #11 from jvdelisle at gcc dot gnu dot org 2007-12-22 15:00 -------
I get a segfault.
--
jvdelisle at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |REOPENED
Resolution|FIXED |
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34540
^ permalink raw reply [flat|nested] 22+ messages in thread
* [Bug libfortran/34540] cshift, eoshift, kind=1 and kind=2 arguments...
2007-12-20 20:40 [Bug libfortran/34540] New: cshift, eoshift, kind=1 and kind=2 arguments tkoenig at gcc dot gnu dot org
` (11 preceding siblings ...)
2007-12-22 15:00 ` jvdelisle at gcc dot gnu dot org
@ 2007-12-22 16:04 ` jvdelisle at gcc dot gnu dot org
2007-12-22 16:29 ` jvdelisle at gcc dot gnu dot org
` (7 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: jvdelisle at gcc dot gnu dot org @ 2007-12-22 16:04 UTC (permalink / raw)
To: gcc-bugs
------- Comment #12 from jvdelisle at gcc dot gnu dot org 2007-12-22 16:04 -------
This latest issue is not a regression so I changed the summary.
--
jvdelisle at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|[4.3 Regression] cshift, |cshift, eoshift, kind=1 and
|eoshift, kind=1 and kind=2 |kind=2 arguments...
|arguments... |
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34540
^ permalink raw reply [flat|nested] 22+ messages in thread
* [Bug libfortran/34540] cshift, eoshift, kind=1 and kind=2 arguments...
2007-12-20 20:40 [Bug libfortran/34540] New: cshift, eoshift, kind=1 and kind=2 arguments tkoenig at gcc dot gnu dot org
` (12 preceding siblings ...)
2007-12-22 16:04 ` [Bug libfortran/34540] " jvdelisle at gcc dot gnu dot org
@ 2007-12-22 16:29 ` jvdelisle at gcc dot gnu dot org
2007-12-22 16:39 ` jvdelisle at gcc dot gnu dot org
` (6 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: jvdelisle at gcc dot gnu dot org @ 2007-12-22 16:29 UTC (permalink / raw)
To: gcc-bugs
------- Comment #13 from jvdelisle at gcc dot gnu dot org 2007-12-22 16:28 -------
This is surprising! If I get rid of the hack that was needed before for
optional_dim_2.f90 :
Index: iresolve.c
===================================================================
--- iresolve.c (revision 131133)
+++ iresolve.c (working copy)
@@ -590,12 +590,6 @@ gfc_resolve_cshift (gfc_expr *f, gfc_exp
if (dim != NULL)
{
- if (dim->expr_type != EXPR_CONSTANT &&
dim->symtree->n.sym->attr.optional)
- {
- /* Mark this for later setting the type in gfc_conv_missing_dummy.
*/
- dim->representation.length = shift->ts.kind;
- }
- else
{
gfc_resolve_dim_arg (dim);
/* Convert dim to shift's kind to reduce variations. */
The new case passes (for cshift and I would presume eoshift) and the
optional_dim_2.f90 passes and I see no apparent regressions. Still testing.
This means something got fixed somewhere else. I also checked this on
ppc64-linux with the same result.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34540
^ permalink raw reply [flat|nested] 22+ messages in thread
* [Bug libfortran/34540] cshift, eoshift, kind=1 and kind=2 arguments...
2007-12-20 20:40 [Bug libfortran/34540] New: cshift, eoshift, kind=1 and kind=2 arguments tkoenig at gcc dot gnu dot org
` (13 preceding siblings ...)
2007-12-22 16:29 ` jvdelisle at gcc dot gnu dot org
@ 2007-12-22 16:39 ` jvdelisle at gcc dot gnu dot org
2007-12-22 19:22 ` jvdelisle at gcc dot gnu dot org
` (5 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: jvdelisle at gcc dot gnu dot org @ 2007-12-22 16:39 UTC (permalink / raw)
To: gcc-bugs
------- Comment #14 from jvdelisle at gcc dot gnu dot org 2007-12-22 16:39 -------
No, I checked the original case for pr33317 and it segfaults on compilation
with the change in comment #13. This means the testcase optional_dim_2.f90 is
not sufficient. I will fix that along the way here.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34540
^ permalink raw reply [flat|nested] 22+ messages in thread
* [Bug libfortran/34540] cshift, eoshift, kind=1 and kind=2 arguments...
2007-12-20 20:40 [Bug libfortran/34540] New: cshift, eoshift, kind=1 and kind=2 arguments tkoenig at gcc dot gnu dot org
` (14 preceding siblings ...)
2007-12-22 16:39 ` jvdelisle at gcc dot gnu dot org
@ 2007-12-22 19:22 ` jvdelisle at gcc dot gnu dot org
2007-12-23 16:43 ` jvdelisle at gcc dot gnu dot org
` (4 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: jvdelisle at gcc dot gnu dot org @ 2007-12-22 19:22 UTC (permalink / raw)
To: gcc-bugs
------- Comment #15 from jvdelisle at gcc dot gnu dot org 2007-12-22 19:22 -------
Thomas, hope you don't mind me taking this over. This last bug is a different
problem all together. I am hoping we don't have to redesign the
implementation.
--
jvdelisle at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|tkoenig at gcc dot gnu dot |jvdelisle at gcc dot gnu dot
|org |org
Status|REOPENED |ASSIGNED
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34540
^ permalink raw reply [flat|nested] 22+ messages in thread
* [Bug libfortran/34540] cshift, eoshift, kind=1 and kind=2 arguments...
2007-12-20 20:40 [Bug libfortran/34540] New: cshift, eoshift, kind=1 and kind=2 arguments tkoenig at gcc dot gnu dot org
` (15 preceding siblings ...)
2007-12-22 19:22 ` jvdelisle at gcc dot gnu dot org
@ 2007-12-23 16:43 ` jvdelisle at gcc dot gnu dot org
2008-01-05 21:33 ` jvdelisle at gcc dot gnu dot org
` (3 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: jvdelisle at gcc dot gnu dot org @ 2007-12-23 16:43 UTC (permalink / raw)
To: gcc-bugs
------- Comment #16 from jvdelisle at gcc dot gnu dot org 2007-12-23 16:43 -------
The test case in comment #9 passes if I revert the code path required by the
original test case in pr33317. Using gdb, I see no difference in the incoming
dim expression for either case. This implies we need to approach this problem
differently.
The root of the problem is saving on the number of variations of the runtime
cshift and eoshift functions, gfortran converts the dim expression to a
convert_* function with dim as an argument. The dim argument is optional and
when it is not present a null is provided. The convert functions do not handle
a null and gfortran ends up segfaulting on memory access at run time.
Attempting to resolve the dim argument also results in a convert function
rather than a NULL constant.
I am unassigning myself for a while.
--
jvdelisle at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
BugsThisDependsOn| |33317
AssignedTo|jvdelisle at gcc dot gnu dot|unassigned at gcc dot gnu
|org |dot org
Status|ASSIGNED |NEW
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34540
^ permalink raw reply [flat|nested] 22+ messages in thread
* [Bug libfortran/34540] cshift, eoshift, kind=1 and kind=2 arguments...
2007-12-20 20:40 [Bug libfortran/34540] New: cshift, eoshift, kind=1 and kind=2 arguments tkoenig at gcc dot gnu dot org
` (16 preceding siblings ...)
2007-12-23 16:43 ` jvdelisle at gcc dot gnu dot org
@ 2008-01-05 21:33 ` jvdelisle at gcc dot gnu dot org
2008-01-06 10:04 ` burnus at gcc dot gnu dot org
` (2 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: jvdelisle at gcc dot gnu dot org @ 2008-01-05 21:33 UTC (permalink / raw)
To: gcc-bugs
------- Comment #17 from jvdelisle at gcc dot gnu dot org 2008-01-05 21:00 -------
I think I have a patch for this. Testing
--
jvdelisle at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|unassigned at gcc dot gnu |jvdelisle at gcc dot gnu dot
|dot org |org
Status|NEW |ASSIGNED
Last reconfirmed|2007-12-21 21:07:37 |2008-01-05 21:00:04
date| |
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34540
^ permalink raw reply [flat|nested] 22+ messages in thread
* [Bug libfortran/34540] cshift, eoshift, kind=1 and kind=2 arguments...
2007-12-20 20:40 [Bug libfortran/34540] New: cshift, eoshift, kind=1 and kind=2 arguments tkoenig at gcc dot gnu dot org
` (17 preceding siblings ...)
2008-01-05 21:33 ` jvdelisle at gcc dot gnu dot org
@ 2008-01-06 10:04 ` burnus at gcc dot gnu dot org
2008-01-06 18:49 ` jvdelisle at gcc dot gnu dot org
2008-01-06 19:25 ` jvdelisle at gcc dot gnu dot org
20 siblings, 0 replies; 22+ messages in thread
From: burnus at gcc dot gnu dot org @ 2008-01-06 10:04 UTC (permalink / raw)
To: gcc-bugs
------- Comment #18 from burnus at gcc dot gnu dot org 2008-01-06 09:40 -------
Posted patch for this PR and PR 34387.
http://gcc.gnu.org/ml/gcc-patches/2008-01/msg00192.html
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34540
^ permalink raw reply [flat|nested] 22+ messages in thread
* [Bug libfortran/34540] cshift, eoshift, kind=1 and kind=2 arguments...
2007-12-20 20:40 [Bug libfortran/34540] New: cshift, eoshift, kind=1 and kind=2 arguments tkoenig at gcc dot gnu dot org
` (18 preceding siblings ...)
2008-01-06 10:04 ` burnus at gcc dot gnu dot org
@ 2008-01-06 18:49 ` jvdelisle at gcc dot gnu dot org
2008-01-06 19:25 ` jvdelisle at gcc dot gnu dot org
20 siblings, 0 replies; 22+ messages in thread
From: jvdelisle at gcc dot gnu dot org @ 2008-01-06 18:49 UTC (permalink / raw)
To: gcc-bugs
------- Comment #19 from jvdelisle at gcc dot gnu dot org 2008-01-06 18:35 -------
Subject: Bug 34540
Author: jvdelisle
Date: Sun Jan 6 18:34:14 2008
New Revision: 131357
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=131357
Log:
2008-01-06 Jerry DeLisle <jvdelisle@gcc.gnu.org>
PR libfortran/34540
* gfortran.dg/optional_dim_3.f90: New test.
Added:
trunk/gcc/testsuite/gfortran.dg/optional_dim_3.f90
Modified:
trunk/gcc/testsuite/ChangeLog
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34540
^ permalink raw reply [flat|nested] 22+ messages in thread
* [Bug libfortran/34540] cshift, eoshift, kind=1 and kind=2 arguments...
2007-12-20 20:40 [Bug libfortran/34540] New: cshift, eoshift, kind=1 and kind=2 arguments tkoenig at gcc dot gnu dot org
` (19 preceding siblings ...)
2008-01-06 18:49 ` jvdelisle at gcc dot gnu dot org
@ 2008-01-06 19:25 ` jvdelisle at gcc dot gnu dot org
20 siblings, 0 replies; 22+ messages in thread
From: jvdelisle at gcc dot gnu dot org @ 2008-01-06 19:25 UTC (permalink / raw)
To: gcc-bugs
------- Comment #20 from jvdelisle at gcc dot gnu dot org 2008-01-06 18:40 -------
Fixed with patch to 34387.
--
jvdelisle at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34540
^ permalink raw reply [flat|nested] 22+ messages in thread
end of thread, other threads:[~2008-01-06 18:41 UTC | newest]
Thread overview: 22+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-12-20 20:40 [Bug libfortran/34540] New: cshift, eoshift, kind=1 and kind=2 arguments tkoenig at gcc dot gnu dot org
2007-12-20 21:16 ` [Bug libfortran/34540] " tkoenig at gcc dot gnu dot org
2007-12-21 3:13 ` [Bug libfortran/34540] [4.3 Regression] " jvdelisle at gcc dot gnu dot org
2007-12-21 19:49 ` tkoenig at gcc dot gnu dot org
2007-12-21 20:57 ` tkoenig at gcc dot gnu dot org
2007-12-21 21:07 ` jvdelisle at gcc dot gnu dot org
2007-12-21 22:18 ` jvdelisle at gcc dot gnu dot org
2007-12-22 1:57 ` jvdelisle at gcc dot gnu dot org
2007-12-22 2:00 ` jvdelisle at gcc dot gnu dot org
2007-12-22 2:01 ` jvdelisle at gcc dot gnu dot org
2007-12-22 9:32 ` tkoenig at gcc dot gnu dot org
2007-12-22 10:57 ` dominiq at lps dot ens dot fr
2007-12-22 15:00 ` jvdelisle at gcc dot gnu dot org
2007-12-22 16:04 ` [Bug libfortran/34540] " jvdelisle at gcc dot gnu dot org
2007-12-22 16:29 ` jvdelisle at gcc dot gnu dot org
2007-12-22 16:39 ` jvdelisle at gcc dot gnu dot org
2007-12-22 19:22 ` jvdelisle at gcc dot gnu dot org
2007-12-23 16:43 ` jvdelisle at gcc dot gnu dot org
2008-01-05 21:33 ` jvdelisle at gcc dot gnu dot org
2008-01-06 10:04 ` burnus at gcc dot gnu dot org
2008-01-06 18:49 ` jvdelisle at gcc dot gnu dot org
2008-01-06 19:25 ` jvdelisle at gcc dot gnu dot org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).