[Bug tree-optimization/34465] New: [4.3 Regression] incorrect sharing of tree nodes

[Bug tree-optimization/34465] New: [4.3 Regression] incorrect sharing of tree nodes

[tbm at cyrius dot com]

I see the following on Alpha with trunk 2007-12-12 but not on x86_64:

(sid)tbm@lima:~$ /usr/lib/gcc-snapshot/bin/gcc -c 
-fconstant-string-class=NSConstantString -O1
projectmanager.app-EditorRulerView.mi
EditorRulerView.m: In function '-[EditorRulerView refreshHighlightedArea]':
EditorRulerView.m:276: error: incorrect sharing of tree nodes
self_1(D)->selectionRect ={v} {};

{}

EditorRulerView.m:276: error: incorrect sharing of tree nodes
# STORES:  { bRect }
bRect ={v} {};

{}

EditorRulerView.m:276: internal compiler error: verify_stmts failed
Please submit a full bug report,
with preprocessed source if appropriate.


-- 
           Summary: [4.3 Regression] incorrect sharing of tree nodes
           Product: gcc
           Version: 4.3.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: tree-optimization
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: tbm at cyrius dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34465

[Bug tree-optimization/34465] [4.3 Regression] incorrect sharing of tree nodes

[tbm at cyrius dot com]

------- Comment #1 from tbm at cyrius dot com  2007-12-14 18:22 -------
Created an attachment (id=14754)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=14754&action=view)
preprocessed source


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34465

[Bug tree-optimization/34465] [4.3 Regression] incorrect sharing of tree nodes

[jakub at gcc dot gnu dot org]

------- Comment #2 from jakub at gcc dot gnu dot org  2007-12-14 19:43 -------
Aldy, this is your patch as well.
Changing:
--- gimplify.c  (revision 130919)
+++ gimplify.c  (working copy)
@@ -3490,7 +3490,7 @@ gimplify_modify_expr_rhs (tree *expr_p, 
            && TYPE_READONLY (TREE_TYPE (*from_p))
            && TREE_CODE (DECL_INITIAL (*from_p)) == CONSTRUCTOR)
          {
-           *from_p = DECL_INITIAL (*from_p);
+           *from_p = unshare_expr (DECL_INITIAL (*from_p));
            ret = GS_OK;
          }
        ret = GS_UNHANDLED;
in stock SVN cures this, but as you are changing this anyway...


-- 

jakub at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aldyh at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34465

[Bug tree-optimization/34465] [4.3 Regression] incorrect sharing of tree nodes

[tbm at cyrius dot com]

------- Comment #3 from tbm at cyrius dot com  2007-12-14 19:54 -------
(In reply to comment #2)
> Aldy, this is your patch as well.

OK, cool.  Do you still want a reduced testcase (because I have one
now, although it's Objective C).


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34465

[Bug tree-optimization/34465] [4.3 Regression] incorrect sharing of tree nodes

[pinskia at gcc dot gnu dot org]

-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pinskia at gcc dot gnu dot
                   |                            |org
   Target Milestone|---                         |4.3.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34465

[Bug tree-optimization/34465] [4.3 Regression] incorrect sharing of tree nodes

[rguenth at gcc dot gnu dot org]

------- Comment #4 from rguenth at gcc dot gnu dot org  2008-01-02 13:05 -------
Ping?  Is this still broken?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34465

[Bug tree-optimization/34465] [4.3 Regression] incorrect sharing of tree nodes

[aldyh at gcc dot gnu dot org]

------- Comment #5 from aldyh at gcc dot gnu dot org  2008-01-02 14:56 -------
Yes.  I submitted a patch which fixed all the related problems, and Diego
wanted some refactoring of the code.  I am working on it as we speak.  Diego
has said that if the patch is too much of a hassle, the current one I submitted
will do.  I will report shortly.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34465

[Bug tree-optimization/34465] [4.3 Regression] incorrect sharing of tree nodes

[aldyh at gcc dot gnu dot org]

------- Comment #6 from aldyh at gcc dot gnu dot org  2008-01-04 14:50 -------
Subject: Bug 34465

Author: aldyh
Date: Fri Jan  4 14:49:28 2008
New Revision: 131323

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=131323
Log:
        PR tree-optimization/34448
        PR tree-optimization/34465
        * gimplify.c (gimplify_init_constructor): Add new parameter
        notify_temp_creation.  Use it.
        (gimplify_modify_expr_rhs): Take volatiles into account when
        optimizing constructors.
        Do not optimize constructors if gimplify_init_constructor will dump to
        memory.
        * gcc.dg/tree-ssa/pr32901.c: Tests const volatiles.
        * gcc.c-torture/compile/pr34448.c: New.

Added:
    trunk/gcc/testsuite/gcc.c-torture/compile/pr34448.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/gimplify.c
    trunk/gcc/testsuite/gcc.dg/tree-ssa/pr32901.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34465

[Bug tree-optimization/34465] [4.3 Regression] incorrect sharing of tree nodes

[jakub at gcc dot gnu dot org]

------- Comment #7 from jakub at gcc dot gnu dot org  2008-01-04 15:06 -------
Fixed.


-- 

jakub at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34465