[Bug tree-optimization/30132] New: ICE in find_lattice_value, at tree-complex.c:133

[Bug tree-optimization/30132] New: ICE in find_lattice_value, at tree-complex.c:133

[debian-gcc at lists dot debian dot org]

[forwarded from http://bugs.debian.org/400484]

seen on i486-linux-gnu with 3.4, 4.1.2, 4.3 20061022, works with -O0

$ gcc -c -O1 complex.c 
complex.c: In function 'testit':
complex.c:4: internal compiler error: in find_lattice_value, at
tree-complex.c:133
Please submit a full bug report,
with preprocessed source if appropriate.
See <URL:http://gcc.gnu.org/bugs.html> for instructions.


-- 
           Summary: ICE in find_lattice_value, at tree-complex.c:133
           Product: gcc
           Version: 4.1.2
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: tree-optimization
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: debian-gcc at lists dot debian dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30132

[Bug tree-optimization/30132] ICE in find_lattice_value, at tree-complex.c:133

[debian-gcc at lists dot debian dot org]

------- Comment #1 from debian-gcc at lists dot debian dot org  2006-12-09 11:33 -------
Created an attachment (id=12774)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=12774&action=view)
preprocessed source

#include <complex.h>

void testit(double complex* t, double* b)
{
  b[0] = t[0]==0.0?0.0:-t[0];
}

main(void)
{
  static double complex k = 5;
  static double b;
  testit(&k,&b);
}



The following modification fixes the problem:

void testit(double complex* t, double* b)
{
  b[0] = t[0]==0.0?0.0:__real__(-t[0]);
}


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30132

[Bug tree-optimization/30132] [4.1/4.2/4.3 Regression] ICE in find_lattice_value, at tree-complex.c:133

[pinskia at gcc dot gnu dot org]

-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |ice-on-valid-code
      Known to fail|                            |4.1.2 4.2.0 4.3.0
      Known to work|                            |4.0.4
            Summary|ICE in find_lattice_value,  |[4.1/4.2/4.3 Regression] ICE
                   |at tree-complex.c:133       |in find_lattice_value, at
                   |                            |tree-complex.c:133
   Target Milestone|---                         |4.1.2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30132

[Bug tree-optimization/30132] [4.1/4.2/4.3 Regression] ICE in find_lattice_value, at tree-complex.c:133

[pinskia at gcc dot gnu dot org]

------- Comment #2 from pinskia at gcc dot gnu dot org  2006-12-09 13:20 -------
The gimplifier is messing up ...


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30132

[Bug tree-optimization/30132] [4.1/4.2/4.3 Regression] ICE in find_lattice_value, at tree-complex.c:133

[pinskia at gcc dot gnu dot org]

------- Comment #3 from pinskia at gcc dot gnu dot org  2006-12-09 14:20 -------
Note, what we have is invalid gimple which we don't catch until tree-complex.c
which is wrong, I have a patch to catch it earlier.

Confirmed.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pinskia at gcc dot gnu dot
                   |                            |org
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2006-12-09 14:20:41
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30132

[Bug middle-end/30132] [4.1/4.2/4.3 Regression] ICE in find_lattice_value, at tree-complex.c:133

[pinskia at gcc dot gnu dot org]

------- Comment #4 from pinskia at gcc dot gnu dot org  2006-12-09 14:22 -------
Also note moving catching it earlier makes this a middle-end (gimplifier) issue
rather than an optimization issue.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|tree-optimization           |middle-end


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30132

[Bug middle-end/30132] [4.1/4.2/4.3 Regression] ICE in find_lattice_value, at tree-complex.c:133

[pinskia at gcc dot gnu dot org]

------- Comment #5 from pinskia at gcc dot gnu dot org  2006-12-09 14:24 -------
After gimplification:
  D.1853 = *t;
  if (D.1853 == __complex__ (0.0, 0.0))
    {
      D.1854 = __complex__ (0.0, 0.0);
      iftmp.0 = &D.1854;
    }
  else
    {
      D.1855 = *t;
      D.1856 = -D.1855;
      iftmp.0 = &D.1856;
    }
  D.1857 = REALPART_EXPR <*iftmp.0>;
  *b = D.1857;


Before:
  *b = REALPART_EXPR <*t == __complex__ (0.0, 0.0) ? __complex__ (0.0, 0.0) :
-*t>;


I have not figured out why we need to take the address of the temp variable
yet.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30132

[Bug middle-end/30132] [4.1/4.2/4.3 Regression] ICE in find_lattice_value, at tree-complex.c:133

[pinskia at gcc dot gnu dot org]

------- Comment #6 from pinskia at gcc dot gnu dot org  2006-12-09 19:11 -------
We have:
      if ((fallback & fb_lvalue) == 0)
        {
          result = tmp2 = tmp = create_tmp_var (TREE_TYPE (expr), "iftmp");
          ret = GS_ALL_DONE;
        }

But fallback is "fallback=fb_either" so the above if is false.
So we have two problems, an ineffient gimplification and a gimplification that
is wrong.

The ineffient gimplification is easy to fix.  I will now go to figure out why
we get an invalid one.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |pinskia at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30132

[Bug middle-end/30132] [4.1/4.2/4.3 Regression] ICE in find_lattice_value, at tree-complex.c:133

[pinskia at gcc dot gnu dot org]

------- Comment #7 from pinskia at gcc dot gnu dot org  2006-12-09 19:24 -------
The second issue (the invalid gimple), comes from marking a variable as
ADDRESSABLE late after the orginal gimplification to that variable had
happened:
          /* Mark the RHS addressable.  */
          lang_hooks.mark_addressable (TREE_OPERAND (expr, 0));


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30132

[Bug middle-end/30132] [4.1/4.2/4.3 Regression] ICE in find_lattice_value, at tree-complex.c:133

[pinskia at gcc dot gnu dot org]

------- Comment #8 from pinskia at gcc dot gnu dot org  2006-12-09 19:36 -------
I now have a fix for both issues (fixing the first problem of ineffient
gimplification is enough to fix this bug but might not be enough to fix
others).


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30132

[Bug middle-end/30132] [4.1/4.2/4.3 Regression] ICE in find_lattice_value, at tree-complex.c:133

[pinskia at gcc dot gnu dot org]

------- Comment #9 from pinskia at gcc dot gnu dot org  2006-12-10 22:47 -------
The patch which fixed PR 20280 causes this invalid gimple to show up.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  BugsThisDependsOn|                            |20280


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30132

[Bug middle-end/30132] [4.1/4.2/4.3 Regression] ICE in find_lattice_value, at tree-complex.c:133

[geir at cray dot com]

------- Comment #10 from geir at cray dot com  2007-01-22 19:24 -------
Here is a Fortran test case:

$ cat bug2737.f90
      PROGRAM get_tst_inc_complex
      implicit none
      external subrrg, checkrr

      complex :: vrr, trr

      vrr=cmplx(1.,2.);
      call subrr ( )

  contains

    subroutine subrr ()
      trr=vrr-(1.0,0.0)
      call checkrr (trr)
      return
    end subroutine subrr

    END

$ gfortran --version
GNU Fortran 95 (GCC) 4.1.1 20060524 (rpm:5)
Copyright (C) 2006 Free Software Foundation, Inc.

GNU Fortran comes with NO WARRANTY, to the extent permitted by law.
You may redistribute copies of GNU Fortran
under the terms of the GNU General Public License.
For more information about these matters, see the file named COPYING

$ gfortran -c -O0 bug2737.f90
$ gfortran -c -O1 bug2737.f90
bug2737.f90: In function 'MAIN__':
bug2737.f90:1: internal compiler error: in find_lattice_value, at
tree-complex.c:133
Please submit a full bug report,
with preprocessed source if appropriate.
See <URL:http://gcc.gnu.org/bugs.html> for instructions.
$


-- 

geir at cray dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |geir at cray dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30132

[Bug middle-end/30132] [4.1/4.2/4.3 Regression] ICE in find_lattice_value, at tree-complex.c:133

[pinskia at gcc dot gnu dot org]

------- Comment #11 from pinskia at gcc dot gnu dot org  2007-01-22 19:30 -------
(In reply to comment #10)
> Here is a Fortran test case:
I think that Fortran issue is something unrelated to this bug.
In fact that Fortran testcase was fixed for 4.1.2 by PR 27889.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30132

[Bug middle-end/30132] [4.1/4.2/4.3 Regression] ICE in find_lattice_value, at tree-complex.c:133

[mmitchel at gcc dot gnu dot org]

-- 

mmitchel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P1


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30132

[Bug middle-end/30132] [4.1/4.2/4.3 Regression] ICE in find_lattice_value, at tree-complex.c:133

[mmitchel at gcc dot gnu dot org]

-- 

mmitchel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.1.2                       |4.1.3


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30132

[Bug middle-end/30132] [4.1/4.2/4.3 Regression] ICE in find_lattice_value, at tree-complex.c:133

[pinskia at gcc dot gnu dot org]

------- Comment #12 from pinskia at gcc dot gnu dot org  2007-03-13 16:12 -------
Created an attachment (id=13201)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=13201&action=view)
patch which I need to retest and fix the last regression


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30132

[Bug tree-optimization/30132] [4.1/4.2/4.3 Regression] ICE in find_lattice_value, at tree-complex.c:133

[pinskia at gcc dot gnu dot org]

------- Comment #13 from pinskia at gcc dot gnu dot org  2007-11-02 04:18 -------
Updated patch send:
http://gcc.gnu.org/ml/gcc-patches/2007-11/msg00060.html


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|http://gcc.gnu.org/ml/gcc-  |http://gcc.gnu.org/ml/gcc-
                   |patches/2007-               |patches/2007-
                   |03/msg00967.html            |11/msg00060.html
   Last reconfirmed|2007-08-06 15:03:17         |2007-11-02 04:18:45
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30132

[Bug tree-optimization/30132] [4.1/4.2/4.3 Regression] ICE in find_lattice_value, at tree-complex.c:133

[steven at gcc dot gnu dot org]

------- Comment #14 from steven at gcc dot gnu dot org  2007-11-10 16:40 -------
Patch is waiting for approval of the C++ bits.


-- 

steven at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jason at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30132

[Bug tree-optimization/30132] [4.1/4.2/4.3 Regression] ICE in find_lattice_value, at tree-complex.c:133

[pinskia at gcc dot gnu dot org]

------- Comment #15 from pinskia at gcc dot gnu dot org  2008-01-03 16:23 -------
This was caused by the patch which fixed PR 20280 and the 2nd iteration of the
patch was rejected so unassigning from me.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aoliva at gcc dot gnu dot
                   |                            |org
         AssignedTo|pinskia at gcc dot gnu dot  |unassigned at gcc dot gnu
                   |org                         |dot org
             Status|ASSIGNED                    |NEW


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30132

[Bug tree-optimization/30132] [4.1/4.2/4.3 Regression] ICE in find_lattice_value, at tree-complex.c:133

[pinskia at gcc dot gnu dot org]

------- Comment #16 from pinskia at gcc dot gnu dot org  2008-01-03 16:26 -------
4.0.0 really did not work either, it just did not cause a crash as the checks
for invalid gimple was not there.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to work|4.0.4                       |3.4.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30132

[Bug tree-optimization/30132] [4.1/4.2/4.3 Regression] ICE in find_lattice_value, at tree-complex.c:133

[rguenth at gcc dot gnu dot org]

------- Comment #17 from rguenth at gcc dot gnu dot org  2008-01-09 14:45 -------
Mine.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |rguenth at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2007-11-02 04:18:45         |2008-01-09 14:45:38
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30132

[Bug tree-optimization/30132] [4.1/4.2/4.3 Regression] ICE in find_lattice_value, at tree-complex.c:133

[rguenth at gcc dot gnu dot org]

------- Comment #18 from rguenth at gcc dot gnu dot org  2008-01-09 15:47 -------
Subject: Bug 30132

Author: rguenth
Date: Wed Jan  9 15:46:49 2008
New Revision: 131430

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=131430
Log:
2008-01-09  Richard Guenther  <rguenther@suse.de>
        Andrew Pinski  <andrew_pinski@playstation.sony.com>

        PR middle-end/30132
        * gimplify.c (gimplify_cond_expr): Do not create an addressable
        temporary if an rvalue is ok or an lvalue is not required.

        * gcc.c-torture/compile/pr30132.c: New testcase.

Added:
    trunk/gcc/testsuite/gcc.c-torture/compile/pr30132.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/gimplify.c
    trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30132

[Bug tree-optimization/30132] [4.1/4.2 Regression] ICE in find_lattice_value, at tree-complex.c:133

[rguenth at gcc dot gnu dot org]

------- Comment #19 from rguenth at gcc dot gnu dot org  2008-01-09 15:47 -------
Fixed on the trunk.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|rguenth at gcc dot gnu dot  |unassigned at gcc dot gnu
                   |org                         |dot org
             Status|ASSIGNED                    |NEW
      Known to fail|4.1.2 4.2.0 4.3.0           |4.1.2 4.2.0
      Known to work|3.4.0                       |3.4.0 4.3.0
            Summary|[4.1/4.2/4.3 Regression] ICE|[4.1/4.2 Regression] ICE in
                   |in find_lattice_value, at   |find_lattice_value, at tree-
                   |tree-complex.c:133          |complex.c:133


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30132

[Bug tree-optimization/30132] [4.2 Regression] ICE in find_lattice_value, at tree-complex.c:133

[jsm28 at gcc dot gnu dot org]

------- Comment #20 from jsm28 at gcc dot gnu dot org  2008-07-04 21:45 -------
Closing 4.1 branch.


-- 

jsm28 at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[4.1/4.2 Regression] ICE in |[4.2 Regression] ICE in
                   |find_lattice_value, at tree-|find_lattice_value, at tree-
                   |complex.c:133               |complex.c:133
   Target Milestone|4.1.3                       |4.2.5


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30132

[Bug tree-optimization/30132] [4.2 Regression] ICE in find_lattice_value, at tree-complex.c:133

[jsm28 at gcc dot gnu dot org]

------- Comment #21 from jsm28 at gcc dot gnu dot org  2009-03-30 20:16 -------
Closing 4.2 branch, fixed in 4.3.


-- 

jsm28 at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
      Known to fail|4.1.2 4.2.0                 |4.1.2 4.2.0 4.2.5
         Resolution|                            |FIXED
   Target Milestone|4.2.5                       |4.3.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30132