[Bug middle-end/34739] New: Need full backport of 28796

[Bug middle-end/34739] New: Need full backport of 28796

[echristo at apple dot com]

Found a testcase that ice's the ppc-darwin backend at -O3 -ffast-math that is
fixed by the full backport of the patches in 28796. In particular, this part:

Author: rguenth
Date: Tue Oct 24 09:15:07 2006
New Revision: 118001

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=118001
Log:
2006-10-24  Richard Guenther  <rguenther@suse.de>

        PR middle-end/28796
        * builtins.c (fold_builtin_classify): Use HONOR_INFINITIES
        and HONOR_NANS instead of MODE_HAS_INFINITIES and MODE_HAS_NANS
        for deciding optimizations in consistency with fold-const.c
        (fold_builtin_unordered_cmp): Likewise.

        * gcc.dg/pr28796-1.c: New testcase.
        * gcc.dg/pr28796-1.c: Likewise.

Added:
    trunk/gcc/testsuite/gcc.dg/pr28796-1.c
    trunk/gcc/testsuite/gcc.dg/pr28796-2.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/builtins.c
    trunk/gcc/testsuite/ChangeLog

Testcase:

#include <math.h>
int test2(double x, double y) {
  return islessgreater(x, y);
}


-- 
           Summary: Need full backport of 28796
           Product: gcc
           Version: 4.2.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: middle-end
        AssignedTo: rguenth at gcc dot gnu dot org
        ReportedBy: echristo at apple dot com
 GCC build triplet: powerpc-darwin9
  GCC host triplet: powerpc-darwin9
GCC target triplet: powerpc-darwin9


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34739

[Bug middle-end/34739] Need full backport of 28796

[steven at gcc dot gnu dot org]

------- Comment #1 from steven at gcc dot gnu dot org  2008-01-11 11:09 -------
Not a regression, so won't be fixed in 4.2.


-- 

steven at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |INVALID


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34739

[Bug middle-end/34739] Need full backport of 28796

[echristo at apple dot com]

------- Comment #2 from echristo at apple dot com  2008-01-11 11:19 -------
Doesn't ice under 4.0 so it is a regression.


-- 

echristo at apple dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |UNCONFIRMED
         Resolution|INVALID                     |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34739

[Bug middle-end/34739] Need full backport of 28796

[steven at gcc dot gnu dot org]

------- Comment #3 from steven at gcc dot gnu dot org  2008-01-11 11:24 -------
So where is the "a testcase" that you found?

And why, pray tell, assign the bug to Richi instead of just trying to backport
it yourself? ;-)


-- 

steven at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |WAITING


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34739

[Bug middle-end/34739] Need full backport of 28796

[echristo at apple dot com]

------- Comment #4 from echristo at apple dot com  2008-01-11 11:26 -------
It's in the bug and I have assignment issues currently and he asked me to?


-- 

echristo at apple dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|0000-00-00 00:00:00         |2008-01-11 11:26:22
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34739

[Bug middle-end/34739] Need full backport of 28796

[pinskia at gcc dot gnu dot org]

------- Comment #5 from pinskia at gcc dot gnu dot org  2008-01-11 11:38 -------
Preprocessed source?  The testcase listed here is not going to show the issue
on most targets anyways.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34739

[Bug middle-end/34739] Need full backport of 28796

[pinskia at gcc dot gnu dot org]

------- Comment #6 from pinskia at gcc dot gnu dot org  2008-01-11 11:48 -------
(In reply to comment #4)
> It's in the bug and I have assignment issues currently and he asked me to?

You mean Apple has issues, not you technically and legally IIRC.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34739

[Bug middle-end/34739] [4.2 Regression] Need full backport of 28796

[rguenth at gcc dot gnu dot org]

-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |ASSIGNED
     Ever Confirmed|0                           |1
      Known to work|                            |4.0.3 4.3.0
   Last reconfirmed|2008-01-11 11:26:22         |2008-01-11 12:15:31
               date|                            |
            Summary|Need full backport of 28796 |[4.2 Regression] Need full
                   |                            |backport of 28796


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34739

[Bug middle-end/34739] Need full backport of 28796

[echristo at apple dot com]

------- Comment #7 from echristo at apple dot com  2008-01-11 11:48 -------
Created an attachment (id=14923)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=14923&action=view)
testcase


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34739

[Bug middle-end/34739] [4.2 Regression] Need full backport of 28796

[pinskia at gcc dot gnu dot org]

-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.2.3


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34739

[Bug middle-end/34739] [4.2 Regression] Need full backport of 28796

[rguenth at gcc dot gnu dot org]

------- Comment #8 from rguenth at gcc dot gnu dot org  2008-01-22 14:46 -------
Subject: Bug 34739

Author: rguenth
Date: Tue Jan 22 14:45:56 2008
New Revision: 131723

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=131723
Log:
2008-01-22  Richard Guenther  <rguenther@suse.de>

        PR middle-end/34739
        Backport from mainline
        2008-01-16  Richard Guenther  <rguenther@suse.de>

        PR c/34768
        * c-typeck.c (common_pointer_type): Do not merge inconsistent
        type qualifiers for function types.

        2007-11-12  Richard Guenther  <rguenther@suse.de>

        PR middle-end/34070
        * fold-const.c (fold_binary): If testing for non-negative
        operands with tree_expr_nonnegative_warnv_p make sure to
        use op0 which has all (sign) conversions retained.

        2006-10-24  Richard Guenther  <rguenther@suse.de>

        PR middle-end/28796
        * builtins.c (fold_builtin_classify): Use HONOR_INFINITIES
        and HONOR_NANS instead of MODE_HAS_INFINITIES and MODE_HAS_NANS
        for deciding optimizations in consistency with fold-const.c
        (fold_builtin_unordered_cmp): Likewise.

Added:
    branches/gcc-4_2-branch/gcc/testsuite/gcc.c-torture/execute/pr34070-1.c
      - copied unchanged from r130098,
trunk/gcc/testsuite/gcc.c-torture/execute/pr34070-1.c
    branches/gcc-4_2-branch/gcc/testsuite/gcc.c-torture/execute/pr34070-2.c
      - copied unchanged from r130098,
trunk/gcc/testsuite/gcc.c-torture/execute/pr34070-2.c
    branches/gcc-4_2-branch/gcc/testsuite/gcc.c-torture/execute/pr34768-1.c
      - copied unchanged from r131568,
trunk/gcc/testsuite/gcc.c-torture/execute/pr34768-1.c
    branches/gcc-4_2-branch/gcc/testsuite/gcc.c-torture/execute/pr34768-2.c
      - copied unchanged from r131568,
trunk/gcc/testsuite/gcc.c-torture/execute/pr34768-2.c
    branches/gcc-4_2-branch/gcc/testsuite/gcc.dg/pr28796-1.c
      - copied unchanged from r118001, trunk/gcc/testsuite/gcc.dg/pr28796-1.c
    branches/gcc-4_2-branch/gcc/testsuite/gcc.dg/pr28796-2.c
      - copied unchanged from r118001, trunk/gcc/testsuite/gcc.dg/pr28796-2.c
Modified:
    branches/gcc-4_2-branch/gcc/ChangeLog
    branches/gcc-4_2-branch/gcc/builtins.c
    branches/gcc-4_2-branch/gcc/c-typeck.c
    branches/gcc-4_2-branch/gcc/fold-const.c
    branches/gcc-4_2-branch/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34739

[Bug middle-end/34739] [4.2 Regression] Need full backport of 28796

[rguenth at gcc dot gnu dot org]

------- Comment #9 from rguenth at gcc dot gnu dot org  2008-01-22 14:50 -------
Fixed.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34739