[Bug target/34787] New: fix -shared + -pthread for mips/linux

[Bug target/34787] New: fix -shared + -pthread for mips/linux

[vapier at gentoo dot org]

like so many other bugs, "-shared -pthread" is broken on mips linux:
$ mips-linux-gcc -dumpspecs
...
%{!shared: %{pthread:-lpthread} ...
...

simple fix until a general solution (as proposed in Bug 20705) is implemented:
--- gcc/config/mips/linux.h
+++ gcc/config/mips/linux.h
@@ -175,7 +175,7 @@
 #undef LIB_SPEC
 #define LIB_SPEC "\
 %{shared: -lc} \
-%{!shared: %{pthread:-lpthread} \
-  %{profile:-lc_p} %{!profile: -lc}}"
+%{pthread:-lpthread} \
+%{!shared: %{profile:-lc_p} %{!profile: -lc}}"

 #define MD_UNWIND_SUPPORT "config/mips/linux-unwind.h"
--- gcc/config/mips/linux64.h
+++ gcc/config/mips/linux64.h
@@ -33,8 +33,8 @@
 #undef LIB_SPEC
 #define LIB_SPEC "\
 %{shared: -lc} \
-%{!shared: %{pthread:-lpthread} \
-  %{profile:-lc_p} %{!profile: -lc}}"
+%{pthread:-lpthread} \
+%{!shared: %{profile:-lc_p} %{!profile: -lc}}"

 #define GLIBC_DYNAMIC_LINKER32 "/lib/ld.so.1"
 #define GLIBC_DYNAMIC_LINKER64 "/lib64/ld.so.1"

this follows the same lines as all other Linux arches:
http://gcc.gnu.org/ml/gcc-patches/2002-12/msg00526.html


-- 
           Summary: fix -shared + -pthread for mips/linux
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: vapier at gentoo dot org
GCC target triplet: mips-linux


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34787

[Bug target/34787] fix -shared + -pthread for mips/linux

[rguenth at gcc dot gnu dot org]

------- Comment #1 from rguenth at gcc dot gnu dot org  2008-01-15 10:37 -------
Patches should be sent to gcc-patches@gcc.gnu.org


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34787

[Bug target/34787] fix -shared + -pthread for mips/linux

[rsandifo at gcc dot gnu dot org]

------- Comment #2 from rsandifo at gcc dot gnu dot org  2008-01-24 19:52 -------
FWIW, this was fixed on mainline by:

2007-06-13  Thiemo Seufer  <ths@networkno.de>

        * config/mips/linux.h, config/mips/linux64.h (LIB_SPEC): Always
        imply -lpthread for -pthread.

By the letter of the law, this shouldn't be backported because
it doesn't fix a regression.  Interested parties: please shout
if you think an exception should be made.

Richard


-- 

rsandifo at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |WAITING
      Known to work|                            |4.3.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34787

[Bug target/34787] fix -shared + -pthread for mips/linux

[vapier at gentoo dot org]

------- Comment #3 from vapier at gentoo dot org  2008-04-07 06:00 -------
this is in gcc-4.3.0 and that's fine by me


-- 

vapier at gentoo dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34787