public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "drow at gcc dot gnu dot org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug bootstrap/32287] gas version style changed causes warnings with configure Date: Mon, 21 Jan 2008 20:54:00 -0000 [thread overview] Message-ID: <20080121204159.930.qmail@sourceware.org> (raw) In-Reply-To: <bug-32287-13830@http.gcc.gnu.org/bugzilla/> ------- Comment #9 from drow at gcc dot gnu dot org 2008-01-21 20:41 ------- Here's why I didn't remember the patch - I just checked it in, I didn't write it. 2007-08-23 Brian Sidebotham <brian.sidebotham@gmail.com> * configure.ac (leb128): Modify sed statement to work with any binutils version string. * configure: Regenerate That version definitely handles: as_ver='GNU assembler (GNU Binutils for Debian) 2.18.20071027' It does not handle: as_ver='GNU assembler (Linux/GNU Binutils) 2.18.50.0.3.20071102' This version format is new and is not produced by the FSF binutils. I assume it's a result of HJ Lu's Linux binutils after a merge from FSF trunk. The ld_vers check up higher in the file was changed to handle the new version format on 2007-09-23. HJ, Richi, I can find a lot of confused versions of HJ's patch in that thread, which starts here: http://gcc.gnu.org/ml/gcc-patches/2007-09/msg01170.html Nowhere can I find the actual approval. The only version which was approved was safe, but the patch as applied is unsafe. If you put a .* there, then it will match any "xx.yy" string anywhere in the version string, including after the binutils version! This does not mess up on --with-pkgversion on new versions of binutils but only because sed will use the shorter match, and the binutils version comes second. + -e 's,^.*[ ]\([0-9][0-9]*\.[0-9][0-9]*.*\)$,\1,p' \ -e 's,^.*[ ]\([0-9][0-9]*\.[0-9][0-9]*\)[ ].*$,\1,p' \ Note that second line will never match now. The ld and as tests should be made uniform again but I think that we should go back to this one: http://gcc.gnu.org/ml/gcc-patches/2007-09/msg01170.html -- drow at gcc dot gnu dot org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hjl dot tools at gmail dot | |com, rguenther at suse dot | |de, bonzini at gnu dot org http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32287
next prev parent reply other threads:[~2008-01-21 20:42 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2007-06-11 16:25 [Bug bootstrap/32287] New: Grep for "as" broken -- configure: line 14092: test: too many arguments sleb128 uleb128 rob1weld at aol dot com 2007-06-11 18:01 ` [Bug bootstrap/32287] " rob1weld at aol dot com 2007-06-11 22:25 ` [Bug bootstrap/32287] gas version style changed causs warnings with configure pinskia at gcc dot gnu dot org 2007-06-12 11:37 ` rob1weld at aol dot com 2007-07-28 0:53 ` [Bug bootstrap/32287] gas version style changed causes " pinskia at gcc dot gnu dot org 2007-07-28 0:53 ` pinskia at gcc dot gnu dot org 2007-10-10 20:47 ` haubi at gentoo dot org 2007-11-20 19:46 ` rask at gcc dot gnu dot org 2008-01-15 10:39 ` aldot at gcc dot gnu dot org 2008-01-21 20:54 ` drow at gcc dot gnu dot org [this message] 2008-01-21 21:59 ` drow at gcc dot gnu dot org 2008-01-21 21:59 ` hjl dot tools at gmail dot com 2008-01-21 22:02 ` hjl dot tools at gmail dot com 2008-01-21 23:56 ` hjl dot tools at gmail dot com 2008-01-22 13:38 ` drow at gcc dot gnu dot org 2008-01-22 13:58 ` hjl at gcc dot gnu dot org 2008-01-22 14:22 ` hjl dot tools at gmail dot com [not found] <bug-32287-4@http.gcc.gnu.org/bugzilla/> 2012-02-03 22:48 ` pinskia at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20080121204159.930.qmail@sourceware.org \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).