[Bug c/31529] New: ICE in cgraph_expand_function with IMA

[Bug c/31529] New: ICE in cgraph_expand_function with IMA

[aldot at gcc dot gnu dot org]

trunk revision 123693

$ /scratch/obj.i686/gcc-4.3/./prev-gcc/xgcc -v
Using built-in specs.
Target: i686-linux-gnu
Configured with: ../../src/gcc-4.3/configure -v
--enable-languages=c,c++,fortran,treelang --prefix=/opt/i686/gcc-4.3/
--enable-shared --with-system-zlib --libexecdir=/opt/i686/gcc-4.3/lib
--enable-nls --without-included-gettext --enable-threads=posix
--program-suffix=-4.3-HEAD --enable-__cxa_atexit
--enable-libstdcxx-allocator=mt --enable-clocale=gnu --enable-libstdcxx-debug
--enable-mpfr --disable-werror --enable-checking=yes --enable-debug
--with-gmp=/opt/i686/gmp-4.2.1/ --with-mpfr=/opt/i686/mpfr-2.2.1
--disable-multilib --enable-intermodule i686-linux-gnu
Thread model: posix
gcc version 4.3.0 20070410 (experimental)


Gives:
[snip]
../../../src/gcc-4.3/gcc/config/i386/i386.c -o libbackend.o  \
          -DBASEVER="\"4.3.0\"" -DDATESTAMP="\" 20070410\"" \
          -DDEVPHASE="\" (experimental)\"" -combine
../../../src/gcc-4.3/gcc/config/i386/i386.c:22057: internal compiler error: in
cgraph_expand_function, at cgraphunit.c:1005


-- 
           Summary: ICE in cgraph_expand_function with IMA
           Product: gcc
           Version: 4.3.0
            Status: UNCONFIRMED
          Keywords: ice-on-valid-code, build
          Severity: normal
          Priority: P3
         Component: c
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: aldot at gcc dot gnu dot org
 GCC build triplet: i686-linux-gnu
  GCC host triplet: i686-linux-gnu
GCC target triplet: i686-linux-gnu


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31529

[Bug c/31529] ICE in cgraph_expand_function with IMA

[rguenth at gcc dot gnu dot org]

------- Comment #1 from rguenth at gcc dot gnu dot org  2007-04-10 18:07 -------
--enable-intermodule is the key.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hubicka at gcc dot gnu dot
                   |                            |org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31529

[Bug middle-end/31529] ICE in cgraph_expand_function with IMA

[aldot at gcc dot gnu dot org]

------- Comment #2 from aldot at gcc dot gnu dot org  2007-11-28 16:28 -------
Can still be observed on trunk.
Reducing.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31529

[Bug middle-end/31529] ICE in cgraph_expand_function with IMA

[aldot at gcc dot gnu dot org]

------- Comment #3 from aldot at gcc dot gnu dot org  2007-11-30 16:53 -------
Target independent. Reduced from toplev.c and i386.c:

$ cat one.i 
getline ()
{
}
$ cat two.i 
extern __inline
getline ()
{
}

$ /scratch/obj.i686/gcc-4.3/./prev-gcc/xgcc -v
-B/scratch/obj.i686/gcc-4.3/./prev-gcc/
-B/opt/i686/gcc-4.3//i686-linux-gnu/bin/ -c one.i two.i -o pr.o -combine
Reading specs from /scratch/obj.i686/gcc-4.3/./prev-gcc/specs
Target: i686-linux-gnu
Configured with: ../../src/gcc-4.3/configure -v
--enable-languages=c,c++,fortran,treelang --prefix=/opt/i686/gcc-4.3/
--enable-shared --with-system-zlib --libexecdir=/opt/i686/gcc-4.3/lib
--enable-nls --without-included-gettext --enable-threads=posix
--program-suffix=-4.3-HEAD --enable-__cxa_atexit
--enable-libstdcxx-allocator=mt --enable-clocale=gnu --enable-libstdcxx-debug
--enable-mpfr --disable-werror --enable-checking=yes --enable-debug
--with-gmp=/opt/i686/gmp-4.2.2/ --with-mpfr=/opt/i686/mpfr-2.3.0
--disable-multilib --enable-intermodule i686-linux-gnu
Thread model: posix
gcc version 4.3.0 20071128 (experimental) (GCC) 
COLLECT_GCC_OPTIONS='-v' '-B/scratch/obj.i686/gcc-4.3/./prev-gcc/'
'-B/opt/i686/gcc-4.3//i686-linux-gnu/bin/' '-c' '-o' 'pr.o' '-combine'
'-mtune=generic'
 /scratch/obj.i686/gcc-4.3/./prev-gcc/cc1 -fpreprocessed one.i two.i -quiet
-dumpbase one.i -mtune=generic -auxbase-strip pr.o -version -o /tmp/ccCpNIlO.s
GNU C (GCC) version 4.3.0 20071128 (experimental) (i686-linux-gnu)
        compiled by GNU C version 4.1.2 20061115 (prerelease) (Debian
4.1.1-21), GMP version 4.2.1, MPFR version 2.3.0-p4.
GGC heuristics: --param ggc-min-expand=30 --param ggc-min-heapsize=4096
Compiler executable checksum: 67dafa8bc8cc74b9ccacf5609573a661
two.i:4: internal compiler error: in cgraph_expand_function, at
cgraphunit.c:1146


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31529

[Bug middle-end/31529] ICE in cgraph_expand_function with IMA

[aldot at gcc dot gnu dot org]

------- Comment #4 from aldot at gcc dot gnu dot org  2007-11-30 16:59 -------
Breakpoint 2, cgraph_expand_function (node=0xb7c7a280)
    at ../../../src/gcc-4.3/gcc/cgraphunit.c:1138
1138      tree decl = node->decl;
1141      gcc_assert (!node->global.inlined_to);
1143      if (flag_unit_at_a_time)
1144        announce_function (decl);
1146      gcc_assert (node->lowered);

trips the node->lowered assert.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31529

[Bug middle-end/31529] [4.3 Regression] ICE in cgraph_expand_function with IMA

[aldot at gcc dot gnu dot org]

------- Comment #5 from aldot at gcc dot gnu dot org  2007-12-02 19:35 -------
Works:
$ cat one.i
extern getline();
$ gcc-4.2 -c -o pr.o one.i one.i -combine -fdump-tree-all
$ gcc-4.3-HEAD -c -o pr.o one.i one.i -combine -fdump-tree-all

4.3 doesn't seem to see the body?

$ cat one.i
extern getline(){}
$ gcc-4.2 -c -o pr.o one.i one.i -combine -fdump-tree-all
$ mv one.i.001t.tu one.i.001t.tu-4.2
$ gcc-4.3-HEAD -c -o pr.o one.i one.i -combine -fdump-tree-all
one.i:1: internal compiler error: in cgraph_expand_function, at
cgraphunit.c:1146
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://gcc.gnu.org/bugs.html> for instructions.
$ mv one.i.001t.tu one.i.001t.tu-4.3
$ grep -A5 getline one.i.001t.tu-4.?
one.i.001t.tu-4.2:@2611   identifier_node  strg: getline  lngt: 7       
one.i.001t.tu-4.2-@2612   bind_expr        type: @115     body: @2619   
one.i.001t.tu-4.2-@2613   tree_list        valu: @51      chan: @129    
one.i.001t.tu-4.2-@2614   tree_list        valu: @25      chan: @2620   
one.i.001t.tu-4.2-@2615   tree_list        valu: @2435    chan: @2621   
one.i.001t.tu-4.2-@2616   identifier_node  strg:
__sync_bool_compare_and_swap_16 
--
one.i.001t.tu-4.3:@2698   identifier_node  strg: getline  lngt: 7       
one.i.001t.tu-4.3-@2699   tree_list        valu: @51      chan: @130    
one.i.001t.tu-4.3-@2700   tree_list        valu: @25      chan: @2704   
one.i.001t.tu-4.3-@2701   tree_list        valu: @2549    chan: @2705   
one.i.001t.tu-4.3-@2702   identifier_node  strg: __sync_val_compare_and_swap 
one.i.001t.tu-4.3-                         lngt: 27      


-- 

aldot at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[4.2 Regression] ICE in     |[4.3 Regression] ICE in
                   |cgraph_expand_function with |cgraph_expand_function with
                   |IMA                         |IMA


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31529

[Bug middle-end/31529] [4.3 Regression] ICE in cgraph_expand_function with IMA

[aldot at gcc dot gnu dot org]

------- Comment #6 from aldot at gcc dot gnu dot org  2007-12-04 12:28 -------
Testing a patch.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31529

[Bug middle-end/31529] [4.3 Regression] ICE in cgraph_expand_function with IMA

[aldot at gcc dot gnu dot org]

------- Comment #7 from aldot at gcc dot gnu dot org  2007-12-05 22:48 -------
Sounds like this was introduced by the ipa pass reordering in r120527 ff.
Jakub, can you confirm this?


-- 

aldot at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31529

[Bug middle-end/31529] [4.3 Regression] ICE in cgraph_expand_function with IMA

[aldot at gcc dot gnu dot org]

------- Comment #8 from aldot at gcc dot gnu dot org  2007-12-15 17:23 -------
Two disfunctional testcases:
pr31529_1a.i:
extern getline(){}
pr31529_1b.i:
extern getline(){}

pr31529_2a.i:
extern getline(){}
pr31529_2a.i:
extern __inline getline(){}

Trying to fix this in cfg led to verify_curr_properties barfing on me or, for a
different approach, to ICEs in dominator opts later on, so these approaches
were improper and/or incomplete so far.
Uncertain if catching this in the FE is a sensible thing to do, although i
think  it is not.


-- 

aldot at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2007-12-15 17:23:07
               date|                            |
   Target Milestone|---                         |4.3.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31529

[Bug middle-end/31529] [4.3 Regression] ICE in cgraph_expand_function with IMA

[rguenth at gcc dot gnu dot org]

------- Comment #9 from rguenth at gcc dot gnu dot org  2008-01-09 15:04 -------
IMHO this shouldn't be P1, IMA is too obscure for that.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31529

[Bug middle-end/31529] [4.3 Regression] ICE in cgraph_expand_function with IMA

[steven at gcc dot gnu dot org]

------- Comment #10 from steven at gcc dot gnu dot org  2008-01-11 09:14 -------
Actually, I don't know if --combine is really that obscure.  People seem to use
it with some success, see e.g. http://lwn.net/Articles/197097/.  Also, others
seem to think IMA is importan enough to upgrade bugs to P1, see
http://gcc.gnu.org/ml/gcc-bugs/2008-01/msg00995.html.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31529

[Bug middle-end/31529] [4.3 Regression] ICE in cgraph_expand_function with IMA

[hubicka at gcc dot gnu dot org]

------- Comment #11 from hubicka at gcc dot gnu dot org  2008-01-11 15:39 -------
The problem here is really how we handle extern inline functions redefining
non-extern inline functions. 

What forntend does is to handle all extern inline or extern functions of same
name in all units as single functions.  It always rewrite in place the
declaration by last body seen.

Within single unit we allow transition from extern inline with definition to
non-extern inline deinition by resetting the node and disabling inline.

This is already ugly and gets worse with IMA: here we transit from non-extern
inline to inline killing the non-extern inline body before cgraph has chance to
output it. This is simply wrong, since we must output it.

If someone gets C frontend to handle extern inline functions by assigning them
separate DECLs different in each source unit (ideally as static inline would
get) and different from DECL of non-extern inline. I can add simple cgraph API
to associate extern inline variant with the offline body for purposes of
inlining. Then we can behave sanely: use extern inline body when inlining and
non-extern inline body when outputting the offline function.

Current scheme where all extern inline functions are disabled from inlining in
IMA or where we ICE as now is simply nonsense.

Honza


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31529

[Bug middle-end/31529] [4.3 Regression] ICE in cgraph_expand_function with IMA

[rguenth at gcc dot gnu dot org]

-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |rguenth at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2007-12-15 17:23:07         |2008-01-23 13:09:46
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31529

[Bug middle-end/31529] [4.3 Regression] ICE in cgraph_expand_function with IMA

[rguenth at gcc dot gnu dot org]

------- Comment #12 from rguenth at gcc dot gnu dot org  2008-01-23 14:20 -------
Fixed.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31529

[Bug middle-end/31529] [4.3 Regression] ICE in cgraph_expand_function with IMA

[rguenth at gcc dot gnu dot org]

------- Comment #13 from rguenth at gcc dot gnu dot org  2008-01-23 14:20 -------
Subject: Bug 31529

Author: rguenth
Date: Wed Jan 23 14:20:07 2008
New Revision: 131758

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=131758
Log:
2008-01-23  Richard Guenther  <rguenther@suse.de>

        PR middle-end/31529
        * cgraphunit.c (cgraph_reset_node): Always mark the node
        not reachable if it is not queued already.

        * gcc.dg/pr31529-1.c: New testcase.
        * gcc.dg/pr31529-2.c: Likewise.

Added:
    trunk/gcc/testsuite/gcc.dg/pr31529-1.c
    trunk/gcc/testsuite/gcc.dg/pr31529-2.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/cgraphunit.c
    trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31529

[Bug middle-end/31529] [4.3 Regression] ICE in cgraph_expand_function with IMA

[reichelt at gcc dot gnu dot org]

------- Comment #14 from reichelt at gcc dot gnu dot org  2008-01-26 14:32 -------
But now we accept the IMHO invalid version:

file1.c:
  void foo() {}
file2.c:
  void foo() {}

GCC 4.0.x used to produce an error:

file2.c:1: error: redefinition of 'foo'
file1.c:1: error: previous definition of 'foo' was here


-- 

reichelt at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
           Keywords|                            |accepts-invalid
         Resolution|FIXED                       |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31529

[Bug c/31529] [4.3 Regression] Does not reject duplicate definitions with IMA

[rguenth at gcc dot gnu dot org]

------- Comment #15 from rguenth at gcc dot gnu dot org  2008-01-26 14:35 -------
Yep, a frontend problem.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|middle-end                  |c
           Keywords|build, ice-on-valid-code    |
           Priority|P1                          |P2
            Summary|[4.3 Regression] ICE in     |[4.3 Regression] Does not
                   |cgraph_expand_function with |reject duplicate definitions
                   |IMA                         |with IMA


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31529

[Bug c/31529] [4.1/4.2/4.3 Regression] Does not reject duplicate definitions with IMA

[rguenth at gcc dot gnu dot org]

------- Comment #16 from rguenth at gcc dot gnu dot org  2008-01-26 14:37 -------
Bah, you should have opened a new PR.  Anyway, this is now this "new" one.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to fail|                            |4.1.3 4.2.3 4.3.0
      Known to work|4.2.2                       |4.0.4
            Summary|[4.3 Regression] Does not   |[4.1/4.2/4.3 Regression]
                   |reject duplicate definitions|Does not reject duplicate
                   |with IMA                    |definitions with IMA


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31529

[Bug c/31529] [4.1/4.2/4.3 Regression] Does not reject duplicate definitions with IMA

[pinskia at gcc dot gnu dot org]

------- Comment #17 from pinskia at gcc dot gnu dot org  2008-01-26 18:59 -------
That is PR 23104.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31529

[Bug middle-end/31529] [4.3 Regression] ICE in cgraph_expand_function with IMA

[pinskia at gcc dot gnu dot org]

------- Comment #18 from pinskia at gcc dot gnu dot org  2008-01-26 19:04 -------
Changing this back to the bug about the ICE.

>But now we accept the IMHO invalid version:

This is PR 23104.

Closing this bug as fixed as the original bug was fixed and the accepts invalid
has been around for a while now.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
          Component|c                           |middle-end
           Keywords|accepts-invalid             |build, ice-on-valid-code
      Known to fail|4.1.3 4.2.3 4.3.0           |
      Known to work|4.0.4                       |4.2.2
           Priority|P2                          |P1
         Resolution|                            |FIXED
            Summary|[4.1/4.2/4.3 Regression]    |[4.3 Regression] ICE in
                   |Does not reject duplicate   |cgraph_expand_function with
                   |definitions with IMA        |IMA


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31529